Subject: Re: Resubmission of patch for Package Description for CRAN Package r-crochet

From: Naga Malleswari <[email-masked]>
Date: Thu, 19 Mar 2020 13:43:30 +0530

Hi

Resubmitting v3 of my patch. I really hope i did the changes right.

I am going through documentation and learning the things. For seeking 
clarification, Is there any other way i can communicate with you or the 
community. I have joined IRC channel as well #guix on freenode.

On 17/03/20 3:20 pm, Danny Milosavljevic wrote:
> Hi,
>
> there's a whitespace error at the bottom of the patch.  When I try to apply it
> using "git am" I immediately get a warning message.
>
> Also, the subject you used "gnu: r-crochet: New variable" would mean that
> you add a new variable inside r-chochet, which you don't.
>
> It should be: "gnu: Add r-crochet".
>
> and
>
> "* gnu/packages/cran.scm (r-crochet): New variable.".
>
> Please examine some other commit messages in guix master for a template.

I have done the changes and understood.

> I've invoked guix lint and I get:
>
> gnu/packages/cran.scm:20813:6: [email-masked]: use @code or similar ornament instead of quotes
> /home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20814:0: [email-masked]: trailing white space on line 20814
> /home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20815:0: [email-masked]: trailing white space on line 20815

I am a beginner at this stuff. I am understanding the standards. I have 
invoked lint and found no errors.

> Could you fix these problems and submit a new version (v3) of the patch
> (using git send-email --to=[email-masked] , for example)?

-- 
Regards
NagaMalli

>From 213ad27a6275d14fe61339ef3adc808f9e8f8b73 Mon Sep 17 00:00:00 2001
From: Naga Malleswari <[email-masked]>
Date: Thu, 19 Mar 2020 13:29:05 +0530
Subject: [PATCH] gnu: Add r-crochet.

* gnu/packages/cran.scm (r-crochet): New variable.
---
 gnu/packages/cran.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 4c18275eaa..90788ba109 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -20794,3 +20794,25 @@ statistics and p-values of the correlation coefficients.")
 scales and utilities, including a spell check function for plot label fields
 and an overall emphasis on typography.")
     (license license:expat)))
+
+(define-public r-crochet
+  (package
+    (name "r-crochet")
+    (version "2.2.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (cran-uri "crochet" version))
+        (sha256
+          (base32
+            "1cbv79nyycxk6f8ldcsnn2pvgxqlnrj0qs19nhafnq2clxy863k6"))))
+    (build-system r-build-system)
+    (home-page "https://github.com/agrueneberg/crochet")
+    (synopsis "Implementation Helper for Matrix-Like Types")
+    (description
+      "Functions to help implement the extraction / subsetting / indexing
+function @code{[} and replacement function @code{[<-} of custom matrix-like
+types (based on S3, S4, etc.), modeled as closely to the base matrix class
+as possible (with tests to prove it).")
+    (license license:expat)))
+
-- 
2.20.1