GNU bug report logs - #4004
filename completion

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4004 in the body.
You can then email your comments to 4004 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Colin Williams <lackita <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: filename completion
Date: Sat, 1 Aug 2009 12:36:44 -0400

In 23.1.50.1, there's a bad interaction between tab completion and
tramp filenames.  If you try to do tab completion on
"/ssh:remote-host:~/~/te", where the file "test" exists on the remote
host but not locally, the completion says there's no match.

Colin

Message #10 received at 4004 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Colin Williams <lackita <at> gmail.com>
Cc: 4004 <at> debbugs.gnu.org
Subject: Re: bug#4004: filename completion
Date: Mon, 03 Aug 2009 05:13:42 +0200

Colin Williams <lackita <at> gmail.com> writes:

> In 23.1.50.1, there's a bad interaction between tab completion and
> tramp filenames.  If you try to do tab completion on
> "/ssh:remote-host:~/~/te", where the file "test" exists on the remote
> host but not locally, the completion says there's no match.

For me, it works.

What happens if you try to complete "/ssh:remote-host:~/te"?

Has the file "test" been created on the remote host outside Emacs, while
Tramp was running already?

Have you enabled partial-completion-mode, which is needed for Tramp
sometimes?

> Colin

Best regards, Michael.

Message #15 received at 4004-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Colin Williams <lackita <at> gmail.com>
Cc: <4004-done <at> debbugs.gnu.org>
Subject: Re: bug#4004: filename completion
Date: Mon, 03 Aug 2009 10:29:49 +0200

Colin Williams <lackita <at> gmail.com> writes:

> So partial completion mode seems to fix the problem.  I thought
> graying out the irrelevant parts of the path was a handy feature, but
> I don't really mind doing without it.

I don't completely understand what you mean with your remark about
"graying out the irrelevant parts", but there was an error, indeed (it
didn't mark parts starting with tilde). I've committed a fix to the
trunk.

Besides this, I believe there is no problem anymore, so I have set this
bug to resolved.

> Cheers,
> Colin

Best regards, Michael.

Message #20 received at 4004 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 4004 <at> debbugs.gnu.org, Colin Williams
	<lackita <at> gmail.com>,
        Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#4004: filename completion
Date: Mon, 03 Aug 2009 14:37:51 -0400

> Have you enabled partial-completion-mode, which is needed for Tramp
> sometimes?

Note that partial-completion-mode is on the way out, so if you need
partial-completion-mode to make it work, it's important to know it.


        Stefan

Message #25 received at 4004 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 4004 <at> debbugs.gnu.org, Colin Williams <lackita <at> gmail.com>
Subject: Re: bug#4004: filename completion
Date: Mon, 03 Aug 2009 20:46:18 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> Have you enabled partial-completion-mode, which is needed for Tramp
>> sometimes?
>
> Note that partial-completion-mode is on the way out, so if you need
> partial-completion-mode to make it work, it's important to know it.

I must check the code, but IIRC partial-completion-mode is just an
indication for Tramp whether some file name completion functionality
shall be enabled, before Tramp is fully loaded. There were people who
disliked Tramp's file name completion.

If partial-completion-mode will be kicked off, Tramp might need another
indication. Just tell me when it happens, that I can change Tramp.

Just now?

>         Stefan

Best regards, Michael.

Message #30 received at 4004 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 4004 <at> debbugs.gnu.org, Colin Williams <lackita <at> gmail.com>
Subject: Re: bug#4004: filename completion
Date: Thu, 06 Aug 2009 14:37:15 -0400

>>> Have you enabled partial-completion-mode, which is needed for Tramp
>>> sometimes?
>> 
>> Note that partial-completion-mode is on the way out, so if you need
>> partial-completion-mode to make it work, it's important to know it.

> I must check the code, but IIRC partial-completion-mode is just an
> indication for Tramp whether some file name completion functionality
> shall be enabled, before Tramp is fully loaded. There were people who
> disliked Tramp's file name completion.

Then this needs to be fixed.  Looking at the code, I can't quite
understand what it does: it seems that Tramp's method/user/host
completion is only activated for people you use either
partial-completion-mode, ido, icycle, or XEmacs.  I'm not sure what's
the logic behind it, but I'd rather just activate it based on a specific
configuration variable (or just always activate it, as you do in
XEmacs).  In Emacs-23, the functionality that was previous offered by
partial-completion-mode is enabled by default (tho implemented
differently and activated differently as well).


        Stefan

Message #35 received at 4004 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: "4004\@debbugs.gnu.org" <4004 <at> debbugs.gnu.org>,
        Colin Williams <lackita <at> gmail.com>, emacs-devel <at> gnu.org
Subject: Re: bug#4004: filename completion
Date: Fri, 07 Aug 2009 14:04:32 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

[added emacs-devel, we shall continue to discuss there]

>> I must check the code, but IIRC partial-completion-mode is just an
>> indication for Tramp whether some file name completion functionality
>> shall be enabled, before Tramp is fully loaded. There were people who
>> disliked Tramp's file name completion.
>
> Then this needs to be fixed.  Looking at the code, I can't quite
> understand what it does: it seems that Tramp's method/user/host
> completion is only activated for people you use either
> partial-completion-mode, ido, icycle, or XEmacs.  I'm not sure what's
> the logic behind it, but I'd rather just activate it based on a specific
> configuration variable (or just always activate it, as you do in
> XEmacs).  In Emacs-23, the functionality that was previous offered by
> partial-completion-mode is enabled by default (tho implemented
> differently and activated differently as well).

There was a discussion about some years ago, when I did add Tramp's
autoloads. People were annoyed, that even after typing something like
"/a" in the minibuffer, Tramp was already loaded, which raised some
delays. So it was suggested to make Tramp's autoloading optional. It was
even requested that this "optionality" should not be something, which
the user has to disnable herself; users should not be bashed by a new
feature they are not interested in.

The compromise was to find indications, were it could be expected that
the user would appreciate Tramp. partial-completion-mode was the first
candidate, ido and icycle were added later. The XEmacs case is
different, because there is another syntax for Tramp.

If partial-completion-mode is discarded in Emacs, we should either find
a replacement for this "indication", or we shall decide, that Tramp *is*
always loaded as soon as somebody writes an absolute filename in the
minibuffer.

The check for partial-completion-mode shall remain in tramp.el, for
backward compatibility.

>         Stefan

Best regards, Michael.

Message #40 received at 4004 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: "4004\@debbugs.gnu.org" <4004 <at> debbugs.gnu.org>,
        Colin Williams <lackita <at> gmail.com>, emacs-devel <at> gnu.org
Subject: Re: bug#4004: filename completion
Date: Mon, 10 Aug 2009 15:53:38 -0400

> There was a discussion about some years ago, when I did add Tramp's
> autoloads. People were annoyed, that even after typing something like
> "/a" in the minibuffer, Tramp was already loaded, which raised some
> delays. So it was suggested to make Tramp's autoloading optional. It was
> even requested that this "optionality" should not be something, which
> the user has to disnable herself; users should not be bashed by a new
> feature they are not interested in.

That's beginning to make more sense.  But I just tried the following:

   emacs -Q
   C-x C-f /a TAB :

and then

   emacs -Q
   M-: (setq partial-completion-mode t)
   C-x C-f /a TAB :

and I don't see any difference (Tramp gets loaded when I hit : and no
earlier).  Could you show me another example where I can see
the difference, so I can better understand the tradeoffs?


        Stefan

Message #45 received at 4004 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Michael Albinus <michael.albinus <at> gmx.de>,
        Colin Williams <lackita <at> gmail.com>,
        "4004 <at> debbugs.gnu.org" <4004 <at> debbugs.gnu.org>,
        emacs-devel <at> gnu.org
Subject: Re: bug#4004: filename completion
Date: Mon, 10 Aug 2009 22:06:31 +0200

> and I don't see any difference (Tramp gets loaded when I hit : and no
> earlier).  Could you show me another example where I can see
> the difference, so I can better understand the tradeoffs?

When : is hit? That or something close to it might explain a bug I see
sometimes on w32. Tramp gets loaded when doing local file name
completion. Though it has something to do with my customization too,
it does not happen for "emacs -Q". I have not had time  to track it
down.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.