From unknown Mon Jun 23 13:12:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40032] [PATCH] gnu: Add nvme-cli Resent-From: Vincent Legoll Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 12 Mar 2020 01:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 40032 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40032@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158397560413310 (code B ref -1); Thu, 12 Mar 2020 01:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 Mar 2020 01:13:24 +0000 Received: from localhost ([127.0.0.1]:55738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCCPc-0003Sc-HU for submit@debbugs.gnu.org; Wed, 11 Mar 2020 21:13:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:52183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCCPa-0003ST-FM for submit@debbugs.gnu.org; Wed, 11 Mar 2020 21:13:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60946) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCCPZ-0006xo-5a for guix-patches@gnu.org; Wed, 11 Mar 2020 21:13:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCCPX-0004ej-W9 for guix-patches@gnu.org; Wed, 11 Mar 2020 21:13:21 -0400 Received: from mail-il1-x12a.google.com ([2607:f8b0:4864:20::12a]:40299) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jCCPX-0004cQ-Ox for guix-patches@gnu.org; Wed, 11 Mar 2020 21:13:19 -0400 Received: by mail-il1-x12a.google.com with SMTP id g6so3919670ilc.7 for ; Wed, 11 Mar 2020 18:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=M4R5Bk4xRuWte+TD5LRCTlyB96+PVMHA/bdUl/uxMcc=; b=JegA7IDjGeMMaE3SrMpLe5UwlJOnF+TEsk6F+goypM1xHgIhXP+U8p5pVIE/98TMD2 a8/2RXt5PVwR8E+qLGLYbhaB1GmQfWbYxy1HIFxyP+OsgfJkYEq7loukGVzM0yNezvd2 VwSLIdM3RI9w8JrCFIaIhDhgtxFH8ngurPJSzBK81FzuMAM8+ZC5hLjaGY9R5nW80kip H+fpjiHu6Zi5t3ujc3DLl2fZqAt29A1EANk3IifJoL+JQd4s8IBKXNZgywM0XfqcO1c7 bY0tHR+hmRGZR/BPrUimFG5PorkjM+DuhxXJ0m7emJ2wbl7jNYsmfzqa2vyFic/Iwrqb qogA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=M4R5Bk4xRuWte+TD5LRCTlyB96+PVMHA/bdUl/uxMcc=; b=YnxDmbBtRIQibYLi9tz62rCHrIjvc9IhLGA4wjY7FJf92cFYVnHKSs+emBkCAd3kWq EIZwxO0ldM4fRsT2Ir7btLoVHZUGmjKb37ftp01gTKy0MtcIMTZE1LelfEnNFoY3zl2b IgifRqPWNT9zAVRRs5jw/tzO1AFTIYpDyLnCkzsY7TPEfNOvrIXkaWhb/2vp4QxDz2y9 Ddlsroq/TLaqlBGPMCJB9MLXhDwSVZ1jXtZwCy40lsGcEl8S/iW4rl2hVxhYwShEy0jP Y9P1DPa9bYgzUFIVXdm49uK4OC/7suWmJ8UxYOOVtE2k1ivG0B1kvbWrMPvkM9Y3TKwh NE3w== X-Gm-Message-State: ANhLgQ2jUmGb6QSV5OohTXnA/NwjfXXEJyuJ1TQWsVDo5ddppXPNUE5S GnwIH6xSb8JbZy7fp+HglC3xo6nkSBTY8GX5JV6p5A== X-Google-Smtp-Source: ADFU+vvLbcPmMY1I1+tdxhJU+ODRwL/YUtbRuzit8o0AmKd7pDEraw/gBqfzs7vyTBNnpzm/qR0Pnz1IGoApENp/vB8= X-Received: by 2002:a92:d8cc:: with SMTP id l12mr5381507ilo.92.1583975598740; Wed, 11 Mar 2020 18:13:18 -0700 (PDT) MIME-Version: 1.0 From: Vincent Legoll Date: Thu, 12 Mar 2020 02:13:06 +0100 Message-ID: Content-Type: multipart/mixed; boundary="000000000000e593dd05a09e0e78" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::12a X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000e593dd05a09e0e78 Content-Type: text/plain; charset="UTF-8" Lightly tested (list & list-subsys commands) on real hardware. Guix pack'ed the binary and copied out of the VM to run (in debian) -- Vincent Legoll --000000000000e593dd05a09e0e78 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-Add-nvme-cli.patch" Content-Disposition: attachment; filename="0001-gnu-Add-nvme-cli.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k7o25xxf0 RnJvbSA5YzgzNmIyMDZkNjVjMGU4MDcwNmMwYTM3MzBlNzdmNTA4YjEwZjQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaW5jZW50IExlZ29sbCA8dmluY2VudC5sZWdvbGxAZ21haWwu Y29tPgpEYXRlOiBUaHUsIDEyIE1hciAyMDIwIDAxOjUxOjEyICswMTAwClN1YmplY3Q6IFtQQVRD SF0gZ251OiBBZGQgbnZtZS1jbGkKCiogZ251L3BhY2thZ2VzL2xpbnV4LnNjbSAobnZtZS1jbGkp OiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2xpbnV4LnNjbSB8IDI5ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKQoK ZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9saW51eC5zY20gYi9nbnUvcGFja2FnZXMvbGludXgu c2NtCmluZGV4IGI2MDQ4YThjZmIuLmQ3YjMxMTAzYzggMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdl cy9saW51eC5zY20KKysrIGIvZ251L3BhY2thZ2VzL2xpbnV4LnNjbQpAQCAtMzU0NCw2ICszNTQ0 LDM1IEBAIElERSBkcml2ZXIgc3Vic3lzdGVtLiAgTWFueSBleHRlcm5hbCBVU0IgZHJpdmUgZW5j bG9zdXJlcyB3aXRoIFNDU0ktQVRBIENvbW1hbmQKIFRyYW5zbGF0aW9uIChAZGZue1NBVH0pIGFy ZSBhbHNvIHN1cHBvcnRlZC4iKQogICAgIChsaWNlbnNlIChsaWNlbnNlOm5vbi1jb3B5bGVmdCAi ZmlsZTovL0xJQ0VOU0UuVFhUIikpKSkKIAorKGRlZmluZS1wdWJsaWMgbnZtZS1jbGkKKyAgKHBh Y2thZ2UKKyAgICAobmFtZSAibnZtZS1jbGkiKQorICAgICh2ZXJzaW9uICIxLjEwLjEiKQorICAg IChob21lLXBhZ2UgImh0dHBzOi8vZ2l0aHViLmNvbS9saW51eC1udm1lL252bWUtY2xpIikKKyAg ICAoc291cmNlIChvcmlnaW4KKyAgICAgICAgICAgICAgKG1ldGhvZCBnaXQtZmV0Y2gpCisgICAg ICAgICAgICAgICh1cmkgKGdpdC1yZWZlcmVuY2UKKyAgICAgICAgICAgICAgICAgICAgKHVybCBo b21lLXBhZ2UpCisgICAgICAgICAgICAgICAgICAgIChjb21taXQgKHN0cmluZy1hcHBlbmQgInYi IHZlcnNpb24pKSkpCisgICAgICAgICAgICAgIChzaGEyNTYKKyAgICAgICAgICAgICAgIChiYXNl MzIgIjEyd3Ayd3htc3cydjhtOWJodnd2ZGJoZGd4MW1kOGlpbGhibDE5c2Z6ejJhcmFpd2kyeDgi KSkKKyAgICAgICAgICAgICAgKGZpbGUtbmFtZSAoZ2l0LWZpbGUtbmFtZSBuYW1lIHZlcnNpb24p KSkpCisgICAgKGJ1aWxkLXN5c3RlbSBnbnUtYnVpbGQtc3lzdGVtKQorICAgIChhcmd1bWVudHMK KyAgICAgYCgjOm1ha2UtZmxhZ3MgKGxpc3QgIkNDPWdjYyIpCisgICAgICAgIzpwaGFzZXMgKG1v ZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAgICAgICAgICAgICAgKGRlbGV0ZSAn Y29uZmlndXJlKQorICAgICAgICAgICAgICAgICAgKHJlcGxhY2UgJ2luc3RhbGwKKyAgICAgICAg ICAgICAgICAgICAgKGxhbWJkYSBfCisgICAgICAgICAgICAgICAgICAgICAgKHplcm8/IChzeXN0 ZW0qICJtYWtlIiAiaW5zdGFsbC1zcGVjIiAiUFJFRklYPSIKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgIkRFU1RESVI9IiAlb3V0cHV0KSkpKSkp CisgICAgICAgIzp0ZXN0cz8gI2YpKQorICAgIChzeW5vcHNpcyAiTlZNLUV4cHJlc3MgdXNlciBz cGFjZSB0b29saW5nIGZvciBMaW51eCIpCisgICAgKGRlc2NyaXB0aW9uICJVdGlsaXR5IHRvIHBy b3ZpZGUgc3RhbmRhcmRzIGNvbXBsaWFudCB0b29saW5nIGZvciBOVk0tRXhwcmVzcworZHJpdmVz LiAgSXQgd2FzIG1hZGUgc3BlY2lmaWNhbGx5IGZvciBMaW51eCBhcyBpdCByZWxpZXMgb24gdGhl IElPQ1RMcyBkZWZpbmVkCitieSB0aGUgbWFpbmxpbmUga2VybmVsIGRyaXZlci4iKQorICAgIChs aWNlbnNlIGxpY2Vuc2U6Z3BsMispKSkKKwogKGRlZmluZS1wdWJsaWMgcmZraWxsCiAgIChwYWNr YWdlCiAgICAgKG5hbWUgInJma2lsbCIpCi0tIAoyLjI1LjEKCg== --000000000000e593dd05a09e0e78-- From unknown Mon Jun 23 13:12:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40032] [PATCH] gnu: Add nvme-cli Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 12 Mar 2020 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40032 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vincent Legoll Cc: 40032@debbugs.gnu.org Received: via spool by 40032-submit@debbugs.gnu.org id=B40032.158403692124648 (code B ref 40032); Thu, 12 Mar 2020 18:16:02 +0000 Received: (at 40032) by debbugs.gnu.org; 12 Mar 2020 18:15:21 +0000 Received: from localhost ([127.0.0.1]:57795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCSMb-0006PT-1h for submit@debbugs.gnu.org; Thu, 12 Mar 2020 14:15:21 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:55553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCSMZ-0006PF-Sc for 40032@debbugs.gnu.org; Thu, 12 Mar 2020 14:15:20 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id C9E4E222E3; Thu, 12 Mar 2020 14:15:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 12 Mar 2020 14:15:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=Q3JboegF42aF/+9W5CdtmKDS gLnQmWSM4O/ejSCV9VQ=; b=zpoBOWRRE+E2iiWf9/CGBdctUSpA3QnPQK03maRQ CFaWDbCyngpn9PBQfKWAO8Q3Xr1mgO4UrvwGAgyca1CMo+I46EWBTaaRwWHVvcor BR0q4bMtwrVeVVVeeQXiYPmTLjw9i7qxs+e7jD3fOUbGw78+hbzZoiJS9KQSLxk2 wcQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Q3Jboe gF42aF/+9W5CdtmKDSgLnQmWSM4O/ejSCV9VQ=; b=dIsBcQ+hX424SUfId/PQ/X hpa3W6LwyPAJUy0M5KjEnp9Xa5HcK4bSUC0X9pvPkDUGqLpApf2HrOkiDN724iOW KTKKs3jILqyf3nKCqSDWpYVGH7MjIDpvNUXlTJOvu8RZK8Io0UzZtyu8uVZR2NFe uJM4B2xIYt4riakSsboJse9O78dQV5rXB1rVd9lEktgGYdko5ad+4LW+j0vao9di 5SsIklQgft7HoIlu9NoTFJlT3vcNvUlYWmQFCyLKkZlG8a+ptkQOkNnSLgEv4CcY zaVXCWZkEhKrXzLx+5QN8Ezl5shCY0NWfMu39IouLLTE/G+d+3IiICQRyQQPCHgA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddvhedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecukfhppeejie druddvgedrudefkedrieefnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehm rghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id 78AFE3060F09; Thu, 12 Mar 2020 14:15:14 -0400 (EDT) Date: Thu, 12 Mar 2020 14:15:13 -0400 From: Leo Famulari Message-ID: <20200312181513.GA8595@jasmine.lan> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Mar 12, 2020 at 02:13:06AM +0100, Vincent Legoll wrote: > + #:tests? #f)) Why are the tests skipped? Please, always add a code comment here for reviewers. From unknown Mon Jun 23 13:12:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40032] [PATCH] gnu: Add nvme-cli Resent-From: Vincent Legoll Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 13 Mar 2020 23:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40032 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 40032@debbugs.gnu.org Received: via spool by 40032-submit@debbugs.gnu.org id=B40032.15841413005696 (code B ref 40032); Fri, 13 Mar 2020 23:15:02 +0000 Received: (at 40032) by debbugs.gnu.org; 13 Mar 2020 23:15:00 +0000 Received: from localhost ([127.0.0.1]:60353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCtW8-0001To-2D for submit@debbugs.gnu.org; Fri, 13 Mar 2020 19:15:00 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:42738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCtW6-0001Tb-9M for 40032@debbugs.gnu.org; Fri, 13 Mar 2020 19:14:58 -0400 Received: by mail-io1-f68.google.com with SMTP id q128so11263048iof.9 for <40032@debbugs.gnu.org>; Fri, 13 Mar 2020 16:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2K+Q4o2jOdeoDPjDO12+VnfxDbV5aQWd1NxxdLz4sOM=; b=mTN7n3n6l3k6j2SOTrmmJ7gvXqUtXo2dxioGBkBHf5+FGo9EZoh34gpB+z7Rv/09a/ 2Y3PJHhT2IMwal+GZKqQ++ZPm4vS+M4U+fZV6EkRdRy5zB7k4u3KMZ5HqnktLUfUqOeR t9OIBG0dD2H2YdQlhMhcNJ41ShH0luNGJZVhW8Pa8xt+PJ/tuC2gzFUEhcja+/wzT+SG NZ905AuuouTUsb1/XXr3zaDWrdnIDVfqQcHyCOhuLRPPikSdwYEaajPHj/hGJvKrynOi ebMHlakNYZEVwULKGNyIMkr89R/5wyHnQQf0WP++Ti2JR2vOcMX3SyVkHTewjDqB1X2D Osdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2K+Q4o2jOdeoDPjDO12+VnfxDbV5aQWd1NxxdLz4sOM=; b=EetKPkJvt0W8xPqvHCAmkq1fg5m/LjJwGv8bRwvJ9nMoQ1dE0R3emd/lRiJhyEy36K pMCH/FwdhQUzPU7Qap514dgeTjNTEVD4xEjw7Yygmy40Sqr15XzFwq3VWxg/mWaD6avP bH83ueP9xokWV+lgv/tkYw4FQZo3Xtm6M034PpyhAyfdx9r1puBab3AQ6M3MKEPnRmEs xnz9raT/6NW4+eFWzwIsZc7KmrYNDjf/4l4pygnMyGcbMYumyv9hmHE3JV2lEquXNGe3 5FgC68JIA5HY4wIf3V0h5odI4Rjbx7Y/LDZoZFXs2R1BJ7Yh5+/jx7zPUXu4Fg1L/JCA yblA== X-Gm-Message-State: ANhLgQ1qfY0PO79ynTj0xrt3Taai5MaB5LQa7VwXYsKiZSFrnmiItWFq qtacq+cVYkQ85zlckFds1TnkWlyXtAWumEKcX2vwJg== X-Google-Smtp-Source: ADFU+vt1C4xxpWn3Z2cl7Lnh42oqnnsyo1jvQNv1l5w1ltrp7OwYTFT3u+hq0OpNx9+NdM8ahnBBFbZrL7BJkN3tdAo= X-Received: by 2002:a02:c7cd:: with SMTP id s13mr186217jao.81.1584141292680; Fri, 13 Mar 2020 16:14:52 -0700 (PDT) MIME-Version: 1.0 References: <20200312181513.GA8595@jasmine.lan> In-Reply-To: <20200312181513.GA8595@jasmine.lan> From: Vincent Legoll Date: Sat, 14 Mar 2020 00:14:41 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I'll investigate further and amend the patch On Thu, Mar 12, 2020 at 7:15 PM Leo Famulari wrote: > > On Thu, Mar 12, 2020 at 02:13:06AM +0100, Vincent Legoll wrote: > > + #:tests? #f)) > > Why are the tests skipped? Please, always add a code comment here for > reviewers. -- Vincent Legoll From unknown Mon Jun 23 13:12:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40032] [PATCH] gnu: Add nvme-cli Resent-From: Vincent Legoll Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Mar 2020 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40032 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 40032@debbugs.gnu.org Received: via spool by 40032-submit@debbugs.gnu.org id=B40032.15842920827402 (code B ref 40032); Sun, 15 Mar 2020 17:09:01 +0000 Received: (at 40032) by debbugs.gnu.org; 15 Mar 2020 17:08:02 +0000 Received: from localhost ([127.0.0.1]:35409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDWk6-0001vK-Fl for submit@debbugs.gnu.org; Sun, 15 Mar 2020 13:08:02 -0400 Received: from mail-il1-f195.google.com ([209.85.166.195]:47087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDWk5-0001ui-22 for 40032@debbugs.gnu.org; Sun, 15 Mar 2020 13:08:01 -0400 Received: by mail-il1-f195.google.com with SMTP id e8so14103958ilc.13 for <40032@debbugs.gnu.org>; Sun, 15 Mar 2020 10:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M/5Ksv534YCb5wIMY0GieaMxS4cx4v6q60SORVYKg2U=; b=gOvc+kRPcOEGu6lyG7qB5rEKEk/C9gdRAZqNPEOC7KLCG4s+3orSY6cH2gquexr/WK VyZWysPDGgV4jvyQyFSvWH3RjYSEB0wOPtr1WJ7KoJkCtmxWJFqJ9wG3sd90rFxiKJ/D eMf/E0bI65HACdxEHNaCa+86cwY1iw8mNKZXP2ksId+cGP+jZiXlDBipV/x6e5ymE/7v N6wtCt0WcID+Ww3PY9zCb7iGAtcLlP7NnhCt4Wl6eEIbbCsTGUX4I1kdqHwDCVjXhDCt YafYt65KrxYGuk9bFRCtepqbhB4vpkKV8ruDDaikruTjcejHd2Vdscskfqov1ecArLc3 SzzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M/5Ksv534YCb5wIMY0GieaMxS4cx4v6q60SORVYKg2U=; b=VtBB93Np41TM9wRJksekwhIPx2fhAXaZm4TZ6lqcFLyilbp71pz8JcefzATp53Si4N dHPhzGKa0r+itMSVgb3IgEZ8lp6OFLctT/cbd9xzhp123AXk0wuumaiD7rE1wM4uOGW8 eOVzweaYmpTTM7fQSdIjgF9JUZ58lnDxEw7zRvRrr9iy60H6AP7xiyoSr6LJwbqovo3T wVTWEEL3mlfNY8LiLvj+aKfG5yAP94mgXXqRa+VAnjR3naHloHXfLBm/ogQdtfvMjCYy Y0k8UAb6zMgPATv8dhOfJ8k9fxCkxLSETM+z4GqCORKJ59CXsAdEBhUXriO0syscU5qX QVJw== X-Gm-Message-State: ANhLgQ1hWIo7MURwaBHPoq+A0lRHXp/FUvo4TJE7c8BQwkT9DeFtuPVv uq9TtSl41Y+FErBS+HHZxTUs2vReRGrtsCpfZVgZUw== X-Google-Smtp-Source: ADFU+vsOusFDhdJTl0Z6NnnDcNvUYjro0T8iPe7NAACFr7bIhRPMvAtzjwxXtU1walq6XdP+8luMBWWD3fYIE4NNj00= X-Received: by 2002:a92:9ec5:: with SMTP id s66mr1933290ilk.284.1584292075567; Sun, 15 Mar 2020 10:07:55 -0700 (PDT) MIME-Version: 1.0 References: <20200312181513.GA8595@jasmine.lan> In-Reply-To: From: Vincent Legoll Date: Sun, 15 Mar 2020 18:07:44 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) It looks like the tests require the presence of /sys/devices... Should I just add that explanation as comment ? On Sat, Mar 14, 2020 at 12:14 AM Vincent Legoll wrote: > > I'll investigate further and amend the patch > > On Thu, Mar 12, 2020 at 7:15 PM Leo Famulari wrote: > > > > On Thu, Mar 12, 2020 at 02:13:06AM +0100, Vincent Legoll wrote: > > > + #:tests? #f)) > > > > Why are the tests skipped? Please, always add a code comment here for > > reviewers. > > > > -- > Vincent Legoll -- Vincent Legoll From unknown Mon Jun 23 13:12:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40032] [PATCH] gnu: Add nvme-cli Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Mar 2020 17:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40032 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vincent Legoll Cc: 40032@debbugs.gnu.org Received: via spool by 40032-submit@debbugs.gnu.org id=B40032.15842929709055 (code B ref 40032); Sun, 15 Mar 2020 17:23:02 +0000 Received: (at 40032) by debbugs.gnu.org; 15 Mar 2020 17:22:50 +0000 Received: from localhost ([127.0.0.1]:35435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDWyP-0002Ly-ME for submit@debbugs.gnu.org; Sun, 15 Mar 2020 13:22:49 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:35127) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDWyO-0002Lm-IK for 40032@debbugs.gnu.org; Sun, 15 Mar 2020 13:22:48 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 43A032134B; Sun, 15 Mar 2020 13:22:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 15 Mar 2020 13:22:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=Jl8UxPQ6Z+bHO1i51zTDhN04 kJzvutfKBNBQ7r6rTNE=; b=iqvaB5CM+g4gH+mR4gpNKvxzjdvxCBv+S7p6grlp eoDPzWrKEGUAelghV7GUdZ56KixP2LkS2q3Bu/dCXeKffjyqStsQ7Wwzo872JXgz 4eoaek6UjjuAIo3FakWNd2aN7+XQMwvgZ1LuRzQkvoHv4GgZDKOsZ9tHCnKuw/G+ 6y0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Jl8UxP Q6Z+bHO1i51zTDhN04kJzvutfKBNBQ7r6rTNE=; b=ETt2EZTBxJt2T+BJEzByMI KOVhk7ZL25nrZ0pYKBb4hdtZG+v6sqVe4y1/BoRBc7sr2rijoUouLlXDYZZd+sp/ GV8kuBJet2PBzUjE2UHASOY3+4zLJVpfk7xt7Lk5vsC9+62clls+4H5xkmtqPt3W T7Avp3RbO22VPooAe0LhIu/35u5APC8HoEeQ7A/hxi5jqM2q4qILRBSGr7oaJd7f j9HAw0LnS8IEfR1d+bPr4W8Y/9Lz2TPYz3buEdLGG+lwCMRt7OpKgT2elQAVznNt 8Chgj7o5bal6UrmddfcAYrT6y8n1mCvsPXYDV4i7k7gRXsj/k0Tmldl9qsyWSmgw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudefuddgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucffohhmrghinh epghhnuhdrohhrghenucfkphepjeeirdduvdegrddufeekrdeifeenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrih drnhgrmhgv X-ME-Proxy: Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id B2EDC3280059; Sun, 15 Mar 2020 13:22:42 -0400 (EDT) Date: Sun, 15 Mar 2020 13:22:42 -0400 From: Leo Famulari Message-ID: <20200315172242.GA26892@jasmine.lan> References: <20200312181513.GA8595@jasmine.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Mar 15, 2020 at 06:07:44PM +0100, Vincent Legoll wrote: > It looks like the tests require the presence of /sys/devices... > > Should I just add that explanation as comment ? Yeah, I would say that they require sysfs, which is not accessible from the build environment. One could check with "ls -l /sys" in a build phase, or check the docs: https://guix.gnu.org/manual/en/html_node/Build-Environment-Setup.html Can you send a revised patch? From unknown Mon Jun 23 13:12:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40032] [PATCH] gnu: Add nvme-cli Resent-From: Vincent Legoll Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Mar 2020 17:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40032 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 40032@debbugs.gnu.org Received: via spool by 40032-submit@debbugs.gnu.org id=B40032.158429383410624 (code B ref 40032); Sun, 15 Mar 2020 17:38:02 +0000 Received: (at 40032) by debbugs.gnu.org; 15 Mar 2020 17:37:14 +0000 Received: from localhost ([127.0.0.1]:35463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDXCL-0002lI-Qy for submit@debbugs.gnu.org; Sun, 15 Mar 2020 13:37:14 -0400 Received: from mail-il1-f196.google.com ([209.85.166.196]:36718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDXCJ-0002ku-E0 for 40032@debbugs.gnu.org; Sun, 15 Mar 2020 13:37:11 -0400 Received: by mail-il1-f196.google.com with SMTP id h3so14212971ils.3 for <40032@debbugs.gnu.org>; Sun, 15 Mar 2020 10:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ArpUpRuAAxfut6NubHZXpK1r9ehzer7Y0rR7R/AAnRQ=; b=SV5LExnzZWoFuJIOwbl6CY0XBLcmb2esVZ/5QAmjBiM5BOvXasfVYrZFmuRVW+HViZ 4amqUxvvUQzErtDHoi4I0A7b4yUATNICY1TmfMKQQBafT+Z7+TnCn4FUlk6gy8qZelBY pSrJFCmIm+w4Q2PU0CnEWAnYyhsfMD6nlEJtVZOAJtpza1WOtWgBazuhJsrbqGxpRjPi 39OLynIy4EZxs3UFpG6rJhcLHc+oDk2rQaRyJWUyu6a9x3beF7GLI71SPtrn89wlajZy 8KF9SGgrE7+575eEslxWuF35AUajOoVY0wd/y4IJ1XGNibUgwlaNQefJ18RK56+4HpfQ 1g3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ArpUpRuAAxfut6NubHZXpK1r9ehzer7Y0rR7R/AAnRQ=; b=UjOQPxAb1Kx8aBOaGLyIzz/OTgm7oc0tXJstx0UegkohgDcWJ46RkceRhLuu6v+lVm 1Q5hNVFZLhqmw5JSJy+m8j+tNAdfgKKORam5Z/TEp0E3Bvy8ozODjgQZEN0NiKANoyQS z8V+u/+WKAfk54w60YCcDJ0CjozWAle0Kezmc4rlaKc+KWJBNjbUOEgxb+eBKf0+lzPX 3TtOZ9m/KlZFItKooM/zfMZ1zyxihE5L4MoD8+763uHqrbBQTPCwh3p94LXHh+7FIeqO F0SGM8tC2DN0lQALTAipG2tdZpHv6Y878gHDVJ7bpqAHpp9cD4zNyzit0UAAeFyYSmyn 0wkA== X-Gm-Message-State: ANhLgQ0LuHkiW5gprmAWW/bwQkkrqXCiQnczu3S3sdXzZPfbtquU67Ym mTWCA3iuHaQ+SPUge65HwwdOIX8B4wcCawPnKoc= X-Google-Smtp-Source: ADFU+vskalH2LoZreNhLNw7fgBPPaS2A2HGsaG/JHXgHNWikacDzCVwIjxiz0m8aC+NE3evcuadb/epDL1TD0Sp629s= X-Received: by 2002:a92:8c42:: with SMTP id o63mr22315876ild.189.1584293825874; Sun, 15 Mar 2020 10:37:05 -0700 (PDT) MIME-Version: 1.0 References: <20200312181513.GA8595@jasmine.lan> <20200315172242.GA26892@jasmine.lan> In-Reply-To: <20200315172242.GA26892@jasmine.lan> From: Vincent Legoll Date: Sun, 15 Mar 2020 18:36:54 +0100 Message-ID: Content-Type: multipart/mixed; boundary="000000000000b6883b05a0e826da" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000b6883b05a0e826da Content-Type: text/plain; charset="UTF-8" Like the following ? On Sun, Mar 15, 2020 at 6:22 PM Leo Famulari wrote: > > On Sun, Mar 15, 2020 at 06:07:44PM +0100, Vincent Legoll wrote: > > It looks like the tests require the presence of /sys/devices... > > > > Should I just add that explanation as comment ? > > Yeah, I would say that they require sysfs, which is not accessible from > the build environment. > > One could check with "ls -l /sys" in a build phase, or check the docs: > > https://guix.gnu.org/manual/en/html_node/Build-Environment-Setup.html > > Can you send a revised patch? -- Vincent Legoll --000000000000b6883b05a0e826da Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-Add-nvme-cli.patch" Content-Disposition: attachment; filename="0001-gnu-Add-nvme-cli.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k7tbmhcu0 RnJvbSA0Zjc5NGY2NGNhNTQzODc3M2ZjOTk4MGJiZjBjZjU3MzkxNDRkYzg3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaW5jZW50IExlZ29sbCA8dmluY2VudC5sZWdvbGxAZ21haWwu Y29tPgpEYXRlOiBUaHUsIDEyIE1hciAyMDIwIDAxOjUxOjEyICswMTAwClN1YmplY3Q6IFtQQVRD SF0gZ251OiBBZGQgbnZtZS1jbGkKCiogZ251L3BhY2thZ2VzL2xpbnV4LnNjbSAobnZtZS1jbGkp OiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2xpbnV4LnNjbSB8IDMwICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKykK CmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvbGludXguc2NtIGIvZ251L3BhY2thZ2VzL2xpbnV4 LnNjbQppbmRleCA2ODhkOWVlZmFmLi5lOGNjMDFkMjg4IDEwMDY0NAotLS0gYS9nbnUvcGFja2Fn ZXMvbGludXguc2NtCisrKyBiL2dudS9wYWNrYWdlcy9saW51eC5zY20KQEAgLTM1NzcsNiArMzU3 NywzNiBAQCBJREUgZHJpdmVyIHN1YnN5c3RlbS4gIE1hbnkgZXh0ZXJuYWwgVVNCIGRyaXZlIGVu Y2xvc3VyZXMgd2l0aCBTQ1NJLUFUQSBDb21tYW5kCiBUcmFuc2xhdGlvbiAoQGRmbntTQVR9KSBh cmUgYWxzbyBzdXBwb3J0ZWQuIikKICAgICAobGljZW5zZSAobGljZW5zZTpub24tY29weWxlZnQg ImZpbGU6Ly9MSUNFTlNFLlRYVCIpKSkpCiAKKyhkZWZpbmUtcHVibGljIG52bWUtY2xpCisgIChw YWNrYWdlCisgICAgKG5hbWUgIm52bWUtY2xpIikKKyAgICAodmVyc2lvbiAiMS4xMC4xIikKKyAg ICAoaG9tZS1wYWdlICJodHRwczovL2dpdGh1Yi5jb20vbGludXgtbnZtZS9udm1lLWNsaSIpCisg ICAgKHNvdXJjZSAob3JpZ2luCisgICAgICAgICAgICAgIChtZXRob2QgZ2l0LWZldGNoKQorICAg ICAgICAgICAgICAodXJpIChnaXQtcmVmZXJlbmNlCisgICAgICAgICAgICAgICAgICAgICh1cmwg aG9tZS1wYWdlKQorICAgICAgICAgICAgICAgICAgICAoY29tbWl0IChzdHJpbmctYXBwZW5kICJ2 IiB2ZXJzaW9uKSkpKQorICAgICAgICAgICAgICAoc2hhMjU2CisgICAgICAgICAgICAgICAoYmFz ZTMyICIxMndwMnd4bXN3MnY4bTliaHZ3dmRiaGRneDFtZDhpaWxoYmwxOXNmenoyYXJhaXdpMng4 IikpCisgICAgICAgICAgICAgIChmaWxlLW5hbWUgKGdpdC1maWxlLW5hbWUgbmFtZSB2ZXJzaW9u KSkpKQorICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRz CisgICAgIGAoIzptYWtlLWZsYWdzIChsaXN0ICJDQz1nY2MiKQorICAgICAgICM6cGhhc2VzICht b2RpZnktcGhhc2VzICVzdGFuZGFyZC1waGFzZXMKKyAgICAgICAgICAgICAgICAgIChkZWxldGUg J2NvbmZpZ3VyZSkKKyAgICAgICAgICAgICAgICAgIChyZXBsYWNlICdpbnN0YWxsCisgICAgICAg ICAgICAgICAgICAgIChsYW1iZGEgXworICAgICAgICAgICAgICAgICAgICAgICh6ZXJvPyAoc3lz dGVtKiAibWFrZSIgImluc3RhbGwtc3BlYyIgIlBSRUZJWD0iCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChzdHJpbmctYXBwZW5kICJERVNURElSPSIgJW91dHB1dCkpKSkp KQorICAgICAgICM6dGVzdHM/ICNmKSkgOyBUaGUgdGVzdHMgcmVxdWlyZSBzeXNmcywgd2hpY2gg aXMgbm90IGFjY2Vzc2libGUgZnJvbQorICAgICAgICAgICAgICAgICAgICAgOyB0aGUgYnVpbGQg ZW52aXJvbm1lbnQKKyAgICAoc3lub3BzaXMgIk5WTS1FeHByZXNzIHVzZXIgc3BhY2UgdG9vbGlu ZyBmb3IgTGludXgiKQorICAgIChkZXNjcmlwdGlvbiAiVXRpbGl0eSB0byBwcm92aWRlIHN0YW5k YXJkcyBjb21wbGlhbnQgdG9vbGluZyBmb3IgTlZNLUV4cHJlc3MKK2RyaXZlcy4gIEl0IHdhcyBt YWRlIHNwZWNpZmljYWxseSBmb3IgTGludXggYXMgaXQgcmVsaWVzIG9uIHRoZSBJT0NUTHMgZGVm aW5lZAorYnkgdGhlIG1haW5saW5lIGtlcm5lbCBkcml2ZXIuIikKKyAgICAobGljZW5zZSBsaWNl bnNlOmdwbDIrKSkpCisKIChkZWZpbmUtcHVibGljIHJma2lsbAogICAocGFja2FnZQogICAgIChu YW1lICJyZmtpbGwiKQotLSAKMi4yNS4xCgo= --000000000000b6883b05a0e826da-- From unknown Mon Jun 23 13:12:27 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Vincent Legoll Subject: bug#40032: closed (Re: [bug#40032] [PATCH] gnu: Add nvme-cli) Message-ID: References: <20200315175722.GE26892@jasmine.lan> X-Gnu-PR-Message: they-closed 40032 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 40032@debbugs.gnu.org Date: Sun, 15 Mar 2020 17:58:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1584295082-12714-1" This is a multi-part message in MIME format... ------------=_1584295082-12714-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #40032: [PATCH] gnu: Add nvme-cli which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 40032@debbugs.gnu.org. --=20 40032: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D40032 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1584295082-12714-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 40032-done) by debbugs.gnu.org; 15 Mar 2020 17:57:31 +0000 Received: from localhost ([127.0.0.1]:35486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDXVz-0003I3-DD for submit@debbugs.gnu.org; Sun, 15 Mar 2020 13:57:31 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:45093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDXVx-0003Hp-Dy for 40032-done@debbugs.gnu.org; Sun, 15 Mar 2020 13:57:29 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E82BA22007; Sun, 15 Mar 2020 13:57:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 15 Mar 2020 13:57:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=9z914lvR1EXbd8ttWcb8p6oE O1MVXBeV0aqHv/gnYi0=; b=Y/oGMcWEabE69jb8Bhd7om9xBHd6PDoIN/P/NPmI Jbao3LYoSGDFudwAcotI8NwkQdXqHyUd39a/IiWS6dhVdzpzWSq5CJ54+cfRKay9 QrE9SkYKrNlTXyoL9OZjpnEry786A/HClr7KlzZYSCyg4OaNhVLmM7zC5u0iD8tK Gkc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=9z914l vR1EXbd8ttWcb8p6oEO1MVXBeV0aqHv/gnYi0=; b=lfCwtls5mMmGBfOkgQPrnI q6J8MvYJKecuqXHW/+iaM1JsptD1X2Bi9vusVJHQdRgmq+GFIlapslchtapPA1ra 4qVGi9t7YB4gyxp+aTruNBMJ8pqm0DAdcZdw2CuZbtukjv5NADUFT1/jVhIZ+NXP wrqg7t+KSZbPje4eQZHfEUX7B5Rn9GcuIm5lXhGGIMV/u+twtn8lelYNYhKVfE/4 7F17n0bblNcrFjzNdY9ykSe4/TaWHYzxUhQv9qj7QV2QVKbo+B7s0dBe6o5fqC9u FBGx3GYLQ5q27DNup9jFKQ+xdSedmywicyzSmoKzGYptkmUJiJ8BBF/x6fMJzX2g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudefuddguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucffohhmrghinh epghhnuhdrohhrghenucfkphepjeeirdduvdegrddufeekrdeifeenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrih drnhgrmhgv X-ME-Proxy: Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id 5CA3830618B7; Sun, 15 Mar 2020 13:57:23 -0400 (EDT) Date: Sun, 15 Mar 2020 13:57:22 -0400 From: Leo Famulari To: Vincent Legoll Subject: Re: [bug#40032] [PATCH] gnu: Add nvme-cli Message-ID: <20200315175722.GE26892@jasmine.lan> References: <20200312181513.GA8595@jasmine.lan> <20200315172242.GA26892@jasmine.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40032-done Cc: 40032-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Mar 15, 2020 at 06:36:54PM +0100, Vincent Legoll wrote: > From 4f794f64ca5438773fc9980bbf0cf5739144dc87 Mon Sep 17 00:00:00 2001 > From: Vincent Legoll > Date: Thu, 12 Mar 2020 01:51:12 +0100 > Subject: [PATCH] gnu: Add nvme-cli > > * gnu/packages/linux.scm (nvme-cli): New variable. Thanks! Pushed as 323841bda4e5b8f9b30626ab768aaf711ee6aabf with the following changes that I somehow forgot to mention. There was no need to make you revise the patch again... > + #:phases (modify-phases %standard-phases > + (delete 'configure) I added a comment about why the phase is deleted. > + (replace 'install > + (lambda _ > + (zero? (system* "make" "install-spec" "PREFIX=" > + (string-append "DESTDIR=" %output)))))) I replaced (zero? (system* ...)) with (invoke ...), which raises exceptions on failure rather than returning a boolean #f. This is "the Guix way" for a while now: https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00278.html > + (description "Utility to provide standards compliant tooling for NVM-Express > +drives. It was made specifically for Linux as it relies on the IOCTLs defined And I made this first sentence into a complete sentence. ------------=_1584295082-12714-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Mar 2020 01:13:24 +0000 Received: from localhost ([127.0.0.1]:55738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCCPc-0003Sc-HU for submit@debbugs.gnu.org; Wed, 11 Mar 2020 21:13:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:52183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCCPa-0003ST-FM for submit@debbugs.gnu.org; Wed, 11 Mar 2020 21:13:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60946) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCCPZ-0006xo-5a for guix-patches@gnu.org; Wed, 11 Mar 2020 21:13:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCCPX-0004ej-W9 for guix-patches@gnu.org; Wed, 11 Mar 2020 21:13:21 -0400 Received: from mail-il1-x12a.google.com ([2607:f8b0:4864:20::12a]:40299) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jCCPX-0004cQ-Ox for guix-patches@gnu.org; Wed, 11 Mar 2020 21:13:19 -0400 Received: by mail-il1-x12a.google.com with SMTP id g6so3919670ilc.7 for ; Wed, 11 Mar 2020 18:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=M4R5Bk4xRuWte+TD5LRCTlyB96+PVMHA/bdUl/uxMcc=; b=JegA7IDjGeMMaE3SrMpLe5UwlJOnF+TEsk6F+goypM1xHgIhXP+U8p5pVIE/98TMD2 a8/2RXt5PVwR8E+qLGLYbhaB1GmQfWbYxy1HIFxyP+OsgfJkYEq7loukGVzM0yNezvd2 VwSLIdM3RI9w8JrCFIaIhDhgtxFH8ngurPJSzBK81FzuMAM8+ZC5hLjaGY9R5nW80kip H+fpjiHu6Zi5t3ujc3DLl2fZqAt29A1EANk3IifJoL+JQd4s8IBKXNZgywM0XfqcO1c7 bY0tHR+hmRGZR/BPrUimFG5PorkjM+DuhxXJ0m7emJ2wbl7jNYsmfzqa2vyFic/Iwrqb qogA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=M4R5Bk4xRuWte+TD5LRCTlyB96+PVMHA/bdUl/uxMcc=; b=YnxDmbBtRIQibYLi9tz62rCHrIjvc9IhLGA4wjY7FJf92cFYVnHKSs+emBkCAd3kWq EIZwxO0ldM4fRsT2Ir7btLoVHZUGmjKb37ftp01gTKy0MtcIMTZE1LelfEnNFoY3zl2b IgifRqPWNT9zAVRRs5jw/tzO1AFTIYpDyLnCkzsY7TPEfNOvrIXkaWhb/2vp4QxDz2y9 Ddlsroq/TLaqlBGPMCJB9MLXhDwSVZ1jXtZwCy40lsGcEl8S/iW4rl2hVxhYwShEy0jP Y9P1DPa9bYgzUFIVXdm49uK4OC/7suWmJ8UxYOOVtE2k1ivG0B1kvbWrMPvkM9Y3TKwh NE3w== X-Gm-Message-State: ANhLgQ2jUmGb6QSV5OohTXnA/NwjfXXEJyuJ1TQWsVDo5ddppXPNUE5S GnwIH6xSb8JbZy7fp+HglC3xo6nkSBTY8GX5JV6p5A== X-Google-Smtp-Source: ADFU+vvLbcPmMY1I1+tdxhJU+ODRwL/YUtbRuzit8o0AmKd7pDEraw/gBqfzs7vyTBNnpzm/qR0Pnz1IGoApENp/vB8= X-Received: by 2002:a92:d8cc:: with SMTP id l12mr5381507ilo.92.1583975598740; Wed, 11 Mar 2020 18:13:18 -0700 (PDT) MIME-Version: 1.0 From: Vincent Legoll Date: Thu, 12 Mar 2020 02:13:06 +0100 Message-ID: Subject: [PATCH] gnu: Add nvme-cli To: guix-patches@gnu.org Content-Type: multipart/mixed; boundary="000000000000e593dd05a09e0e78" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::12a X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000e593dd05a09e0e78 Content-Type: text/plain; charset="UTF-8" Lightly tested (list & list-subsys commands) on real hardware. Guix pack'ed the binary and copied out of the VM to run (in debian) -- Vincent Legoll --000000000000e593dd05a09e0e78 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-Add-nvme-cli.patch" Content-Disposition: attachment; filename="0001-gnu-Add-nvme-cli.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k7o25xxf0 RnJvbSA5YzgzNmIyMDZkNjVjMGU4MDcwNmMwYTM3MzBlNzdmNTA4YjEwZjQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaW5jZW50IExlZ29sbCA8dmluY2VudC5sZWdvbGxAZ21haWwu Y29tPgpEYXRlOiBUaHUsIDEyIE1hciAyMDIwIDAxOjUxOjEyICswMTAwClN1YmplY3Q6IFtQQVRD SF0gZ251OiBBZGQgbnZtZS1jbGkKCiogZ251L3BhY2thZ2VzL2xpbnV4LnNjbSAobnZtZS1jbGkp OiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2xpbnV4LnNjbSB8IDI5ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKQoK ZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9saW51eC5zY20gYi9nbnUvcGFja2FnZXMvbGludXgu c2NtCmluZGV4IGI2MDQ4YThjZmIuLmQ3YjMxMTAzYzggMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdl cy9saW51eC5zY20KKysrIGIvZ251L3BhY2thZ2VzL2xpbnV4LnNjbQpAQCAtMzU0NCw2ICszNTQ0 LDM1IEBAIElERSBkcml2ZXIgc3Vic3lzdGVtLiAgTWFueSBleHRlcm5hbCBVU0IgZHJpdmUgZW5j bG9zdXJlcyB3aXRoIFNDU0ktQVRBIENvbW1hbmQKIFRyYW5zbGF0aW9uIChAZGZue1NBVH0pIGFy ZSBhbHNvIHN1cHBvcnRlZC4iKQogICAgIChsaWNlbnNlIChsaWNlbnNlOm5vbi1jb3B5bGVmdCAi ZmlsZTovL0xJQ0VOU0UuVFhUIikpKSkKIAorKGRlZmluZS1wdWJsaWMgbnZtZS1jbGkKKyAgKHBh Y2thZ2UKKyAgICAobmFtZSAibnZtZS1jbGkiKQorICAgICh2ZXJzaW9uICIxLjEwLjEiKQorICAg IChob21lLXBhZ2UgImh0dHBzOi8vZ2l0aHViLmNvbS9saW51eC1udm1lL252bWUtY2xpIikKKyAg ICAoc291cmNlIChvcmlnaW4KKyAgICAgICAgICAgICAgKG1ldGhvZCBnaXQtZmV0Y2gpCisgICAg ICAgICAgICAgICh1cmkgKGdpdC1yZWZlcmVuY2UKKyAgICAgICAgICAgICAgICAgICAgKHVybCBo b21lLXBhZ2UpCisgICAgICAgICAgICAgICAgICAgIChjb21taXQgKHN0cmluZy1hcHBlbmQgInYi IHZlcnNpb24pKSkpCisgICAgICAgICAgICAgIChzaGEyNTYKKyAgICAgICAgICAgICAgIChiYXNl MzIgIjEyd3Ayd3htc3cydjhtOWJodnd2ZGJoZGd4MW1kOGlpbGhibDE5c2Z6ejJhcmFpd2kyeDgi KSkKKyAgICAgICAgICAgICAgKGZpbGUtbmFtZSAoZ2l0LWZpbGUtbmFtZSBuYW1lIHZlcnNpb24p KSkpCisgICAgKGJ1aWxkLXN5c3RlbSBnbnUtYnVpbGQtc3lzdGVtKQorICAgIChhcmd1bWVudHMK KyAgICAgYCgjOm1ha2UtZmxhZ3MgKGxpc3QgIkNDPWdjYyIpCisgICAgICAgIzpwaGFzZXMgKG1v ZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAgICAgICAgICAgICAgKGRlbGV0ZSAn Y29uZmlndXJlKQorICAgICAgICAgICAgICAgICAgKHJlcGxhY2UgJ2luc3RhbGwKKyAgICAgICAg ICAgICAgICAgICAgKGxhbWJkYSBfCisgICAgICAgICAgICAgICAgICAgICAgKHplcm8/IChzeXN0 ZW0qICJtYWtlIiAiaW5zdGFsbC1zcGVjIiAiUFJFRklYPSIKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgIkRFU1RESVI9IiAlb3V0cHV0KSkpKSkp CisgICAgICAgIzp0ZXN0cz8gI2YpKQorICAgIChzeW5vcHNpcyAiTlZNLUV4cHJlc3MgdXNlciBz cGFjZSB0b29saW5nIGZvciBMaW51eCIpCisgICAgKGRlc2NyaXB0aW9uICJVdGlsaXR5IHRvIHBy b3ZpZGUgc3RhbmRhcmRzIGNvbXBsaWFudCB0b29saW5nIGZvciBOVk0tRXhwcmVzcworZHJpdmVz LiAgSXQgd2FzIG1hZGUgc3BlY2lmaWNhbGx5IGZvciBMaW51eCBhcyBpdCByZWxpZXMgb24gdGhl IElPQ1RMcyBkZWZpbmVkCitieSB0aGUgbWFpbmxpbmUga2VybmVsIGRyaXZlci4iKQorICAgIChs aWNlbnNlIGxpY2Vuc2U6Z3BsMispKSkKKwogKGRlZmluZS1wdWJsaWMgcmZraWxsCiAgIChwYWNr YWdlCiAgICAgKG5hbWUgInJma2lsbCIpCi0tIAoyLjI1LjEKCg== --000000000000e593dd05a09e0e78-- ------------=_1584295082-12714-1-- From unknown Mon Jun 23 13:12:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40032] [PATCH] gnu: Add nvme-cli Resent-From: Vincent Legoll Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Mar 2020 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40032 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 40032-done@debbugs.gnu.org Received: via spool by 40032-done@debbugs.gnu.org id=D40032.158429583614086 (code D ref 40032); Sun, 15 Mar 2020 18:11:02 +0000 Received: (at 40032-done) by debbugs.gnu.org; 15 Mar 2020 18:10:36 +0000 Received: from localhost ([127.0.0.1]:35498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDXid-0003f8-SB for submit@debbugs.gnu.org; Sun, 15 Mar 2020 14:10:36 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:46889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDXic-0003ex-Pt for 40032-done@debbugs.gnu.org; Sun, 15 Mar 2020 14:10:35 -0400 Received: by mail-io1-f66.google.com with SMTP id v3so14792484iom.13 for <40032-done@debbugs.gnu.org>; Sun, 15 Mar 2020 11:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jYajsc0ToaN+3zzoSCDRlkmTxx74pYC2l1EV/yUuKi8=; b=HtORZAAPOmrxaxK/cpAXvpRLUihd4FiIF8ZbsLP7VfLIkVHkm/vYrxu5BSRFKN//9m BxX55+1/5CgOpNLc/v2W4rUvpYYxuZlb6kesopM/Bj1BWfGds2PB7FWUFcST3b9G7yVO UM5RZ0MO1KAWvDaYF11RbMV92tH9lO6Fc4vY8NKF0OIYBv3nuJn52ajkvG0YCvNlVQu6 WHinp88Wk5aQX3rvQ6NVtYR1YU2PunRTF5gCuEN75dIbfDEr0ICeHcsdEXKaNiLEOFAj 9z+C7WgAbVHseDkW4MjfJFd78I/TsOtFgO5CXAGyHVfzjUzKiA5UILr5zOLU6gppSbkO Egbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jYajsc0ToaN+3zzoSCDRlkmTxx74pYC2l1EV/yUuKi8=; b=iprCB2vV6P6B2NOiXBTm1Hv0FQXfxtxAH6mOY+qZZNwI2jbTEIV5l8zA32ugUPxTLH QgPnem7/qgXpj6ZanaqBGiJlUMF9RAylZS3pcjzkipKsSnTuYclzPCrAuafoHyQqGIKq hbRtee6tOqCG28uF7WpwKWfi/MpB9AaFC2QJ5xXQyZgCcVXlr2nYf+efq0nZSq7c3vDk qigP9ITH8k+bCFZWuWjIuWRdONuaBF56q8Pown0YXDGnXesynB7JGJiCgnk7ke1H9X3n g+4k91bxcJGgV1nkHdqvagvaxyDuJMujfP/4kKLSEedXfQ0KYQsuItulxs2ta6NIy+y9 ObXg== X-Gm-Message-State: ANhLgQ3kdjSARp+Lm4NwQzrp7hN1bE04+9fJm7sKHhpCzV8XL3HYjTsr zLGJpqZiPeLGwSyWZ/SrhgDTZZS2Qz9Gm7a8k+E= X-Google-Smtp-Source: ADFU+vu+766R5XF0S2Y9Cf33YnCzBMqHY8XiweZzOM/gYIq8YKT6aDlfgQkRou1mChNigVCGqhZ/APbeOoQ/GiSEp6w= X-Received: by 2002:a5e:990f:: with SMTP id t15mr20992073ioj.153.1584295829261; Sun, 15 Mar 2020 11:10:29 -0700 (PDT) MIME-Version: 1.0 References: <20200312181513.GA8595@jasmine.lan> <20200315172242.GA26892@jasmine.lan> <20200315175722.GE26892@jasmine.lan> In-Reply-To: <20200315175722.GE26892@jasmine.lan> From: Vincent Legoll Date: Sun, 15 Mar 2020 19:10:18 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks for all the fixes, I'll try to get better at doing that myself... On Sun, Mar 15, 2020 at 6:57 PM Leo Famulari wrote: > > On Sun, Mar 15, 2020 at 06:36:54PM +0100, Vincent Legoll wrote: > > From 4f794f64ca5438773fc9980bbf0cf5739144dc87 Mon Sep 17 00:00:00 2001 > > From: Vincent Legoll > > Date: Thu, 12 Mar 2020 01:51:12 +0100 > > Subject: [PATCH] gnu: Add nvme-cli > > > > * gnu/packages/linux.scm (nvme-cli): New variable. > > Thanks! Pushed as 323841bda4e5b8f9b30626ab768aaf711ee6aabf with the > following changes that I somehow forgot to mention. There was no need to > make you revise the patch again... > > > + #:phases (modify-phases %standard-phases > > + (delete 'configure) > > I added a comment about why the phase is deleted. > > > + (replace 'install > > + (lambda _ > > + (zero? (system* "make" "install-spec" "PREFIX=" > > + (string-append "DESTDIR=" %output)))))) > > I replaced (zero? (system* ...)) with (invoke ...), which raises > exceptions on failure rather than returning a boolean #f. This is "the > Guix way" for a while now: > > https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00278.html > > > + (description "Utility to provide standards compliant tooling for NVM-Express > > +drives. It was made specifically for Linux as it relies on the IOCTLs defined > > And I made this first sentence into a complete sentence. -- Vincent Legoll From unknown Mon Jun 23 13:12:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#40032] [PATCH] gnu: Add nvme-cli Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Mar 2020 18:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40032 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vincent Legoll Cc: 40032-done@debbugs.gnu.org Received: via spool by 40032-done@debbugs.gnu.org id=D40032.158429647015429 (code D ref 40032); Sun, 15 Mar 2020 18:22:02 +0000 Received: (at 40032-done) by debbugs.gnu.org; 15 Mar 2020 18:21:10 +0000 Received: from localhost ([127.0.0.1]:35543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDXss-00040n-0Q for submit@debbugs.gnu.org; Sun, 15 Mar 2020 14:21:10 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:50231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDXsr-0003yn-5Y for 40032-done@debbugs.gnu.org; Sun, 15 Mar 2020 14:21:09 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 15FBF21D25; Sun, 15 Mar 2020 14:21:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 15 Mar 2020 14:21:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=uonja2+zoGYEvFjQiv9Hpvq9 5qWTtqULd5m14+Fi9I0=; b=I9tw1an+McI3IFmBVKWx8jlgmT+f2cxjHOPYsIrP Xpb6d9nMoYNiU/p4o8KlZ/F1g9XoBpn5xMC0loAP++dQ56GAsRAVGrTvC15Tke49 lh88B+beeHUHUZzgNab9h87AfSpeWQpQcnshGCokRVOaSDKmfTJhXoT4rTcPVD/X wnE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=uonja2 +zoGYEvFjQiv9Hpvq95qWTtqULd5m14+Fi9I0=; b=Vnikumn2eehIkHVobYvmZA s4wrQAM7zijb7/J1smKl9QebKZk7pLFElYnCpbtEN/uOmdH9dc9UfaXZ+KSJJiwG hlvPNSDk7zVM4elv0U/TkzVPRk8oLWDHnqsBF2kEPFgiq3Ir2i0E0cX5rg/0lhDE VV00ndYd1e+wIPGHL9wTN3dMGqf81Sx/TA5UBN3mbppn1lleMbiDIQyHxHTK7hBe IVtcgXjjk0rDf3dB8jzKY60DPswSFNVVJe4bnMGgg9pojjjGhUcO2LEC7Xsc6jpj oTbeFcUyxmrqFIg07n7ZK8VG0z2mF3OUuT9T3DD6pm72M1XP35VwTYX2jMTB3L/w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudefuddgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucfkphepjeeird duvdegrddufeekrdeifeenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgr ihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id 524643060F09; Sun, 15 Mar 2020 14:21:01 -0400 (EDT) Date: Sun, 15 Mar 2020 14:21:00 -0400 From: Leo Famulari Message-ID: <20200315182100.GB5561@jasmine.lan> References: <20200312181513.GA8595@jasmine.lan> <20200315172242.GA26892@jasmine.lan> <20200315175722.GE26892@jasmine.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Mar 15, 2020 at 07:10:18PM +0100, Vincent Legoll wrote: > Thanks for all the fixes, I'll try to get better at doing that myself... No worries! We're glad to have your patches :)