GNU bug report logs - #40021
gnu: Add mm-common.

Previous Next

Full log

Message #26 received at 40021 <at> debbugs.gnu.org (full text, mbox):

From: "Raghav Gururajan" <raghavgururajan <at> disroot.org>
To: "Danny Milosavljevic" <dannym <at> scratchpost.org>
Cc: 40021 <at> debbugs.gnu.org
Subject: Re: gnu: Add mm-common.
Date: Sun, 05 Apr 2020 04:05:50 +0000

[Message part 1 (text/plain, inline)]

Hi Danny!

> I've tried it both with #:glib-or-gtk? #t and #:glib-or-gtk? #f and then compared
> the result using diffoscope there's no functional difference.
> 
> Therefore, I suggest leaving the #:glib-or-gtk? off, or investigating why it
> doesn't do anything.

You are right, it is not required for this package.

> This package contains unpatched references to perl, git, ln and other
> programs, which means that those programs are looked up in $PATH and
> most probably will not be found.
> 
> It also contains patched references to python.
> 
> That's not consistent.
> 
> Please research what the package is supposed to do. If perl, git and
> ln are internally required modules, let's patch them.
> 
> If they are external "composing" modules, let's leave them as-is.

I have checked and they are not internally required. Only python is required which is already patched. :-)

Please find the revised patch, attached with this email.

Regards,
RG.

[0018-gnu-Add-mm-common.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.