GNU bug report logs - #40010
27.0.90; fix: Specify xlink namespace for svg images

Previous Next

Package: emacs;

Reported by: Zhu Zihao <all_but_last <at> 163.com>

Date: Tue, 10 Mar 2020 11:56:01 UTC

Severity: normal

Tags: fixed, patch

Found in version 27.0.90

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Zhu Zihao <all_but_last <at> 163.com>
To: 40010 <at> debbugs.gnu.org
Subject: bug#40010: 27.0.90; fix: Specify xlink namespace for svg images
Date: Tue, 10 Mar 2020 19:55:04 +0800
svg-create in svg.el generates a svg without specifying the namespace of xlink.
This may fails the render of a svg with image embed in.

A SVG example failed to render was provided here: https://pastebin.com/9QnuMy7Y.

IMO this patch can help fix this issue.

~~~~~~~~

From 93188f91906dea87bfbf62e18b608bbd2f84c7af Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Tue, 10 Mar 2020 19:46:03 +0800
Subject: [PATCH] fix: Specify xlink namespace for svg images.

---
 lisp/svg.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/svg.el b/lisp/svg.el
index 6a2fc4c90fc..370c9c04e76 100644
--- a/lisp/svg.el
+++ b/lisp/svg.el
@@ -70,7 +70,8 @@ svg-create
 	      (height . ,height)
 	      (version . "1.1")
 	      (xmlns . "http://www.w3.org/2000/svg")
-	      ,@(svg--arguments nil args))))
+              (xmlns:xlink . "http://www.w3.org/1999/xlink")
+              ,@(svg--arguments nil args))))
 
 (defun svg-gradient (svg id type stops)
   "Add a gradient with ID to SVG.
-- 
2.25.1







This bug report was last modified 5 years and 66 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.