From unknown Sun Jun 22 15:25:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40010: 27.0.90; fix: Specify xlink namespace for svg images Resent-From: Zhu Zihao Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Mar 2020 11:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 40010 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 40010@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158384133613812 (code B ref -1); Tue, 10 Mar 2020 11:56:01 +0000 Received: (at submit) by debbugs.gnu.org; 10 Mar 2020 11:55:36 +0000 Received: from localhost ([127.0.0.1]:51955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBdU0-0003ah-4f for submit@debbugs.gnu.org; Tue, 10 Mar 2020 07:55:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:58714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBdTy-0003aY-6o for submit@debbugs.gnu.org; Tue, 10 Mar 2020 07:55:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56626) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBdTw-0006UE-4U for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2020 07:55:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBdTr-0005V5-P6 for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2020 07:55:28 -0400 Received: from m12-16.163.com ([220.181.12.16]:50387) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBdTq-0004w6-3Z for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2020 07:55:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:Message-ID:From:Subject:MIME-Version; bh=SbBzG fI+LH2AcJR/fSHkfhfk7tPe/BRhiFwVtbFjPhI=; b=D32avDyOzk+JoB7dTDIX8 gan1R7uJrToDz2jgEXj6qECOjbmxstS4bzMRiqpiiw4M251kN/DPAc35rVN5z1Sl 2RbMm3b2v5h1tr7Ofba42TtlvyqY3uEAxK/cu/X9yL0SW72Z9x34mN6lvSqCW2c1 WOYW+pAhgmY3RH38dAGsco= Received: from archlinux.163.com (unknown [14.121.132.186]) by smtp12 (Coremail) with SMTP id EMCowABXO_AZgGdeICcWBA--.102S2; Tue, 10 Mar 2020 19:55:19 +0800 (CST) Date: Tue, 10 Mar 2020 19:55:04 +0800 Message-ID: <871rq0s9uv.wl-all_but_last@163.com> From: Zhu Zihao User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL/10.8 EasyPG/1.0.0 Emacs/27.0 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-Face: :]]%@R1{oDt0%iKgI@Kga#OZ; ogt+%OOne&J4#E*O,TIlI)yEFw--I\:3s~EV97GI$1.1!}8inmF9UgtUBB@#8>'8NWNC8qg/v*OLfQB; Z:@G3HeNf3u& ,&HpBGv%?p{bzsl'|5T";1&X MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: EMCowABXO_AZgGdeICcWBA--.102S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Jr43GF4rKryDKFWrCFWUCFg_yoWDXwb_Kr yxtr4fWrWDJF1Iv3WFkr4aqFs5CFWFy3Z7ZFs3KrZI9r9rC3Z5Zw1DWFy8Gw13XF4UWFn5 W3sYqw4ayry7KjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0CoGPUUUUU== X-Originating-IP: [14.121.132.186] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/1tbiFBHir1aD4yY0gQAAst X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 220.181.12.16 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) svg-create in svg.el generates a svg without specifying the namespace of xl= ink. This may fails the render of a svg with image embed in. A SVG example failed to render was provided here: https://pastebin.com/9Qnu= My7Y. IMO this patch can help fix this issue. ~~~~~~~~ =46rom 93188f91906dea87bfbf62e18b608bbd2f84c7af Mon Sep 17 00:00:00 2001 From: Zhu Zihao Date: Tue, 10 Mar 2020 19:46:03 +0800 Subject: [PATCH] fix: Specify xlink namespace for svg images. --- lisp/svg.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/svg.el b/lisp/svg.el index 6a2fc4c90fc..370c9c04e76 100644 --- a/lisp/svg.el +++ b/lisp/svg.el @@ -70,7 +70,8 @@ svg-create (height . ,height) (version . "1.1") (xmlns . "http://www.w3.org/2000/svg") - ,@(svg--arguments nil args)))) + (xmlns:xlink . "http://www.w3.org/1999/xlink") + ,@(svg--arguments nil args)))) =20 (defun svg-gradient (svg id type stops) "Add a gradient with ID to SVG. --=20 2.25.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 20 04:45:04 2020 Received: (at control) by debbugs.gnu.org; 20 Mar 2020 08:45:04 +0000 Received: from localhost ([127.0.0.1]:43948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFDH6-0000rB-28 for submit@debbugs.gnu.org; Fri, 20 Mar 2020 04:45:04 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:42937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFDH3-0000ox-Lr for control@debbugs.gnu.org; Fri, 20 Mar 2020 04:45:02 -0400 Received: by mail-qk1-f172.google.com with SMTP id e11so6013998qkg.9 for ; Fri, 20 Mar 2020 01:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=uG4qZmbZK7Ez6NhEFjsoGtV9mHO+QCujJlZShNbca5Q=; b=eHtnfP9R2sK1GXmgMfA1hWjrCiNbcEKkVQ2Jr4ThKH6YtjraLF4SSNXO0CPDuIRGw1 zLAbOlbvSKb1n+zNFWochH0pFZc302UMVQbIDjGzTbj5qyNshblBEDi+y22bd1JZq1pr Gl9oZ14H0N/QZamJsW3MjstprL2nKCxGFkxhiFuY7XSpXUkbyBKofkxqGVjXL7AXtpYb h5V8TzgS9Yo/lhA9OPmjoImaeFCXMGWobbduYZlsCKcXbAQdWwOWp9KgVV6NlYpvdqTG ekZzBuKqP3yGPHWubtiVCAPuBvB//seAc5+YEsTge5G7swfi/TK4dUijkJJLQLBQyTCQ 9b6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=uG4qZmbZK7Ez6NhEFjsoGtV9mHO+QCujJlZShNbca5Q=; b=P3XyoPOxHzdP/t6Zhsfa5i8LyhUCl8mwbcMyp/nI7QRQSjpNyfvRe8Bg/6/7wJrhBF QYYTSDA+TKwNpMXJnosrWEIwii+DSf+gYl18cxwn1M/GrEY3BJ5sCpAs/M61diUv/Gnv qyRi9QsUvuA8Ou+YSxxSbFUqLqprzsn0v1nL0ah4ych42y988Bkopu/Qt5X4CRJoOpdi nt4qSznzu2TSP6jsVDSozWWI81n4UdviQlPwLhPDE8TqEb3n0fU0/fwzTQ2Uz4ViUgIu 3QEyV9r0m/mBZM3IZBIcagGKjafHmNVwk1tp2D4onXO6NRaYN12+DwV665t252c0noVt Op+A== X-Gm-Message-State: ANhLgQ26BkIqgQMsKG6HHiD0Nn5lKCMsXbw4DbjtU3y0mgOztDP4+Zpi DTNwEyAeg6mCqnoppx4Vn/LZnPP4 X-Google-Smtp-Source: ADFU+vvdAzewZeEg8yVlVJ7pmGgk/mZbmxNPwqVcEaQ4SJoZRaBOqDXrYmolpJDCFvtzg6hChy1RZg== X-Received: by 2002:a37:b304:: with SMTP id c4mr6999064qkf.348.1584693895982; Fri, 20 Mar 2020 01:44:55 -0700 (PDT) Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id j50sm4115227qta.42.2020.03.20.01.44.55 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Mar 2020 01:44:55 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #40010 Date: Fri, 20 Mar 2020 04:44:54 -0400 Message-ID: <87blorl8jd.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 40010 + patch quit From unknown Sun Jun 22 15:25:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#40010: 27.0.90; fix: Specify xlink namespace for svg images Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2020 15:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40010 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Zhu Zihao Cc: 40010@debbugs.gnu.org Received: via spool by 40010-submit@debbugs.gnu.org id=B40010.158471863212725 (code B ref 40010); Fri, 20 Mar 2020 15:38:02 +0000 Received: (at 40010) by debbugs.gnu.org; 20 Mar 2020 15:37:12 +0000 Received: from localhost ([127.0.0.1]:45391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFJhw-0003JB-3y for submit@debbugs.gnu.org; Fri, 20 Mar 2020 11:37:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFJhu-0003Iu-OP for 40010@debbugs.gnu.org; Fri, 20 Mar 2020 11:37:11 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jFJhm-0006RX-3S; Fri, 20 Mar 2020 16:37:04 +0100 From: Lars Ingebrigtsen References: <871rq0s9uv.wl-all_but_last@163.com> Date: Fri, 20 Mar 2020 16:37:01 +0100 In-Reply-To: <871rq0s9uv.wl-all_but_last@163.com> (Zhu Zihao's message of "Tue, 10 Mar 2020 19:55:04 +0800") Message-ID: <87sgi3ca1u.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Zhu Zihao writes: > svg-create in svg.el generates a svg without specifying the namespace of xlink. > This may fails the render of a svg with image embed in. > > A SVG example failed to render was provided here: https: [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Zhu Zihao writes: > svg-create in svg.el generates a svg without specifying the namespace of xlink. > This may fails the render of a svg with image embed in. > > A SVG example failed to render was provided here: https://pastebin.com/9QnuMy7Y. > > IMO this patch can help fix this issue. Thanks; applied to Emacs 27.1. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 20 11:37:28 2020 Received: (at control) by debbugs.gnu.org; 20 Mar 2020 15:37:28 +0000 Received: from localhost ([127.0.0.1]:45394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFJiC-0003Jf-Bu for submit@debbugs.gnu.org; Fri, 20 Mar 2020 11:37:28 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFJiA-0003JS-UY for control@debbugs.gnu.org; Fri, 20 Mar 2020 11:37:27 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jFJi3-0006S3-F5 for control@debbugs.gnu.org; Fri, 20 Mar 2020 16:37:21 +0100 Date: Fri, 20 Mar 2020 16:37:19 +0100 Message-Id: <87r1xnca1c.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #40010 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 40010 fixed close 40010 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 40010 fixed close 40010 27.1 quit