GNU bug report logs - #40001
tex-start-options-string not updated in texinfo.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40001 in the body.
You can then email your comments to 40001 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Ernest N. Mamikonyan" <Ernest.Mamikonyan <at> sig.com>
To: bug-gnu-emacs <at> gnu.org
Subject: tex-start-options-string not updated in texinfo.el
Date: Mon, 09 Mar 2020 13:26:44 -0400

Hi,

It seems that 'tex-start-options-string' was not updated to
'tex-start-options' in texinfo.el after the change in version 22.

diff --git a/lisp/textmodes/texinfo.el b/lisp/textmodes/texinfo.el
index 438cb7798a..3898a3ba04 100644
--- a/lisp/textmodes/texinfo.el
+++ b/lisp/textmodes/texinfo.el
@@ -1002,9 +1002,9 @@ texinfo-tex-buffer
   (interactive)
   (require 'tex-mode)
   (let ((tex-command texinfo-texi2dvi-command)
-	;; Disable tex-start-options-string.  texi2dvi would not
-	;; understand anything specified here.
-	(tex-start-options-string ""))
+	;; Disable tex-start-options.  texi2dvi would not understand
+	;; anything specified here.
+	(tex-start-options ""))
     (tex-buffer)))
 
 (defun texinfo-texindex ()


Best,

--
Ernie

Message #8 received at 40001 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Ernest N. Mamikonyan" <Ernest.Mamikonyan <at> sig.com>
Cc: 40001 <at> debbugs.gnu.org
Subject: Re: bug#40001: tex-start-options-string not updated in texinfo.el
Date: Fri, 13 Mar 2020 15:53:54 +0200

> From: "Ernest N. Mamikonyan" <Ernest.Mamikonyan <at> sig.com>
> Date: Mon, 09 Mar 2020 13:26:44 -0400
> 
> It seems that 'tex-start-options-string' was not updated to
> 'tex-start-options' in texinfo.el after the change in version 22.
> 
> diff --git a/lisp/textmodes/texinfo.el b/lisp/textmodes/texinfo.el
> index 438cb7798a..3898a3ba04 100644
> --- a/lisp/textmodes/texinfo.el
> +++ b/lisp/textmodes/texinfo.el
> @@ -1002,9 +1002,9 @@ texinfo-tex-buffer
>    (interactive)
>    (require 'tex-mode)
>    (let ((tex-command texinfo-texi2dvi-command)
> -	;; Disable tex-start-options-string.  texi2dvi would not
> -	;; understand anything specified here.
> -	(tex-start-options-string ""))
> +	;; Disable tex-start-options.  texi2dvi would not understand
> +	;; anything specified here.
> +	(tex-start-options ""))
>      (tex-buffer)))

Should we also bind tex-start-commands to some value (an empty
string)?  If not, why not?

Thanks.

Message #11 received at 40001 <at> debbugs.gnu.org (full text, mbox):

From: "Ernest N. Mamikonyan" <Ernest.Mamikonyan <at> sig.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 40001 <at> debbugs.gnu.org
Subject: Re: bug#40001: tex-start-options-string not updated in texinfo.el
Date: Fri, 13 Mar 2020 10:37:17 -0400

On Fri, Mar 13 2020, Eli Zaretskii wrote:

>> From: "Ernest N. Mamikonyan" <Ernest.Mamikonyan <at> sig.com>
>> Date: Mon, 09 Mar 2020 13:26:44 -0400
>> 
>> It seems that 'tex-start-options-string' was not updated to
>> 'tex-start-options' in texinfo.el after the change in version 22.
>> 
>> diff --git a/lisp/textmodes/texinfo.el b/lisp/textmodes/texinfo.el
>> index 438cb7798a..3898a3ba04 100644
>> --- a/lisp/textmodes/texinfo.el
>> +++ b/lisp/textmodes/texinfo.el
>> @@ -1002,9 +1002,9 @@ texinfo-tex-buffer
>>    (interactive)
>>    (require 'tex-mode)
>>    (let ((tex-command texinfo-texi2dvi-command)
>> -	;; Disable tex-start-options-string.  texi2dvi would not
>> -	;; understand anything specified here.
>> -	(tex-start-options-string ""))
>> +	;; Disable tex-start-options.  texi2dvi would not understand
>> +	;; anything specified here.
>> +	(tex-start-options ""))
>>      (tex-buffer)))
>
> Should we also bind tex-start-commands to some value (an empty
> string)?  If not, why not?

Yes, you're right. Since texi2dvi doesn't take initial commands like
TeX, why not get rid of tex-start-commands but allow the user to supply
command-line options:

diff --git a/lisp/textmodes/texinfo.el b/lisp/textmodes/texinfo.el
index 438cb7798a..a687a27e36 100644
--- a/lisp/textmodes/texinfo.el
+++ b/lisp/textmodes/texinfo.el
@@ -958,6 +958,11 @@ texinfo-texi2dvi-command
   :type 'string
   :group 'texinfo)
 
+(defcustom texinfo-texi2dvi-options ""
+  "Command line options for `texinfo-texi2dvi-command'."
+  :type 'string
+  :group 'texinfo)
+
 (defcustom texinfo-tex-command "tex"
   "Command used by `texinfo-tex-region' to run TeX on a region."
   :type 'string
@@ -1002,9 +1007,10 @@ texinfo-tex-buffer
   (interactive)
   (require 'tex-mode)
   (let ((tex-command texinfo-texi2dvi-command)
-	;; Disable tex-start-options-string.  texi2dvi would not
-	;; understand anything specified here.
-	(tex-start-options-string ""))
+	(tex-start-options texinfo-texi2dvi-options)
+	;; Disable tex-start-commands.  texi2dvi would not understand
+	;; anything specified here.
+        (tex-start-commands ""))
     (tex-buffer)))
 
 (defun texinfo-texindex ()


-- 
Ernie

Message #14 received at 40001 <at> debbugs.gnu.org (full text, mbox):

From: "Ernest N. Mamikonyan" <Ernest.Mamikonyan <at> sig.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 40001 <at> debbugs.gnu.org
Subject: Re: bug#40001: tex-start-options-string not updated in texinfo.el
Date: Mon, 30 Mar 2020 15:25:15 -0400

On Fri, Mar 13 2020, Eli Zaretskii wrote:

> Should we also bind tex-start-commands to some value (an empty
> string)? If not, why not?

Sorry, not sure if you had a chance to look at the previous patch, based
on your suggestion. Do you agree with the approach?

Best,

-- 
Ernie

Message #17 received at 40001 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Ernest N. Mamikonyan" <Ernest.Mamikonyan <at> sig.com>
Cc: 40001 <at> debbugs.gnu.org
Subject: Re: bug#40001: tex-start-options-string not updated in texinfo.el
Date: Tue, 31 Mar 2020 17:10:35 +0300

> From: "Ernest N. Mamikonyan" <Ernest.Mamikonyan <at> sig.com>
> Cc: <40001 <at> debbugs.gnu.org>
> Date: Mon, 30 Mar 2020 15:25:15 -0400
> 
> On Fri, Mar 13 2020, Eli Zaretskii wrote:
> 
> > Should we also bind tex-start-commands to some value (an empty
> > string)? If not, why not?
> 
> Sorry, not sure if you had a chance to look at the previous patch, based
> on your suggestion. Do you agree with the approach?

Yes, I will handle this soon.  Thanks for the reminder.

Message #22 received at 40001-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ernest.Mamikonyan <at> sig.com
Cc: 40001-done <at> debbugs.gnu.org
Subject: Re: bug#40001: tex-start-options-string not updated in texinfo.el
Date: Fri, 03 Apr 2020 15:14:33 +0300

> Date: Tue, 31 Mar 2020 17:10:35 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 40001 <at> debbugs.gnu.org
> 
> > From: "Ernest N. Mamikonyan" <Ernest.Mamikonyan <at> sig.com>
> > Cc: <40001 <at> debbugs.gnu.org>
> > Date: Mon, 30 Mar 2020 15:25:15 -0400
> > 
> > On Fri, Mar 13 2020, Eli Zaretskii wrote:
> > 
> > > Should we also bind tex-start-commands to some value (an empty
> > > string)? If not, why not?
> > 
> > Sorry, not sure if you had a chance to look at the previous patch, based
> > on your suggestion. Do you agree with the approach?
> 
> Yes, I will handle this soon.  Thanks for the reminder.

Thanks, pushed to the master branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.