GNU bug report logs - #39980
[PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Štěpán Němec <stepnem <at> gmail.com>
Cc: larsi <at> gnus.org, 39980 <at> debbugs.gnu.org
Subject: bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error
Date: Sun, 12 Apr 2020 17:35:31 +0300

> From: Štěpán Němec <stepnem <at> gmail.com>
> Cc: larsi <at> gnus.org,  39980 <at> debbugs.gnu.org
> Date: Sun, 12 Apr 2020 16:13:23 +0200
> 
> On Sun, 12 Apr 2020 16:38:57 +0300
> Eli Zaretskii wrote:
> 
> >> You mean instead of reusing an existing function, fix `gnus-shorten-url'
> >> without using it?
> >
> > Almost: the "existing function" doesn't really exist, you introduced
> > it with the same changeset, right?
> 
> No, it's the (hopefully) tried and true `ediff-truncate-string-left',
> only renamed and moved to subr-x to be generally available.

That's exactly what I'd like to avoid on the release branch.  It's
fine for master, of course.


> The changes are cosmetic. It would even be possible (in emacs-27, to
> avoid moving anything), to use `ediff-truncate-string-left'
> unchanged, but that would require gnus-sum to (require 'ediff-init),
> which would be crazy.

It would be crazy and also somewhat risky.

Let's just come up with a local change in gnus-sum, for the emacs-27
branch, okay?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.