Subject: Re: bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error

From: Štěpán Němec <[email-masked]>
Date: Sun, 12 Apr 2020 12:49:33 +0200

On Sun, 12 Apr 2020 13:33:37 +0300
Eli Zaretskii wrote:

>> From: Štěpán Němec <[email-masked]>
>> Cc: [email-masked], Lars Ingebrigtsen <[email-masked]>
>> Date: Sun, 12 Apr 2020 11:53:47 +0200
>> 
>> On Thu, 02 Apr 2020 13:01:35 +0200
>> Lars Ingebrigtsen wrote:
>> 
>> > Štěpán Němec <[email-masked]> writes:
>> >
>> >> Considering the opinions expressed here and in
>> >> https://lists.gnu.org/archive/html/emacs-devel/2020-03/msg00541.html I
>> >> have reverted to defun and autoload the function instead to prevent
>> >> having to load subr-x at runtime whenever gnus-sum is loaded, as it is
>> >> currently only used there by `gnus-summary-browse-url'.
>> >>
>> >> Revised patch attached.
>> >
>> > Looks good to me.
>> 
>> This can go to emacs-27, right? `gnus-summary-browse-url' is new in
>> Emacs 27, it would seem a shame to ship it with this bug.
>
> OK for the change in gnus-summary-browse-url, but let's please leave
> out of emacs-27 changes that aren't necessarily needed to fix the
> original problem; cleanups are for master.

Understood.

> On emacs-27, let's just fix the original problem locally.

The revised patch is upthread
(<https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-03/msg01100.html>)

There are no changes in the patch that are not necessary for fixing the
problem. The ediff changes (only adjusting callers) are necessitated by
moving the helper function to subr-x.el, so that Gnus (or anything else)
can use it, too.

OK?

-- 
Štěpán