From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 06 19:11:53 2020 Received: (at submit) by debbugs.gnu.org; 7 Mar 2020 00:11:53 +0000 Received: from localhost ([127.0.0.1]:46032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAN4G-0007Fd-Oz for submit@debbugs.gnu.org; Fri, 06 Mar 2020 19:11:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:35313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAN4F-0007FW-A3 for submit@debbugs.gnu.org; Fri, 06 Mar 2020 19:11:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43127) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAN4E-000171-1f for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2020 19:11:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jAN4C-0006m9-VE for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2020 19:11:45 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:38943) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jAN4C-0006kw-RI for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2020 19:11:44 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 8F24B22340; Fri, 6 Mar 2020 19:11:44 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 06 Mar 2020 19:11:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm2; bh=5hsqVLf+pXhvVHZEVmbGSB8wvl jIIEYH96EfMG8XK5E=; b=eRaQsUY9dxy1a+4p7Enj1ki0jvfi+wB+KnK6UVV7Ic YAq6YhNvHKaUdoX+szUR4zq4hZICZY6odGZ41zE2cYR8J6KssbHc/56w4WUAq0Cp 4BLrKcLmYqbtHAxObdCa3SniIPHIX04/sN9W75ToNGDFvCWaxJoQMyzhqAXC1kXh wQO4NtjPDSe9JqKq/vRsXoN7Bwc/bizUuFBgHfsmoWKmxGTwGCNghO0lyzr/uYLZ 6CD7zOV/SNK3r8A4O8UNnZF1JNSItMwgTE6qQ+SINjkQEU+bkwQgoF4SzwdZrQKL nH7ckFB0tsi1oL3q3L5JcgwL5eSFTsvsB0zlbSayDf1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=5hsqVLf+pXhvVHZEV mbGSB8wvljIIEYH96EfMG8XK5E=; b=HUkAIU/SYGGdFgtoEz8vul7HsTQfc/FuC Pu8qsIUvhXGqKf8XMx3DEtGKMMxDrRaaAhy27Ev6WcWf3nsUn/E8RFjJQVDwyzW2 D3uoPcQg6NpRCOczOdDrgrAxvFiUuvZE38oLMqLuugaf+wac5YQNyjB2a7j+p/kx 4AiTAd0gbnAi9OZmMe6za9sZVh2WKY4u+k1L0K5eZTH0tO0tpgpR4yG77OBlHAdw 7BHSb8A3RQVba7+2wXPsVwJb7aWrI2a1kEo34OprvALQNsAVc3cw/exK3Plt3dVF /EY9B2gauLfs+czIsVdrnGW5cOOGSjAxU2rM5TP1oyhkUbGwPKSsw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddufedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomheprfhhihhlihhpucfmuceophhhihhlihhpseifrghrphhmrghilhdr nhgvtheqnecuffhomhgrihhnpehgrhgrvhgrthgrrhdrtghomhdplhhisghrrghvrghtrg hrrdhorhhgpdhunhhitghorhhnihhfhidrphhitghtuhhrvghsnecukfhppeejledrvddu ledrudelfedrudeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepphhhihhlihhpseifrghrphhmrghilhdrnhgvth X-ME-Proxy: Received: from localhost (p4fdbc112.dip0.t-ipconnect.de [79.219.193.18]) by mail.messagingengine.com (Postfix) with ESMTPA id DBE4E3280064; Fri, 6 Mar 2020 19:11:43 -0500 (EST) From: Philip K To: bug-gnu-emacs@gnu.org Subject: [PATCH] Add support for multiple gravatar-like services Date: Sat, 7 Mar 2020 01:11:41 +0100 Message-Id: <20200307001141.10771-1-philip@warpmail.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.28 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit Cc: philip.kaludercic@fau.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Specifically, the non-proprietary services libravatar (now default) and unicornify have been added. The behaviour is customised via the new variable `gravatar-service'. --- lisp/image/gravatar.el | 19 +++++++++++++++---- test/lisp/image/gravatar-tests.el | 1 + 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/lisp/image/gravatar.el b/lisp/image/gravatar.el index b8542bc3c3..c1ae0cefe3 100644 --- a/lisp/image/gravatar.el +++ b/lisp/image/gravatar.el @@ -118,9 +118,16 @@ gravatar-force-default :version "27.1" :group 'gravatar) -(defconst gravatar-base-url - "https://www.gravatar.com/avatar" - "Base URL for getting gravatars.") +(defcustom gravatar-service 'libravatar + "Symbol denoting gravatar-like service to use." + :type '(choice (const libravatar) + (const gravatar) + (const unicornify)) + :version "27.1" + :link '(url-link "https://www.libravatar.org/") + :link '(url-link "https://unicornify.pictures/") + :link '(url-link "https://gravatar.com/") + :group 'gravatar) (defun gravatar-hash (mail-address) "Return the Gravatar hash for MAIL-ADDRESS." @@ -142,7 +149,11 @@ gravatar-build-url "Return the URL of a gravatar for MAIL-ADDRESS." ;; https://gravatar.com/site/implement/images/ (format "%s/%s?%s" - gravatar-base-url + (cond ((eq gravatar-service 'gravatar) + "https://www.gravatar.com/avatar") + ((eq gravatar-service 'unicornify) + "https://unicornify.pictures/avatar/") + (t "https://seccdn.libravatar.org/avatar")) (gravatar-hash mail-address) (gravatar--query-string))) diff --git a/test/lisp/image/gravatar-tests.el b/test/lisp/image/gravatar-tests.el index e66b5c6803..31a28293fa 100644 --- a/test/lisp/image/gravatar-tests.el +++ b/test/lisp/image/gravatar-tests.el @@ -65,6 +65,7 @@ gravatar-build-url "Test `gravatar-build-url'." (let ((gravatar-default-image nil) (gravatar-force-default nil) + (gravatar-service 'gravatar) (gravatar-size nil)) (should (equal (gravatar-build-url "foo") "\ https://www.gravatar.com/avatar/acbd18db4cc2f85cedef654fccc4a4d8?r=g")))) -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 07 02:51:52 2020 Received: (at 39965) by debbugs.gnu.org; 7 Mar 2020 07:51:52 +0000 Received: from localhost ([127.0.0.1]:46194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAUFT-0001BI-Mk for submit@debbugs.gnu.org; Sat, 07 Mar 2020 02:51:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAUFS-0001B6-8R for 39965@debbugs.gnu.org; Sat, 07 Mar 2020 02:51:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jAUFL-0005uX-P8; Sat, 07 Mar 2020 02:51:43 -0500 Received: from [176.228.60.248] (port=3010 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jAUFL-0008Sb-4F; Sat, 07 Mar 2020 02:51:43 -0500 Date: Sat, 07 Mar 2020 09:51:42 +0200 Message-Id: <834kv0bo1d.fsf@gnu.org> From: Eli Zaretskii To: Philip K In-Reply-To: <20200307001141.10771-1-philip@warpmail.net> (message from Philip K on Sat, 7 Mar 2020 01:11:41 +0100) Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services References: <20200307001141.10771-1-philip@warpmail.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39965 Cc: philip.kaludercic@fau.de, 39965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Philip K > Date: Sat, 7 Mar 2020 01:11:41 +0100 > Cc: philip.kaludercic@fau.de > > Specifically, the non-proprietary services libravatar (now default) > and unicornify have been added. The behaviour is customised via the > new variable `gravatar-service'. Thanks. I will let the Gnus folks to review this, but I have one nit: > + :version "27.1" This should say "28.1", as the emacs-27 branch doesn't accept new features. Also, we need a NEWS entry describing the new option(s), and possibly also a corresponding change for the Gnus manual. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 09 06:39:29 2020 Received: (at 39965) by debbugs.gnu.org; 9 Mar 2020 10:39:29 +0000 Received: from localhost ([127.0.0.1]:49852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBFom-0003ks-Qo for submit@debbugs.gnu.org; Mon, 09 Mar 2020 06:39:29 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:55088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBFok-0003kW-Sk for 39965@debbugs.gnu.org; Mon, 09 Mar 2020 06:39:27 -0400 Received: by mail-wm1-f54.google.com with SMTP id n8so5211366wmc.4 for <39965@debbugs.gnu.org>; Mon, 09 Mar 2020 03:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=+CXOLs6pa0X4iWzaZpJYG1loj4Wm26F0/p8wiK65vro=; b=Cr22pfpkpZnNPSj2A4lXYymX6ovSlbqosbqy+hV4Kzy8QBpTUiqFxBb+RplAE8iUQu Fe9DkCnMw5em711J2ZtD21vo2PS4LsXEHKh1UtI2/VyDSK96MMMldZQTLsuf/l4JX3n4 HPHRUXX6fnAFt/O4x8AQ2bq6Av19jaziYfGZwwegDokS+Yi7hMUZhR8c+1fRGgylQP4s FcoFj/IfgFNhlWH7Jv2JkTUPUeHW8Mvdm/cZRfVpChXYEej9zpHhFX+4RcD7iycIKspF AiDXGHs+C5HGqDL5MAbdV1NMixtE6xF3rdUuq2gt5ICc2gE0/x6V+876iVbfe/HKbtMU rSBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=+CXOLs6pa0X4iWzaZpJYG1loj4Wm26F0/p8wiK65vro=; b=I1tmz842eLTtalKuFvCi9FY2u7ryOkGPmVlF0UQuT1gA6/zv/uofa9KYnPF8T4QMfF YuLNUlS1N8utBagunpkSLcbDwQaLw3+EFtShcej5/gvGt82znKtsp9wxDv6ks4IwwLtK WfdzNlcd77HNL0aIcCXwsxy9M0+7juqWxnHGTlmd2FWAEDJbSuHEsaLVyE0qrTOBnxg3 Bp1HA0mtlj7dvfS4cSHl51mjZ5cbpSpOuyJPDMF3JsFzWcW9k0bLP8PYzPRv35xKATEK ITeByiLnJmHXuYS/AuKWzcN9anwexUOkNjAtCiV2FPiPRbGi+XidMRMM/LsUNZ75EEXX aQgw== X-Gm-Message-State: ANhLgQ1WWlnxQ8TQ0qIz3yJxxMeisMIQPGR1duV4LP4jLpaYKGRrTldz F3MN2c8oE41Fo3UVFn0uyCM= X-Google-Smtp-Source: ADFU+vszSH9HcXh/8rZ44zj4oP1HtyKpJMPew5YVFDtIThePBpdqu4+gCXph7uEOZql0vFoScBUWuw== X-Received: by 2002:a1c:a307:: with SMTP id m7mr20499186wme.144.1583750360775; Mon, 09 Mar 2020 03:39:20 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id a184sm24991361wmf.29.2020.03.09.03.39.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2020 03:39:19 -0700 (PDT) From: Robert Pluim To: Philip K Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services References: <20200307001141.10771-1-philip@warpmail.net> Date: Mon, 09 Mar 2020 11:39:18 +0100 In-Reply-To: <20200307001141.10771-1-philip@warpmail.net> (Philip K.'s message of "Sat, 7 Mar 2020 01:11:41 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39965 Cc: philip.kaludercic@fau.de, 39965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Sat, 7 Mar 2020 01:11:41 +0100, Philip K said: Philip> Specifically, the non-proprietary services libravatar (now default) Philip> and unicornify have been added. The behaviour is customised via the Philip> new variable `gravatar-service'. Philip> --- Philip> lisp/image/gravatar.el | 19 +++++++++++++++---- Philip> test/lisp/image/gravatar-tests.el | 1 + Philip> 2 files changed, 16 insertions(+), 4 deletions(-) Philip> diff --git a/lisp/image/gravatar.el b/lisp/image/gravatar.el Philip> index b8542bc3c3..c1ae0cefe3 100644 Philip> --- a/lisp/image/gravatar.el Philip> +++ b/lisp/image/gravatar.el Philip> @@ -118,9 +118,16 @@ gravatar-force-default Philip> :version "27.1" Philip> :group 'gravatar) Philip> -(defconst gravatar-base-url Philip> - "https://www.gravatar.com/avatar" Philip> - "Base URL for getting gravatars.") Philip> +(defcustom gravatar-service 'libravatar Philip> + "Symbol denoting gravatar-like service to use." Philip> + :type '(choice (const libravatar) Philip> + (const gravatar) Philip> + (const unicornify)) Philip> + :version "27.1" Philip> + :link '(url-link "https://www.libravatar.org/") Philip> + :link '(url-link "https://unicornify.pictures/") Philip> + :link '(url-link "https://gravatar.com/") Philip> + :group 'gravatar) If you make this an alist then your cond below becomes just 'alist-get', and you have the URLS in just one place. Philip> (defun gravatar-hash (mail-address) Philip> "Return the Gravatar hash for MAIL-ADDRESS." Philip> @@ -142,7 +149,11 @@ gravatar-build-url Philip> "Return the URL of a gravatar for MAIL-ADDRESS." Philip> ;; https://gravatar.com/site/implement/images/ Philip> (format "%s/%s?%s" Philip> - gravatar-base-url Philip> + (cond ((eq gravatar-service 'gravatar) Philip> + "https://www.gravatar.com/avatar") Philip> + ((eq gravatar-service 'unicornify) Philip> + "https://unicornify.pictures/avatar/") Philip> + (t "https://seccdn.libravatar.org/avatar")) Philip> (gravatar-hash mail-address) Philip> (gravatar--query-string))) This is changing the default from gravatar->libravatar, won't that break stuff? Robert From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 09 11:04:21 2020 Received: (at 39965) by debbugs.gnu.org; 9 Mar 2020 15:04:21 +0000 Received: from localhost ([127.0.0.1]:51329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBJx7-0005zJ-I6 for submit@debbugs.gnu.org; Mon, 09 Mar 2020 11:04:21 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:34418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBJx6-0005z6-0d for 39965@debbugs.gnu.org; Mon, 09 Mar 2020 11:04:21 -0400 Received: by mail-wm1-f50.google.com with SMTP id x3so102600wmj.1 for <39965@debbugs.gnu.org>; Mon, 09 Mar 2020 08:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=0Ei2bWPBSj+Xm7bZIcPAeSrb6aHRuXbjd83xSzXVjzc=; b=coY3Y8eT5ds3QoidWhyCLm9CfhRYkLkB2pdbUEMUfuK7QTY1nffmhoQ00tdV3/kwZ4 5xxmZ3nwJwaAHpryC5TeOIoqcqOBfht43rBv6poRqvV2+oWlpJJ8p3CzSmRIYtUNiWT6 TSb1cPbmh33df6D2yx/VeJzmWhmsQRtxhC3Drk7C+pn2orZMDkIb3AHavwq5IyCQIWQB ACNptlSQjdM0d2uCFFfLNFgxq5tF/L9k5ae7JR3uin9fhI8A55QBElNv5aiDi6NWZDEQ EE6mxyLPOiTeXBjtt4bkie3tVRdHx8ZZiGwLmrDRl+i93TGcAr4YxyRrNpO+AdVtQ+kL zgbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=0Ei2bWPBSj+Xm7bZIcPAeSrb6aHRuXbjd83xSzXVjzc=; b=BcQ2djn4DpS9vEMupKRU/aKY8fp23vFUI9O/SqJm1+NhO6LFz8P+prrh4QX7ufidHx IwOMK0y8PFrN1QujClZN7MUbXbmnFuPupDBPHV4s0pCIPuK59nYFQIt7N0v3v2TVDav3 B3zNfs1MXckjBW8nwWRcTMdS09mnNB4sZW6L7jJ5IRMcx4noaADWSQNYtA4+k5wnvlXP EyPmA28eMMqwJJra/pcqbStivrYzgAjHP5b19+/XUZt8WY4muX045LQZO+NKebkVxC2h +v+/+ejPm/ao+rLMacieAirl89KwhLHyKr9HQl2s1oAGnDlPlFvxrz9YfFfKK+TdI4Vj LMlw== X-Gm-Message-State: ANhLgQ1+smr8MZPv3i2DZOnukaIyWWynXaCK4pMzEiTgEGFVPlFFKhrX yf2qbXYUG42+brDHufHZ191YetRL X-Google-Smtp-Source: ADFU+vsteGw+l+buGShXHGDPF2FKHYYteBwJPRbPi4rHO2DVIDu1czVq4MX4ZXaodW+mVZkZLWvkMg== X-Received: by 2002:a7b:c305:: with SMTP id k5mr21484564wmj.189.1583766251314; Mon, 09 Mar 2020 08:04:11 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id k2sm30822227wrn.57.2020.03.09.08.04.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2020 08:04:09 -0700 (PDT) From: Robert Pluim To: Philip Kaludercic Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services References: <20200307001141.10771-1-philip@warpmail.net> Date: Mon, 09 Mar 2020 16:04:08 +0100 In-Reply-To: (Philip Kaludercic's message of "Mon, 09 Mar 2020 15:48:59 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39965 Cc: 39965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) (please keep 39965@debbugs.gnu.org in the CC list) >>>>> On Mon, 09 Mar 2020 15:48:59 +0100, Philip Kaludercic said: >>=20 >> If you make this an alist then your cond below becomes just >> 'alist-get', and you have the URLS in just one place. Philip> That's right, I had already "fixed" that in the next version of= the Philip> patch, but primarily because libravatar requires a bit more to = work Philip> correctly than just alist-get. OK Philip> Sadly I cannot send the patch right now, because git-send-email= doesn't Philip> work from where I am writing. git format-patch HEAD~ + attaching the result will work as well, assuming your MUA doesn=CA=BCt mangle patches :-) >> This is changing the default from gravatar->libravatar, won't that >> break stuff? Philip> All Gravatar avatars should still be resolved as they have been= until Philip> now (just via Libravatar's servers). The only user-visible chan= ge is Philip> that people who just use Libravatar will also have avatar image= s. Philip> If there is too much Resistance towards changing this, it shoul= dn't be a Philip> problem to keep gravatar the default, but as mentioned in the c= ommit Philip> message, I think that it is somewhat dubious for *Emacs* to def= ault to a Philip> proprietary service. If the avatars are still resolved, then I think there=CA=BCs no issue with changing the default (especially considering it wasn=CA=BCt configurable before). Thanks for clarifying. Robert From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 09 11:35:55 2020 Received: (at 39965) by debbugs.gnu.org; 9 Mar 2020 15:35:55 +0000 Received: from localhost ([127.0.0.1]:51349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBKRf-0006kH-A3 for submit@debbugs.gnu.org; Mon, 09 Mar 2020 11:35:55 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:52368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBKRd-0006k4-Lh for 39965@debbugs.gnu.org; Mon, 09 Mar 2020 11:35:54 -0400 Received: by mail-wm1-f52.google.com with SMTP id p9so10454563wmc.2 for <39965@debbugs.gnu.org>; Mon, 09 Mar 2020 08:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=NeAtSORMM6u66sv/WNTEcgY4xzYgaDwhSDLFJJ5o8Hc=; b=d/0+ETNNwp2+9Bw1j+u0QTq0D7bD2lszH4ETGK42bWyRTVrK4U1+N25EkK3QRRHhZF 8gQjIMm1vs0gyK77vOgT+cqrWGdLz0FR9npcvb5TWXHSLMARk+IPGQ/3DNeV5zz1Eomw T7znuj/S/0Aw3q0BYyAohmlHYEmPYmzuaziEQ6S5mjkr1WCZD4XNgHuw8wh8yVE/H+ka eAb47lfSvFOqQzRZzjJY0CREwkvgTjgExRao5ScfAy2xXK4HOIl1O5Z9J4TSpb4zrDld yoBl6AWt9pfBy9f4L5akFdPsW3M+/0WqJV6mL8O2dFlYAqL3soajDaEOI3mLAlzvKO8y MZAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=NeAtSORMM6u66sv/WNTEcgY4xzYgaDwhSDLFJJ5o8Hc=; b=lb+4IJilbkm4jYgJp4AH8hUQES8pcmb1fK6uVEqBl51aVXHRDY6lKHq0gNvglz/VHh h1sPytwpxbHWQwJOSZM48w8st6JZ32uKOhIMR0YRi6Bgd6yXE64R4j5a4HMsSEBEjJ+X PtN/rZVqqxdQJPmWZ4t9GjZbeEJQrett/FallTeVUy9InRCglb8Y+XoDkKOrZU51bZLM fVkvt+vcrdWtqgTy/Z0rPYmKE7C0/LOQL4wzAM7g3/v615lE9FdbU+3MfG5YUMZDapdj L7TXFK2G49cKxZ5Sm1geT8qgJXW71YDdhUfhlyK9jBlw+wyWdMY8ST4I4wVpYRkyRVIj pBCw== X-Gm-Message-State: ANhLgQ2DJ5P72ah82BGCCauHZD1dclaplZl+8Bnn01VaFuXnke3pZcCE HNoUXDgXkzzKl7EZ20pPdSRSVPI5 X-Google-Smtp-Source: ADFU+vspr9vLIADbdlrSPEdy/0Vlpr0gO6WXrmBWse/+BgFk2yxFZnVZPyeEiRs2McR8vtJ+ZOmsvQ== X-Received: by 2002:a05:600c:21c6:: with SMTP id x6mr20302110wmj.17.1583768147325; Mon, 09 Mar 2020 08:35:47 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id a7sm6671001wrn.25.2020.03.09.08.35.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2020 08:35:46 -0700 (PDT) From: Robert Pluim To: Philip Kaludercic Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services References: <20200307001141.10771-1-philip@warpmail.net> Date: Mon, 09 Mar 2020 16:35:45 +0100 In-Reply-To: (Philip Kaludercic's message of "Mon, 09 Mar 2020 16:10:48 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39965 Cc: 39965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 09 Mar 2020 16:10:48 +0100, Philip Kaludercic said: Philip> In that case I'm attaching the patch to this mail, I hope Gnus = handels Philip> it corretly.=20 I hand't realised you were using the One True Emacs Mail Agent. Of course it works. Philip> From 5c967bc9e2c3bc72e3803d84b23b8b121328c49c Mon Sep 17 00:00:= 00 2001 Philip> From: Philip K Philip> Date: Fri, 6 Mar 2020 12:40:28 +0100 Philip> Subject: [PATCH] Add support for multiple gravatar-like services Philip> Specifically, the non-proprietary services libravatar (now defa= ult) Philip> and unicornify have been added. The behaviour is customised via= the Philip> new variable `gravatar-service'. This is missing a ChangeLog style comment. There are various ways to produce that, the easiest is probably: C-x v d ; vc-dir m ; mark the files you want to commit v ; vc-next-action, which will put you in a commit message buffer C-c C-w ; this will look through the diffs of the files you=CA=BCre ; commiting and pre-populate the commit message with ; file/function/variable names. You then fill in the details ; of what you changed. Of course, a preamble like you had explaining the 'why' of the change is also good. See "** Commit messages" in CONTRIBUTE for a more detailed description of the desired format for commit messages. Philip> +--- Philip> +*** New variable `gravatar-service' changes avatar service. Philip> +Now supports Libravatar (as default) and Unicornify, next to t= he Philip> +already implemented Gravatar. Philip> + We normally call these 'user options', and don=CA=BCt use back-quotes in NEWS, and try to have the first line be a complete sentence, so: ** Gravatar =3D=3D=3D *** New user-option 'gravatar-service' for host to query for gravatars. Defaults to Libravatar, with Unicornify and Gravatar as options. Thanks for your patch. Robert From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 09 12:17:12 2020 Received: (at 39965) by debbugs.gnu.org; 9 Mar 2020 16:17:12 +0000 Received: from localhost ([127.0.0.1]:51365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBL5b-0007mn-Fo for submit@debbugs.gnu.org; Mon, 09 Mar 2020 12:17:12 -0400 Received: from mx-rz-2.rrze.uni-erlangen.de ([131.188.11.21]:43741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBK3R-00068W-BG for 39965@debbugs.gnu.org; Mon, 09 Mar 2020 11:10:54 -0400 Received: from mx-rz-smart.rrze.uni-erlangen.de (mx-rz-smart.rrze.uni-erlangen.de [IPv6:2001:638:a000:1025::1e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mx-rz-2.rrze.uni-erlangen.de (Postfix) with ESMTPS id 48bhVz4VHFzPjw4; Mon, 9 Mar 2020 16:10:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fau.de; s=fau-2013; t=1583766651; bh=Znzyo8McE+qyI3SKYR3tBC0emyd/SU6llTKiMRPVJ8k=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:To:CC: Subject; b=E/2DT4E/qpE5IHnvzxG+0u6FsIfkJev5JgE/SD1Rs1cDpooUaARblP5a3DRU37jZK pxoIFytYSAqWTK3h8MsXc0u3FtIA8TzBsRUfs0N/9ucok8ldnwYXL4RNseIzocUPYG /M9pU1iqtAtcCopNbjDQrEDrpJJipsmHosR+pz5+SkGkVHmZ82oupzVXBLct4LCd1f XOA6KENaMOg89Wr8JLl5upfldihLamEATqpVaBFd7P3e6e2O+77ieea7XNAbiVLNWB vpqLR7BShioQ/8Kv0D8WHu6b6laOl38oXGjHasusdy0e2vwxNcv0W64ExI6Mq4t8/q xUEotevwDj6EA== X-Virus-Scanned: amavisd-new at boeck2.rrze.uni-erlangen.de (RRZE) X-RRZE-Flag: Not-Spam X-RRZE-Submit-IP: 2001:638:a000:4160:131:188:60:167 Received: from cip6b5 (cip6b5.cip.cs.fau.de [IPv6:2001:638:a000:4160:131:188:60:167]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: U2FsdGVkX1/UQKWwlvHT64pE62JLAx40C2CSuKwp+ic=) by smtp-auth.uni-erlangen.de (Postfix) with ESMTPSA id 48bhVw54W1zPjxH; Mon, 9 Mar 2020 16:10:48 +0100 (CET) From: Philip Kaludercic To: Robert Pluim Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services References: <20200307001141.10771-1-philip@warpmail.net> Date: Mon, 09 Mar 2020 16:10:48 +0100 In-Reply-To: (Robert Pluim's message of "Mon, 09 Mar 2020 16:04:08 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39965 X-Mailman-Approved-At: Mon, 09 Mar 2020 12:17:11 -0400 Cc: 39965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Robert Pluim writes: > (please keep 39965@debbugs.gnu.org in the CC list) Sorry for that! >>>>>> On Mon, 09 Mar 2020 15:48:59 +0100, Philip Kaludercic said: > > >>=20 > >> If you make this an alist then your cond below becomes just > >> 'alist-get', and you have the URLS in just one place. > > Philip> That's right, I had already "fixed" that in the next version = of the > Philip> patch, but primarily because libravatar requires a bit more t= o work > Philip> correctly than just alist-get. > > OK > > Philip> Sadly I cannot send the patch right now, because git-send-ema= il doesn't > Philip> work from where I am writing. > > git format-patch HEAD~ + attaching the result will work as > well, assuming your MUA doesn=CA=BCt mangle patches :-) In that case I'm attaching the patch to this mail, I hope Gnus handels it corretly.=20 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-support-for-multiple-gravatar-like-services.patch >From 5c967bc9e2c3bc72e3803d84b23b8b121328c49c Mon Sep 17 00:00:00 2001 From: Philip K Date: Fri, 6 Mar 2020 12:40:28 +0100 Subject: [PATCH] Add support for multiple gravatar-like services Specifically, the non-proprietary services libravatar (now default) and unicornify have been added. The behaviour is customised via the new variable `gravatar-service'. --- etc/NEWS | 7 ++++++ lisp/image/gravatar.el | 37 +++++++++++++++++++++++++++---- test/lisp/image/gravatar-tests.el | 1 + 3 files changed, 41 insertions(+), 4 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 7f70d149d6..24edf2de6a 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -171,6 +171,13 @@ key binding / v package-menu-filter-by-version / / package-menu-filter-clear +** gravatar.el + +--- +*** New variable `gravatar-service' changes avatar service. +Now supports Libravatar (as default) and Unicornify, next to the +already implemented Gravatar. + * New Modes and Packages in Emacs 28.1 diff --git a/lisp/image/gravatar.el b/lisp/image/gravatar.el index b8542bc3c3..4ac545730a 100644 --- a/lisp/image/gravatar.el +++ b/lisp/image/gravatar.el @@ -118,9 +118,37 @@ gravatar-force-default :version "27.1" :group 'gravatar) -(defconst gravatar-base-url - "https://www.gravatar.com/avatar" - "Base URL for getting gravatars.") +(defconst gravatar-service-alist + `((gravatar . ,(lambda (_addr) "https://www.gravatar.com/avatar")) + (unicornify . ,(lambda (_addr) "https://unicornify.pictures/avatar/")) + (libravatar . ,#'gravatar--service-libravatar)) + "Alist of supported gravatar services.") + +(defcustom gravatar-service 'libravatar + "Symbol denoting gravatar-like service to use. +Note that certain services might ignore other options, such as +`gravatar-default-image' or certain values as with +`gravatar-rating'." + :type `(choice ,@(mapcar (lambda (s) `(const ,(car s))) + gravatar-service-alist)) + :version "28.1" + :link '(url-link "https://www.libravatar.org/") + :link '(url-link "https://unicornify.pictures/") + :link '(url-link "https://gravatar.com/") + :group 'gravatar) + +(defun gravatar--service-libravatar (addr) + "Find domain that hosts avatars for email address ADDR." + ;; implements https://wiki.libravatar.org/api/ + (require 'dns) + (let* ((domain (save-match-data + (unless (string-match ".+@\\(.+\\)" addr) + (error "%s is not an email address" addr)) + (match-string 1 addr))) + (result (dns-query (concat "_avatars._tcp." domain) 'SRV))) + (if result + (concat "http://" result "/address") + "https://seccdn.libravatar.org/avatar"))) (defun gravatar-hash (mail-address) "Return the Gravatar hash for MAIL-ADDRESS." @@ -142,7 +170,8 @@ gravatar-build-url "Return the URL of a gravatar for MAIL-ADDRESS." ;; https://gravatar.com/site/implement/images/ (format "%s/%s?%s" - gravatar-base-url + (funcall (cdr (assq gravatar-service gravatar-service-alist)) + mail-address) (gravatar-hash mail-address) (gravatar--query-string))) diff --git a/test/lisp/image/gravatar-tests.el b/test/lisp/image/gravatar-tests.el index e66b5c6803..31a28293fa 100644 --- a/test/lisp/image/gravatar-tests.el +++ b/test/lisp/image/gravatar-tests.el @@ -65,6 +65,7 @@ gravatar-build-url "Test `gravatar-build-url'." (let ((gravatar-default-image nil) (gravatar-force-default nil) + (gravatar-service 'gravatar) (gravatar-size nil)) (should (equal (gravatar-build-url "foo") "\ https://www.gravatar.com/avatar/acbd18db4cc2f85cedef654fccc4a4d8?r=g")))) -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 09 19:53:13 2020 Received: (at 39965) by debbugs.gnu.org; 9 Mar 2020 23:53:13 +0000 Received: from localhost ([127.0.0.1]:51640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBSCv-0006Ej-6p for submit@debbugs.gnu.org; Mon, 09 Mar 2020 19:53:13 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:55629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBSCt-0006EU-TY for 39965@debbugs.gnu.org; Mon, 09 Mar 2020 19:53:12 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 669182224E; Mon, 9 Mar 2020 19:53:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 09 Mar 2020 19:53:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:cc:subject:in-reply-to:date:message-id:mime-version :content-type:content-transfer-encoding; s=fm2; bh=krHqzO3akk2yT xGixomC/wOCxfFvlDfsBP06URKlt04=; b=V2SN4Mqcw8cvt3Qlqd0TYDJfOh8KC fz86e7MKNbDOmHImJIRYNUyJDqlyjn6FZvsOoIxd8cKsFiQIWQKiAhYB9DzPkvql ZtQBnAkV3GfdqOAKRE1tFTtAUKcl/Z/d1KH7Gx3ps54D2FLvk7OTHa2+C/QfJt1s MRMih8ITBVCXMtnrNOHm1crWE/rfD/4LBfODRYNR1tI19HcyNQnijrobyW4bRbTz WcQGGKQ324ho6SU+8be/7YxxF4JGbWC1Keqs1UbM2he5ypl74NMXAWeJ15lRBji9 4eGRul19N05b/UaRTzZl+oedxp0+eW5wVYLD7HpVKWnfaARs6mZHkXBTw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=krHqzO3akk2yTxGixomC/wOCxfFvlDfsBP06URKlt04=; b=CWZHjLqG VCL0jYpM/SVxQPeJom7DGLtU7Pd++JpyK6+JD85I9YPSBhgJdmAXm9iLROyfMZS/ 8BeZNyRFm9uFcyqtBci/sDXWc4LaOzPu+FnpxkA3g8L4GF6TRJaaXh7Mnu7N8ZLK JSKUXZW08SKlVRYPJelLGoKgr8itgWMDVzdxDPQyr5Hn5n7EE4eh0nwTTi7t27+9 C4vMAWV6ihtj0LdlqI9MD4/pPFJEr5CjXW4eTzP2a2iwjphMo2N2wXxUmQIjk481 8XXO5nOmvIdlNuzCck5JCVdZY1Q3NJPTnWNLFuzvCntKIxqNJWQR47GYxNv3RVe1 rfyjhl8zTtvmUg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudduledgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfffkgggtgfesthhqredttddtjeenucfhrhhomhepphhhihhlihhp seifrghrphhmrghilhdrnhgvthculdfrhhhilhhiphcumfdrmdenucfkphepjeelrddvud elrdduleefrddukeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehphhhilhhiphesfigrrhhpmhgrihhlrdhnvght X-ME-Proxy: Received: from localhost (p4fdbc112.dip0.t-ipconnect.de [79.219.193.18]) by mail.messagingengine.com (Postfix) with ESMTPA id 9A5FD328005A; Mon, 9 Mar 2020 19:53:05 -0400 (EDT) From: philip@warpmail.net (Philip K.) To: Robert Pluim Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services In-Reply-To: (message from Robert Pluim on Mon, 09 Mar 2020 16:35:45 +0100) Date: Tue, 10 Mar 2020 00:53:02 +0100 Message-ID: <87r1y1t7a9.fsf@bulbul> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39965 Cc: 39965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Robert Pluim writes: >>>>>> On Mon, 09 Mar 2020 16:10:48 +0100, Philip Kaludercic said: > > Philip> From 5c967bc9e2c3bc72e3803d84b23b8b121328c49c Mon Sep 17 00:0= 0:00 2001 > Philip> From: Philip K > Philip> Date: Fri, 6 Mar 2020 12:40:28 +0100 > Philip> Subject: [PATCH] Add support for multiple gravatar-like servi= ces > > Philip> Specifically, the non-proprietary services libravatar (now de= fault) > Philip> and unicornify have been added. The behaviour is customised v= ia the > Philip> new variable `gravatar-service'. > > This is missing a ChangeLog style comment. There are various ways to > produce that, the easiest is probably: > > C-x v d ; vc-dir > m ; mark the files you want to commit > v ; vc-next-action, which will put you in a commit message buffer > C-c C-w ; this will look through the diffs of the files you=CA=BCre > ; commiting and pre-populate the commit message with > ; file/function/variable names. You then fill in the details > ; of what you changed. > > Of course, a preamble like you had explaining the 'why' of the change > is also good. > > See "** Commit messages" in CONTRIBUTE for a more detailed description > of the desired format for commit messages. I have been trying what you mention and what the "Commit message" section describes, but I just cannot execute C-c C-w, nor can I find it anywhere. What command is it supposed to call? We are talking about the "*vc-log*" buffer, aren't we? > We normally call these 'user options', and don=CA=BCt use back-quotes in > NEWS, and try to have the first line be a complete sentence, so: > > ** Gravatar > > =3D=3D=3D > *** New user-option 'gravatar-service' for host to query for gravatars. > Defaults to Libravatar, with Unicornify and Gravatar as options. I'll just use your log message, it sound a lot better. --=20 With kind regards, Philip K. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 09 21:58:25 2020 Received: (at 39965) by debbugs.gnu.org; 10 Mar 2020 01:58:25 +0000 Received: from localhost ([127.0.0.1]:51679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBUA4-0000pv-Q5 for submit@debbugs.gnu.org; Mon, 09 Mar 2020 21:58:24 -0400 Received: from mail-qt1-f181.google.com ([209.85.160.181]:38485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBUA3-0000pg-1Z for 39965@debbugs.gnu.org; Mon, 09 Mar 2020 21:58:23 -0400 Received: by mail-qt1-f181.google.com with SMTP id e20so8602822qto.5 for <39965@debbugs.gnu.org>; Mon, 09 Mar 2020 18:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=YLhnwOeUQpFkPi9a4/b0PBu8ynvL/CCStnfwsgv63oc=; b=UM0fIQMNDZktrBI9ecp44UoXGilqPgNkIZUMy8k6eQpkpgPJ4PTqJCZjCGuE9WoIOP wWeLjtitcLNTuxfHHdp9i4FBZneeuU3vVGOx1vsSM0YXlfZuyS6+RtYU6nl1/iE6EcvR xNVd5vh8QDtXzxiCEsaJEIGwqQ88im0MPt7jM36hfAWvqZWJK1OMJcgSl1yH93If89dd U/aoi0hJVR6Qp6HgQPBQC/vtwOvBUKjkYeMn6mkBJ6cMVR9w5yhIszXZbVDqp58qTKTa PgHqa4tvMpF1cRVafI5aplcIHdUjwsUjblEV6uYgyUKdYhjIeINwSZSQc0NmH5jPZzXB yOiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=YLhnwOeUQpFkPi9a4/b0PBu8ynvL/CCStnfwsgv63oc=; b=X+WmJtyoAYEdrEGfrwUlGewbI+ebw3VJnjmbqE8oVqQYc/fiq3U9OGBIoSmwEEqzx4 ODu/0NwUR1vJMn+XIIwMozM2FP/dImMpupit0eQYriI5DQuJfuzU9XITir7CuN+UJJDn kvSMFsztXKunkiN/nVuedN72uWV8zd7wgMwyDZIIkIWjUtNSo70/GGh2DJPXblzWI+LS c5gD7jxamI+Q8zFtGxmsIGX+Ga2/QDjtbQMGeMJ3Uoa411LFPZR7nFz3+ShwV3UB6yFy lZfVRp+mdzwXssIUouABkJ+uyZ+GRrMthGnESxPUGOjfWx5IXXd3QAaG+dNTxrZj9k5H vV7w== X-Gm-Message-State: ANhLgQ30Znf18bm0WhUi4So4o7SYQAvdKlNYDHiJdMx+Gt/5WCLDEzaF aYh9RC3tPVNJcp5/IdV1mvEHSeNM X-Google-Smtp-Source: ADFU+vtwRmB4u4OG/4+T5xK8zobQR2wo/WE8ohLt5STFghOIvMDHNnpAk6BoFkAr6wja8rPb7jOYLQ== X-Received: by 2002:aed:3e8e:: with SMTP id n14mr14662817qtf.245.1583805497282; Mon, 09 Mar 2020 18:58:17 -0700 (PDT) Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id x6sm3227850qke.43.2020.03.09.18.58.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Mar 2020 18:58:16 -0700 (PDT) From: Noam Postavsky To: philip@warpmail.net (Philip K.) Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services References: <20200307001141.10771-1-philip@warpmail.net> <87r1y1t7a9.fsf@bulbul> Date: Mon, 09 Mar 2020 21:58:15 -0400 In-Reply-To: <87r1y1t7a9.fsf@bulbul> (Philip K.'s message of "Tue, 10 Mar 2020 00:53:02 +0100") Message-ID: <87y2s96keg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 39965 Cc: Robert Pluim , 39965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) philip@warpmail.net (Philip K.) writes: > I have been trying what you mention and what the "Commit message" > section describes, but I just cannot execute C-c C-w, nor > can I find it anywhere. What command is it supposed to call? We are > talking about the "*vc-log*" buffer, aren't we? Assuming you are running Emacs 27, then yes, it should work in the *vc-log* buffer. C-c C-w runs the command log-edit-generate-changelog-from-diff (found in vc-git-log-edit-mode-map), which is an interactive compiled Lisp function in =E2=80=98log-edit.el=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 10 05:31:55 2020 Received: (at submit) by debbugs.gnu.org; 10 Mar 2020 09:31:55 +0000 Received: from localhost ([127.0.0.1]:51880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBbEr-0003nh-S9 for submit@debbugs.gnu.org; Tue, 10 Mar 2020 05:31:55 -0400 Received: from lists.gnu.org ([209.51.188.17]:45524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBbEq-0003nT-2O for submit@debbugs.gnu.org; Tue, 10 Mar 2020 05:31:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59104) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBbEn-0004uM-4B for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2020 05:31:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_40,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBbEl-0006po-7a for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2020 05:31:44 -0400 Received: from mx-rz-2.rrze.uni-erlangen.de ([131.188.11.21]:41189) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBbEk-0006Qj-Gw for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2020 05:31:43 -0400 Received: from mx-rz-smart.rrze.uni-erlangen.de (mx-rz-smart.rrze.uni-erlangen.de [IPv6:2001:638:a000:1025::1e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mx-rz-2.rrze.uni-erlangen.de (Postfix) with ESMTPS id 48c8wy6BwlzPkVf; Tue, 10 Mar 2020 10:31:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fau.de; s=fau-2013; t=1583832690; bh=5C2gOBGMSihKPOiRoc/B9jQK79wpobRJaIv/x4c7x2o=; h=From:To:Cc:Subject:In-Reply-To:Date:From:To:CC:Subject; b=hGD7VHr6mVgyvalwSZbLnD2vK0JZXosvwHaavjo8O6LsFDy+uq426PTtASBjfrkor wHm3lGx0JRGV/32iSXyGYcvXBClDODpGbyq8RKSmdrWBnLBBY3Q+UL6tnbE4KOCV8S v+WQJWSEegGwq5rBaUxFZfyfc0CbWL2MAw/WbKBj9YvClOcEzxxV7HbRyTxh7gaMcB mVOXr5MdwbLaTKXLKrp6tu0LPNC/VPGrb1xKUE2fkx/tZ9oospNv2DGiN0x20WPsro fSMq2RKWiOn7XXMwaHMFhqs6oQuw38R+/dhq3fdLOwJOxgkIBbkddoKwOOSx3jHI/y j4PgYP7MkDGLQ== X-Virus-Scanned: amavisd-new at boeck2.rrze.uni-erlangen.de (RRZE) X-RRZE-Flag: Not-Spam X-RRZE-Submit-IP: 2001:638:a000:4160:131:188:60:167 Received: from cip6b5 (cip6b5.cip.cs.fau.de [IPv6:2001:638:a000:4160:131:188:60:167]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: U2FsdGVkX1+Y29kNsiTtkjPEqfNlueT8BuZxar1+jlg=) by smtp-auth.uni-erlangen.de (Postfix) with ESMTPSA id 48c8ww001nzPjx8; Tue, 10 Mar 2020 10:31:27 +0100 (CET) From: Philip K. To: rpluim@gmail.com Subject: bug#39965: [PATCH] Add support for multiple gravatar-like services In-Reply-To: m25zfdee26.fsf@gmail.com Date: Tue, 10 Mar 2020 10:31:27 +0100 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 131.188.11.21 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --=-=-= Content-Type: text/plain Sorry for the delay, I hope the commit message is ok now. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-support-for-multiple-Gravatar-services.patch >From 45ef168f4c7b2c0195de040570fa613c89e41ae4 Mon Sep 17 00:00:00 2001 From: Philip K Date: Tue, 10 Mar 2020 10:21:08 +0100 Subject: [PATCH] Add support for multiple Gravatar services Now supports Libravatar and Unicornify, next to Gravatar. * lisp/image/gravatar.el (gravatar-base-url): Remove constant. (gravatar-service-alist): List supported services. (gravatar-service): Add user option to specify service, defaults to Libravatar. (gravatar--service-libravatar): Add libravatar image host resolver implementation. (gravatar-build-url): Use alist gravatar-service-alist instead of gravatar-base-url. * etc/NEWS: Add note. --- etc/NEWS | 6 ++++++ lisp/image/gravatar.el | 37 +++++++++++++++++++++++++++++++++---- 2 files changed, 39 insertions(+), 4 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 7f70d149d6..7d9f858555 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -171,6 +171,12 @@ key binding / v package-menu-filter-by-version / / package-menu-filter-clear +** Gravatar + +=== +*** New user-option 'gravatar-service' for host to query for gravatars. +Defaults to Libravatar, with Unicornify and Gravatar as options. + * New Modes and Packages in Emacs 28.1 diff --git a/lisp/image/gravatar.el b/lisp/image/gravatar.el index b8542bc3c3..9b4e93275d 100644 --- a/lisp/image/gravatar.el +++ b/lisp/image/gravatar.el @@ -118,9 +118,37 @@ gravatar-force-default :version "27.1" :group 'gravatar) -(defconst gravatar-base-url - "https://www.gravatar.com/avatar" - "Base URL for getting gravatars.") +(defconst gravatar-service-alist + `((gravatar . ,(lambda (_addr) "https://www.gravatar.com/avatar")) + (unicornify . ,(lambda (_addr) "https://unicornify.pictures/avatar/")) + (libravatar . ,#'gravatar--service-libravatar)) + "Alist of supported gravatar services.") + +(defcustom gravatar-service 'libravatar + "Symbol denoting gravatar-like service to use. +Note that certain services might ignore other options, such as +`gravatar-default-image' or certain values as with +`gravatar-rating'." + :type `(choice ,@(mapcar (lambda (s) `(const ,(car s))) + gravatar-service-alist)) + :version "28.1" + :link '(url-link "https://www.libravatar.org/") + :link '(url-link "https://unicornify.pictures/") + :link '(url-link "https://gravatar.com/") + :group 'gravatar) + +(defun gravatar--service-libravatar (addr) + "Find domain that hosts avatars for email address ADDR." + ;; implements https://wiki.libravatar.org/api/ + (require 'dns) + (let* ((domain (save-match-data + (unless (string-match ".+@\\(.+\\)" addr) + (error "%s is not an email address" addr)) + (match-string 1 addr))) + (result (dns-query (concat "_avatars._tcp." domain) 'SRV))) + (if result + (concat "http://" result "/address") + "https://seccdn.libravatar.org/avatar"))) (defun gravatar-hash (mail-address) "Return the Gravatar hash for MAIL-ADDRESS." @@ -142,7 +170,8 @@ gravatar-build-url "Return the URL of a gravatar for MAIL-ADDRESS." ;; https://gravatar.com/site/implement/images/ (format "%s/%s?%s" - gravatar-base-url + (funcall (alist-get gravatar-service gravatar-service-alist) + mail-address) (gravatar-hash mail-address) (gravatar--query-string))) -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 11 03:38:42 2020 Received: (at 39965) by debbugs.gnu.org; 11 Mar 2020 07:38:42 +0000 Received: from localhost ([127.0.0.1]:53597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBvwv-0002kk-Pi for submit@debbugs.gnu.org; Wed, 11 Mar 2020 03:38:42 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:55113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBvwu-0002kY-M0 for 39965@debbugs.gnu.org; Wed, 11 Mar 2020 03:38:40 -0400 Received: by mail-wm1-f52.google.com with SMTP id n8so911704wmc.4 for <39965@debbugs.gnu.org>; Wed, 11 Mar 2020 00:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:message-id:mime-version; bh=gXvKxznAR7BskGe1pxeIYlPZfNRjWaTKRHN+s9YOgaU=; b=B5zkhqnSMBdXA9/K9TuoZg1LNHy0B1bukKMtRfMHZBVFr0R5C4kP9mzInzql4TIVPS +nFFj2lyZ7mk/lldNmJJJJmYjFre8esk6CgViJiBwwMUZt1TIB1tMsGDGhcjhrVDan1F sl3qFQT7J6VcH5uhos+HjRdjJ0+qM4UXMxHVCXV9RoRWGFIpoo51j5bIIH0Lwk0drG66 XO3EssxjX0Th4jqSDk1i5D82/qQhHgZR3f/TtHW3sEBBiwScEQNhZXkloQR06wJSZAsh p9UmVdYVDU0qD6w6tcMHRzSdyONoNXm1m9wHAZ7Prj6P50EGoZAKB/nFml+aNqh0I0TW 4pkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :mime-version; bh=gXvKxznAR7BskGe1pxeIYlPZfNRjWaTKRHN+s9YOgaU=; b=leM3F0znhPQgKUnpnzF9FZbUAKDkIkE4TEXkf+7Tewzh0qgKjYsZGw79XWto+tv9Uq kQgUOgksoOs8mLmzPW5o4K19haAcmX71Wt5rkREpa7PNZd1b3vJM01w0AdqdmKEiQKDi riJUTA0FIX6HOC4e9W+F94sZWBM6UYmCWdWS8yKD/lONWfQJR8B6R/OAl+BwZp9jddX6 +4PKojMHzS7iIJVsts/mKdX6vGRFndxnRS5T4mYlBZyFTHX8RJh7/nirVAc6s2+71u2A 0RhV7BXsQ1G7qF5mUsmsR71137bk3WTpBaBeHG45e2xs0Nu9ZkRfFmW8beEeKC7bU/M5 YtTA== X-Gm-Message-State: ANhLgQ2+uJqkR3+YRGzlA0ju89LcrWybLW0/7DXiWrCLZLaUKn27JWVw 7x603EMFBXwn4S1d9qTOVy8= X-Google-Smtp-Source: ADFU+vv2VzZKzvLLu6Ec7XbBuPFoKMSB/w9GN+vyMmZNSSLg9qVfiVlemqJZM3B+4dFLDwQQC4Et9Q== X-Received: by 2002:a1c:68c2:: with SMTP id d185mr2297774wmc.150.1583912315020; Wed, 11 Mar 2020 00:38:35 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id s2sm7084091wmj.15.2020.03.11.00.38.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 00:38:34 -0700 (PDT) From: Robert Pluim To: Philip K. Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services References: <20200307001141.10771-1-philip@warpmail.net> Date: Wed, 11 Mar 2020 08:38:32 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39965 Cc: eliz@gnu.org, 39965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 10 Mar 2020 10:31:27 +0100, Philip K. said: Philip> Sorry for the delay, I hope the commit message is ok now. Thanks, much better. Eli, is this a small enough change to commit as 'Copyright-paperwork-exempt'? Robert From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 11 04:50:17 2020 Received: (at 39965) by debbugs.gnu.org; 11 Mar 2020 08:50:17 +0000 Received: from localhost ([127.0.0.1]:53616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBx4C-0004S0-V5 for submit@debbugs.gnu.org; Wed, 11 Mar 2020 04:50:17 -0400 Received: from mx-rz-1.rrze.uni-erlangen.de ([131.188.11.20]:33883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBx48-0004Ro-I1 for 39965@debbugs.gnu.org; Wed, 11 Mar 2020 04:50:15 -0400 Received: from mx-rz-smart.rrze.uni-erlangen.de (mx-rz-smart.rrze.uni-erlangen.de [IPv6:2001:638:a000:1025::1e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mx-rz-1.rrze.uni-erlangen.de (Postfix) with ESMTPS id 48clyp5zWpz8sZT; Wed, 11 Mar 2020 09:50:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fau.de; s=fau-2013; t=1583916610; bh=9+C7ihYmCOkmsin55/HvKDOD+IQN7bfrXmGAv+Lp0XY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:To:CC: Subject; b=WDs5mBjrsdmEC8zNIUa0DXV3pjyCgNJJ/QpXotUn27A7Div+qrrVlkN1IMwUK538+ LZkdTnIZUHSV2KZErkV1DkB6GOi6dop/q6aSmwdXvdUHgMauduAXKz4cxgKtPm57ox GVLGF6Ytl/L9aJYujy0HX09FhfVdhKW1h2j/3xUgTpZIO/uw9lSg0gn2hD1KoZIRC2 OU+j5nztnuOEDz3QgGA6+6ndRQBnGPI1Th+jNWX2hJ1Tk/s2gj1m3xWQpOMjKdqCiL w1kPIjUJbdTuRKctEBjuuPa2cWpZZowGCpIzRrLzCzFYb+SbWd5m4M6itYXG2LtWlT pyYvRmN7CDttg== X-Virus-Scanned: amavisd-new at boeck5.rrze.uni-erlangen.de (RRZE) X-RRZE-Flag: Not-Spam X-RRZE-Submit-IP: 2001:638:a000:4160:131:188:60:167 Received: from cip6b5 (cip6b5.cip.cs.fau.de [IPv6:2001:638:a000:4160:131:188:60:167]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: U2FsdGVkX18n0qeOBHQKQnRf7kHM7fnC2W/Gw28YzKU=) by smtp-auth.uni-erlangen.de (Postfix) with ESMTPSA id 48clym3Nyjz8srq; Wed, 11 Mar 2020 09:50:08 +0100 (CET) From: Philip Kaludercic To: Robert Pluim Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services References: <20200307001141.10771-1-philip@warpmail.net> Date: Wed, 11 Mar 2020 09:50:08 +0100 In-Reply-To: (Robert Pluim's message of "Wed, 11 Mar 2020 08:38:32 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39965 Cc: eliz@gnu.org, 39965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Robert Pluim writes: >>>>>> On Tue, 10 Mar 2020 10:31:27 +0100, Philip K. said: > > Philip> Sorry for the delay, I hope the commit message is ok now. > > Thanks, much better. Eli, is this a small enough change to commit as > 'Copyright-paperwork-exempt'? > > Robert I actually signed the copyright assignment last year, for contributing to an ELPA package. I thought that applied to the Emacs core too? From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 11 12:08:22 2020 Received: (at 39965) by debbugs.gnu.org; 11 Mar 2020 16:08:22 +0000 Received: from localhost ([127.0.0.1]:55389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jC3u9-00038A-Vv for submit@debbugs.gnu.org; Wed, 11 Mar 2020 12:08:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jC3u7-00037w-FN for 39965@debbugs.gnu.org; Wed, 11 Mar 2020 12:08:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jC3u1-0001YK-5q; Wed, 11 Mar 2020 12:08:13 -0400 Received: from [176.228.60.248] (port=3063 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jC3u0-0007do-9N; Wed, 11 Mar 2020 12:08:12 -0400 Date: Wed, 11 Mar 2020 18:08:16 +0200 Message-Id: <83k13qan7z.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: (message from Robert Pluim on Wed, 11 Mar 2020 08:38:32 +0100) Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services References: <20200307001141.10771-1-philip@warpmail.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39965 Cc: philip.kaludercic@fau.de, 39965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Robert Pluim > Cc: 39965@debbugs.gnu.org, eliz@gnu.org > Date: Wed, 11 Mar 2020 08:38:32 +0100 > > >>>>> On Tue, 10 Mar 2020 10:31:27 +0100, Philip K. said: > > Philip> Sorry for the delay, I hope the commit message is ok now. > > Thanks, much better. Eli, is this a small enough change to commit as > 'Copyright-paperwork-exempt'? There's no need, since Philip has an assignment on file. But I didn't understand how was the issue of preferring Libravatar resolved? Didn't someone say it wasn't a free service? From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 11 12:09:48 2020 Received: (at 39965) by debbugs.gnu.org; 11 Mar 2020 16:09:48 +0000 Received: from localhost ([127.0.0.1]:55393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jC3vY-0003AE-9Z for submit@debbugs.gnu.org; Wed, 11 Mar 2020 12:09:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jC3vW-0003A1-B1 for 39965@debbugs.gnu.org; Wed, 11 Mar 2020 12:09:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jC3vR-00047N-8y; Wed, 11 Mar 2020 12:09:41 -0400 Received: from [176.228.60.248] (port=3153 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jC3vQ-0007kE-Na; Wed, 11 Mar 2020 12:09:41 -0400 Date: Wed, 11 Mar 2020 18:09:45 +0200 Message-Id: <83imjaan5i.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: (message from Philip Kaludercic on Wed, 11 Mar 2020 09:50:08 +0100) Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services References: <20200307001141.10771-1-philip@warpmail.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39965 Cc: rpluim@gmail.com, 39965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Philip Kaludercic > Cc: 39965@debbugs.gnu.org, eliz@gnu.org > Date: Wed, 11 Mar 2020 09:50:08 +0100 > > I actually signed the copyright assignment last year, for contributing > to an ELPA package. I thought that applied to the Emacs core too? The assignment is for Emacs, and it applies to ELPA as well. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 11 13:00:18 2020 Received: (at 39965) by debbugs.gnu.org; 11 Mar 2020 17:00:18 +0000 Received: from localhost ([127.0.0.1]:55449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jC4iQ-0004Nj-6S for submit@debbugs.gnu.org; Wed, 11 Mar 2020 13:00:18 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:38619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jC4iO-0004NW-In for 39965@debbugs.gnu.org; Wed, 11 Mar 2020 13:00:16 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id B4DB26D0; Wed, 11 Mar 2020 13:00:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 11 Mar 2020 13:00:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:cc:subject:in-reply-to:date:message-id:mime-version :content-type; s=fm2; bh=sO9aF/uA6meJnVKBJtgHziPCxljcE4M7XiSUwfm HJ5k=; b=Uz66pes9yYS9HYGSFzqdI4EE7gMLrzyIlox4urV/U0HIUmfaXjyrbCw rlHnEdHLecVZF2iodAId8NGBpA1kJO/d7fUhQ9XzlZHG5y6adJoIIlsGWr66wcOX OLLPGY3dK8FOqorEDQwzWH67LNqVP9qxntvANqfWWJaSKEG7hcsBCOcPJAgPR9n/ 85ZgspLctW8t+zs96wqIm6jFLzDDKO88hFf/zhuwyFvYPgSTSY+mdWWUC9kFBuGR DqFj4jIOsvvqTbb1fAuiUE/MjqifO3JWfl8CzJS4HnunJ5fRYx55cd/aAlqQEFce oSJwaMZc0ybFC6nHNizEWsE22BKqvgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=sO9aF/uA6meJnVKBJ tgHziPCxljcE4M7XiSUwfmHJ5k=; b=xk22xF0AFNw4NvOdzXN2gs/RPm3sLeCIN YNb7TAfXa7rPiKPsPItDb6KetCUPzlRy3XDCY/BLVoKum2DqjmJujO+65w2uhFNl Ojf7Y4Pab6IPXdYkftPyvwtfHtRqv7h1T3LLTuCevj8zPM7NAnCsxXS4oEI2W9bL LnvoPsR4BlGSHLJo/oAC40I9JouzGib7aPmBpeP77+i71JLp7lR9uxtjZCpCyDeU GT61LRw2cm077IUjYVov56rVoPzyw9LMaBaCIOWanjCv0RZ5TB0Y4XJJsigNcmGW ol/lw+/0fFQBESImTU32MmDGtWeGo8rbkWbqjT9JF+Nvo+dQdft0A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddvvddgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfffkgggtsehttdertddttddtnecuhfhrohhmpehphhhilhhiphes figrrhhpmhgrihhlrdhnvghtucdlrfhhihhlihhpucfmrddmnecukfhppeejledrvddule drudelfedrudeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepphhhihhlihhpseifrghrphhmrghilhdrnhgvth X-ME-Proxy: Received: from localhost (p4fdbc112.dip0.t-ipconnect.de [79.219.193.18]) by mail.messagingengine.com (Postfix) with ESMTPA id 8E126328005E; Wed, 11 Mar 2020 13:00:09 -0400 (EDT) From: philip@warpmail.net (Philip K.) To: Eli Zaretskii Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services In-Reply-To: <83k13qan7z.fsf@gnu.org> (message from Eli Zaretskii on Wed, 11 Mar 2020 18:08:16 +0200) Date: Wed, 11 Mar 2020 18:00:06 +0100 Message-ID: <87k13qrfmx.fsf@bulbul> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39965 Cc: rpluim@gmail.com, 39965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: > But I didn't understand how was the issue of preferring Libravatar > resolved? Didn't someone say it wasn't a free service? No, I might have said that Gravatar is non-free, and as such shouldn't be the default. -- With kind regards, Philip K. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 12 03:42:05 2020 Received: (at 39965) by debbugs.gnu.org; 12 Mar 2020 07:42:05 +0000 Received: from localhost ([127.0.0.1]:55866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCITl-0005E7-L9 for submit@debbugs.gnu.org; Thu, 12 Mar 2020 03:42:05 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:34423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCITj-0005DW-TD for 39965@debbugs.gnu.org; Thu, 12 Mar 2020 03:42:04 -0400 Received: by mail-wm1-f42.google.com with SMTP id x3so4875340wmj.1 for <39965@debbugs.gnu.org>; Thu, 12 Mar 2020 00:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=d38PizNJOIN99pAayJoBaGuAGPpvSkLO11Lee/nv8hg=; b=EtVD1HAND5b/hyXh2PCSxxnMyunLGX+M4J/aOy/b6T9mpKa7Nfm31FoTg7uOdAegxN SaDu+5Oj1atEcobLl7vEui5yHD1sevUkKXvx0hV3wo/04s3Fg+oC3tVeT1+hqCmqjQQJ sxs53NrCf+plwK2f67ACP/YaZU1QbTBlQZi69iIydeW7EEDF8/qpXIrRfQOFu1NSrKWl k1FTGo1SwUJ6qfrEm1W/W08eyozXBolLz+W30oEp3O/9TS3foq0+A1ZY/eDd/QU/kprX QKr7Wn3g06lryq/2zEGwf1dzOq+NLWiKsW9fzCHs+GnWZVwV7n7v51fUXsQ9jNITSkYr 6eJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=d38PizNJOIN99pAayJoBaGuAGPpvSkLO11Lee/nv8hg=; b=YKqc73xJZh39f5QK2s6Ik9DZn+SFX+nYs3Gu/bQ3wZyvqqQTt3RBozsQawzc2tv20K 1TLE7P72zvdOxuzTQoikKE+EB9t1gMYGt2pCELRU42GC3zDitygMoNGQtqir21S3rikX fMHhFETY28Q0SWMn1Tt1IFDgcMAM9P7HWmt0KVToRd/TiZgQkkILUnDCnWgRC6ncVAdM Sm28U6azYV/Uf+fgeDQDr2oZl/IgYJoQvHR2MJiW49CwpYdCT3QlwUWyCxLDvHYQ9Eei afYXLaubK0H425/EBwq4kGPcwy3KRQg2SQxKVOajwc8sStl70GUIy4eNNrvKHjpSZPlD PPWQ== X-Gm-Message-State: ANhLgQ0qHFHfTJfxlWTIB3DMGtayKHCTmWFf99pg614x2SlP8GWaKrRB smwZXuCczKddoVo7qTMC0ttT8+Kg X-Google-Smtp-Source: ADFU+vs90eqytmZCU3ZCs47TDC95y3zb6sIH6rpfkEkozDDyo/DA9feuQCp8dgSrpFGaqZkNR3fIng== X-Received: by 2002:a1c:a502:: with SMTP id o2mr3268245wme.94.1583998917633; Thu, 12 Mar 2020 00:41:57 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id o10sm27134269wru.38.2020.03.12.00.41.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2020 00:41:56 -0700 (PDT) From: Robert Pluim To: philip@warpmail.net (Philip K.) Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services References: <20200307001141.10771-1-philip@warpmail.net> <87k13qrfmx.fsf@bulbul> Date: Thu, 12 Mar 2020 08:41:54 +0100 In-Reply-To: <87k13qrfmx.fsf@bulbul> (Philip K.'s message of "Wed, 11 Mar 2020 18:00:06 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 39965 Cc: Eli Zaretskii , 39965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 11 Mar 2020 18:00:06 +0100, philip@warpmail.net (Philip K.) said: Philip> Eli Zaretskii writes: >> But I didn't understand how was the issue of preferring Libravatar >> resolved? Didn't someone say it wasn't a free service? Philip> No, I might have said that Gravatar is non-free, and as such shouldn't Philip> be the default. Right, and the default will become Libravatar, which is a free service. Robert From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 17 09:51:34 2020 Received: (at 39965) by debbugs.gnu.org; 17 Mar 2020 13:51:34 +0000 Received: from localhost ([127.0.0.1]:38299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jECd4-0007Az-4m for submit@debbugs.gnu.org; Tue, 17 Mar 2020 09:51:34 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:34314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jECd2-0007Am-Dx for 39965@debbugs.gnu.org; Tue, 17 Mar 2020 09:51:33 -0400 Received: by mail-wr1-f44.google.com with SMTP id z15so25744743wrl.1 for <39965@debbugs.gnu.org>; Tue, 17 Mar 2020 06:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=IXbJB45oLxkvEqQinMfIYGMX8l15x40UB9eD02nydnI=; b=APMFWolAnuWWfcUyYk32s756SWA1Wl5b9zBz3jDNbNQKngEDmy8gUlpFZUTcxsu6Nw pFKjAzydFBTaTeKLyMFuvQLHTcsWYEG49umZOIIZ473Bqr4KGDy6Fmpq3UxrxL6VDfWX mTXM16iEsenzIUa09cfcHna+YoBpOoBR/0LIaGfjMX1UoggIdtRa4ezroEJ2MQQYxdoO T/wxuw2yy5GuTSV27D2xeXLwQQtXMS2ire15510aFSP5Tn7QJGqXlbYp3bpLwQ7tByNM FD9MV3fhsnrECy4FkqX2f7K1Z+7dSoFfK1CxM2vYPcaqGR0h3FGkqYeqip0UtQ/6rnUh qwUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=IXbJB45oLxkvEqQinMfIYGMX8l15x40UB9eD02nydnI=; b=k75DzNkv0ij+jWF/NUIlGZuUbKR6nKgWSJc7WGfyjpVlkATvwuSsrdpGp3SRo2DEbC pINgdnMinEqh+5WNX3YJDIZEdmXvPGQpn4bdfDB7JPnHQyoLSgWQaIllv4vch0V///Sl vn1R0lcTgZCWaJimqxUMlZvQZdwAqpFwasNqXc37K290KEOmSLwsC59/hHudfihtdtvi hIlPatR2jsU3nSBjKtg2j07z+1L2MJJ2EdL8rXCia8F8cnf76hYkv8GWASXCopSYxPF2 tVsZUb/Q/nN513Nj1ZMuLGqz3xS36NoQrjZSiRPaCgsLBTpCV7PN81rhyXxfseGho7oh /Y6g== X-Gm-Message-State: ANhLgQ3XeYVsRyhy4MfjzXZf6TOVogkaax6hztDw6fv04ZFSv8kPP1MM 1cR5OWtJlRWih8VZ9zUcexbMeSnI X-Google-Smtp-Source: ADFU+vtuEiWtZnjLOCXI0EFXLaE3GmfF4ndaZfQDpdjaNf2NY1VslH0bP9beF2oPK0hyxlXkTyvIMA== X-Received: by 2002:adf:9e8b:: with SMTP id a11mr6069018wrf.32.1584453086007; Tue, 17 Mar 2020 06:51:26 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:7800:e590:5d04:163a]) by smtp.gmail.com with ESMTPSA id y80sm4282927wmc.45.2020.03.17.06.51.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2020 06:51:24 -0700 (PDT) From: Robert Pluim To: Philip K. Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services References: <20200307001141.10771-1-philip@warpmail.net> Date: Tue, 17 Mar 2020 14:51:22 +0100 In-Reply-To: (Philip K.'s message of "Tue, 10 Mar 2020 10:31:27 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39965 Cc: 39965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 10 Mar 2020 10:31:27 +0100, Philip K. said: Philip> Sorry for the delay, I hope the commit message is ok now. Sorry for my delay in getting back to you. I have one question: Philip> +(defun gravatar--service-libravatar (addr) Philip> + "Find domain that hosts avatars for email address ADDR." Philip> + ;; implements https://wiki.libravatar.org/api/ Philip> + (require 'dns) Philip> + (let* ((domain (save-match-data Philip> + (unless (string-match ".+@\\(.+\\)" addr) Philip> + (error "%s is not an email address" addr)) Philip> + (match-string 1 addr))) Philip> + (result (dns-query (concat "_avatars._tcp." domain) '= SRV))) Philip> + (if result Philip> + (concat "http://" result "/address") Philip> + "https://seccdn.libravatar.org/avatar"))) Here you do the SRV lookup for the TCP service, but I believe there=CA=BCs an HTTPS service type available as well. Could you look that up first, then the TCP one, then fall back to the default libravatar URL? Robert From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 17 10:37:25 2020 Received: (at 39965) by debbugs.gnu.org; 17 Mar 2020 14:37:25 +0000 Received: from localhost ([127.0.0.1]:39397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEDLR-0002IP-0m for submit@debbugs.gnu.org; Tue, 17 Mar 2020 10:37:25 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:47707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEDLP-0002IA-BM for 39965@debbugs.gnu.org; Tue, 17 Mar 2020 10:37:24 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 33A5A5C025C; Tue, 17 Mar 2020 10:37:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 17 Mar 2020 10:37:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:cc:subject:in-reply-to:date:message-id:mime-version :content-type; s=fm2; bh=ZC9VuSfg+qjxmV3zkwg1tdNoaXo93g0dQff5imz ZtO8=; b=ZFSD0pPnvu4Lda7+2gycgw2TfSOciYA/bdLuR6g7Nn3baR5RW6rCK/C 25v1w3r7Ce0+u9ZerZjf97wCt0eQB6uZJZwXYAdGkHH4S2SWrdW8WBzCYgy1Ee+l UZSeAk5hr126t+8H6LvHrrzHpNx7vyXADi26d28Vh1T1la1wRh1Jw0JFfa9z2R3X 1juI1FPQlPtXnI7q7VtpcQzDH37w4i8OE/euNLqaQ/Vwoo6MxsipAZFzQBiSPmI/ IY/aM2cuMCYLEa+GLaZGK/riE0ub+Pohu7lSxzn/981+NjF6rDn4npVgy+Wcaf81 XLwZ5HZso1w6ttdJqZSq68GzBxno1jg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ZC9VuSfg+qjxmV3zk wg1tdNoaXo93g0dQff5imzZtO8=; b=Oxw2NbcMNLDYfvYv3lizKTHOsCOJLsNa1 7AQOb6Ugp5UKFc1MLcKcMhEB2laWTECleFwy6zhL/+EcoavfBjFd6TUAvJmGFTaI Gifv0GOQhp5PixXsXU+hyD7oDm+qEpV1LyWg08anlOYvPSKVKQwOQ593X8zmAdTX B1d6+v2aIae5wlQphfKbWMHKRyX+/SiV6XmvdY7uJ/vhMMYWQVYo/BfRZCT8GdAC mTXCTgZctpa7bp1baXTIq1pBoMD3uWSL0Al/xr1KWKDyBIfs/e69Ne+2YFQrYYbg bB/1yXfdRedfowhqQkIIlPIhXbZMkRq7csvFt3AaVaROeoOAk7kxQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudefhedgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfffkgggtsehmtderredttdejnecuhfhrohhmpehphhhilhhiphes figrrhhpmhgrihhlrdhnvghtucdlrfhhihhlihhpucfmrddmnecukfhppeejledrvddule drudelledruddvvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehphhhilhhiphesfigrrhhpmhgrihhlrdhnvght X-ME-Proxy: Received: from localhost (p4fdbc77a.dip0.t-ipconnect.de [79.219.199.122]) by mail.messagingengine.com (Postfix) with ESMTPA id 9992530618C1; Tue, 17 Mar 2020 10:37:15 -0400 (EDT) From: philip@warpmail.net (Philip K.) To: Robert Pluim Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services In-Reply-To: (message from Robert Pluim on Tue, 17 Mar 2020 14:51:22 +0100) Autocrypt: addr=philip@warpmail.net; keydata= mDMEXmoX2BYJKwYBBAHaRw8BAQdA/YuGV2Dy6UZtMk+KfA7Nnlj38k22KQ/+sXVa2ttGaHm0O1Bo aWxpcCBLLiAoZ2VuZXJhdGVkIGJ5IGF1dG9jcnlwdC5lbCkgPHBoaWxpcEB3YXJwbWFpbC5uZXQ+ iJAEExYIADgWIQSx6XCgW+bhLMR4DmPClWiPoyRe6AUCXmoX2AIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAAKCRDClWiPoyRe6IDNAP0eOlYoYIGVcCinuewkEb762T6lqA2hIHcNeRyX8LyQ8gEA krv4pIlZNLF+nBvaCtKvCPZF9428X50CvNvRHCNqgwe4OAReahfYEgorBgEEAZdVAQUBAQdACM09 XXce+t9YpOLbLdESh5g4RTY/0Zys7U1FapIZLA4DAQgHiHgEGBYIACAWIQSx6XCgW+bhLMR4DmPC lWiPoyRe6AUCXmoX2AIbDAAKCRDClWiPoyRe6LYcAQDn15KGn/E9MqloWN4mBJ7/tepYIk2IxrkZ imC531HsIAD+LKQYjorQosVe1oym0VZjmgKsem1kJZHG2tY601I+QwM= Date: Tue, 17 Mar 2020 15:37:12 +0100 Message-ID: <87pndbhwtj.fsf@bulbul> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39965 Cc: 39965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Robert Pluim writes: > Sorry for my delay in getting back to you. I have one question: > > [...] > > Here you do the SRV lookup for the TCP service, but I believe there=CA=BCs > an HTTPS service type available as well. Could you look that up first, > then the TCP one, then fall back to the default libravatar URL? You're right, I missed that. This patch checks the avatar-sec and avatar record. I rewrote it a bit, to avoid duplication, so I hope the style is ok. --=20 Philip K. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-support-for-multiple-Gravatar-services.patch >From 45ef168f4c7b2c0195de040570fa613c89e41ae4 Mon Sep 17 00:00:00 2001 From: Philip K Date: Tue, 10 Mar 2020 10:21:08 +0100 Subject: [PATCH] Add support for multiple Gravatar services Now supports Libravatar and Unicornify, next to Gravatar. * lisp/image/gravatar.el (gravatar-base-url): Remove constant. (gravatar-service-alist): List supported services. (gravatar-service): Add user option to specify service, defaults to Libravatar. (gravatar--service-libravatar): Add libravatar image host resolver implementation. (gravatar-build-url): Use alist gravatar-service-alist instead of gravatar-base-url. * etc/NEWS: Add note. --- etc/NEWS | 6 ++++++ lisp/image/gravatar.el | 37 +++++++++++++++++++++++++++++++++---- 2 files changed, 39 insertions(+), 4 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 7f70d149d6..7d9f858555 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -171,6 +171,12 @@ key binding / v package-menu-filter-by-version / / package-menu-filter-clear +** Gravatar + +=== +*** New user-option 'gravatar-service' for host to query for gravatars. +Defaults to Libravatar, with Unicornify and Gravatar as options. + * New Modes and Packages in Emacs 28.1 diff --git a/lisp/image/gravatar.el b/lisp/image/gravatar.el index b8542bc3c3..9b4e93275d 100644 --- a/lisp/image/gravatar.el +++ b/lisp/image/gravatar.el @@ -118,9 +118,37 @@ gravatar-force-default :version "27.1" :group 'gravatar) -(defconst gravatar-base-url - "https://www.gravatar.com/avatar" - "Base URL for getting gravatars.") +(defconst gravatar-service-alist + `((gravatar . ,(lambda (_addr) "https://www.gravatar.com/avatar")) + (unicornify . ,(lambda (_addr) "https://unicornify.pictures/avatar/")) + (libravatar . ,#'gravatar--service-libravatar)) + "Alist of supported gravatar services.") + +(defcustom gravatar-service 'libravatar + "Symbol denoting gravatar-like service to use. +Note that certain services might ignore other options, such as +`gravatar-default-image' or certain values as with +`gravatar-rating'." + :type `(choice ,@(mapcar (lambda (s) `(const ,(car s))) + gravatar-service-alist)) + :version "28.1" + :link '(url-link "https://www.libravatar.org/") + :link '(url-link "https://unicornify.pictures/") + :link '(url-link "https://gravatar.com/") + :group 'gravatar) + +(defun gravatar--service-libravatar (addr) + "Find domain that hosts avatars for email address ADDR." + ;; implements https://wiki.libravatar.org/api/ + (require 'dns) + (let* ((domain (save-match-data + (unless (string-match ".+@\\(.+\\)" addr) + (error "%s is not an email address" addr)) + (match-string 1 addr))) + (result (dns-query (concat "_avatars._tcp." domain) 'SRV))) + (if result + (concat "http://" result "/address") + "https://seccdn.libravatar.org/avatar"))) (defun gravatar-hash (mail-address) "Return the Gravatar hash for MAIL-ADDRESS." @@ -142,7 +170,8 @@ gravatar-build-url "Return the URL of a gravatar for MAIL-ADDRESS." ;; https://gravatar.com/site/implement/images/ (format "%s/%s?%s" - gravatar-base-url + (funcall (alist-get gravatar-service gravatar-service-alist) + mail-address) (gravatar-hash mail-address) (gravatar--query-string))) -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 24 13:01:29 2020 Received: (at control) by debbugs.gnu.org; 24 Mar 2020 17:01:29 +0000 Received: from localhost ([127.0.0.1]:55510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGmvh-00035v-5n for submit@debbugs.gnu.org; Tue, 24 Mar 2020 13:01:29 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:43981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGmvf-00035b-HL for control@debbugs.gnu.org; Tue, 24 Mar 2020 13:01:27 -0400 Received: by mail-wr1-f45.google.com with SMTP id b2so22397656wrj.10 for ; Tue, 24 Mar 2020 10:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=BYkomIPdvXB8y43b1kuOfyW18stgQn9cAlLlGevILI8=; b=S7EKpcwYRS3jhSSCupRPomaIssenmr+DTHgnPjQFRZr63uUi9o7S/Tg3WRiZN3wUeO iuEtgOV4Vbp1VqCyMjKiX2S81dnAlcug+ftwalG/cmXkBsTgFfsruhjVqSVgEboqcGuc Tig366S1ABKxPXw8m+0g0WFiNB7yS4ddmTbK3+V5P5Gd/+RzU6FDv1ngk0y4RjSmXCLy tZUy7XDmLuVkYb5Icoxe0gdD9++Lk4y6VWhroWBTHhNT53xXAfR7nmakFbHi04KvfEqK zLhAOvM4EvBZpXUS+ti1ZunfO7tcoG6Em10gswKk2GwE6EOUHxR+xx3dI4vw1pqIkefN ntLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=BYkomIPdvXB8y43b1kuOfyW18stgQn9cAlLlGevILI8=; b=tDlvL+/7XSmz5Mkwz0E6WODKFnPfGpYOaDSjsbyaZ8HUQtj9FFMseKshYDY97WU76x K+fZgiXRYxU9wCg/csu7dLudmcGFn4boEcrcmH0MK6OQZYBNVUvSCubuu0YmuO+fcx42 2wdRM07HYeIk3tDVK/94PldkvUfpobLfebVcoblR850xc4B4FCCj/hmjT2ClayQqe+YD ijcW5eQagXj4apLz0+4hNo5bXvCea1elqWSyKCtgBug/Ly/I6lX5OoGJf5fIGg6+CBHU wY/vFHgfzwBUWFYvvSAPU8XDn8vfHnByo/2msd9Z5ZZdN6USx60sXhVZYHR54Od2ioO6 sCmQ== X-Gm-Message-State: ANhLgQ0yronPvBTr45XwCIWLd3gGOnuitUmih6DNeMH51O3BOxM0e2ly v+UFzHjb9qS2u4VKB2z5O6VmBAUX X-Google-Smtp-Source: ADFU+vvUeUHWIH7pFVQTtLNJmM/TQMSbWI8AohyDVyWtAQp6O0d6wsCxDTZ00e2QcMGUTbHZYdeywA== X-Received: by 2002:a5d:4091:: with SMTP id o17mr23349072wrp.254.1585069281542; Tue, 24 Mar 2020 10:01:21 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:2867:4995:9986:65c2]) by smtp.gmail.com with ESMTPSA id p13sm17304215wru.3.2020.03.24.10.01.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 10:01:21 -0700 (PDT) From: Robert Pluim To: control@debbugs.gnu.org Subject: control message for bug #39965 Date: Tue, 24 Mar 2020 18:01:20 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) fixed 39965 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 24 13:01:09 2020 Received: (at 39965-done) by debbugs.gnu.org; 24 Mar 2020 17:01:09 +0000 Received: from localhost ([127.0.0.1]:55504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGmvN-000358-6U for submit@debbugs.gnu.org; Tue, 24 Mar 2020 13:01:09 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:43929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGmvL-00034c-AZ for 39965-done@debbugs.gnu.org; Tue, 24 Mar 2020 13:01:08 -0400 Received: by mail-wr1-f48.google.com with SMTP id b2so22396039wrj.10 for <39965-done@debbugs.gnu.org>; Tue, 24 Mar 2020 10:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:message-id:mime-version; bh=BdxdJ3C/m4si0E3QGlu4sE1Pxewcl+yYiOUwlmdD2PY=; b=NPomEh74Xh5VQF1/I8uNY7wIZiA7plxvqJhHaKGNuxCfLo442ez8qjmQmDxPeNTCKg AuAevmuc8A2kA3UV4TUfIHLtsLF9eHlSs2gJKsUzCBNzw1AhFC0YJI2d28vHJAjEEgor jzcxw+zbSjEAtLIZGKeqa8tGpaaWgZJegIF/sIN+VEd1ddy7rq8aeYYU9lYMnkTk8iu4 IGEWLhqE+BfHrGPJaPsCd15+FNlNK3Ki8XoxBKB95JN8aA3ZIUv5yp+JsrH+ElS4lFMc VD1ZnHl/AHbTRdM9XX3tyG+RVWYftoyuiLeaG9HAIaDO7RN4p2URP7eeefwyf6c2ltQF nVXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :mime-version; bh=BdxdJ3C/m4si0E3QGlu4sE1Pxewcl+yYiOUwlmdD2PY=; b=MGra85kS9Be3F+lOZEx0Mga7Er0te9ozf6d7aSTK/cr8nv2zhUG/NYC75Yquoh/gcx 6XeT7E/fmVBnKpPrY3w4ubtLB/7j+9irQjTMV1HG9S4m7gZV6eCPTRsLDshPva86zey+ 5j3is5+CABZZJGga8hxWVwoXUgnSSwuhFs2apLZbdQq3f5KaKLGyw0oSWQaagUIHG4ZJ /1eQA/8FVz5oByOBKnc6YB5scJNVxymLvdaDgrXOBqrzbDmWGkiDMih4YcLRH+TR3m8p +ZwUtpQ8Pkma9ILYwZG5ejSpdfzo3Z3LFRJjLSfYWIatYtvyPBggGw3YLv9aU+M2mUZd kFyw== X-Gm-Message-State: ANhLgQ1E6qpu3J/wa06eGb8qkTIERA9+NTpBEWzv+PsVWDSYM5BxHISu nSiLAdsHiBb8lvXgTkVfzpI2BFx/ X-Google-Smtp-Source: ADFU+vs2wXhRT8kgBGrNYBvH2LD5khlOyq1hfMRPst2nN9fVDwNJe8COm5gGRjTPczXPAKgORndXaA== X-Received: by 2002:a5d:55c2:: with SMTP id i2mr21450444wrw.133.1585069260953; Tue, 24 Mar 2020 10:01:00 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:2867:4995:9986:65c2]) by smtp.gmail.com with ESMTPSA id z203sm4977113wmg.12.2020.03.24.10.00.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 10:00:59 -0700 (PDT) From: Robert Pluim To: philip@warpmail.net (Philip K.) Subject: Re: bug#39965: [PATCH] Add support for multiple gravatar-like services References: <87mu8ej1pg.fsf@bulbul> Date: Tue, 24 Mar 2020 18:00:55 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 39965-done Cc: 39965-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 17 Mar 2020 19:06:19 +0100, philip@warpmail.net (Philip K.) said: Philip> Robert Pluim writes: >> This one still checks only the avatar record (and is it avatar-sec or >> avatar_sec?). Philip> Oops, I seem to have selected the wrong patch. I double checked this Philip> time. And regarding your question, according to [0] it has to be Philip> "avatar-sec.". Sorry for all the trouble! Thanks. Pushed to master as 421eeff243 (with my typo in NEWS fixed). Closing bug. Robert From unknown Tue Aug 19 01:58:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Apr 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator