Subject: Re: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27

From: Eli Zaretskii <[email-masked]>
Date: Sat, 07 Mar 2020 09:43:39 +0200

> From: Philipp <[email-masked]>
> Date: Fri, 06 Mar 2020 23:39:16 +0100
> 
> 
> In Emacs 26, sql-add-product has the signature
> 
> (sql-add-product PRODUCT DISPLAY &rest PLIST)
> 
> However, in the Emacs 27 pretest the signature is now
> 
> (sql-add-product PRODUCT DISPLAY &optional PLIST)
> 
> Note the change from &rest to &optional.  This is a breaking change that
> breaks all users of sql-add-product.  I've found quite a few uses of the
> old signature in the wild,
> e.g. https://github.com/kat-co/sql-prestodb/blob/f4a74d88dcb166445bb41efb865147c0faf1de3a/src/sql-presto.el#L59
> or
> https://github.com/r0man/vertica-el/blob/3c9647b425c5c13c30bf0cba483646af18196588/vertica.el#L68
> or
> https://github.com/jterk/sql-impala/blob/466e7c0c789ec3e5e8a276c8f6754f91bb584c3e/sql-impala.el#L71.
> This change was introduced in commit
> c124d5323c05a4010db9b2d330575d029936ade1.  I don't think we should
> introduce such a breaking change to a widely-used public function; at
> the very least, Emacs 27 should accept both signatures.

Thanks for reporting this.

Michael, could you please look into this ASAP?  TIA.

Btw, this change of a public API is not in NEWS, AFAICT; if we decide
eventually on keeping the change, we should announce it in NEWS.