From unknown Sat Aug 16 18:38:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Resent-From: Philipp Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Mar 2020 22:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 39960@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158353436619688 (code B ref -1); Fri, 06 Mar 2020 22:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Mar 2020 22:39:26 +0000 Received: from localhost ([127.0.0.1]:45982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jALcs-00057U-5G for submit@debbugs.gnu.org; Fri, 06 Mar 2020 17:39:26 -0500 Received: from lists.gnu.org ([209.51.188.17]:58223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jALcq-00057M-Tt for submit@debbugs.gnu.org; Fri, 06 Mar 2020 17:39:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46024) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jALco-0007PU-An for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2020 17:39:24 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jALcm-0004xW-Os for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2020 17:39:22 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:42035) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jALcm-0004tT-G9 for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2020 17:39:20 -0500 Received: by mail-wr1-x432.google.com with SMTP id v11so4134706wrm.9 for ; Fri, 06 Mar 2020 14:39:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=+kNaoSHDSh0WGpBEcoqgGmpb8ajgjrMtL9u2ku25sZ0=; b=QoCmFytkoBlQJpfmnKcGsM5/IZ7LfuncAq+y+s6BwjykG0m5jS07zNMC69XOyPgweV O9yEY9BFNEAqxdoEOHRIM3px5gbOtv+WyMufYhIKMvE9wJZBN9an1Z2pgYgzhWVJv0RA 6NuoLrFXPNZ8IjgIW2AaiqbrL3AIH28gO3wCIyqLGOwWbLtu84Y8lS8m/0KaDmgkhxGF Mu4dQRbgXYJevQwwrEhPF3uV1IUYNegaJWdH0EGa9RiCgk9E8F0+RCw+3/xGYUW6bjh2 FgALjNwX2hvamRZZe/XVe3T7FnMJwGnMlm5eKFXvnE54gocVr0GNhqdudSjdPBuLzFKO 3tSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=+kNaoSHDSh0WGpBEcoqgGmpb8ajgjrMtL9u2ku25sZ0=; b=eNDomoPau3N89A+xUS14K7ss9AHqmfPWU5vzMqwks2IzErf9Tf4roB+ZoeJI8MkvhK wdTtkqu+cL4bBoNmctxmG0yudEp1jKn3Zh1Hj0yz1iVhriyTmZq9PERq5wbXUlDPAUi0 /jXEMJqEDUp3obLHVIcLtt0yVS//3JOyBp+DiCYRrqPvlJb2mSFuE2POeFp+iN4Ehc5z 0ckcjX3WM870KnTNdXUhUpppc8EiT83gYRoV7DXNlCziHflKQ7h8jqfqg6v8/IC+dtog yaeqTATtR1SL/DWjZwCY1Ly+KDmFuZYhcwV4+4faf3x8BOxuttygBdXDFpOpRIVLny64 mK2Q== X-Gm-Message-State: ANhLgQ3ODhDvm8+8r+vZuAEakTawAuz/MV7SOEbjC3C2+LSJm7Hrc43c PDEFDk9ibJm/BYgMaRfN7ipUbpl1 X-Google-Smtp-Source: ADFU+vtq4e5lRUG0KBfknYfM+WSY3lgKCTyl8cx7EboYh6gF8H4Gfm+ke5D1ZrL34BNSKuHb1PAIZg== X-Received: by 2002:adf:e506:: with SMTP id j6mr5903557wrm.309.1583534358378; Fri, 06 Mar 2020 14:39:18 -0800 (PST) Received: from p (85.233.42.145.dynamic.cablesurf.de. [85.233.42.145]) by smtp.gmail.com with ESMTPSA id c62sm15676994wmd.7.2020.03.06.14.39.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2020 14:39:17 -0800 (PST) From: Philipp Date: Fri, 06 Mar 2020 23:39:16 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::432 X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) In Emacs 26, sql-add-product has the signature (sql-add-product PRODUCT DISPLAY &rest PLIST) However, in the Emacs 27 pretest the signature is now (sql-add-product PRODUCT DISPLAY &optional PLIST) Note the change from &rest to &optional. This is a breaking change that breaks all users of sql-add-product. I've found quite a few uses of the old signature in the wild, e.g. https://github.com/kat-co/sql-prestodb/blob/f4a74d88dcb166445bb41efb865147c0faf1de3a/src/sql-presto.el#L59 or https://github.com/r0man/vertica-el/blob/3c9647b425c5c13c30bf0cba483646af18196588/vertica.el#L68 or https://github.com/jterk/sql-impala/blob/466e7c0c789ec3e5e8a276c8f6754f91bb584c3e/sql-impala.el#L71. This change was introduced in commit c124d5323c05a4010db9b2d330575d029936ade1. I don't think we should introduce such a breaking change to a widely-used public function; at the very least, Emacs 27 should accept both signatures. In GNU Emacs 28.0.50 (build 39, x86_64-apple-darwin19.3.0, NS appkit-1894.30 Version 10.15.3 (Build 19D76)) of 2020-02-29 Repository revision: 3d2c82ac96a7f37e60b2b85a5c9c1d792084ab54 Repository branch: master Windowing system distributor 'Apple', version 10.3.1894 System Description: Mac OS X 10.15.3 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --with-modules --without-xml2 --without-pop --with-mailutils --enable-gcc-warnings=warn-only --enable-checking=all --enable-check-lisp-object-type 'CFLAGS=-ggdb3 -O0'' Configured features: NOTIFY KQUEUE ACL GNUTLS ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS JSON PDUMPER LCMS2 GMP Important settings: value of $LANG: de_DE.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived edmacro kmacro pcase ffap thingatpt url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars subr-x rx gnutls puny seq byte-opt gv bytecomp byte-compile cconv dbus xml cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 60470 5746) (symbols 48 8045 0) (strings 32 20761 1931) (string-bytes 1 688813) (vectors 16 12996) (vector-slots 8 167493 10214) (floats 8 27 19) (intervals 56 196 0) (buffers 1000 11)) From unknown Sat Aug 16 18:38:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Mar 2020 07:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Philipp , Michael Mauger Cc: 39960@debbugs.gnu.org Received: via spool by 39960-submit@debbugs.gnu.org id=B39960.15835670283811 (code B ref 39960); Sat, 07 Mar 2020 07:44:01 +0000 Received: (at 39960) by debbugs.gnu.org; 7 Mar 2020 07:43:48 +0000 Received: from localhost ([127.0.0.1]:46186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAU7g-0000zP-IG for submit@debbugs.gnu.org; Sat, 07 Mar 2020 02:43:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAU7e-0000zC-Rl for 39960@debbugs.gnu.org; Sat, 07 Mar 2020 02:43:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jAU7Z-0007LO-HQ; Sat, 07 Mar 2020 02:43:41 -0500 Received: from [176.228.60.248] (port=2521 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jAU7Z-0007ts-0B; Sat, 07 Mar 2020 02:43:41 -0500 Date: Sat, 07 Mar 2020 09:43:39 +0200 Message-Id: <837dzwboes.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Philipp on Fri, 06 Mar 2020 23:39:16 +0100) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Philipp > Date: Fri, 06 Mar 2020 23:39:16 +0100 > > > In Emacs 26, sql-add-product has the signature > > (sql-add-product PRODUCT DISPLAY &rest PLIST) > > However, in the Emacs 27 pretest the signature is now > > (sql-add-product PRODUCT DISPLAY &optional PLIST) > > Note the change from &rest to &optional. This is a breaking change that > breaks all users of sql-add-product. I've found quite a few uses of the > old signature in the wild, > e.g. https://github.com/kat-co/sql-prestodb/blob/f4a74d88dcb166445bb41efb865147c0faf1de3a/src/sql-presto.el#L59 > or > https://github.com/r0man/vertica-el/blob/3c9647b425c5c13c30bf0cba483646af18196588/vertica.el#L68 > or > https://github.com/jterk/sql-impala/blob/466e7c0c789ec3e5e8a276c8f6754f91bb584c3e/sql-impala.el#L71. > This change was introduced in commit > c124d5323c05a4010db9b2d330575d029936ade1. I don't think we should > introduce such a breaking change to a widely-used public function; at > the very least, Emacs 27 should accept both signatures. Thanks for reporting this. Michael, could you please look into this ASAP? TIA. Btw, this change of a public API is not in NEWS, AFAICT; if we decide eventually on keeping the change, we should announce it in NEWS. From unknown Sat Aug 16 18:38:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Mar 2020 09:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: michael@mauger.com Cc: 39960@debbugs.gnu.org, p.stephani2@gmail.com Received: via spool by 39960-submit@debbugs.gnu.org id=B39960.158409324714251 (code B ref 39960); Fri, 13 Mar 2020 09:55:01 +0000 Received: (at 39960) by debbugs.gnu.org; 13 Mar 2020 09:54:07 +0000 Received: from localhost ([127.0.0.1]:58182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCh14-0003hn-SD for submit@debbugs.gnu.org; Fri, 13 Mar 2020 05:54:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCh12-0003hG-O8 for 39960@debbugs.gnu.org; Fri, 13 Mar 2020 05:54:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jCh0x-0001nY-E5; Fri, 13 Mar 2020 05:53:59 -0400 Received: from [176.228.60.248] (port=2647 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jCh0w-0002kI-Id; Fri, 13 Mar 2020 05:53:59 -0400 Date: Fri, 13 Mar 2020 11:53:56 +0200 Message-Id: <83k13o8tsb.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <837dzwboes.fsf@gnu.org> (message from Eli Zaretskii on Sat, 07 Mar 2020 09:43:39 +0200) References: <837dzwboes.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Ping! > Date: Sat, 07 Mar 2020 09:43:39 +0200 > From: Eli Zaretskii > Cc: 39960@debbugs.gnu.org > > > From: Philipp > > Date: Fri, 06 Mar 2020 23:39:16 +0100 > > > > > > In Emacs 26, sql-add-product has the signature > > > > (sql-add-product PRODUCT DISPLAY &rest PLIST) > > > > However, in the Emacs 27 pretest the signature is now > > > > (sql-add-product PRODUCT DISPLAY &optional PLIST) > > > > Note the change from &rest to &optional. This is a breaking change that > > breaks all users of sql-add-product. I've found quite a few uses of the > > old signature in the wild, > > e.g. https://github.com/kat-co/sql-prestodb/blob/f4a74d88dcb166445bb41efb865147c0faf1de3a/src/sql-presto.el#L59 > > or > > https://github.com/r0man/vertica-el/blob/3c9647b425c5c13c30bf0cba483646af18196588/vertica.el#L68 > > or > > https://github.com/jterk/sql-impala/blob/466e7c0c789ec3e5e8a276c8f6754f91bb584c3e/sql-impala.el#L71. > > This change was introduced in commit > > c124d5323c05a4010db9b2d330575d029936ade1. I don't think we should > > introduce such a breaking change to a widely-used public function; at > > the very least, Emacs 27 should accept both signatures. > > Thanks for reporting this. > > Michael, could you please look into this ASAP? TIA. > > Btw, this change of a public API is not in NEWS, AFAICT; if we decide > eventually on keeping the change, we should announce it in NEWS. > > > > From unknown Sat Aug 16 18:38:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Resent-From: Michael Mauger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Mar 2020 01:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: "39960@debbugs.gnu.org" <39960@debbugs.gnu.org>, "michael@mauger.com" , "p.stephani2@gmail.com" Reply-To: Michael Mauger Received: via spool by 39960-submit@debbugs.gnu.org id=B39960.158492645527647 (code B ref 39960); Mon, 23 Mar 2020 01:21:02 +0000 Received: (at 39960) by debbugs.gnu.org; 23 Mar 2020 01:20:55 +0000 Received: from localhost ([127.0.0.1]:51255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGBlv-0007Br-3G for submit@debbugs.gnu.org; Sun, 22 Mar 2020 21:20:55 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:17734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGBls-0007BY-Qm for 39960@debbugs.gnu.org; Sun, 22 Mar 2020 21:20:54 -0400 Date: Mon, 23 Mar 2020 01:20:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1584926446; bh=ekTVyCCMnZvRvelLAhln4LNGDJM43dFKOwyQQBFSuGM=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=cvwZVQyshNfMpxaAZozEeM94nMfoiARvx7iS8Y3j82CxLsfRQDFqwCA42ShCv3W+H 9KHC0UrVaUdOLNAAT6cgoX1dIabG1hY4t1uiOx39MSltdDqF4NXsgkbqwQ6r5X9vcI d4uY3yR915fDWIMpTpMxA85pdZjJHRqXSBSH6DYo= From: Michael Mauger Message-ID: In-Reply-To: <83k13o8tsb.fsf@gnu.org> References: <837dzwboes.fsf@gnu.org> <83k13o8tsb.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FREEMAIL_REPLYTO shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Friday, March 13, 2020 5:53 AM, Eli Zaretskii wrote: > Ping! > > > Date: Sat, 07 Mar 2020 09:43:39 +0200 > > From: Eli Zaretskii eliz@gnu.org > > Cc: 39960@debbugs.gnu.org > > > > > From: Philipp p.stephani2@gmail.com > > > Date: Fri, 06 Mar 2020 23:39:16 +0100 > > > In Emacs 26, sql-add-product has the signature > > > (sql-add-product PRODUCT DISPLAY &rest PLIST) > > > However, in the Emacs 27 pretest the signature is now > > > (sql-add-product PRODUCT DISPLAY &optional PLIST) > > > Note the change from &rest to &optional. This is a breaking change th= at > > > breaks all users of sql-add-product. I've found quite a few uses of t= he > > > old signature in the wild, > > > > Thanks for reporting this. > > Michael, could you please look into this ASAP? TIA. > > Btw, this change of a public API is not in NEWS, AFAICT; if we decide > > eventually on keeping the change, we should announce it in NEWS. Sorry for the delay. The massive switch to WFH and illness concerns at home interfered. All are fine, and I actually do get work done occasionally. I've got the following patch to make. I assume it needs to be made to the emacs-27 branch and corresponding patches made to master as well. If I should only commit to master (same change is needed there) for cherry-picki= ng for emacs-27, let me know. $ git diff diff --git a/ChangeLog.3 b/ChangeLog.3 index fc41c1f7dc..e6cad9ed7c 100644 --- a/ChangeLog.3 +++ b/ChangeLog.3 @@ -1,3 +1,11 @@ +2020-03-22 Michael R. Mauger + +=09* lisp/progmodes/sql.el (sql-add-product): Re-correct argument +=09spec. Previous change was due to my own stupidity; I have +=09resolved prior behavior (Bug#39960). +=09* test/lisp/progmodes/sql-tests.el (sql-test-add-product): Added +=09test to insure I don't make the same mistake again. + 2020-02-27 Nicolas Petton =09* admin/authors.el (authors-ignored-files): Fix entries. diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el index 400e304ecf..a04c26d276 100644 --- a/lisp/progmodes/sql.el +++ b/lisp/progmodes/sql.el @@ -2740,7 +2740,7 @@ sql-read-product nil 'require-match init 'sql-product-history init)))) -(defun sql-add-product (product display &optional plist) +(defun sql-add-product (product display &rest plist) "Add support for a database product in `sql-mode'. Add PRODUCT to `sql-product-alist' which enables `sql-mode' to diff --git a/test/lisp/progmodes/sql-tests.el b/test/lisp/progmodes/sql-tes= ts.el index d6f89341be..91805ab725 100644 --- a/test/lisp/progmodes/sql-tests.el +++ b/test/lisp/progmodes/sql-tests.el @@ -187,13 +187,19 @@ sql-test-add-product (sql-add-product 'xyz "XyzDb") (should (equal (pp-to-string (assoc 'xyz sql-product-alist)) - "(xyz :name \"XyzDb\")\n")))) + "(xyz :name \"XyzDb\")\n"))) + + (sql-test-product-feature-harness + (sql-add-product 'stu "StuDb" :X 1 :Y "2") + + (should (equal (pp-to-string (assoc 'stu sql-product-alist)) + "(stu :name \"StuDb\" :X 1 :Y \"2\")\n")))) (ert-deftest sql-test-add-existing-product () "Add a product that already exists." (sql-test-product-feature-harness - (should-error (sql-add-feature 'a "Aaa")) + (should-error (sql-add-product 'a "Aaa")) (should (equal (pp-to-string (assoc 'a sql-product-alist)) "(a :X 1 :Y 2 :Z sql-test-feature-value-a)\n")))) -- MICHAEL@MAUGER.COM // FSF and EFF member // GNU Emacs sql.el maintainer From unknown Sat Aug 16 18:38:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Mar 2020 14:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Mauger Cc: 39960@debbugs.gnu.org, michael@mauger.com, p.stephani2@gmail.com Received: via spool by 39960-submit@debbugs.gnu.org id=B39960.158497346711793 (code B ref 39960); Mon, 23 Mar 2020 14:25:01 +0000 Received: (at 39960) by debbugs.gnu.org; 23 Mar 2020 14:24:27 +0000 Received: from localhost ([127.0.0.1]:53369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGO0A-000348-R8 for submit@debbugs.gnu.org; Mon, 23 Mar 2020 10:24:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGO09-00033w-Cz for 39960@debbugs.gnu.org; Mon, 23 Mar 2020 10:24:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jGO03-0001zR-Lq; Mon, 23 Mar 2020 10:24:19 -0400 Received: from [176.228.60.248] (port=4102 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jGO03-0003Bx-1q; Mon, 23 Mar 2020 10:24:19 -0400 Date: Mon, 23 Mar 2020 16:24:24 +0200 Message-Id: <83pnd3b147.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Michael Mauger on Mon, 23 Mar 2020 01:20:45 +0000) References: <837dzwboes.fsf@gnu.org> <83k13o8tsb.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Date: Mon, 23 Mar 2020 01:20:45 +0000 > From: Michael Mauger > Cc: "michael@mauger.com" , "p.stephani2@gmail.com" , "39960@debbugs.gnu.org" <39960@debbugs.gnu.org> > > Sorry for the delay. The massive switch to WFH and illness concerns at home > interfered. All are fine, and I actually do get work done occasionally. Good to hear you are fine. > I've got the following patch to make. I assume it needs to be made to the > emacs-27 branch and corresponding patches made to master as well. If I > should only commit to master (same change is needed there) for cherry-picking > for emacs-27, let me know. Please push only to emacs-27. It will be merged to master soon enough, no need to push there as well. Thanks. From unknown Sat Aug 16 18:38:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Jul 2020 20:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Mauger Cc: "39960@debbugs.gnu.org" <39960@debbugs.gnu.org>, "michael@mauger.com" , Eli Zaretskii Received: via spool by 39960-submit@debbugs.gnu.org id=B39960.15959667827106 (code B ref 39960); Tue, 28 Jul 2020 20:07:02 +0000 Received: (at 39960) by debbugs.gnu.org; 28 Jul 2020 20:06:22 +0000 Received: from localhost ([127.0.0.1]:59148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0Vri-0001qX-0s for submit@debbugs.gnu.org; Tue, 28 Jul 2020 16:06:22 -0400 Received: from mail-oo1-f49.google.com ([209.85.161.49]:44152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0Vre-0001qF-6P for 39960@debbugs.gnu.org; Tue, 28 Jul 2020 16:06:21 -0400 Received: by mail-oo1-f49.google.com with SMTP id o36so4048407ooi.11 for <39960@debbugs.gnu.org>; Tue, 28 Jul 2020 13:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8zxcJ1jZGtbtdIejjz9k5nQ+rfKP7Oe1nRSGmBdltBQ=; b=VRvel9VC/98Jzk7LmbxGbezbo+WHl62OltHfizoZOFJCybaBQwltPg0x6LHoL1hhBk EgVMOy2TOsclxrFSAUCkRXOdFTrvhCH/GflVT74k+7aFHLopG/KO8Eq52/NSiLwY08o/ RLQuQC8XLqLhuVv9OoV3BJsjByMnd/Zn3EpTayaTrWPMh8WhTkDZf73SjNrWesqcvwqs 0z9s8Wlb1mPpV2HAttopqGx5e38nvEx9DyFtdb8qUiGclwtIFrAA0jpRgYSUquT86JWd oGXlxzhlbJ3GUtsxXqN2qSq/1VVXr1ReoJVNbOC6+ViTPqoBmxddIqzVZ7byfyx7WWZq P9QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8zxcJ1jZGtbtdIejjz9k5nQ+rfKP7Oe1nRSGmBdltBQ=; b=s/2SeodwPuIUD7QgPqmibieS3TpXFYL2EOHfv0R5HeKqgno1G7o7Ca6lG2Weza8lhz Nf1tXKwrfiE/FWC2RVQDIYqvyT/ASRzr6zCwrOI3MBOnzOyoSENMjZgV2gD+iIObAlJI tTFX91jPBYE0KUh7K8t3W1CCWw4yf+KOTJcqgnSpqYJ+qkPXAo2tT9xXhtZEN5/o91R3 lpNTd7aHw2iAS9yTIdBemPry1FU3oLWoLnD0L+IzD0Ry7xhNkhaIpJM1WuH17Qk+EQUr pBGW0OwsJws/5DE44Yo3b7HhTn2IVSqjcstWBEIhzGPn3HzJd0JMti5pTdfIAT5ybBSJ vu2Q== X-Gm-Message-State: AOAM533T0cOrNFMYvfp2oFyYQ0HX5ZwqIjt8mxl03rZdkpaQAw0mnpvd Wg60pDd+3wmzzuJ2APd3DqEqggwtTDKuJJ+Wdg8= X-Google-Smtp-Source: ABdhPJwPjjnXhCmmYay/+BjNHoDMWCA20konvIIM99FDGUrl0D2v5lVLAQPH4T4BEbKrxF3s7xwIFApUwuPdZzx4kRI= X-Received: by 2002:a4a:3b0f:: with SMTP id s15mr23350355oos.71.1595966772509; Tue, 28 Jul 2020 13:06:12 -0700 (PDT) MIME-Version: 1.0 References: <837dzwboes.fsf@gnu.org> <83k13o8tsb.fsf@gnu.org> In-Reply-To: From: Philipp Stephani Date: Tue, 28 Jul 2020 22:06:00 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Mo., 23. M=C3=A4rz 2020 um 02:20 Uhr schrieb Michael Mauger : > > =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original = Message =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 > On Friday, March 13, 2020 5:53 AM, Eli Zaretskii wrote: > > > Ping! > > > > > Date: Sat, 07 Mar 2020 09:43:39 +0200 > > > From: Eli Zaretskii eliz@gnu.org > > > Cc: 39960@debbugs.gnu.org > > > > > > > From: Philipp p.stephani2@gmail.com > > > > Date: Fri, 06 Mar 2020 23:39:16 +0100 > > > > In Emacs 26, sql-add-product has the signature > > > > (sql-add-product PRODUCT DISPLAY &rest PLIST) > > > > However, in the Emacs 27 pretest the signature is now > > > > (sql-add-product PRODUCT DISPLAY &optional PLIST) > > > > Note the change from &rest to &optional. This is a breaking change = that > > > > breaks all users of sql-add-product. I've found quite a few uses of= the > > > > old signature in the wild, > > > > > > Thanks for reporting this. > > > Michael, could you please look into this ASAP? TIA. > > > Btw, this change of a public API is not in NEWS, AFAICT; if we decide > > > eventually on keeping the change, we should announce it in NEWS. > > Sorry for the delay. The massive switch to WFH and illness concerns at ho= me > interfered. All are fine, and I actually do get work done occasionally. No worries, and good to hear that! > > I've got the following patch to make. I assume it needs to be made to the > emacs-27 branch and corresponding patches made to master as well. If I > should only commit to master (same change is needed there) for cherry-pic= king > for emacs-27, let me know. Thanks for the patch! I noticed that it made it to master as commit 82a632edc8b80bf16d9b9f205474bf9724b084c0, but not to emacs-27, are you still planning to backport it? From unknown Sat Aug 16 18:38:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Resent-From: Michael Mauger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Aug 2020 02:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Philipp Stephani Cc: "39960@debbugs.gnu.org" <39960@debbugs.gnu.org>, Eli Zaretskii Reply-To: Michael Mauger Received: via spool by 39960-submit@debbugs.gnu.org id=B39960.159693924822162 (code B ref 39960); Sun, 09 Aug 2020 02:15:02 +0000 Received: (at 39960) by debbugs.gnu.org; 9 Aug 2020 02:14:08 +0000 Received: from localhost ([127.0.0.1]:59814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4aqe-0005lO-D2 for submit@debbugs.gnu.org; Sat, 08 Aug 2020 22:14:08 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:30226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4aqc-0005kl-F0 for 39960@debbugs.gnu.org; Sat, 08 Aug 2020 22:14:07 -0400 Date: Sun, 09 Aug 2020 02:13:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1596939240; bh=CSblgSY2adPAOckTvUEgQkvbBfPXlQvQ83DAFoAzyV0=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=UvYDePLc0n6OdiU8tDYa40p2nzuEqhrfqSEPYDM36GydPOyL/GdNMi+MkqkCN8deq 8dlYv7pOIqNOraZSpn70mV1dj9fjq5feUL6MYFMmQ8fDKrAvza/9eJ6WjI+yUIVuzw cZXoIwOnqArfLa6/CXshx6rdcGE5QLi/BlzN+pv8= From: Michael Mauger Message-ID: <0ECl7a2DnX9lhCgi5l9yWWgYuaVA8vXSgopiT8XnU1gOTJ03LLk0aMCVRbM4a95Ab9aYDuP5EiFpeL03TY_RzB5ogHS-3jPzLxH5dVjUW8o=@protonmail.com> In-Reply-To: References: <837dzwboes.fsf@gnu.org> <83k13o8tsb.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Tuesday, July 28, 2020 4:06 PM, Philipp Stephani = wrote: > Am Mo., 23. M=C3=A4rz 2020 um 02:20 Uhr schrieb Michael Mauger > mmauger@protonmail.com: > > > =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Origina= l Message =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80= =90 > > On Friday, March 13, 2020 5:53 AM, Eli Zaretskii eliz@gnu.org wrote: > > > > > Ping! > > > > > > > Date: Sat, 07 Mar 2020 09:43:39 +0200 > > > > From: Eli Zaretskii eliz@gnu.org > > > > Cc: 39960@debbugs.gnu.org > > > > > > > > > From: Philipp p.stephani2@gmail.com > > > > > Date: Fri, 06 Mar 2020 23:39:16 +0100 > > > > > In Emacs 26, sql-add-product has the signature > > > > > (sql-add-product PRODUCT DISPLAY &rest PLIST) > > > > > However, in the Emacs 27 pretest the signature is now > > > > > (sql-add-product PRODUCT DISPLAY &optional PLIST) > > > > > Note the change from &rest to &optional. This is a breaking chang= e that > > > > > breaks all users of sql-add-product. I've found quite a few uses = of the > > > > > old signature in the wild, > > > > > > > > Thanks for reporting this. > > > > Michael, could you please look into this ASAP? TIA. > > > > Btw, this change of a public API is not in NEWS, AFAICT; if we deci= de > > > > eventually on keeping the change, we should announce it in NEWS. > > > > Sorry for the delay. The massive switch to WFH and illness concerns at = home > > interfered. All are fine, and I actually do get work done occasionally. > > No worries, and good to hear that! > > > I've got the following patch to make. I assume it needs to be made to t= he > > emacs-27 branch and corresponding patches made to master as well. If I > > should only commit to master (same change is needed there) for cherry-p= icking > > for emacs-27, let me know. > > Thanks for the patch! I noticed that it made it to master as commit > 82a632edc8b80bf16d9b9f205474bf9724b084c0, but not to emacs-27, are you > still planning to backport it? Yes, it definitely needs to be backported. Eli, what do I need to do to get= this backported to Emacs 27? This was a bad breaking change to 27 that I fixed a= fter the release branch was cut. Let me know if I need to do a separate commit o= r take other action to get this done... -- MICHAEL@MAUGER.COM // FSF and EFF member // GNU Emacs sql.el maintainer From unknown Sat Aug 16 18:38:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Aug 2020 09:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Mauger Cc: "39960@debbugs.gnu.org" <39960@debbugs.gnu.org>, Eli Zaretskii Received: via spool by 39960-submit@debbugs.gnu.org id=B39960.159696448529403 (code B ref 39960); Sun, 09 Aug 2020 09:15:02 +0000 Received: (at 39960) by debbugs.gnu.org; 9 Aug 2020 09:14:45 +0000 Received: from localhost ([127.0.0.1]:59942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4hPg-0007eA-OA for submit@debbugs.gnu.org; Sun, 09 Aug 2020 05:14:45 -0400 Received: from mail-oi1-f171.google.com ([209.85.167.171]:42964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4hPd-0007du-8g for 39960@debbugs.gnu.org; Sun, 09 Aug 2020 05:14:43 -0400 Received: by mail-oi1-f171.google.com with SMTP id j7so6180731oij.9 for <39960@debbugs.gnu.org>; Sun, 09 Aug 2020 02:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Pzq4C9cRtX5hZ6V3TqL2hoqJe/DAGr/5wLV71Pm+a4E=; b=vCWtly3IwaTCmCjyFwls8R6/vj2zVkrRy+LRb+fXyzHpLoG4/p9lizn2KsipYeSVnv SwYMVdsPwtBPIOwYoQPTFF0QIR1DARsaBts1qwK/+71mKg48G2ANeLPaBHhP5M/Pzr6y v1piG01cQinjf0qjgSAGs+7R0g5CCAEdHPWh//cZCw6oegV360VgAgNvuu7IH17mtezt pphxHeFCA5R3Iy4FiEfX+jYsnCNqTb2WW3hTbhKuKcLU8HD5/ypz7Y3S527o08k7q2NA O+hTYM4WYoNmUWrfEovFF/WCGttV6azu5wpVl3R/0lsLhRBfpQjVeeUSQYTqjow2EjR8 JnLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Pzq4C9cRtX5hZ6V3TqL2hoqJe/DAGr/5wLV71Pm+a4E=; b=qx/ogVIzLodYfTifO0Wic/4IxXfHJ35GricrXnoEt0fXXXumntKXJZpEEzaAHCTVGT 2oJFOn5mSelwCIJR16jJppAbdvkK8qM3dcsBKCJT0tc2dm2Ia9saHCFSLE3hG/sUEGG7 wJs6Fw3lt2EWhng91r+lUhVTYWcFaWJ23w9BOp3C0ggCM3T+x9bmbubd7lTexemJGQRm KzjyrbhE5fHa9oKyesdpex0e6UxDbAhgwq6ULDiHw2LYhH4lsKn8gyctpFIaVeG1uVQQ seRLFt3es10Eq0pG/0XJi0CLkjZCVPNcnSeHXgee2kwSzdEp2m3AD74FwLN4/Lf3fTik 5iMw== X-Gm-Message-State: AOAM533myhCSNeaca7PkHlleDzPBYxud9RWlGkD8Nw/uYc7d32exVdi0 l/TDiePuf4DODGPcaf4S1pR9Wsdvh7ybFgH5M8A= X-Google-Smtp-Source: ABdhPJyQ3gfyYZ8zzdjWtlzwsheD4qok2gyetsG6WyDrmyMi0/tGISwfO4PG/r+mTM87kCEvaFucbNDnWbV+QPUCdEw= X-Received: by 2002:aca:2101:: with SMTP id 1mr18244121oiz.170.1596964475547; Sun, 09 Aug 2020 02:14:35 -0700 (PDT) MIME-Version: 1.0 References: <837dzwboes.fsf@gnu.org> <83k13o8tsb.fsf@gnu.org> <0ECl7a2DnX9lhCgi5l9yWWgYuaVA8vXSgopiT8XnU1gOTJ03LLk0aMCVRbM4a95Ab9aYDuP5EiFpeL03TY_RzB5ogHS-3jPzLxH5dVjUW8o=@protonmail.com> In-Reply-To: <0ECl7a2DnX9lhCgi5l9yWWgYuaVA8vXSgopiT8XnU1gOTJ03LLk0aMCVRbM4a95Ab9aYDuP5EiFpeL03TY_RzB5ogHS-3jPzLxH5dVjUW8o=@protonmail.com> From: Philipp Stephani Date: Sun, 9 Aug 2020 11:14:24 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Am So., 9. Aug. 2020 um 04:14 Uhr schrieb Michael Mauger : > > =?UTF-8?Q?=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90?= Original Message =?UTF-8?Q?=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90?= > On Tuesday, July 28, 2020 4:06 PM, Philipp Stephani wrote: > > > Am Mo. [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (p.stephani2[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (p.stephani2[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.171 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.171 listed in wl.mailspike.net] 1.0 FREEMAIL_REPLY From and body contain different freemails X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Am So., 9. Aug. 2020 um 04:14 Uhr schrieb Michael Mauger : > > =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original = Message =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 > On Tuesday, July 28, 2020 4:06 PM, Philipp Stephani wrote: > > > Am Mo., 23. M=C3=A4rz 2020 um 02:20 Uhr schrieb Michael Mauger > > mmauger@protonmail.com: > > > > > =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Origi= nal Message =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 > > > On Friday, March 13, 2020 5:53 AM, Eli Zaretskii eliz@gnu.org wrote: > > > > > > > Ping! > > > > > > > > > Date: Sat, 07 Mar 2020 09:43:39 +0200 > > > > > From: Eli Zaretskii eliz@gnu.org > > > > > Cc: 39960@debbugs.gnu.org > > > > > > > > > > > From: Philipp p.stephani2@gmail.com > > > > > > Date: Fri, 06 Mar 2020 23:39:16 +0100 > > > > > > In Emacs 26, sql-add-product has the signature > > > > > > (sql-add-product PRODUCT DISPLAY &rest PLIST) > > > > > > However, in the Emacs 27 pretest the signature is now > > > > > > (sql-add-product PRODUCT DISPLAY &optional PLIST) > > > > > > Note the change from &rest to &optional. This is a breaking cha= nge that > > > > > > breaks all users of sql-add-product. I've found quite a few use= s of the > > > > > > old signature in the wild, > > > > > > > > > > Thanks for reporting this. > > > > > Michael, could you please look into this ASAP? TIA. > > > > > Btw, this change of a public API is not in NEWS, AFAICT; if we de= cide > > > > > eventually on keeping the change, we should announce it in NEWS. > > > > > > Sorry for the delay. The massive switch to WFH and illness concerns a= t home > > > interfered. All are fine, and I actually do get work done occasionall= y. > > > > No worries, and good to hear that! > > > > > I've got the following patch to make. I assume it needs to be made to= the > > > emacs-27 branch and corresponding patches made to master as well. If = I > > > should only commit to master (same change is needed there) for cherry= -picking > > > for emacs-27, let me know. > > > > Thanks for the patch! I noticed that it made it to master as commit > > 82a632edc8b80bf16d9b9f205474bf9724b084c0, but not to emacs-27, are you > > still planning to backport it? > > Yes, it definitely needs to be backported. Eli, what do I need to do to g= et this > backported to Emacs 27? This was a bad breaking change to 27 that I fixed= after > the release branch was cut. Let me know if I need to do a separate commit= or take > other action to get this done... > Typically you'd cherry-pick the commit onto the release branch. But since Emacs 27 is about to be released (tomorrow), it might be too late now. From unknown Sat Aug 16 18:38:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Aug 2020 14:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Philipp Stephani Cc: 39960@debbugs.gnu.org, mmauger@protonmail.com Received: via spool by 39960-submit@debbugs.gnu.org id=B39960.159698176513882 (code B ref 39960); Sun, 09 Aug 2020 14:03:01 +0000 Received: (at 39960) by debbugs.gnu.org; 9 Aug 2020 14:02:45 +0000 Received: from localhost ([127.0.0.1]:33201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4luP-0003bq-30 for submit@debbugs.gnu.org; Sun, 09 Aug 2020 10:02:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4luN-0003bd-RR for 39960@debbugs.gnu.org; Sun, 09 Aug 2020 10:02:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60264) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4luI-0001UC-FZ; Sun, 09 Aug 2020 10:02:38 -0400 Received: from [176.228.60.248] (port=1262 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k4luH-0000Q5-H9; Sun, 09 Aug 2020 10:02:38 -0400 Date: Sun, 09 Aug 2020 17:02:22 +0300 Message-Id: <83imdr6hox.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Philipp Stephani on Sun, 9 Aug 2020 11:14:24 +0200) References: <837dzwboes.fsf@gnu.org> <83k13o8tsb.fsf@gnu.org> <0ECl7a2DnX9lhCgi5l9yWWgYuaVA8vXSgopiT8XnU1gOTJ03LLk0aMCVRbM4a95Ab9aYDuP5EiFpeL03TY_RzB5ogHS-3jPzLxH5dVjUW8o=@protonmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philipp Stephani > Date: Sun, 9 Aug 2020 11:14:24 +0200 > Cc: Eli Zaretskii , "39960@debbugs.gnu.org" <39960@debbugs.gnu.org> > > Typically you'd cherry-pick the commit onto the release branch. But > since Emacs 27 is about to be released (tomorrow), it might be too > late now. Indeed, it's too late for 27.1. Let's try to cherry-pick after 27.1 is released, so that the fix ends up in 27.2. Thanks. From unknown Sat Aug 16 18:38:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Oct 2020 18:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 39960@debbugs.gnu.org, Philipp Stephani , mmauger@protonmail.com Received: via spool by 39960-submit@debbugs.gnu.org id=B39960.160157739030680 (code B ref 39960); Thu, 01 Oct 2020 18:37:01 +0000 Received: (at 39960) by debbugs.gnu.org; 1 Oct 2020 18:36:30 +0000 Received: from localhost ([127.0.0.1]:38295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO3RL-0007yd-2G for submit@debbugs.gnu.org; Thu, 01 Oct 2020 14:36:30 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO3RG-0007yM-KO for 39960@debbugs.gnu.org; Thu, 01 Oct 2020 14:36:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PUlJQsGoAR1Oi/HPA2Z5qWrvdByoccLLyMJJ06IG3mg=; b=DecpDgXnch3kHJiQB5rI/aVPtl xt30XTkZCORIPIuXIeEWvuhNLVR4dUzz2qbKcVGB1Bq6xExd0yorpycEIUTNg+z0yRO44RDa9m9Fu XlEgiDTerLEuFlN79Cz2MBzWBnJWk0G56CiqPo/YAEpAl4eT179bIuQZuIyrF6Sf831s=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO3R5-0001r7-SF; Thu, 01 Oct 2020 20:36:16 +0200 From: Lars Ingebrigtsen References: <837dzwboes.fsf@gnu.org> <83k13o8tsb.fsf@gnu.org> <0ECl7a2DnX9lhCgi5l9yWWgYuaVA8vXSgopiT8XnU1gOTJ03LLk0aMCVRbM4a95Ab9aYDuP5EiFpeL03TY_RzB5ogHS-3jPzLxH5dVjUW8o=@protonmail.com> <83imdr6hox.fsf@gnu.org> X-Now-Playing: Nanang Tatang's _Muki_: "Can't Help It" Date: Thu, 01 Oct 2020 20:36:10 +0200 In-Reply-To: <83imdr6hox.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 09 Aug 2020 17:02:22 +0300") Message-ID: <87d0213iat.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > Indeed, it's too late for 27.1. Let's try to cherry-pick after 27.1 > is released, so that the fix ends up in 27.2. I've now cherry-picked Michael's patch and pushed it to the Emacs 27 branch. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Indeed, it's too late for 27.1. Let's try to cherry-pick after 27.1 > is released, so that the fix ends up in 27.2. I've now cherry-picked Michael's patch and pushed it to the Emacs 27 branch. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 01 14:36:30 2020 Received: (at control) by debbugs.gnu.org; 1 Oct 2020 18:36:30 +0000 Received: from localhost ([127.0.0.1]:38298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO3RO-0007yn-JJ for submit@debbugs.gnu.org; Thu, 01 Oct 2020 14:36:30 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO3RL-0007yS-L1 for control@debbugs.gnu.org; Thu, 01 Oct 2020 14:36:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eUZ0YanyO8/k4qrsQub0zvld7Pk5c9xIiYg0jBR6weU=; b=IS9qodlZSbz4g5ceINfWibFi8x Ee16xXtxDjeHPe1Sm6yZj65AYntJCfNpLG6LGCo7CqxzFR7LpXQ8WysaPoXhw46KMrQdSVhgPZb4e sw1QEpMO5elFZwsfL29sNKyofrTsnjiP+4buLMUqUm5ErsTsC0TdNM+3BovAKFCyg+gQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO3RD-0001rG-SX for control@debbugs.gnu.org; Thu, 01 Oct 2020 20:36:22 +0200 Date: Thu, 01 Oct 2020 20:36:18 +0200 Message-Id: <87blhl3ial.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #39960 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 39960 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 39960 28.1 quit From unknown Sat Aug 16 18:38:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Oct 2020 18:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 39960@debbugs.gnu.org, Eli Zaretskii , Michael Mauger Received: via spool by 39960-submit@debbugs.gnu.org id=B39960.160183739328058 (code B ref 39960); Sun, 04 Oct 2020 18:50:01 +0000 Received: (at 39960) by debbugs.gnu.org; 4 Oct 2020 18:49:53 +0000 Received: from localhost ([127.0.0.1]:46749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP94z-0007IU-IY for submit@debbugs.gnu.org; Sun, 04 Oct 2020 14:49:53 -0400 Received: from mail-oi1-f175.google.com ([209.85.167.175]:37518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP94x-0007IE-Ju for 39960@debbugs.gnu.org; Sun, 04 Oct 2020 14:49:52 -0400 Received: by mail-oi1-f175.google.com with SMTP id t77so3126884oie.4 for <39960@debbugs.gnu.org>; Sun, 04 Oct 2020 11:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jw7iqgOef/P/9I75nRDW6T8IQGLYlQKgs2o9oSupHQ8=; b=jzjVmn+gYz9URwiXdJgeRgZcPHDtQiHWV7qE4S7f7UHEVeb2vSKDTMurA53nCwiDpg Y/HS/PUYcQC3U1+OPbRyViiO64zzX0Ul36TAKn0RDcpGRd6EwtBz0LHxBMMrDLNoxV1m 6mtzefqXtrVAFp5KbB1gjrF+/p6krmZ/WlIBe2dQB1YALhID3m655jQgXVO9EkNObnCU qzKBUHDoJG4Y4rNHU6QrCiV8G5EBKUsWaeQUff/WKMg1XiHe05NPXEenU2TpGnstf1um nA103YMNX5xR19o+dhLsXDEsXWECYhpkYhzCyhcq9GG2EnwWp4DdrdTbxqJa2F0SgGut gtpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jw7iqgOef/P/9I75nRDW6T8IQGLYlQKgs2o9oSupHQ8=; b=UZsjFfjKAIguxjbybnymc+PNXLe985FieIWrGBw+qT0Y/XVawRZ4EljwV3pSM5+GW5 O8ZuUqVdF/77tJGKDrV3DOkO7zzqdK1sd6jazBLDBxJaDqpWhs7vf0nSrDmoWdFHBZ3p UL7OQACh9OVBuQMo0aPGfcP9Qrt8AVX2UXeTrERQQx4f28cGdQUsmH2LJCEqlvfz/XA/ q3b2BxGvO5KnQPCef2rsfUg7yWHSI5qJCVI3SaMlDoba+z+bhPc0R8VmvYHVMHAtye9R jMrDXumfraIGvNT6fAdH3yHIr33sRSYwqAg7ot5cdUAZNDdwv8RDmiMACsynAFi53O3x MtwA== X-Gm-Message-State: AOAM533LbkNciV49Czzddifigl0XOyF7vi+Xf9sjqd3NC7NhuG7YBaD4 5u+Y47v4ZCifSYgxYc88CeBKL3PQ4qfsOoQe1yQ= X-Google-Smtp-Source: ABdhPJzqCRqcnx9/ucnn7dhOU6y2ZoXGfIN9HqUZRB9CqUXwVkOHerxvDI5vlN6uyzDYjb8QL8WV110x+3MkMljLs5k= X-Received: by 2002:aca:a853:: with SMTP id r80mr6682965oie.170.1601837385798; Sun, 04 Oct 2020 11:49:45 -0700 (PDT) MIME-Version: 1.0 References: <837dzwboes.fsf@gnu.org> <83k13o8tsb.fsf@gnu.org> <0ECl7a2DnX9lhCgi5l9yWWgYuaVA8vXSgopiT8XnU1gOTJ03LLk0aMCVRbM4a95Ab9aYDuP5EiFpeL03TY_RzB5ogHS-3jPzLxH5dVjUW8o=@protonmail.com> <83imdr6hox.fsf@gnu.org> <87d0213iat.fsf@gnus.org> In-Reply-To: <87d0213iat.fsf@gnus.org> From: Philipp Stephani Date: Sun, 4 Oct 2020 20:49:34 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Am Do., 1. Okt. 2020 um 20:36 Uhr schrieb Lars Ingebrigtsen : > > Eli Zaretskii writes: > > > Indeed, it's too late for 27.1. Let's try to cherry-pick after 27.1 > > is released, so that the fix ends up in 27.2. > > I've now cherry-picked Michael's patch and pushed it to the Emacs 27 > branch. Thanks. Unfortunately, now that Emacs 27.1 is already released, this created a second incompatible change.