GNU bug report logs - #39943
[PATCH 0/3] WIP: Hyperledger Iroha

Previous Next

Full log

Message #41 received at 39943 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Efraim Flashner <efraim <at> flashner.co.il>, 39943 <at> debbugs.gnu.org
Subject: Re: [PATCH v2 4/4] gnu: Add hyperledger-iroha.
Date: Wed, 11 Mar 2020 15:13:25 +0100

[Message part 1 (text/plain, inline)]

I've tested it and run the example here
https://iroha.readthedocs.io/en/latest/getting_started/cli-guide.html
It works!

Patch looks good, feel free to merge.
A few comments below:

> +              (snippet
> +               '(begin
> +                  ;; Backport unversioned fmt dependency:
> +                  (substitute* "libs/logger/logger.hpp"
> +                    (("fmt::v5") "fmt"))
> +                  #t))))

Mention the commit you've sent me and that this should be removed on
next update.

> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:configure-flags
> +       '("-DTESTING=OFF"
> +         ; Don't install the shared libraries of the dependencies:
> +         "-DENABLE_LIBS_PACKAGING=OFF")
> +       #:tests? #f

Explain why the tests must be disabled.

> +       #:test-target "."

Why setting the test-target if you are not running it?

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'change-compilation-flags
> +           (lambda _
> +             (substitute* "cmake/functions.cmake"
> +               (("-Werror") ""))
> +             #t)))))

Why do you need to do this?

> +    ;; See https://iroha.readthedocs.io/en/latest/build/index.html.
> +    (native-inputs
> +     `(("googletest" ,googletest)))
> +    (inputs
> +     `(("boost" ,boost-1.69)
> +       ("fmt" ,fmt)
> +       ("gflags" ,gflags)
> +       ("grpc" ,grpc)
> +       ("hyperledger-iroha-ed25519" ,hyperledger-iroha-ed25519)
> +       ("postgresql" ,postgresql)
> +       ("protobuf" ,protobuf)
> +       ("rapidjson" ,rapidjson)
> +       ("rxcpp" ,rxcpp)
> +       ("soci" ,soci)
> +       ("spdlog" ,spdlog)
> +       ("tbb" ,tbb)))
> +    (synopsis "Simple, decentralized ledger")
> +    (description "Iroha is a distributed ledger technology (DLT). Iroha has

Double spacing.

Thanks!
Cheers!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.