GNU bug report logs - #39932
[PATCH 0/3] python-virtualenv: Update to 20.0.8.

Previous Next

Full log

Message #25 received at 39932-done <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 39932-done <at> debbugs.gnu.org
Subject: Re: [bug#39932] [PATCH 1/3] gnu: python-xyz: Add python-distlib.
Date: Mon, 9 Mar 2020 00:22:57 +0100

[Message part 1 (text/plain, inline)]

On Sun, Mar 08, 2020 at 09:18:12PM +0100, Ludovic Courtès wrote:
> Hello,
> 
> Jakub Kądziołka <kuba <at> kadziolka.net> skribis:
> 
> > * gnu/packages/python-xyz.scm (python-distlib): New variable.
> 
> [...]
> 
> > +       (modify-phases %standard-phases
> > +         (add-before 'build 'no-/bin/sh
> > +           (lambda _
> > +             (substitute* '("distlib/scripts.py" "tests/test_scripts.py")
> > +               (("/bin/sh") (which "sh")))))
> > +         (add-before 'check 'prepare-test-env
> > +           (lambda _
> > +             (setenv "HOME" "/tmp")
> > +             ;; NOTE: Any value works, the variable just has to be present.
> > +             (setenv "SKIP_ONLINE" "1"))))))
> 
> Please return #t from both phases, as is conventional.
Argh, I'm always forgetting about that. It would be nice to have a lint
for this...

> Apart from that, all 3 patches LGTM!
Thanks! I pushed the commits, the last one got a hash of
94d57ba3399aeb1b34d52e5e866c609f5a18ec2b

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.