From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 05 14:13:44 2020 Received: (at submit) by debbugs.gnu.org; 5 Mar 2020 19:13:44 +0000 Received: from localhost ([127.0.0.1]:43719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9vwF-0003bd-S1 for submit@debbugs.gnu.org; Thu, 05 Mar 2020 14:13:44 -0500 Received: from lists.gnu.org ([209.51.188.17]:51610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9vwE-0003bW-I2 for submit@debbugs.gnu.org; Thu, 05 Mar 2020 14:13:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59920) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9vwD-0004gk-IX for guix-patches@gnu.org; Thu, 05 Mar 2020 14:13:42 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9vwC-0008Px-Jv for guix-patches@gnu.org; Thu, 05 Mar 2020 14:13:41 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:34904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j9vwC-0008NW-9L for guix-patches@gnu.org; Thu, 05 Mar 2020 14:13:40 -0500 Received: (qmail 7338 invoked by uid 1009); 5 Mar 2020 20:13:38 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25741. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.008783 secs); 05 Mar 2020 19:13:38 -0000 Received: from unknown (HELO localhost.localdomain) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with AES256-SHA encrypted SMTP; 5 Mar 2020 20:13:38 +0100 From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= To: guix-patches@gnu.org Subject: [PATCH 0/3] python-virtualenv: Update to 20.0.8. Date: Thu, 5 Mar 2020 20:14:24 +0100 Message-Id: <20200305191424.12134-1-kuba@kadziolka.net> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 37.59.186.212 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) I have ran into an issue with virtualenv (see #39930). I have thought that updating the package might help, but it didn't change anything. Either way, the task was non-trivial enough to benefit from your review. Jakub Kądziołka (3): gnu: python-xyz: Add python-distlib. gnu: python-xyz: Add python-filelock. gnu: python-virtualenv: Update to 20.0.8. gnu/packages/python-xyz.scm | 80 +++++++++++++++++++++++++++++++------ 1 file changed, 67 insertions(+), 13 deletions(-) -- 2.25.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 05 14:21:17 2020 Received: (at 39932) by debbugs.gnu.org; 5 Mar 2020 19:21:17 +0000 Received: from localhost ([127.0.0.1]:43732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9w3Y-0003pL-Vc for submit@debbugs.gnu.org; Thu, 05 Mar 2020 14:21:17 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:49874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9w3X-0003oz-5k for 39932@debbugs.gnu.org; Thu, 05 Mar 2020 14:21:15 -0500 Received: (qmail 9693 invoked by uid 1009); 5 Mar 2020 20:21:13 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25741. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.019185 secs); 05 Mar 2020 19:21:13 -0000 Received: from unknown (HELO localhost.localdomain) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with AES256-SHA encrypted SMTP; 5 Mar 2020 20:21:13 +0100 From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= To: 39932@debbugs.gnu.org Subject: [PATCH 1/3] gnu: python-xyz: Add python-distlib. Date: Thu, 5 Mar 2020 20:22:02 +0100 Message-Id: <20200305192204.14973-1-kuba@kadziolka.net> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Qmailux-2.08st: added fake Content-Type header Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39932 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/python-xyz.scm (python-distlib): New variable. --- gnu/packages/python-xyz.scm | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 3cd1686d28..2dfda3d26d 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -4410,6 +4410,38 @@ by pycodestyle.") (define-public python2-autopep8 (package-with-python2 python-autopep8)) +(define-public python-distlib + (package + (name "python-distlib") + (version "0.3.0") + (source + (origin + (method url-fetch) + (uri (pypi-uri "distlib" version ".zip")) + (sha256 + (base32 + "08fyi2r246733vharl2yckw20rilci28r91mzrnnvcr638inw5if")))) + (build-system python-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-before 'build 'no-/bin/sh + (lambda _ + (substitute* '("distlib/scripts.py" "tests/test_scripts.py") + (("/bin/sh") (which "sh"))))) + (add-before 'check 'prepare-test-env + (lambda _ + (setenv "HOME" "/tmp") + ;; NOTE: Any value works, the variable just has to be present. + (setenv "SKIP_ONLINE" "1")))))) + (native-inputs `(("unzip" ,unzip))) + (home-page "https://bitbucket.org/pypa/distlib") + (synopsis "Distribution utilities") + (description "Distlib is a library which implements low-level functions that +relate to packaging and distribution of Python software. It is intended to be +used as the basis for third-party packaging tools.") + (license license:psfl))) + (define-public python-distutils-extra (package (name "python-distutils-extra") -- 2.25.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 05 14:21:17 2020 Received: (at 39932) by debbugs.gnu.org; 5 Mar 2020 19:21:17 +0000 Received: from localhost ([127.0.0.1]:43734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9w3Z-0003pN-BA for submit@debbugs.gnu.org; Thu, 05 Mar 2020 14:21:17 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:49880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9w3X-0003p0-5E for 39932@debbugs.gnu.org; Thu, 05 Mar 2020 14:21:15 -0500 Received: (qmail 9704 invoked by uid 1009); 5 Mar 2020 20:21:13 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25741. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.018073 secs); 05 Mar 2020 19:21:13 -0000 Received: from unknown (HELO localhost.localdomain) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with AES256-SHA encrypted SMTP; 5 Mar 2020 20:21:13 +0100 From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= To: 39932@debbugs.gnu.org Subject: [PATCH 2/3] gnu: python-xyz: Add python-filelock. Date: Thu, 5 Mar 2020 20:22:03 +0100 Message-Id: <20200305192204.14973-2-kuba@kadziolka.net> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200305192204.14973-1-kuba@kadziolka.net> References: <20200305192204.14973-1-kuba@kadziolka.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Qmailux-2.08st: added fake Content-Type header Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39932 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/python-xyz.scm (python-filelock): New variable. --- gnu/packages/python-xyz.scm | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 2dfda3d26d..c3d08844e6 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -670,6 +670,26 @@ API for locking files.") (define-public python2-lockfile (package-with-python2 python-lockfile)) +(define-public python-filelock + (package + (name "python-filelock") + (version "3.0.12") + (source + (origin + (method url-fetch) + (uri (pypi-uri "filelock" version)) + (sha256 + (base32 + "0ngzlvb5j8gqs2nxlp2b0jhzii792h66wsn694qm8kqixr225n0q")))) + (build-system python-build-system) + (home-page + "https://github.com/benediktschmitt/py-filelock") + (synopsis "A platform independent file lock") + (description "@code{filelock} contains a single module implementing +a platform independent file lock in Python, which provides a simple way of +inter-process communication.") + (license license:unlicense))) + (define-public python-semantic-version (package (name "python-semantic-version") -- 2.25.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 05 14:21:18 2020 Received: (at 39932) by debbugs.gnu.org; 5 Mar 2020 19:21:18 +0000 Received: from localhost ([127.0.0.1]:43736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9w3Z-0003pU-Kj for submit@debbugs.gnu.org; Thu, 05 Mar 2020 14:21:17 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:49906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9w3X-0003p1-7A for 39932@debbugs.gnu.org; Thu, 05 Mar 2020 14:21:16 -0500 Received: (qmail 9713 invoked by uid 1009); 5 Mar 2020 20:21:13 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25741. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.022388 secs); 05 Mar 2020 19:21:13 -0000 Received: from unknown (HELO localhost.localdomain) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with AES256-SHA encrypted SMTP; 5 Mar 2020 20:21:13 +0100 From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= To: 39932@debbugs.gnu.org Subject: [PATCH 3/3] gnu: python-virtualenv: Update to 20.0.8. Date: Thu, 5 Mar 2020 20:22:04 +0100 Message-Id: <20200305192204.14973-3-kuba@kadziolka.net> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200305192204.14973-1-kuba@kadziolka.net> References: <20200305192204.14973-1-kuba@kadziolka.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Qmailux-2.08st: added fake Content-Type header Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39932 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/python-xyz.scm (python-virtualenv): Update to 20.0.8. [arguments]: Remove the now-redundant 'disable-failing-test phase. [native-inputs]: Add python-setuptools and python-setuptools-scm. [inputs]: Add python-{appdirs, distlib, filelock, six, importlib-metadata}. --- gnu/packages/python-xyz.scm | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index c3d08844e6..6131baf5ea 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -2397,28 +2397,30 @@ e.g. filters, callbacks and errbacks can all be promises.") (define-public python-virtualenv (package (name "python-virtualenv") - (version "16.1.0") + (version "20.0.8") (source (origin (method url-fetch) (uri (pypi-uri "virtualenv" version)) (sha256 (base32 - "0242cg3hdq3qdvx5flyrki8lpwlgwf5k45c21ks5049fv7ygm6gq")))) + "096r7g5cv85vxymg9iqbn5z749613snlvd6p3rf1nxnrd386j0qz")))) (build-system python-build-system) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-before 'check 'disable-failing-test - (lambda _ - ;; Disable failing test. See upstream bug report - ;; https://github.com/pypa/virtualenv/issues/957 - (substitute* "tests/test_virtualenv.py" - (("skipif.*") "skipif(True, reason=\"Guix\")\n")) - #t))))) (native-inputs `(("python-mock" ,python-mock) - ("python-pytest" ,python-pytest))) + ("python-pytest" ,python-pytest) + ;; NOTE: guix lint remarks that "python-setuptools should probably not + ;; be an input at all". However, removing the input makes the build error: + ;; File "setup.py", line 4, in + ;; raise RuntimeError("setuptools >= 41 required to build") + ("python-setuptools" ,python-setuptools) + ("python-setuptools-scm" ,python-setuptools-scm))) + (inputs + `(("python-appdirs" ,python-appdirs) + ("python-distlib" ,python-distlib) + ("python-filelock" ,python-filelock) + ("python-six" ,python-six) + ("python-importlib-metadata" ,python-importlib-metadata))) (home-page "https://virtualenv.pypa.io/") (synopsis "Virtual Python environment builder") (description -- 2.25.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 05 15:28:53 2020 Received: (at 39932) by debbugs.gnu.org; 5 Mar 2020 20:28:53 +0000 Received: from localhost ([127.0.0.1]:43768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9x6z-0006Am-5H for submit@debbugs.gnu.org; Thu, 05 Mar 2020 15:28:53 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:56076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9x6x-0006Ab-8H for 39932@debbugs.gnu.org; Thu, 05 Mar 2020 15:28:51 -0500 Received: (qmail 29292 invoked by uid 1009); 5 Mar 2020 21:28:49 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25741. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.022333 secs); 05 Mar 2020 20:28:49 -0000 Received: from unknown (HELO gravity) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 5 Mar 2020 21:28:49 +0100 Date: Thu, 5 Mar 2020 21:29:38 +0100 From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= To: 39932@debbugs.gnu.org Subject: Addendum: python-virtualenv: Update to 20.0.8. Message-ID: <20200305202938.7bswb2fregqqwcd6@gravity> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fkgrgehoveao3cw3" Content-Disposition: inline X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39932 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --fkgrgehoveao3cw3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I forgot to re-lint my packages after addressing some, but as it turns out, not all complaints of the linker. I will modify the relevant patch as follows when committing: @@ -684,7 +684,7 @@ API for locking files.") (build-system python-build-system) (home-page "https://github.com/benediktschmitt/py-filelock") - (synopsis "A platform independent file lock") + (synopsis "Platform independent file lock") (description "@code{filelock} contains a single module implementing a platform independent file lock in Python, which provides a simple way of inter-process communication.") --fkgrgehoveao3cw3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl5hYSwACgkQ4xWnWEYT FWSzrw//T2dDv9agCeKvJE2y9u1HnmYRpPxmxEHB4/3VysnYsGl9b2i21omV0m1o b/LrFldwzf7jROJljM266SOU8l6NIVU/bw2/mXCs1uAoz1O/zpSFNDpoLlYgMlO/ 1KANPsVm5xMw4WSxGAPGVuG1/ujaBMAlBUihMFGWA0kdzmJS1ODRGdHa5AGo3pEZ /jdoBpF5jjRVpdiFc4sO8JZDsR9jgjHEAWaxNvi/sVGwjUPDPnxWndMWR7oIF/x7 kIr+YGDyWk3sPudAymA5At8AzM46oi593UK3KUGJZYcv2ClSUyTrRVv3wztYUfFk o54HX4VCHcYLAjXk0/KsjS/HB0R0xSSyK03EMPBTOA+1h/u3uKx765MHkRWkvpAl bYmitdlvhsdpY5MmSzSdt4+POoW1EIra2EKweE6c26GYXAYf7Xabcnn087mWG837 8ctsQaOMSJ+/SMJATKnBtJf+lG/wktkWvAO1R3ZrUxbueX8UMXk4ET9fZ8rDHASa +0LrdyIy8hCGKusX3H+1wwWI/A5LIKjE/IfT32l7mSl2UMge/QeKVf1gg4pnlk0I QbWJWsT9DmJsKeLmUblvF4jlV+g/vhjknZaTTj50NxhQbD93kOVDmBh3Yh/BZQP2 jBxA4AQHJMeemAcEANkHhJR1rATU6O+IovUyD9NKaDmaGen9XkM= =d1cg -----END PGP SIGNATURE----- --fkgrgehoveao3cw3-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 08 16:18:21 2020 Received: (at 39932) by debbugs.gnu.org; 8 Mar 2020 20:18:21 +0000 Received: from localhost ([127.0.0.1]:49314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jB2NR-0004RZ-Df for submit@debbugs.gnu.org; Sun, 08 Mar 2020 16:18:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jB2NP-0004RJ-JA for 39932@debbugs.gnu.org; Sun, 08 Mar 2020 16:18:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jB2NK-0005YQ-6e; Sun, 08 Mar 2020 16:18:14 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36542 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jB2NJ-0006UV-Jj; Sun, 08 Mar 2020 16:18:14 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= Subject: Re: [bug#39932] [PATCH 1/3] gnu: python-xyz: Add python-distlib. References: <20200305191424.12134-1-kuba@kadziolka.net> <20200305192204.14973-1-kuba@kadziolka.net> Date: Sun, 08 Mar 2020 21:18:12 +0100 In-Reply-To: <20200305192204.14973-1-kuba@kadziolka.net> ("Jakub \=\?utf-8\?B\?S8SFZHppb8WCa2EiJ3M\=\?\= message of "Thu, 5 Mar 2020 20:22:02 +0100") Message-ID: <877dzua9dn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39932 Cc: 39932@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Jakub K=C4=85dzio=C5=82ka skribis: > * gnu/packages/python-xyz.scm (python-distlib): New variable. [...] > + (modify-phases %standard-phases > + (add-before 'build 'no-/bin/sh > + (lambda _ > + (substitute* '("distlib/scripts.py" "tests/test_scripts.py") > + (("/bin/sh") (which "sh"))))) > + (add-before 'check 'prepare-test-env > + (lambda _ > + (setenv "HOME" "/tmp") > + ;; NOTE: Any value works, the variable just has to be prese= nt. > + (setenv "SKIP_ONLINE" "1")))))) Please return #t from both phases, as is conventional. Apart from that, all 3 patches LGTM! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 08 19:22:10 2020 Received: (at 39932-done) by debbugs.gnu.org; 8 Mar 2020 23:22:10 +0000 Received: from localhost ([127.0.0.1]:49471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jB5FK-0000Oy-0W for submit@debbugs.gnu.org; Sun, 08 Mar 2020 19:22:10 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:60758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jB5FH-0000Oo-C0 for 39932-done@debbugs.gnu.org; Sun, 08 Mar 2020 19:22:08 -0400 Received: (qmail 22264 invoked by uid 1009); 9 Mar 2020 00:22:05 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25744. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.022974 secs); 08 Mar 2020 23:22:05 -0000 Received: from unknown (HELO gravity) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 9 Mar 2020 00:22:05 +0100 Date: Mon, 9 Mar 2020 00:22:57 +0100 From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#39932] [PATCH 1/3] gnu: python-xyz: Add python-distlib. Message-ID: <20200308232257.pcwhhzzgetzomayy@gravity> References: <20200305191424.12134-1-kuba@kadziolka.net> <20200305192204.14973-1-kuba@kadziolka.net> <877dzua9dn.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ylai7nkiajsl7ghq" Content-Disposition: inline In-Reply-To: <877dzua9dn.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39932-done Cc: 39932-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --ylai7nkiajsl7ghq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 08, 2020 at 09:18:12PM +0100, Ludovic Court=C3=A8s wrote: > Hello, >=20 > Jakub K=C4=85dzio=C5=82ka skribis: >=20 > > * gnu/packages/python-xyz.scm (python-distlib): New variable. >=20 > [...] >=20 > > + (modify-phases %standard-phases > > + (add-before 'build 'no-/bin/sh > > + (lambda _ > > + (substitute* '("distlib/scripts.py" "tests/test_scripts.p= y") > > + (("/bin/sh") (which "sh"))))) > > + (add-before 'check 'prepare-test-env > > + (lambda _ > > + (setenv "HOME" "/tmp") > > + ;; NOTE: Any value works, the variable just has to be pre= sent. > > + (setenv "SKIP_ONLINE" "1")))))) >=20 > Please return #t from both phases, as is conventional. Argh, I'm always forgetting about that. It would be nice to have a lint for this... > Apart from that, all 3 patches LGTM! Thanks! I pushed the commits, the last one got a hash of 94d57ba3399aeb1b34d52e5e866c609f5a18ec2b --ylai7nkiajsl7ghq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl5lflEACgkQ4xWnWEYT FWQ2ABAA4R3nsog27JMOB2kHBjAoaepafrd+OUziuUa/Ts3aMavfIMiP/NF9wLKN Q8pX7iKR80dzbUolMwElM7BoWb8t9/Migw3AiAlU7HiljTVnOPA2tqGKI/ZlKeta 028jMjEHVaU42coKFJlluNcAF2AtY6IS9N42fhY9zzzvK3PE9qPRlT3DTQsPJzsO E/tOTOpcQwOBXWHoG7Sr6aZMtxIx291xmNOGD6Tkq3mpaabyugVRXAcDHVal0Fn8 cC3HleJ5R2C9WACkgNZdY6Iy6Hlf/wadbdeDSUOvfwWsJeF7rAtLCOVuys4oSKzj 094qUZGO02jLgrNI7vtsDuLGBr2cEzkeBVmSZrGg2XOjjAAdWCeLKMbl9iwoCZPe hgxEzPMYaBKd+aUmYoHK/TUqONGuP4HPLZZDrvyHlxgO7H/UxgFWwX9YOdOaV5Ok 7Nxyd+J/qekjdQVyzk6l75RRPn1aebIkZIQpkAUloNTWqsdii5IGb8Ki5BbrNP7U H61i6YukSw3EoTy789/s2S+6R59VzzhgB8IOeEUzZKZ238OJcF3JqQDutVx/u1Vt gwkkgr7VVbTt/n4qbrPhnPWAs6j/owZMQR6MUhKQmakGVH50r0OdOrSQXOFfsOtT IZp8yPbQ8jFv65RC6X7YNoV34/5sNZrNuh7ou3mYbGua/DrjtlU= =b122 -----END PGP SIGNATURE----- --ylai7nkiajsl7ghq-- From unknown Sun Jun 15 08:23:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 06 Apr 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator