From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 05 11:22:07 2020 Received: (at submit) by debbugs.gnu.org; 5 Mar 2020 16:22:07 +0000 Received: from localhost ([127.0.0.1]:43620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9tGB-0007wI-6B for submit@debbugs.gnu.org; Thu, 05 Mar 2020 11:22:07 -0500 Received: from lists.gnu.org ([209.51.188.17]:36279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9tG9-0007w9-3s for submit@debbugs.gnu.org; Thu, 05 Mar 2020 11:22:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57872) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9tG8-0000Na-3k for bug-coreutils@gnu.org; Thu, 05 Mar 2020 11:22:04 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9tG6-0000sG-Q2 for bug-coreutils@gnu.org; Thu, 05 Mar 2020 11:22:03 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:35651 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j9tG6-0000rW-L3 for bug-coreutils@gnu.org; Thu, 05 Mar 2020 11:22:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583425321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mcPvs8qTOgg0B4B3s6658Va8bd/PpfqgEo8jacIw3gw=; b=VWy7Tr98P3vEk0VZkHRUi6cXVSrhtFcqwSGHWYOHCGUF4ZsD2Pkh2ppfwZwurksU8onBt7 KREfn9LB9bnKDYuM6fsDiNHEvFHMpGNJ6myBuA/YkB9IIqPFw5/PXHYBqTjMLsCtuPrFWc kTRajqviN7x/Y0lw5PdiqCpxRVvHbgU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-255-L7YiNdI1OTS9qof2HPih9A-1; Thu, 05 Mar 2020 11:22:00 -0500 X-MC-Unique: L7YiNdI1OTS9qof2HPih9A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1759618A8C94 for ; Thu, 5 Mar 2020 16:21:59 +0000 (UTC) Received: from nbkamil.localnet (unknown [10.43.7.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id B4DDF60C99 for ; Thu, 5 Mar 2020 16:21:58 +0000 (UTC) From: Kamil Dudka To: bug-coreutils@gnu.org Subject: coreutils-8.32 fails to build on aarch64 Date: Thu, 05 Mar 2020 17:21:57 +0100 Message-ID: <4228098.LvFx2qVVIh@nbkamil> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) While trying to build coreutils-8.32 for Fedora on aarch64, I got the following compilation failure: ../src/ls.c: In function 'print_dir': ../src/ls.c:3026:24: error: 'SYS_getdents' undeclared (first use in this function); did you mean 'SYS_getdents64'? 3026 | if (syscall (SYS_getdents, dirfd (dirp), NULL, 0) == -1 | ^~~~~~~~~~~~ | SYS_getdents64 ../src/ls.c:3026:24: note: each undeclared identifier is reported only once for each function it appears in Sorry for reporting it late. I tried to build 8.31.90-cc4c and 8.31.99-f2034 in Fedora copr but forgot to enable aarch64, so these builds succeeded :-/ Kamil From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 05 12:39:36 2020 Received: (at 39929) by debbugs.gnu.org; 5 Mar 2020 17:39:36 +0000 Received: from localhost ([127.0.0.1]:43683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9uTA-0001O4-AP for submit@debbugs.gnu.org; Thu, 05 Mar 2020 12:39:36 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]:38682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9uT7-0001Np-BO for 39929@debbugs.gnu.org; Thu, 05 Mar 2020 12:39:34 -0500 Received: by mail-wr1-f48.google.com with SMTP id t11so8066539wrw.5 for <39929@debbugs.gnu.org>; Thu, 05 Mar 2020 09:39:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=hOg3KcIfYqreS43X8kula0ctDEYfC4G3b35BXeId+jE=; b=DL75/m+VBXV4+TVqA7eerbJwKFX5klurBiXZ8hxA9yeOOvmJOp27lVdo25MfvlomJw Asola5Wrk6jLX2iMSZv75OmhrABIeKboJbMuIW7wfuTLkuSeL23eK37EMgu0LxHk8q3U VW+YJhI4bmNpQVDYgQHaN3xTDoFHcF1c+B2omyuiJQOX4Z8IC3pcGWjXcZ0jTpA7QwUQ 2ENtxnI2DcINy/LEJ6IKP9o7T6tlNI9dTm3Hr/6pf3ZHBixBsWPAc2zcvGoSW4bDjGII fQTtiOnCp8o5JT7FJabjCOIO1ouifCr5B+iHOFzmttgEeySyis8SgRBGDwEtcCS6eTqS P/DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language; bh=hOg3KcIfYqreS43X8kula0ctDEYfC4G3b35BXeId+jE=; b=WCnHzq5gI8CruV3rKFkMU5k+bzl5aqazZpnYkWBf7JUC2xTa/v4gwuYeuswXz6D8Dg yQ0GRP62iACus7t/e05rQ6F/SibSNnE3H6Ln/KZEl2Y26Ud0iHDkPSU7Ton+yH4bBv44 n85Y5TKhSIyIPUUAa9KMPLf7rUwtPqZnckk2NHHGU02AkuA4BzHwUA0cmzzvXbMZ82hl sddfMLZJswFU/97TTeYpOFmwnJ7XMwsNJmlnBjr421q3F/2KG0TmNgQBCXTenuO6hz08 uO4g0N9n4ru3kZm1YUJEVaYp8Jo/kZ6j+tmp+BVsIFPdQ1EmKuIUNhlHf04FxxzW8vUo +6hg== X-Gm-Message-State: ANhLgQ38otA7435DKp/jSnkFk6BKaAPXuFVA15jQXR+799PHt++n27KH nktOUx/xIvzHU4vD4i1OHin34uuNFGE= X-Google-Smtp-Source: ADFU+vuPrGnCnvgvVGjNFWlFMykUjMBaPAk5kzgKK5H2WET0X6XMRQInhaUhfZVjfFjhb0Ig1l+hjQ== X-Received: by 2002:adf:eb51:: with SMTP id u17mr47212wrn.29.1583429967106; Thu, 05 Mar 2020 09:39:27 -0800 (PST) Received: from localhost.localdomain (86-42-14-227-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.42.14.227]) by smtp.googlemail.com with ESMTPSA id o3sm12232633wme.36.2020.03.05.09.39.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2020 09:39:25 -0800 (PST) Subject: Re: bug#39929: coreutils-8.32 fails to build on aarch64 To: Kamil Dudka , 39929@debbugs.gnu.org References: <4228098.LvFx2qVVIh@nbkamil> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: <4a7b4098-e02f-9751-67ed-1e22ee994655@draigBrady.com> Date: Thu, 5 Mar 2020 17:39:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Thunderbird/73.0 MIME-Version: 1.0 In-Reply-To: <4228098.LvFx2qVVIh@nbkamil> Content-Type: multipart/mixed; boundary="------------8080F81B2D815B68820FFC2A" Content-Language: en-US X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 39929 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) This is a multi-part message in MIME format. --------------8080F81B2D815B68820FFC2A Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 05/03/2020 16:21, Kamil Dudka wrote: > While trying to build coreutils-8.32 for Fedora on aarch64, I got the following > compilation failure: > > ../src/ls.c: In function 'print_dir': > ../src/ls.c:3026:24: error: 'SYS_getdents' undeclared (first use in this function); did you mean 'SYS_getdents64'? > 3026 | if (syscall (SYS_getdents, dirfd (dirp), NULL, 0) == -1 > | ^~~~~~~~~~~~ > | SYS_getdents64 > ../src/ls.c:3026:24: note: each undeclared identifier is reported only once for each function it appears in > > > Sorry for reporting it late. I tried to build 8.31.90-cc4c and 8.31.99-f2034 > in Fedora copr but forgot to enable aarch64, so these builds succeeded :-/ Ah well. Does the attached address this for you. --------------8080F81B2D815B68820FFC2A Content-Type: text/x-patch; charset=UTF-8; name="coreutils-getdents64.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="coreutils-getdents64.patch" >From 8012c07aae89f9f855b7c0663158b24464248a3d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Thu, 5 Mar 2020 17:34:33 +0000 Subject: [PATCH] build: fix build failure on linux systems without getdents * src/ls.c (print_dir): aarch64 doesn't define the getdents system call, only providing the getdents64 variant. This is available enough to use instead. --- src/ls.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ls.c b/src/ls.c index 24b983287..29462bfee 100644 --- a/src/ls.c +++ b/src/ls.c @@ -3018,12 +3018,12 @@ print_dir (char const *name, char const *realname, bool command_line_arg) if (errno != EOVERFLOW) break; } -#ifdef __linux__ else if (! found_any_entries) { +#if defined __linux__ && defined SYS_getdents64 /* If readdir finds no directory entries at all, not even "." or "..", then double check that the directory exists. */ - if (syscall (SYS_getdents, dirfd (dirp), NULL, 0) == -1 + if (syscall (SYS_getdents64, dirfd (dirp), NULL, 0) == -1 && errno != EINVAL) { /* We exclude EINVAL as that pertains to buffer handling, @@ -3031,9 +3031,9 @@ print_dir (char const *name, char const *realname, bool command_line_arg) ENOENT is returned if appropriate before buffer handling. */ file_failure (command_line_arg, _("reading directory %s"), name); } +#endif break; } -#endif else break; -- 2.24.1 --------------8080F81B2D815B68820FFC2A-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 05 16:43:19 2020 Received: (at 39929) by debbugs.gnu.org; 5 Mar 2020 21:43:19 +0000 Received: from localhost ([127.0.0.1]:43812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9yH1-0001dR-1S for submit@debbugs.gnu.org; Thu, 05 Mar 2020 16:43:19 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:39306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9yGz-0001dC-Gn for 39929@debbugs.gnu.org; Thu, 05 Mar 2020 16:43:18 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 314E5160087; Thu, 5 Mar 2020 13:43:11 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id caCO8XT0431n; Thu, 5 Mar 2020 13:43:10 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 88D3F160092; Thu, 5 Mar 2020 13:43:10 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id pTCW4ajDLv7x; Thu, 5 Mar 2020 13:43:10 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 701D5160087; Thu, 5 Mar 2020 13:43:10 -0800 (PST) Subject: Re: bug#39929: coreutils-8.32 fails to build on aarch64 To: =?UTF-8?Q?P=c3=a1draig_Brady?= , Kamil Dudka , 39929@debbugs.gnu.org References: <4228098.LvFx2qVVIh@nbkamil> <4a7b4098-e02f-9751-67ed-1e22ee994655@draigBrady.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Thu, 5 Mar 2020 13:43:09 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <4a7b4098-e02f-9751-67ed-1e22ee994655@draigBrady.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39929 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 3/5/20 9:39 AM, P=C3=A1draig Brady wrote: > Ah well. > Does the attached address this for you. Eeeuw. Why is this code even there at all? If readdir(3) says that the current=20 directory has no entries, shouldn't 'ls' just say that? Why should ls=20 report an error simply because the current directory isn't reachable=20 from the filesystem? Whether the current directory is unreachable has=20 nothing to do with ls's job, which is to report whether the current=20 directory has entries. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 05 20:27:27 2020 Received: (at 39929) by debbugs.gnu.org; 6 Mar 2020 01:27:28 +0000 Received: from localhost ([127.0.0.1]:43931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jA1lv-0002Vg-IE for submit@debbugs.gnu.org; Thu, 05 Mar 2020 20:27:27 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:55896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jA1lt-0002VR-RM for 39929@debbugs.gnu.org; Thu, 05 Mar 2020 20:27:26 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C565C1600A0; Thu, 5 Mar 2020 17:27:19 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ZD3HbVNYAG9Q; Thu, 5 Mar 2020 17:27:18 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7CC5E16009E; Thu, 5 Mar 2020 17:27:16 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id MRngzf8bbjTb; Thu, 5 Mar 2020 17:27:16 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 5DB0C1600AF; Thu, 5 Mar 2020 17:27:16 -0800 (PST) Subject: Re: bug#39929: coreutils-8.32 fails to build on aarch64 From: Paul Eggert To: =?UTF-8?Q?P=c3=a1draig_Brady?= , Kamil Dudka , 39929@debbugs.gnu.org References: <4228098.LvFx2qVVIh@nbkamil> <4a7b4098-e02f-9751-67ed-1e22ee994655@draigBrady.com> Organization: UCLA Computer Science Department Message-ID: Date: Thu, 5 Mar 2020 17:27:16 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------774183A3FCE46225F41A1751" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39929 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------774183A3FCE46225F41A1751 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 3/5/20 1:43 PM, Paul Eggert wrote: > Why is this code even there at all? If readdir(3) says that the current > directory has no entries, shouldn't 'ls' just say that? Why should ls > report an error simply because the current directory isn't reachable > from the filesystem? Whether the current directory is unreachable has > nothing to do with ls's job, which is to report whether the current > directory has entries. Attached is a proposed patch to fix this. --------------774183A3FCE46225F41A1751 Content-Type: text/x-patch; charset=UTF-8; name="0001-ls-restore-8.31-behavior-on-removed-directories.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-ls-restore-8.31-behavior-on-removed-directories.patch" >From 511d0c323bc90a0ab7e8f3672b07a1144885a9e8 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 5 Mar 2020 17:25:29 -0800 Subject: [PATCH] ls: restore 8.31 behavior on removed directories * NEWS: Mention this. * src/ls.c: Do not include (print_dir): Don't worry about whether the directory is removed. * tests/ls/removed-directory.sh: Adjust to match new (i.e., old) behavior. --- NEWS | 6 ++++++ src/ls.c | 22 ---------------------- tests/ls/removed-directory.sh | 10 ++-------- 3 files changed, 8 insertions(+), 30 deletions(-) diff --git a/NEWS b/NEWS index fdc8bf5db..653e7178b 100644 --- a/NEWS +++ b/NEWS @@ -2,6 +2,12 @@ GNU coreutils NEWS -*- outline -*- * Noteworthy changes in release ?.? (????-??-??) [?] +** Changes in behavior + + On GNU/Linux systems, ls no longer issues an error message on + directory merely because it was removed. This reverts a change + that was made in release 8.32. + * Noteworthy changes in release 8.32 (2020-03-05) [stable] diff --git a/src/ls.c b/src/ls.c index 24b983287..4acf5f44d 100644 --- a/src/ls.c +++ b/src/ls.c @@ -49,10 +49,6 @@ # include #endif -#ifdef __linux__ -# include -#endif - #include #include #include @@ -2896,7 +2892,6 @@ print_dir (char const *name, char const *realname, bool command_line_arg) struct dirent *next; uintmax_t total_blocks = 0; static bool first = true; - bool found_any_entries = false; errno = 0; dirp = opendir (name); @@ -2972,7 +2967,6 @@ print_dir (char const *name, char const *realname, bool command_line_arg) next = readdir (dirp); if (next) { - found_any_entries = true; if (! file_ignored (next->d_name)) { enum filetype type = unknown; @@ -3018,22 +3012,6 @@ print_dir (char const *name, char const *realname, bool command_line_arg) if (errno != EOVERFLOW) break; } -#ifdef __linux__ - else if (! found_any_entries) - { - /* If readdir finds no directory entries at all, not even "." or - "..", then double check that the directory exists. */ - if (syscall (SYS_getdents, dirfd (dirp), NULL, 0) == -1 - && errno != EINVAL) - { - /* We exclude EINVAL as that pertains to buffer handling, - and we've passed NULL as the buffer for simplicity. - ENOENT is returned if appropriate before buffer handling. */ - file_failure (command_line_arg, _("reading directory %s"), name); - } - break; - } -#endif else break; diff --git a/tests/ls/removed-directory.sh b/tests/ls/removed-directory.sh index e8c835dab..fe8f929a1 100755 --- a/tests/ls/removed-directory.sh +++ b/tests/ls/removed-directory.sh @@ -26,20 +26,14 @@ case $host_triplet in *) skip_ 'non linux kernel' ;; esac -LS_FAILURE=2 - -cat <<\EOF >exp-err || framework_failure_ -ls: reading directory '.': No such file or directory -EOF - cwd=$(pwd) mkdir d || framework_failure_ cd d || framework_failure_ rmdir ../d || framework_failure_ -returns_ $LS_FAILURE ls >../out 2>../err || fail=1 +ls >../out 2>../err || fail=1 cd "$cwd" || framework_failure_ compare /dev/null out || fail=1 -compare exp-err err || fail=1 +compare /dev/null err || fail=1 Exit $fail -- 2.24.1 --------------774183A3FCE46225F41A1751-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 06 02:31:55 2020 Received: (at 39929) by debbugs.gnu.org; 6 Mar 2020 07:31:55 +0000 Received: from localhost ([127.0.0.1]:43981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jA7Sc-0002kK-RP for submit@debbugs.gnu.org; Fri, 06 Mar 2020 02:31:54 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:57285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jA7Sa-0002k2-VD for 39929@debbugs.gnu.org; Fri, 06 Mar 2020 02:31:53 -0500 Received: from [192.168.101.10] ([93.218.105.44]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N1gac-1jKrzH1VA8-0123Fm; Fri, 06 Mar 2020 08:31:31 +0100 Subject: Re: bug#39929: coreutils-8.32 fails to build on aarch64 To: Paul Eggert , =?UTF-8?Q?P=c3=a1draig_Brady?= , Kamil Dudka , 39929@debbugs.gnu.org References: <4228098.LvFx2qVVIh@nbkamil> <4a7b4098-e02f-9751-67ed-1e22ee994655@draigBrady.com> From: Bernhard Voelker Autocrypt: addr=mail@bernhard-voelker.de; prefer-encrypt=mutual; keydata= mQENBFPirzMBCACyzYldTjQ4ufFOkByY5Nn5USb5GFoL48nWBwNHjd9KUbtRRNlQiPNKd6hK Gvd3BGi5aoFKA4ytfRk6jbAbW3jVb3R8wYaV08mOy4KVEKxqN4bxsXlMjNChXVR+rtKDmfI+ oPTL+cPH2X6gW4W02IRbVw0uUhNm6zEedC/gNrY/mTlf1enZ46jxZ7BTUZaG+kx38UMISIMB zSzLRtdkwgmHj4jS3p1fF2cwRqLclIfMjKGpbNFPEXeXKWrCLcqHw78795eAR9q0YvrDkfIn GdDBwfb3VM4NdulwIFzvYZMSXvSbbyPLB5YkHU5aAWQHUse4WlfT5ccDpbzUYldRAvF9ABEB AAG0K0Jlcm5oYXJkIFZvZWxrZXIgPG1haWxAYmVybmhhcmQtdm9lbGtlci5kZT6JATkEEwEC ACMFAlPirzMCGwMHCwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRBGUC73lpFxle5wCACC dbs0QaJ0vR3Sff2cKdTk41rUq3YfWngsR///IOU0C5DdkePmCnJE/lUsUy0LRTxcUDLxQR+x QHU8ssRT0JUO9726dI3miy36UdsgmBYaOtLvQcidGmW1R7o0PYYf04+TFtyqKgngOUBPpMgR 6o4UsQxy/OD4bN1WDqOgIjL+D/qJpkKmgp6L6+hhaBCpiOFKRmmV7YyQ3SqVlfQNiHs5ZtkR nXpIjgZARV+GllKucI17bO0CGmTJZ1tstVy0+W3DQT1lbBkTTc++5LONM99D3jjn23l1ocOp folR53F7I4cb2RNfT23v1I59RH37lB9wMOqrKj0UjYAC2YoPGQ3BuQENBFPirzMBCADXLWWp QihBldY6reca8ZKdc3T9qXEOa3akE3DWKztIBmNJhtYOjmpLYajQTkGa7UoJTnbmZE2Rn6ZE oNnvb0gcFNAIcY95KOI+bjOR8HEgh4cx2REXh6L6olIgyXqt/KFusE4wtVZAFxZl+30HzN6n D+1HvrjXxPJRX6MsIYOYyyX9/6OofwJK6QHODYGp8WL2olHDnmsXg4AT6Wlr7qKpKrQELlcF R4xkvdmgL/Ghw/tK0yJTxMIcewCCZWLPOXRmFRbvAadZWPAgVsJ63siNyUlVnVMSzDgTJl+s l/DMabXpqrJQx3/1Yy6mTaDs3XZT/wmBKaTLXx/LByaPxQQ7ABEBAAGJAR8EGAECAAkFAlPi rzMCGwwACgkQRlAu95aRcZWVPwgAqZT6iTXkoP37wYb41323RzhBcJ8JSk4cyBDBUXX0lMrM 3qhiClKG7phpxVdu817Gwc6Hsecg7FfjQAV8MHQ0ZFeEFdk3b2rKBqfsStc+h49/xF3Fb+if CzR9qeQF82fMSxkg18++7hMcHCMO/hPZ/Q0xRi+lrSr2QKDJQuLzSyVU14TxrCkevZjEhtma VNvcJlJzCbiBXee9Fpc5jITUXPFG8E8dxqo1n+duOyIMgozrAnzP7X5V/Ob/Ozf/aGGX9+Jd inyfCX18nWcHALKMU/36Eua/ylalf/2c2YkBp9KCLVmGgPkUgW52EeRPgroIsiwu+rwCSV6Z UyCJ+OymCg== Message-ID: <1148eaa7-868f-8eba-5c06-4c80a8072269@bernhard-voelker.de> Date: Fri, 6 Mar 2020 08:31:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:6+ApObGthTYb7QdL606hnG5dG1yP6iE05Gi+tYSSgEgaWeqNK3w YhIOJqN0SzXCO4OpPV+d+7yLNht/pmna1ExRF1lPRHaPXgr5Kl+Vd7KseJHNoj5rZkywyqg 5QyT6M2Zv5ITxWFXuWp74ymz/opmvMRCdqUrrTqS2ih11VWsDvwZab+lhgWqoK3WD9Jc2DL +2b6VsuF6pUaEd2lrnhdQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:meXb2GWGzPE=:0vTG46jtg0GEYZ91n5BFvZ OQ82FtAr+pWM7qcQzss+RpV9YaRjDYw5EywZzA/XlEKnaQLfpr5MUNmFWctw/F9jhTjVG9mUa jFfFxPK9RAneu5u5bNwwnnkQPRariX2COplVSFsUT3ag2hKgGayM0LGwxufdR4SWZuW1f/4QW z0PMHFHuBHkJGAkZK3wDlykzjN3USXz7yl37jbVK3/8If+QOlGG8x6kFxYcQUp0ZH19ZFo5vN oylbK55uoxdBxJkcSX69U6UbvRmpqv/eNi4u6++MDsdDsR5yvgEAAFi+WEXCcojwISC4dRLFX rposb76ICQE7123MrRa1RwnBlF2xrFkc0OAkCv4ONe4OmUAzvNzy25d2HkVnmYACNeugKCaYb 2DTTYtAAOgnrzKMeMNkiK4ennrGgIq0KhXdqY5jVp93GNnPPohygmc2Ok8s4gTstZgEHo74P8 YCGedP4kNIIXgrkdAGVAC7uyjXWYfLy/4qNggZCxEiaIMV+CPO5vNqv0QYCbAPXiRvUEQtNTL DMBbCPWBnNQpqMRU17ik5E2y+/YpWK+UKpPa59IwR30utMzRKQz217tx3UJR03wvzo3YkTX/S yxmgqapeJRO32zOOIAqwLF6JKeQdL0AIvnu5GFwAyhbCJ+AVQdV0RVijFPyNEYXF3tfuoMS6H Yz9WYApj1cU7GcVnvLA7WaFLjtjJkAVpzdW994gQIzw70XopeSNe/6xN+N4hK7zbZBzaN/1y4 ZUWpuWFjB/MT5yFupmRA1ZpF0Dc8T+0Utm12alZefXvSnvP/KB8K/x59HGjtZoXYgyuwYXd1x a4xuaPYwj6iTgRXP5yFpRR8RJe6U5jsW0g/0s5khs3sjVllzJkJk+ZlXaxC4t2FNVhXq9Is X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39929 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2020-03-06 02:27, Paul Eggert wrote: > On 3/5/20 1:43 PM, Paul Eggert wrote: > >> Why is this code even there at all? If readdir(3) says that the current >> directory has no entries, shouldn't 'ls' just say that? Why should ls >> report an error simply because the current directory isn't reachable >> from the filesystem? Whether the current directory is unreachable has >> nothing to do with ls's job, which is to report whether the current >> directory has entries. > > Attached is a proposed patch to fix this. I tend to agree (now): returning an error when there was none seems at least unlucky. Sorry I didn't comment in the original discussion. > diff --git a/tests/ls/removed-directory.sh b/tests/ls/removed-directory.sh That test was also added in commit 05a99f7d7f8e, so the the description at the top does not match after reverting: #!/bin/sh # If ls is asked to list a removed directory (e.g. the parent process's # current working directory that has been removed by another process), it # emits an error message. s/emits/shall not emit/ Thanks & have a nice day, Berny From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 06 02:36:28 2020 Received: (at 39929) by debbugs.gnu.org; 6 Mar 2020 07:36:28 +0000 Received: from localhost ([127.0.0.1]:43989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jA7X2-0002r0-I4 for submit@debbugs.gnu.org; Fri, 06 Mar 2020 02:36:28 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:58919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jA7X0-0002qn-Uh for 39929@debbugs.gnu.org; Fri, 06 Mar 2020 02:36:27 -0500 Received: from [192.168.101.10] ([93.218.105.44]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mn2eN-1jbidb1BAN-00k3sq; Fri, 06 Mar 2020 08:36:08 +0100 Subject: Re: bug#39929: coreutils-8.32 fails to build on aarch64 From: Bernhard Voelker To: Paul Eggert , =?UTF-8?Q?P=c3=a1draig_Brady?= , Kamil Dudka , 39929@debbugs.gnu.org References: <4228098.LvFx2qVVIh@nbkamil> <4a7b4098-e02f-9751-67ed-1e22ee994655@draigBrady.com> <1148eaa7-868f-8eba-5c06-4c80a8072269@bernhard-voelker.de> Autocrypt: addr=mail@bernhard-voelker.de; prefer-encrypt=mutual; keydata= mQENBFPirzMBCACyzYldTjQ4ufFOkByY5Nn5USb5GFoL48nWBwNHjd9KUbtRRNlQiPNKd6hK Gvd3BGi5aoFKA4ytfRk6jbAbW3jVb3R8wYaV08mOy4KVEKxqN4bxsXlMjNChXVR+rtKDmfI+ oPTL+cPH2X6gW4W02IRbVw0uUhNm6zEedC/gNrY/mTlf1enZ46jxZ7BTUZaG+kx38UMISIMB zSzLRtdkwgmHj4jS3p1fF2cwRqLclIfMjKGpbNFPEXeXKWrCLcqHw78795eAR9q0YvrDkfIn GdDBwfb3VM4NdulwIFzvYZMSXvSbbyPLB5YkHU5aAWQHUse4WlfT5ccDpbzUYldRAvF9ABEB AAG0K0Jlcm5oYXJkIFZvZWxrZXIgPG1haWxAYmVybmhhcmQtdm9lbGtlci5kZT6JATkEEwEC ACMFAlPirzMCGwMHCwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRBGUC73lpFxle5wCACC dbs0QaJ0vR3Sff2cKdTk41rUq3YfWngsR///IOU0C5DdkePmCnJE/lUsUy0LRTxcUDLxQR+x QHU8ssRT0JUO9726dI3miy36UdsgmBYaOtLvQcidGmW1R7o0PYYf04+TFtyqKgngOUBPpMgR 6o4UsQxy/OD4bN1WDqOgIjL+D/qJpkKmgp6L6+hhaBCpiOFKRmmV7YyQ3SqVlfQNiHs5ZtkR nXpIjgZARV+GllKucI17bO0CGmTJZ1tstVy0+W3DQT1lbBkTTc++5LONM99D3jjn23l1ocOp folR53F7I4cb2RNfT23v1I59RH37lB9wMOqrKj0UjYAC2YoPGQ3BuQENBFPirzMBCADXLWWp QihBldY6reca8ZKdc3T9qXEOa3akE3DWKztIBmNJhtYOjmpLYajQTkGa7UoJTnbmZE2Rn6ZE oNnvb0gcFNAIcY95KOI+bjOR8HEgh4cx2REXh6L6olIgyXqt/KFusE4wtVZAFxZl+30HzN6n D+1HvrjXxPJRX6MsIYOYyyX9/6OofwJK6QHODYGp8WL2olHDnmsXg4AT6Wlr7qKpKrQELlcF R4xkvdmgL/Ghw/tK0yJTxMIcewCCZWLPOXRmFRbvAadZWPAgVsJ63siNyUlVnVMSzDgTJl+s l/DMabXpqrJQx3/1Yy6mTaDs3XZT/wmBKaTLXx/LByaPxQQ7ABEBAAGJAR8EGAECAAkFAlPi rzMCGwwACgkQRlAu95aRcZWVPwgAqZT6iTXkoP37wYb41323RzhBcJ8JSk4cyBDBUXX0lMrM 3qhiClKG7phpxVdu817Gwc6Hsecg7FfjQAV8MHQ0ZFeEFdk3b2rKBqfsStc+h49/xF3Fb+if CzR9qeQF82fMSxkg18++7hMcHCMO/hPZ/Q0xRi+lrSr2QKDJQuLzSyVU14TxrCkevZjEhtma VNvcJlJzCbiBXee9Fpc5jITUXPFG8E8dxqo1n+duOyIMgozrAnzP7X5V/Ob/Ozf/aGGX9+Jd inyfCX18nWcHALKMU/36Eua/ylalf/2c2YkBp9KCLVmGgPkUgW52EeRPgroIsiwu+rwCSV6Z UyCJ+OymCg== Message-ID: <48c2cadd-5ba1-774a-79e4-ce7801b9a9e9@bernhard-voelker.de> Date: Fri, 6 Mar 2020 08:36:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1148eaa7-868f-8eba-5c06-4c80a8072269@bernhard-voelker.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:a9DlSK9zurX2517ZqzxJW1zbHI7ak4jAYvW3+YlXKi4tYZ+EM+O y1QBJq93WnPy/1TEPEQf2aFpJAmUAZUVcNCZjSaEdtjnFJSEhPwNkr1Oofz28s603eaiBPE nEB+rQUiLUiXKpbvgqMMViKoDUtPABPpmATrJ10qn6EPM5TVtL7p1lHtBYe5X77tKwKbTGd w2wrzuPl0tXGUZL4WWHNA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:7f1GI+9A1mc=:a2QI/jJPvaY5HdTa5cAUEw RCTauuOTY1vxwNeMgnMRFYMvMve+jniyQxGJerrtkvi+CHfNgT55pBhWT6OcsokzVKkUfEVIc FNVUW/4W6cOXw8Zgt7+/FCJM0DzpsN1FY2wiMJZx3wED3QvzCaPi5Xn7St95HwhGAz36Wsuz5 EdH3Dv0eHFD2pqpdGKLp39qZWCaMJzXC0TMSULqni/0sI6+glbokD5QepYcnLk57Lz9i7UaB/ dZS1OULITLr3U+m0PFxkziUo/ybGj607L2RF7xFKTORfLrHzs3TuJ45XXPWifIzIvIXu55Xh4 MZcsj662mCmDuD0QdfCMuLBK2UwcP89LZtvaX6u8wqXTTvCf6/NHMw7C38BSGp0uaJ/XkCAhQ xatR0L+svjVl0UFlb79Odetd8PcY123yKgrNu/JfvZIFszytPP51YQ+mI2SpGRPyyan7nS60R quRU8u1qhOvEWZV2LmU9Ka8pAtbpWq4izi/c0KD1ho8f+vQXpbgv0KAUYfwaxpA3o3a5Q+YQq 6FpB+Hv4xMyitdgtFbzCGraZG4jEXYpyOvXyQgemLqQMnvHi5bAeprJqcB+Ij8BAhkV1CDgIl c7rnHLA1dL+011bkNrgg6h7nfOWopxMBTzwe0DGK/slebT7LhUXiG7Hy7/80QP1W7z29sU6Nh hnk3AcVf/68L9Ejp5F/hRZYMe5MNArx7XuhB/pEHnVdBwlf+Zm6B7Vp2rvBYy4RMxR9COen3g mH2Jq5q74UKVFUC4fk4HVAI7iLzlpCjTJJpSFcQcJMY0Hi7931NlfW/CU2VmsOzssrMHwLDdk aZR0ZoBRanOb6zbQc1wFQWsnUEG1F2tN/yhlTROiFILldBnQo7f4yhILeXFTmIy6WshoDxN X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39929 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2020-03-06 08:31, Bernhard Voelker wrote: > On 2020-03-06 02:27, Paul Eggert wrote: >> On 3/5/20 1:43 PM, Paul Eggert wrote: >> >>> Why is this code even there at all? If readdir(3) says that the current >>> directory has no entries, shouldn't 'ls' just say that? Why should ls >>> report an error simply because the current directory isn't reachable >>> from the filesystem? Whether the current directory is unreachable has >>> nothing to do with ls's job, which is to report whether the current >>> directory has entries. >> >> Attached is a proposed patch to fix this. > > I tend to agree (now): returning an error when there was none seems at least > unlucky. Sorry I didn't comment in the original discussion. > >> diff --git a/tests/ls/removed-directory.sh b/tests/ls/removed-directory.sh > > That test was also added in commit 05a99f7d7f8e, so the the description > at the top does not match after reverting: > > #!/bin/sh > # If ls is asked to list a removed directory (e.g. the parent process's > # current working directory that has been removed by another process), it > # emits an error message. > > s/emits/shall not emit/ P.S. Also the check for $host_triplet containing 'linux' in test is: a) no longer needed, and b) looks like a good argument to revert 05a99f7d7f8e, because it introduced different (and user-visible) behavior just because of the platform. Have a nice day, Berny From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 06 03:48:32 2020 Received: (at 39929) by debbugs.gnu.org; 6 Mar 2020 08:48:32 +0000 Received: from localhost ([127.0.0.1]:44045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jA8em-0004bZ-0s for submit@debbugs.gnu.org; Fri, 06 Mar 2020 03:48:32 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:59874 helo=us-smtp-delivery-1.mimecast.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jA8ek-0004bN-9d for 39929@debbugs.gnu.org; Fri, 06 Mar 2020 03:48:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583484504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OzSGCNIAkRpruySM6MbeT6q3t7toUOcdq/zFtzyqIKc=; b=d2uQYx9xjGJLrdXDBY3zKrXVRIjFGwPZy8xEInE+kL79H+i+I+ZvyT4nihgmJznHdud59t nKXFBmFsXmp0c1GIGK8225K3LeZp2gUfOiqB7OHL67tmJrARG9TugKlK8qbT557Vn8vzhy wyj3VNXKnTgmPYVDWf+IRmr5i4DUL/s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-187-k4h7qcVAMa64jdBbYaWlLg-1; Fri, 06 Mar 2020 03:48:17 -0500 X-MC-Unique: k4h7qcVAMa64jdBbYaWlLg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 990AC1007268; Fri, 6 Mar 2020 08:48:16 +0000 (UTC) Received: from nbkamil.localnet (unknown [10.43.7.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id 07D6373887; Fri, 6 Mar 2020 08:48:15 +0000 (UTC) From: Kamil Dudka To: =?ISO-8859-1?Q?P=E1draig?= Brady Subject: Re: bug#39929: coreutils-8.32 fails to build on aarch64 Date: Fri, 06 Mar 2020 09:48:15 +0100 Message-ID: <1755043.tdWV9SEqCh@nbkamil> In-Reply-To: <4a7b4098-e02f-9751-67ed-1e22ee994655@draigBrady.com> References: <4228098.LvFx2qVVIh@nbkamil> <4a7b4098-e02f-9751-67ed-1e22ee994655@draigBrady.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39929 Cc: 39929@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thursday, March 5, 2020 6:39:23 PM CET P=E1draig Brady wrote: > On 05/03/2020 16:21, Kamil Dudka wrote: > > While trying to build coreutils-8.32 for Fedora on aarch64, I got the > > following compilation failure: > >=20 > > ../src/ls.c: In function 'print_dir': > > ../src/ls.c:3026:24: error: 'SYS_getdents' undeclared (first use in thi= s > > function); did you mean 'SYS_getdents64'?>=20 > > 3026 | if (syscall (SYS_getdents, dirfd (dirp), NULL, 0) = =3D=3D -1 > > =20 > > | ^~~~~~~~~~~~ > > | SYS_getdents64 > >=20 > > ../src/ls.c:3026:24: note: each undeclared identifier is reported only > > once for each function it appears in > >=20 > >=20 > > Sorry for reporting it late. I tried to build 8.31.90-cc4c and > > 8.31.99-f2034 in Fedora copr but forgot to enable aarch64, so these > > builds succeeded :-/ > Ah well. > Does the attached address this for you. Thanks! I confirm that the ls/removed-directory test passes with the patch on all architectures that Fedora builds for: https://koji.fedoraproject.org/koji/taskinfo?taskID=3D42242960 Kamil From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 06 05:48:27 2020 Received: (at 39929) by debbugs.gnu.org; 6 Mar 2020 10:48:27 +0000 Received: from localhost ([127.0.0.1]:44133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAAWp-0007bM-Cu for submit@debbugs.gnu.org; Fri, 06 Mar 2020 05:48:27 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:53161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAAWo-0007b9-0r for 39929@debbugs.gnu.org; Fri, 06 Mar 2020 05:48:27 -0500 Received: by mail-wm1-f68.google.com with SMTP id p9so1849429wmc.2 for <39929@debbugs.gnu.org>; Fri, 06 Mar 2020 02:48:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pttv3F/qR+GTLGZTWVigs0J9VfpR2wNhU8UfrlW/Nx4=; b=Oqx+T6r+XsNbYnBypSTW6BPl4d3ld9S7BVydL9avs9pMin/G11lDkdXLBNvyAy3UcA THVuu55my6SR2bdCVZmoUt0fNdYjjg5LOObLAWmEqf4fBqiCCeDFoxaJ4TItzFv2LJ20 p248MxNi5WiEA0kwuDr0aeSzmhYbJOXNjJVap4xODrWiCkJwUF4IwzPTHn2WfxlyjEs/ 9ppNTvJS9Ri6A/uQ8ZZukIyrursLdaNd3Of7LQoFpYDFTf+b1nccGoDcyjBQ4dSJrgvc Rf+fDv3178dujuGXLl8A2+JkCPhum9F18zUYNF1wiT/DrglpyZlKGQkRFeORmfJzwkgb HDTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pttv3F/qR+GTLGZTWVigs0J9VfpR2wNhU8UfrlW/Nx4=; b=uU05p6g1satqYIPsVP+i6jz8W8kV2qXKVeVxry+sPAxvPhOGwvDiaDOkcdV4OZDHdk JH5/kZQV/1QuWTjVjVyssiOQbrMiaBJLXv1cKQtfhYljQyfRWgXpqypGi1spZVuq94Zo EYX7bN0S7cUz6Fm7KtKTa243n2MgTO/QIG+btxkCeFwomCV3fF1RTKKIHXIlyqK8ybNP JhRiYYST9oHx2U2+Fzcy5u+N4HFVNh035Mc6t+gUnvQDJ3c25sWnzRTnZTkYLWbjan8L pZMmg4Ew1Johbp+UWfteNdhTR2ajMArY/tcDhtqqcLr3moEdYGoITNGXk1j4lGShywXP V73Q== X-Gm-Message-State: ANhLgQ2ZgHVmjsG+rETeDbct3xs6tKRabQmoEP7X9A2hCYIwS33haMzd HBMJGqxlXfkiSNQVAkG2Y2XbVNoV9iU= X-Google-Smtp-Source: ADFU+vtsjGwpGsn4b+KE0zk05lWEzxCInjCQxGX8Lg5sVeLbQlAmVGRkaXYMBGmE0gOq8lVYU+WtpQ== X-Received: by 2002:a1c:9c4c:: with SMTP id f73mr3239643wme.125.1583491699850; Fri, 06 Mar 2020 02:48:19 -0800 (PST) Received: from localhost.localdomain (86-42-14-227-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.42.14.227]) by smtp.googlemail.com with ESMTPSA id a7sm49982164wrm.29.2020.03.06.02.48.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2020 02:48:19 -0800 (PST) Subject: Re: bug#39929: coreutils-8.32 fails to build on aarch64 To: Paul Eggert , Kamil Dudka , 39929@debbugs.gnu.org References: <4228098.LvFx2qVVIh@nbkamil> <4a7b4098-e02f-9751-67ed-1e22ee994655@draigBrady.com> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: <306f74e1-17a6-7864-5faa-4b6fb88c8f4d@draigBrady.com> Date: Fri, 6 Mar 2020 10:48:18 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Thunderbird/73.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 39929 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) On 05/03/2020 21:43, Paul Eggert wrote: > On 3/5/20 9:39 AM, Pádraig Brady wrote: >> Ah well. >> Does the attached address this for you. > > Eeeuw. > > Why is this code even there at all? If readdir(3) says that the current > directory has no entries, shouldn't 'ls' just say that? Why should ls > report an error simply because the current directory isn't reachable > from the filesystem? Whether the current directory is unreachable has > nothing to do with ls's job, which is to report whether the current > directory has entries. I'm not very attached to the new behavior so feel free to apply this. As per the original discussion, the change was made to distinguish unreachable directories from empty directories. Unreachable dirs are not common, but it seems useful for the user to know they're in one cheers, Pádraig From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 07 13:32:29 2020 Received: (at 39929) by debbugs.gnu.org; 7 Mar 2020 18:32:29 +0000 Received: from localhost ([127.0.0.1]:47545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAeFR-0003jW-2I for submit@debbugs.gnu.org; Sat, 07 Mar 2020 13:32:29 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:48068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAeFO-0003jI-8j for 39929@debbugs.gnu.org; Sat, 07 Mar 2020 13:32:27 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 349FF1600C5; Sat, 7 Mar 2020 10:32:20 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 3zmytFFkc3TR; Sat, 7 Mar 2020 10:32:19 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3D64D1600C6; Sat, 7 Mar 2020 10:32:19 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id hh5UgZ59f8Rv; Sat, 7 Mar 2020 10:32:18 -0800 (PST) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 965001600C5; Sat, 7 Mar 2020 10:32:18 -0800 (PST) Subject: Re: bug#39929: coreutils-8.32 fails to build on aarch64 To: Bernhard Voelker , =?UTF-8?Q?P=c3=a1draig_Brady?= , Kamil Dudka , 39929@debbugs.gnu.org References: <4228098.LvFx2qVVIh@nbkamil> <4a7b4098-e02f-9751-67ed-1e22ee994655@draigBrady.com> <1148eaa7-868f-8eba-5c06-4c80a8072269@bernhard-voelker.de> <48c2cadd-5ba1-774a-79e4-ce7801b9a9e9@bernhard-voelker.de> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <64c95c52-503f-dae2-520e-22667211abd8@cs.ucla.edu> Date: Sat, 7 Mar 2020 10:32:18 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <48c2cadd-5ba1-774a-79e4-ce7801b9a9e9@bernhard-voelker.de> Content-Type: multipart/mixed; boundary="------------B41EF34F20067DF082879724" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39929 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------B41EF34F20067DF082879724 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 3/5/20 11:36 PM, Bernhard Voelker wrote: >> s/emits/shall not emit/ > P.S. Also the check for $host_triplet containing 'linux' in test is: > a) no longer needed, ... Thanks for catching those; I installed the attached further patch. --------------B41EF34F20067DF082879724 Content-Type: text/x-patch; charset=UTF-8; name="0001-ls-improve-removed-directory-test.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-ls-improve-removed-directory-test.patch" >From ab149bd415daf1cb8ecde0b948bc0a2663611a61 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 7 Mar 2020 10:29:51 -0800 Subject: [PATCH] ls: improve removed-directory test * tests/ls/removed-directory.sh: Remove host_triplet test. Skip this test if one cannot remove the working directory. >From a suggestion by Bernhard Voelker (Bug#39929). --- tests/ls/removed-directory.sh | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/tests/ls/removed-directory.sh b/tests/ls/removed-directory.sh index fe8f929a1..63b209dee 100755 --- a/tests/ls/removed-directory.sh +++ b/tests/ls/removed-directory.sh @@ -1,7 +1,7 @@ #!/bin/sh -# If ls is asked to list a removed directory (e.g. the parent process's -# current working directory that has been removed by another process), it -# emits an error message. +# If ls is asked to list a removed directory (e.g., the parent process's +# current working directory has been removed by another process), it +# should not emit an error message merely because the directory is removed. # Copyright (C) 2020 Free Software Foundation, Inc. @@ -21,15 +21,10 @@ . "${srcdir=.}/tests/init.sh"; path_prepend_ ./src print_ver_ ls -case $host_triplet in - *linux*) ;; - *) skip_ 'non linux kernel' ;; -esac - cwd=$(pwd) mkdir d || framework_failure_ cd d || framework_failure_ -rmdir ../d || framework_failure_ +rmdir ../d || skip_ "can't remove working directory on this platform" ls >../out 2>../err || fail=1 cd "$cwd" || framework_failure_ -- 2.17.1 --------------B41EF34F20067DF082879724-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 07 13:32:52 2020 Received: (at control) by debbugs.gnu.org; 7 Mar 2020 18:32:52 +0000 Received: from localhost ([127.0.0.1]:47548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAeFo-0003k5-Bx for submit@debbugs.gnu.org; Sat, 07 Mar 2020 13:32:52 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:48150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAeFm-0003jt-GM for control@debbugs.gnu.org; Sat, 07 Mar 2020 13:32:50 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 29B801600C6 for ; Sat, 7 Mar 2020 10:32:45 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id tJWuOvqcS2Rc for ; Sat, 7 Mar 2020 10:32:44 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 794EC1600C7 for ; Sat, 7 Mar 2020 10:32:44 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 656ncmk-jOln for ; Sat, 7 Mar 2020 10:32:44 -0800 (PST) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 4F0791600C6 for ; Sat, 7 Mar 2020 10:32:44 -0800 (PST) To: control@debbugs.gnu.org From: Paul Eggert Subject: 39929 is fixed Organization: UCLA Computer Science Department Message-ID: <02432ec7-3466-e667-0f5d-6d1947720a90@cs.ucla.edu> Date: Sat, 7 Mar 2020 10:32:44 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 39929 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 07 15:33:36 2020 Received: (at 39929) by debbugs.gnu.org; 7 Mar 2020 20:33:37 +0000 Received: from localhost ([127.0.0.1]:47622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAg8e-0000C3-Oa for submit@debbugs.gnu.org; Sat, 07 Mar 2020 15:33:36 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:58778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAg8d-0000Bn-Br for 39929@debbugs.gnu.org; Sat, 07 Mar 2020 15:33:35 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6AA851600C6; Sat, 7 Mar 2020 12:33:29 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ZP8MokdVHFJK; Sat, 7 Mar 2020 12:33:26 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5A4BE1600CA; Sat, 7 Mar 2020 12:33:26 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id C8QL5RBZtIul; Sat, 7 Mar 2020 12:33:26 -0800 (PST) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 261761600C6; Sat, 7 Mar 2020 12:33:26 -0800 (PST) Subject: Re: bug#39929: coreutils-8.32 fails to build on aarch64 To: =?UTF-8?Q?P=c3=a1draig_Brady?= , Kamil Dudka , 39929@debbugs.gnu.org References: <4228098.LvFx2qVVIh@nbkamil> <4a7b4098-e02f-9751-67ed-1e22ee994655@draigBrady.com> <306f74e1-17a6-7864-5faa-4b6fb88c8f4d@draigBrady.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Sat, 7 Mar 2020 12:33:25 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <306f74e1-17a6-7864-5faa-4b6fb88c8f4d@draigBrady.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39929 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 3/6/20 2:48 AM, P=C3=A1draig Brady wrote: >=20 > I'm not very attached to the new behavior so feel free to apply this. > As per the original discussion, the change was made to distinguish > unreachable directories from empty directories. > Unreachable dirs are not common, but it seems useful for the user > to know they're in one Thanks, I applied the patch. My feeling is that 'ls' is about listing dir= ectory=20 contents, which is a different issue than reachability. A user wanting to= know=20 whether they're in an unreachable directory can use a reachability-tester= , like=20 'pwd'. From unknown Sat Jun 14 03:51:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 05 Apr 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator