GNU bug report logs - #39915
[PATCH] gnu: Add nyancat.

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: Add nyancat.
Date: Mon, 9 Mar 2020 13:12:19 +0100

[Message part 1 (text/plain, inline)]

On Wed, Mar 04, 2020 at 09:44:48PM +0200, Efraim Flashner wrote:
> +    (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure) ; no configure script
> +         (add-after 'unpack 'set-environment-variables
> +           (lambda _ (setenv "CC" (which "gcc")) #t))
I'm not fond of formatting a whole phase on one line, I feel like
(lambda _
  (setenv "CC" (which "gcc"))
  #t)
would be clearer. Either way, as far as I can see, this can also be done
with the simpler #:make-flags '("CC=gcc")

Apart from that, LGTM.

> +    (synopsis "Nyan cat telnet server")
I'm kinda disappointed you didn't include a service to go with it :P

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.