Subject: bug#39915: closed (Re: [PATCH] gnu: Add nyancat.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 09 Mar 2020 12:34:01 +0000

Your bug report

#39915: [PATCH] gnu: Add nyancat.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
39915: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39915
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [PATCH] gnu: Add nyancat.
From: Efraim Flashner <[email-masked]>
To: Jakub Kądziołka <[email-masked]>
Cc: [email-masked]
Date: Mon, 9 Mar 2020 14:32:37 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

On Mon, Mar 09, 2020 at 01:12:19PM +0100, Jakub Kądziołka wrote:
> On Wed, Mar 04, 2020 at 09:44:48PM +0200, Efraim Flashner wrote:
> > +    (arguments
> > +     '(#:phases
> > +       (modify-phases %standard-phases
> > +         (delete 'configure) ; no configure script
> > +         (add-after 'unpack 'set-environment-variables
> > +           (lambda _ (setenv "CC" (which "gcc")) #t))
> I'm not fond of formatting a whole phase on one line, I feel like
> (lambda _
>   (setenv "CC" (which "gcc"))
>   #t)
> would be clearer. Either way, as far as I can see, this can also be done
> with the simpler #:make-flags '("CC=gcc")

Good points. make-flags it is.

> 
> Apart from that, LGTM.
> 
> > +    (synopsis "Nyan cat telnet server")
> I'm kinda disappointed you didn't include a service to go with it :P

It's coming one of these days :) It turned out it was harder than
expected to have the output go to a telnet connection and not to stdout
when running a service. I'll have to play with it more one of these
days.

-- 
Efraim Flashner   <[email-masked]>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Subject: [PATCH] gnu: Add nyancat.
From: Efraim Flashner <[email-masked]>
To: [email-masked]
Cc: Efraim Flashner <[email-masked]>
Date: Wed, 4 Mar 2020 21:44:48 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/toys.scm (nyancat): New variable.
---
 gnu/packages/toys.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/toys.scm b/gnu/packages/toys.scm
index fd86aec6ef..3f2b273cf9 100644
--- a/gnu/packages/toys.scm
+++ b/gnu/packages/toys.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <[email-masked]>
 ;;; Copyright © 2019 Jesse Gibbons <[email-masked]>
 ;;; Copyright © 2019 Timotej Lazar <[email-masked]>
+;;; Copyright © 2020 Efraim Flashner <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -200,3 +201,39 @@ The GNU project hosts a similar collection of filters, the GNU talkfilters.")
 the desktop background.  Additional customizable effects include wind, stars
 and various scenery elements.")
     (license license:gpl3+)))
+
+(define-public nyancat
+  (package
+    (name "nyancat")
+    (version "1.5.2")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/klange/nyancat")
+               (commit version)))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32
+          "1mg8nm5xzcq1xr8cvx24ym2vmafkw53rijllwcdm9miiz0p5ky9k"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (delete 'configure) ; no configure script
+         (add-after 'unpack 'set-environment-variables
+           (lambda _ (setenv "CC" (which "gcc")) #t))
+         (replace 'install
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (bin (string-append out "/bin"))
+                    (man (string-append out "/share/man/man1")))
+               (install-file "src/nyancat" bin)
+               (install-file "nyancat.1" man))
+             #t)))))
+    (home-page "https://nyancat.dakko.us/")
+    (synopsis "Nyan cat telnet server")
+    (description
+     "This is an animated, color, ANSI-text telnet server that renders a loop
+of the Nyan Cat / Poptart Cat animation.")
+    (license license:ncsa)))
-- 
2.25.1