GNU bug report logs - #39903
28.0.50; Feature request: another filter for Package Menu

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39903 in the body.
You can then email your comments to 39903 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pieter van Oostrum <pieter <at> vanoostrum.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Feature request: another filter for Package Menu
Date: Wed, 4 Mar 2020 15:53:46 +0100

[Message part 1 (text/plain, inline)]

This is a request for a new filter in Package Menu.

Motivation: The command `package-menu-mark-upgrades' in the "*Packages*"
buffer marks all packages that have new versions. Both the new versions
are marked for installation (I) and the old versions for deletion (D).

However, it is not so easy to inspect which packages will be
affected. Currently the only simple ways are to do an `isearch' in the
"*Packages*" buffer for "^[^ ]", or to do an `occur' for the same
regexp. The latter gives an overview of all packages involved, but
requires an indirection step to get into the "*Packages*" buffer, for
example to unmark a package.

The attached file adds a new command to filter the "*Packages*"
buffer to show only the packages with a non-empty mark, i.e. the same as
the above `occur' command would show, but then without the extra
indirection.

My proposal is to bind it to "/m", and to add a menu entry.

This function is dependent on commit aea12d4903 (Bug#38424), which
introduces other filters. Contrary to the other filters, this filter
keeps the marks intact. Otherwise it would not be useful.
(Other filters clear the marks, because the marks are not part of the
data structure that builds the package list, but only of the
representation in the buffer.)

If this filter is accepted, I will make it into a full-blown patch with
documentation, etc.) The current format is fit to be included in the `init' file.

[package-filter.el (application/octet-stream, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Pieter van Oostrum <pieter <at> vanoostrum.org>
www: http://pieter.vanoostrum.org/
PGP key: [8DAE142BE17999C4]


-- 
Pieter van Oostrum <pieter <at> vanoostrum.org>
www: http://pieter.vanoostrum.org/
PGP key: [8DAE142BE17999C4]

Message #8 received at 39903 <at> debbugs.gnu.org (full text, mbox):

From: Pieter van Oostrum <pieter-l <at> vanoostrum.org>
To: Pieter van Oostrum <pieter <at> vanoostrum.org>
Cc: 39903 <at> debbugs.gnu.org
Subject: Re: bug#39903: 28.0.50; Feature request: another filter for Package
 Menu
Date: Thu, 05 Mar 2020 15:24:02 +0100

I saw that I had inadvertently used a -- in the function name.
package-menu--filter-marked should be replaced with package-menu-filter-marked.
-- 
Pieter van Oostrum
www: http://pieter.vanoostrum.org/
PGP key: [8DAE142BE17999C4]

Message #11 received at 39903 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Pieter van Oostrum <pieter <at> vanoostrum.org>
Cc: 39903 <at> debbugs.gnu.org
Subject: Re: bug#39903: 28.0.50;
 Feature request: another filter for Package Menu
Date: Thu, 05 Mar 2020 15:51:50 +0100

Pieter van Oostrum <pieter <at> vanoostrum.org> writes:

> This is a request for a new filter in Package Menu.
>
> Motivation: The command `package-menu-mark-upgrades' in the "*Packages*"
> buffer marks all packages that have new versions. Both the new versions
> are marked for installation (I) and the old versions for deletion (D).
>
> However, it is not so easy to inspect which packages will be
> affected. Currently the only simple ways are to do an `isearch' in the
> "*Packages*" buffer for "^[^ ]", or to do an `occur' for the same
> regexp. The latter gives an overview of all packages involved, but
> requires an indirection step to get into the "*Packages*" buffer, for
> example to unmark a package.
>
> The attached file adds a new command to filter the "*Packages*"
> buffer to show only the packages with a non-empty mark, i.e. the same as
> the above `occur' command would show, but then without the extra
> indirection.
>
> My proposal is to bind it to "/m", and to add a menu entry.

This looks useful.  Could you write this up as a patch instead?
Preferably also with a Changelog entry as described in the CONTRIBUTE
file.  We should also add this new command to the relevant NEWS entry,
and the user manual.

Thanks in advance.

Best regards,
Stefan Kangas

Message #14 received at 39903 <at> debbugs.gnu.org (full text, mbox):

From: Pieter van Oostrum <pieter-l <at> vanoostrum.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Pieter van Oostrum <pieter <at> vanoostrum.org>, 39903 <at> debbugs.gnu.org
Subject: Re: bug#39903: 28.0.50; Feature request: another filter for Package
 Menu
Date: Thu, 05 Mar 2020 16:19:33 +0100

Stefan Kangas <stefan <at> marxist.se> writes:
>
> This looks useful.  Could you write this up as a patch instead?
> Preferably also with a Changelog entry as described in the CONTRIBUTE
> file.  We should also add this new command to the relevant NEWS entry,
> and the user manual.

Yes, I'll do.
-- 
Pieter van Oostrum
www: http://pieter.vanoostrum.org/
PGP key: [8DAE142BE17999C4]

Message #17 received at 39903 <at> debbugs.gnu.org (full text, mbox):

From: Pieter van Oostrum <pieter-l <at> vanoostrum.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Pieter van Oostrum <pieter <at> vanoostrum.org>, 39903 <at> debbugs.gnu.org
Subject: Re: bug#39903: 28.0.50; Feature request: another filter for Package
 Menu
Date: Thu, 05 Mar 2020 23:24:45 +0100

[Message part 1 (text/plain, inline)]

Here is the patch:

[0001-Add-new-filter-command-to-Package-Menu-Bug-39903.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Pieter van Oostrum
www: http://pieter.vanoostrum.org/
PGP key: [8DAE142BE17999C4]

Message #20 received at 39903 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Pieter van Oostrum <pieter-l <at> vanoostrum.org>
Cc: Pieter van Oostrum <pieter <at> vanoostrum.org>, 39903 <at> debbugs.gnu.org
Subject: Re: bug#39903: 28.0.50;
 Feature request: another filter for Package Menu
Date: Sat, 9 May 2020 11:38:24 -0400

Pieter van Oostrum <pieter-l <at> vanoostrum.org> writes:

> Here is the patch:

Sorry for the late reply here.  The patch looks good to me.

Have you signed the copyright assignment papers?

Best regards,
Stefan Kangas

Message #23 received at 39903 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: pieter-l <at> vanoostrum.org, 39903 <at> debbugs.gnu.org
Subject: Re: bug#39903: 28.0.50;
 Feature request: another filter for Package Menu
Date: Sat, 09 May 2020 18:51:32 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Sat, 9 May 2020 11:38:24 -0400
> Cc: Pieter van Oostrum <pieter <at> vanoostrum.org>, 39903 <at> debbugs.gnu.org
> 
> Have you signed the copyright assignment papers?

Yes, he has.

Message #26 received at 39903 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: pieter-l <at> vanoostrum.org, 39903 <at> debbugs.gnu.org
Subject: Re: bug#39903: 28.0.50;
 Feature request: another filter for Package Menu
Date: Sat, 9 May 2020 12:22:32 -0400

close 39903 28.1
thanks

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Have you signed the copyright assignment papers?
>
> Yes, he has.

Thanks.  This patch is now pushed to master as commit 196bc13b7b.
I'm closing the bug with this message.

Thank you, Pieter, for your contribution.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.