GNU bug report logs - #39882
[PATCH 0/1] Add kexec-tools.

Previous Next

Package: guix-patches;

Reported by: Chris Marusich <cmmarusich <at> gmail.com>

Date: Tue, 3 Mar 2020 11:58:01 UTC

Severity: normal

Tags: patch

Done: Christopher Marusich <cmmarusich <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 39882 in the body.
You can then email your comments to 39882 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#39882; Package guix-patches. (Tue, 03 Mar 2020 11:58:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Chris Marusich <cmmarusich <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 03 Mar 2020 11:58:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Chris Marusich <cmmarusich <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Chris Marusich <cmmarusich <at> gmail.com>
Subject: [PATCH 0/1] Add kexec-tools.
Date: Tue,  3 Mar 2020 03:56:28 -0800
Hi,

This simple patch adds kexec-tools.  I've built it successfully on an
x86_64-linux system and confirmed via basic manual testing that kexec
works.  I verified the signature of the upstream release tarball when
adding this.  The patch applies cleanly to commit 6ce086550.

I was kind of surprised to find that kexec-tools was not already
packaged.  Is there a reason why it hasn't been packaged, or am I just
the first one to try packaging it?

Thank you,

Chris

Chris Marusich (1):
  gnu: Add kexec-tools.

 gnu/packages/linux.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

-- 
2.24.1





Information forwarded to guix-patches <at> gnu.org:
bug#39882; Package guix-patches. (Tue, 03 Mar 2020 12:01:01 GMT) Full text and rfc822 format available.

Message #8 received at 39882 <at> debbugs.gnu.org (full text, mbox):

From: Chris Marusich <cmmarusich <at> gmail.com>
To: 39882 <at> debbugs.gnu.org
Cc: Chris Marusich <cmmarusich <at> gmail.com>
Subject: [PATCH 1/1] gnu: Add kexec-tools.
Date: Tue,  3 Mar 2020 03:59:37 -0800
* gnu/packages/linux.scm (kexec-tools): New variable.
---
 gnu/packages/linux.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 0289047d27..fa9fdf759c 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -40,6 +40,7 @@
 ;;; Copyright © 2019 Kei Kebreau <kkebreau <at> posteo.net>
 ;;; Copyright © 2020 Oleg Pykhalov <go.wigust <at> gmail.com>
 ;;; Copyright © 2020 Pierre Neidhardt <mail <at> ambrevar.xyz>
+;;; Copyright © 2020 Chris Marusich <cmmarusich <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6408,3 +6409,27 @@ user space tracer.  It receives commands from a session daemon, for example to
 enable and disable specific instrumentation points, and writes event records
 to ring buffers shared with a consumer daemon.")
     (license license:lgpl2.1+)))
+
+(define-public kexec-tools
+  (package
+    (name "kexec-tools")
+    (version "2.0.20")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://mirrors.edge.kernel.org/pub/linux"
+                                  "/utils/kernel/kexec/kexec-tools-" version
+                                  ".tar.xz"))
+              (sha256
+               (base32
+                "1j7qlhxk1rbv9jbj8wd6hb7zl8p2mp29ymrmccgmsi0m0dzhgn6s"))))
+    (build-system gnu-build-system)
+    (arguments
+     ;; There are no automated tests.
+     '(#:tests? #f))
+    (home-page "https://mirrors.edge.kernel.org/pub/linux/utils/kernel/kexec/")
+    (synopsis "@code{kexec} and related tools for Linux kernels")
+    (description "This package provides the @code{kexec} program and ancillary
+utilities.  Using @code{kexec}, it is possible to boot directly into a new
+Linux kernel from the context of an already-running Linux kernel, bypassing
+the normal system boot process.")
+    (license license:gpl2)))
-- 
2.24.1





Information forwarded to guix-patches <at> gnu.org:
bug#39882; Package guix-patches. (Tue, 03 Mar 2020 12:29:01 GMT) Full text and rfc822 format available.

Message #11 received at 39882 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 39882 <at> debbugs.gnu.org, Chris Marusich <cmmarusich <at> gmail.com>
Subject: Re: [bug#39882] [PATCH 0/1] Add kexec-tools.
Date: Tue, 03 Mar 2020 13:28:34 +0100
[Message part 1 (text/plain, inline)]
Chris,

Chris Marusich 写道:
> I was kind of surprised to find that kexec-tools was not already
> packaged.  Is there a reason why it hasn't been packaged, or am 
> I just
> the first one to try packaging it?

I was also surprised, having installed kexec-tools on Guix before 
;-)

Turns out I never upstreamed it.  There are probably 5 other 
kexec-tools patches somewhere.  Oh well.

Your patch looks good to me.  I prefer the home page below over a 
directory listing.  Feel free to crib what you like.

Your synopsis/description imply that it's boot-Linux-only.  I 
don't think that's the case, but haven't tried others in practice.

Thanks!

T G-R


commit 69a6d90a988f86e556b2fb39092755f88eb9d323
Author: Tobias Geerinckx-Rice <me <at> tobias.gr>
Date:   Thu Feb 8 16:13:57 2018 +0100

   gnu: Add kexec-tools.
   
   * gnu/packages/linux.scm (kexec-tools): New public variable.

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 303a85c7fd..1ebc8b1744 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4632,3 +4632,24 @@ text-mode or graphical applications that 
don't use a display server.
Also included is @command{fbgrab}, a wrapper around 
@command{fbcat} that
emulates the behaviour of Gunnar Monell's older fbgrab utility.")
    (license license:gpl2)))
+
+(define-public kexec-tools
+  (package
+    (name "kexec-tools")
+    (version "2.0.15")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append 
"mirror://kernel.org/pub/linux/utils/kernel/kexec/"
+                           "kexec-tools-" version ".tar.xz"))
+       (sha256
+        (base32 
"0ra8ph9m1dckqaikfnbsh408fp2w9k49fkl425fl2hvhwsm14xk6"))))
+    (build-system gnu-build-system)
+    (home-page "https://projects.horms.net/projects/kexec/")
+    (synopsis "Linux tools to directly execute different 
kernels")
+    (description "This package provides tools to load a kernel 
into memory and
+reboot directly into it using the @code{kexec} system call, 
bypassing the normal
+boot process.  @dfn{Kexec} is the mechanism by which both Linux 
and Xen kernels
+can support fast soft reboots and kernel crash dump analysis.")
+    (license license:gpl2)))
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#39882; Package guix-patches. (Tue, 03 Mar 2020 13:09:02 GMT) Full text and rfc822 format available.

Message #14 received at 39882 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Marusich <cmmarusich <at> gmail.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: Chris Marusich <cmmarusich <at> gmail.com>, 39882 <at> debbugs.gnu.org
Subject: Re: [bug#39882] [PATCH 0/1] Add kexec-tools.
Date: Tue, 03 Mar 2020 05:08:23 -0800
[Message part 1 (text/plain, inline)]
Hi Tobias,

Sounds good.  I've gone ahead and committed this in commit
dedbdacf275cb7871c7336bd7a27ceb609b15113 with a few little changes, per
your suggestions.

Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> I was also surprised, having installed kexec-tools on Guix before ;-)
>
> Turns out I never upstreamed it.  There are probably 5 other
> kexec-tools patches somewhere.  Oh well.

Glad to know I wasn't missing something :-)

> Your patch looks good to me.  I prefer the home page below over a
> directory listing.  Feel free to crib what you like.
>
> Your synopsis/description imply that it's boot-Linux-only.  I don't
> think that's the case, but haven't tried others in practice.

You're probably right.  I've removed the Linux-specific wording.

> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> "mirror://kernel.org/pub/linux/utils/kernel/kexec/"
> +                           "kexec-tools-" version ".tar.xz"))

I didn't know we had mirror config for kernel.org.  I've switched to
using that in the latest patch.

> +       (sha256
> +        (base32
> "0ra8ph9m1dckqaikfnbsh408fp2w9k49fkl425fl2hvhwsm14xk6"))))
> +    (build-system gnu-build-system)
> +    (home-page "https://projects.horms.net/projects/kexec/")

Yes, this home page is better.  I'll use it!

> +    (synopsis "Linux tools to directly execute different kernels")

I've changed my synopsis to be more like yours.

-- 
Chris
[signature.asc (application/pgp-signature, inline)]

Reply sent to Christopher Marusich <cmmarusich <at> gmail.com>:
You have taken responsibility. (Tue, 03 Mar 2020 13:10:01 GMT) Full text and rfc822 format available.

Notification sent to Chris Marusich <cmmarusich <at> gmail.com>:
bug acknowledged by developer. (Tue, 03 Mar 2020 13:10:01 GMT) Full text and rfc822 format available.

Message #19 received at 39882-close <at> debbugs.gnu.org (full text, mbox):

From: Christopher Marusich <cmmarusich <at> gmail.com>
To: bug#39882 <39882-close <at> debbugs.gnu.org>
Subject: Re: Status: [PATCH 0/1] Add kexec-tools.
Date: Tue, 03 Mar 2020 05:09:40 -0800
[Message part 1 (text/plain, inline)]
Hi,

I'll close this patch now.

-- 
Chris
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 01 Apr 2020 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 136 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.