GNU bug report logs - #39865
28.0.50; Emacs crash

Previous Next

Package: emacs;

Reported by: Vinicius José Latorre <viniciusjl <at> gmail.com>

Date: Mon, 2 Mar 2020 01:55:02 UTC

Severity: normal

Tags: confirmed

Merged with 23386, 35803, 36835

Found in versions 25.0.95, 28.0.50, 24.1, 25.0.50, 24.5, 26.2, 27.0.50

Fixed in version 27.1

Done: Robert Pluim <rpluim <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 39865 <at> debbugs.gnu.org, viniciusjl <at> gmail.com
Subject: bug#39865: 28.0.50; Emacs crash
Date: Fri, 13 Mar 2020 16:09:27 +0200
> From: Robert Pluim <rpluim <at> gmail.com>
> Date: Fri, 13 Mar 2020 10:35:14 +0100
> Cc: 39865 <at> debbugs.gnu.org
> 
> Eli, the patch as it stands is not suitable for pushing to emacs-27,
> since it breaks the macOS build, which doesnʼt have a
> gui_default_font_parameter function. As far as I can tell (and have
> tested :-) ), we can get away with a dummy one, since there is only
> one font backend on macOS.

I'm okay with doing that.  However, ...

> If you agree, this is what the complete patch looks like:

... this is not how we introduce terminal-dependent methods.  We don't
define different versions of gui_SOMETHING functions in each
terminal-specific back-end.  Instead, we add a member to 'struct
redisplay_interface', and then assign a different value to it in each
back-end.  See how x_redisplay_interface, w32_redisplay_interface,
etc. are defined in the respective *term.[cm] files, and how they are
used via the FRAME_RIF macro.




This bug report was last modified 5 years and 64 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.