GNU bug report logs - #39862
[PATCH 0/4] update Dune finite element packages

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Felix Gruber <felgru <at> posteo.net>
Cc: 39862 <at> debbugs.gnu.org
Subject: [bug#39862] [PATCH v3 2/2] gnu: define dune-*-openmpi packages
Date: Fri, 13 Mar 2020 22:28:11 +0100

Hi,

Felix Gruber <felgru <at> posteo.net> skribis:

>>> +      (lambda (p) (not (dune-package? p))))))
>> 
>> You can replace the lambda with:
>> 
>>   (negate dune-package?)
>
> Thanks for this hint, as I'm new to Scheme, my knowledge of its standard
> library is still pretty limited.

Sure, I think sharing knowledge is one of the goals of review.

>> One last thing: could you look at the output of, say, ‘guix graph
>> dune-geometry-openmpi’ and ensure we’re not duplicating more nodes than
>> needed in the graph?
>> 
>> For example, you can compare node counts with:
>> 
>>   guix graph dune-geometry | grep 'label =' | wc -l
>>   guix graph dune-geometry-openmpi | grep 'label =' | wc -l
>> 
>> The difference should be less than:
>> 
>>   guix graph openmpi | grep 'label =' | wc -l
>> 
>> If that works well, please send an updated patch and we should be ready
>> to go!
>
> I get the following numbers:
>
>  graph dune-geometry | grep 'label =' | wc -l
>  70
>
>  guix graph dune-geometry-openmpi | grep 'label =' | wc -l
>  143
>
>  guix graph openmpi | grep 'label =' | wc -l
>  137
>
> The difference seems to be OK: 143 - 70 = 73 < 137.

Looks good, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.