GNU bug report logs - #39842
[PATCH] Use help-fns-short-filename in other describe- commands

Previous Next

Full log

View this message in rfc822 format

From: Štěpán Němec <stepnem <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 39842 <at> debbugs.gnu.org
Subject: bug#39842: [PATCH] Use help-fns-short-filename in other describe- commands
Date: Sat, 29 Feb 2020 21:18:33 +0100

On Sat, 29 Feb 2020 15:02:05 -0500
Stefan Monnier wrote:

>> +;;;###autoload
>>  (defun help-fns-short-filename (filename)
>
> OK, we can live that.  Maybe, moving it to help.el would be a cleaner option.
>
>> index 45cbaad4e8..32204d04e3 100644
>> --- a/lisp/help.el
>> +++ b/lisp/help.el
>> @@ -879,6 +879,7 @@ describe-key
>>              (princ ", which is ")
>>  	    (describe-function-1 defn)))))))
>>  
>> +(declare-function help-fns-short-filename "help-fns" (filename))
>>  (defun describe-mode (&optional buffer)
>>    "Display documentation of current major mode and minor modes.
>>  A brief summary of the minor modes comes first, followed by the
>
> The autoload cookie above should render this `declare-function`
> unnecessary, right?

R...right...? I'm somewhat unclear on the "something non-preloaded
required by something preloaded" situation. :-)

So, which shall it be? Move help-fns-short-filename to help.el, or
just remove the declaration?

Thanks,

  Štěpán

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.