GNU bug report logs - #39823
26.3; update-directory-autoloads regression from Emacs 26 to Emacs 27

Previous Next

Full log

Message #62 received at 39823 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 39823 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Noam Postavsky <npostavs <at> gmail.com>, rms <at> gnu.org
Subject: Re: bug#39823: 26.3; update-directory-autoloads regression from
 Emacs 26 to Emacs 27
Date: Wed, 30 Sep 2020 17:23:21 +0200

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> I've given this idea a try with the attached patch.  For some reason I
> can't seem to simply eval the definition to test it (Debugger
> entered--Lisp error: (void-function byte-compile-info-string).  I'm
> rebuilding Emacs with the change right now.

[...]

> This provides a way to explicitly specify the GENERATED-AUTOLOAD-FILE
> file name to use for the generated autoload definitions, which is more
> convenient when using lexical scoping.  Previously, the user had to
> use dynamic scoping and bind the variable before calling
> `update-directory-autoloads'.  This was discussed in
> <https://bugs.gnu.org/39823>.

This seems like a good change -- I'm all for explicit function arguments
instead of binding variables around the call.

[...]

>  ;;;###autoload
> -(defun update-directory-autoloads (&rest dirs)
> +(cl-defun update-directory-autoloads (&rest dirs
> +                                            &key (generated-autoload-file
> +                                                  generated-autoload-file)
> +                                            &allow-other-keys)

But I'm not really enthusiastic about this complicated function
signature.  The doc string to the function already goes on way too long
to explain what the parameter means.

I think it would make more sense to introduce a new function, say,
`make-directory-autoloads' (because it doesn't so much update the
autoloads as create an autoload file, I think?) with a sane function
signature, and then deprecate update-directory-autoloads (which is only
used a handful of place in the Emacs tree).

Any comments?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.