GNU bug report logs -
#39822
27.0.90; Cannot set *Completions* buffer height using display-buffer-alist
Previous Next
Reported by: Davor Rotim <drot <at> firemail.cc>
Date: Fri, 28 Feb 2020 14:06:02 UTC
Severity: normal
Tags: fixed
Found in version 27.0.90
Fixed in version 28.0.50
Done: Juri Linkov <juri <at> linkov.net>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
> Here is the first step, this patch seems to keep the original behavior,
> but I need your help to finish it. Could you confirm that calls of
> window-preserve-size at the end of with-displayed-buffer-window are
> not needed anymore after this patch is applied, because there are the
> same calls of window-preserve-size at the end of window--display-buffer
> that are called later after buffer contents is filled
> by after-display-function in the middle of window--display-buffer:
Didn't we agree that 'vaction' is harmful anyway so these "same calls"
should never have been applied in the first place? I wouldn't bother
about them at the moment, when something fails we find out soon enough.
But what if a function like 'dired-format-columns-of-files' wanted to
(1) know the width of the window used for displaying the buffer,
(2) according to that (presumably fixed) width adjust columns, establish
a maximum width of buffer lines or do something else width related,
(3) leave it to 'window--display-buffer' to adjust the window height
afterwards?
And be able to do (1)-(3) in the orthogonal direction, that is, base (2)
on a presumably fixed window height?
I conjecture that in such case, the function (functions?) specified by
'after-display-function' should be supplied the window to display the
buffer as first argument (just in case there's another window showing
the same buffer). WDYT?
martin
This bug report was last modified 5 years and 53 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.