From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 28 08:38:35 2020 Received: (at submit) by debbugs.gnu.org; 28 Feb 2020 13:38:35 +0000 Received: from localhost ([127.0.0.1]:60803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7fqc-0004PW-Ro for submit@debbugs.gnu.org; Fri, 28 Feb 2020 08:38:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:35298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7fqa-0004PO-JN for submit@debbugs.gnu.org; Fri, 28 Feb 2020 08:38:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57012) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7fqZ-0000JZ-Bc for bug-gnu-emacs@gnu.org; Fri, 28 Feb 2020 08:38:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7fqY-0002qr-6j for bug-gnu-emacs@gnu.org; Fri, 28 Feb 2020 08:38:31 -0500 Received: from mail-io1-xd34.google.com ([2607:f8b0:4864:20::d34]:41186) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j7fqY-0002qQ-1Z for bug-gnu-emacs@gnu.org; Fri, 28 Feb 2020 08:38:30 -0500 Received: by mail-io1-xd34.google.com with SMTP id m25so3399173ioo.8 for ; Fri, 28 Feb 2020 05:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=yRTAQK/siWdhC/1ePXqJ6vWx8zrjdrZxnr4vafvRbNI=; b=gM9Ny/VkQGljGVAW+d2ZlU2qdE0trEocR0jRHI4sc8we5uAcUIq2qJeXjM/7W9mvw5 jGeSv7G98hIRHdVWA7HIv0UgvXrP71RFX26NrXLKTHaz8zWvY3BB8qpBbXyd6/EsMada Dy7/qNqu9v1PhtFQH6ApLXFRU6z8Vp1GOJbTUvI2vNQMqYCvzkZEdsmgoUKI5CFeKcSb eWIJVKqN5nub/GoaHCXwF3z2NWbmQfX3xmjaOfHq1x+xCy8iaffpbdBAiIjzfjGW12KB 8W0HNGNh+wcIJYwZW1OFJM7J8B1RGV2GQ3qLaMg7KYrUk/KCzdgo8xFXbsJ73MQnEB6z KBDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=yRTAQK/siWdhC/1ePXqJ6vWx8zrjdrZxnr4vafvRbNI=; b=Wrlo09jagb/dh/WAbphD/IDhPe/jaxrpbRoZrbJt+yFVeWGkZCWFYFj5upk2V5Yz9f x28GbA3dPfGKha0d51r3FYFRLGxrWSHMO7/HretNoq77jLX+ent8DOHz15whW9XSLGxO +PbKzqyu0nqReT9EXSnG+Q6PZ8UJJ1FTeatP3KoI+Kfb/VRNwgJgWB3GNEJhAQwhqRCS WDKJ+c21djFT3GC35APAh/l/pXMxpoQyoj/V5OL0Pe5tF7rZd5rui36+O7QP5ug7n9M2 YDJnZehD/UgYViXNpbW8rzEWTqL18xidT3V5Po4v8Mup3y3gzvOrqJ0hFAuB97qbX5wp t46A== X-Gm-Message-State: APjAAAXoJzIAl+7x7wapVJdWojIxHk3GWW9ykPGn8qd9/NNHJzHaqGgP nxW/KrCNILzjIn6bIE9SdU1x/8H284nhY4ANGUviM475 X-Google-Smtp-Source: APXvYqyKVWtEFd9ZLE7IDTyRqnbianQrYy3jdVZCq0XeFVGl2NsZ8UIjn5Ok9hYCjDcOeZ74fzUbsjnrB7uyQZGuRQU= X-Received: by 2002:a5d:8f06:: with SMTP id f6mr550345iof.137.1582897108706; Fri, 28 Feb 2020 05:38:28 -0800 (PST) MIME-Version: 1.0 From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Fri, 28 Feb 2020 13:38:17 +0000 Message-ID: Subject: 27.0.60; lisp/cedet/pulse.el destroys pulsed overlay priorities To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="000000000000e169b8059fa2f358" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d34 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000e169b8059fa2f358 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, The bug is easy to reproduce, just make an overlay somewhere, "pulse" it with pulse-momentary-highlight-overlay, and watch its previous 'priorty value get destroyed. The patch attached inline fixes the issue, it restores the priority just like it does the face. I'll push it as soon as there is approval, or in a few days if there are no objections. Jo=C3=A3o Subject: [PATCH] Have pulse.el save and restore overlay priorities * lisp/cedet/pulse.el (pulse-momentary-highlight-overlay): Save overlay priority. (pulse-momentary-unhighlight): Restore. --- lisp/cedet/pulse.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el index 5713a7b0d1..16243e16b4 100644 --- a/lisp/cedet/pulse.el +++ b/lisp/cedet/pulse.el @@ -181,6 +181,7 @@ pulse-momentary-highlight-overlay (overlay-put o 'original-face (overlay-get o 'face)) ;; Make this overlay take priority over the `transient-mark-mode' ;; overlay. + (overlay-put o 'original-priority (overlay-get o 'priority)) (overlay-put o 'priority 1) (setq pulse-momentary-overlay o) (if (eq pulse-flag 'never) @@ -214,6 +215,7 @@ pulse-momentary-unhighlight (let ((ol pulse-momentary-overlay)) (overlay-put ol 'face (overlay-get ol 'original-face)) (overlay-put ol 'original-face nil) + (overlay-put ol 'priority (overlay-get ol 'original-priority)) ;; Clear the overlay if it needs deleting. (when (overlay-get ol 'pulse-delete) (delete-overlay ol))) --=20 2.20.1 --000000000000e169b8059fa2f358 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

The bug is easy to reproduce, just make an over= lay somewhere, "pulse" it
with pulse-momentary-highlight-overl= ay, and watch its previous 'priorty
value get destroyed.=C2=A0 The p= atch attached inline fixes the issue, it
restores the priority just like= it does the face.=C2=A0 I'll push it as soon
as there is approval, = or in a few days if there are no objections.

Jo=C3=A3o

Subjec= t: [PATCH] Have pulse.el save and restore overlay priorities

* lisp/= cedet/pulse.el (pulse-momentary-highlight-overlay): Save
overlay priorit= y.
(pulse-momentary-unhighlight): Restore.
---
=C2=A0lisp/cedet/pu= lse.el | 2 ++
=C2=A01 file changed, 2 insertions(+)

diff --git a/= lisp/cedet/pulse.el b/lisp/cedet/pulse.el
index 5713a7b0d1..16243e16b4 1= 00644
--- a/lisp/cedet/pulse.el
+++ b/lisp/cedet/pulse.el
@@ -181,= 6 +181,7 @@ pulse-momentary-highlight-overlay
=C2=A0 =C2=A0(overlay-put = o 'original-face (overlay-get o 'face))
=C2=A0 =C2=A0;; Make thi= s overlay take priority over the `transient-mark-mode'
=C2=A0 =C2=A0= ;; overlay.
+ =C2=A0(overlay-put o 'original-priority (overlay-get o= 'priority))
=C2=A0 =C2=A0(overlay-put o 'priority 1)
=C2=A0 = =C2=A0(setq pulse-momentary-overlay o)
=C2=A0 =C2=A0(if (eq pulse-flag &= #39;never)
@@ -214,6 +215,7 @@ pulse-momentary-unhighlight
=C2=A0 =C2= =A0 =C2=A0(let ((ol pulse-momentary-overlay))
=C2=A0 =C2=A0 =C2=A0 =C2= =A0(overlay-put ol 'face (overlay-get ol 'original-face))
=C2=A0= =C2=A0 =C2=A0 =C2=A0(overlay-put ol 'original-face nil)
+ =C2=A0 = =C2=A0 =C2=A0(overlay-put ol 'priority (overlay-get ol 'original-pr= iority))
=C2=A0 =C2=A0 =C2=A0 =C2=A0;; Clear the overlay if it needs del= eting.
=C2=A0 =C2=A0 =C2=A0 =C2=A0(when (overlay-get ol 'pulse-delet= e) (delete-overlay ol)))
=C2=A0
--
2.20.1
--000000000000e169b8059fa2f358-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 21 07:40:02 2020 Received: (at 39821) by debbugs.gnu.org; 21 Aug 2020 11:40:03 +0000 Received: from localhost ([127.0.0.1]:45185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k95Os-0005nX-Iy for submit@debbugs.gnu.org; Fri, 21 Aug 2020 07:40:02 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k95Oq-0005mf-Ij for 39821@debbugs.gnu.org; Fri, 21 Aug 2020 07:40:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jExPVflfQyzfoxUfOC5a9AHWohEJou81lKzyKoNQ1w0=; b=A2s1CoC03TKOeFpzRLHNG3Pw6M d+M2XaUuppDSIwsCqg9lR7FZXLARiLp/h+2crdWQuvM+tQGG21HX34qmNCmw37zP3xVyp0FQgDsK1 QtVcunHbHtIv0V5AAr6Ie8wtZWGzHRP2VX2VmRg79Gl/E3hy4rhtjuG75HKNcsu0owG8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k95Oh-00034B-Hp; Fri, 21 Aug 2020 13:39:54 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#39821: 27.0.60; lisp/cedet/pulse.el destroys pulsed overlay priorities References: X-Now-Playing: Move D & Pete Namlook's _Reissued 001_: "Der =?utf-8?B?QmVy?= =?utf-8?B?Z2vDg8K2bmlnIg==?= Date: Fri, 21 Aug 2020 13:39:49 +0200 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Fri, 28 Feb 2020 13:38:17 +0000") Message-ID: <87sgcg6xdm.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: João Távora writes: > The bug is easy to reproduce, just make an overlay somewhere, "pulse" it > with pulse-momentary-highlight-overlay, and watch its previous 'priorty > value get destroyed. The patch attached inline fi [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39821 Cc: 39821@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > The bug is easy to reproduce, just make an overlay somewhere, "pulse" it > with pulse-momentary-highlight-overlay, and watch its previous 'priorty > value get destroyed. The patch attached inline fixes the issue, it > restores the priority just like it does the face. I'll push it as soon > as there is approval, or in a few days if there are no objections. Looks like this was applied, but the bug report was left open, so I'm closing it now. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 21 07:40:18 2020 Received: (at control) by debbugs.gnu.org; 21 Aug 2020 11:40:18 +0000 Received: from localhost ([127.0.0.1]:45189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k95P7-0005o9-UF for submit@debbugs.gnu.org; Fri, 21 Aug 2020 07:40:18 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k95P5-0005nv-JD for control@debbugs.gnu.org; Fri, 21 Aug 2020 07:40:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Z5o2EcnZ/DqZ144w4tNas1neG7hIwLfpBRzOUlIkc/Q=; b=j9Jqzz6PdmXJdnvpnvI+knjnay 0oSoEbY0a4omLoAZLsRmTmPO9LO5QVB2nt32iDhxqf0QQZg04TbF+v1ivtPjTSv3B7YnPdywsX7xq cuCP2aTaLO1+IYWVi4uON+nX+vj1Gr63dizHpRDevY/A7kA72Oxe6P56DIR4voAot3xU=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k95Ox-00034R-QY for control@debbugs.gnu.org; Fri, 21 Aug 2020 13:40:10 +0200 Date: Fri, 21 Aug 2020 13:40:06 +0200 Message-Id: <87r1s06xd5.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #39821 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 39821 + patch tags 39821 fixed close 39821 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 39821 + patch tags 39821 fixed close 39821 27.1 quit From unknown Sun Jun 22 17:17:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 19 Sep 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator