Subject: Re: [bug#39818] [PATCH] gnu: Add emacs-ddskk.

From: Masaya Tojo <[email-masked]>
Date: Thu, 5 Mar 2020 14:13:29 +0000

Hello.

> Another option is to re-send the package with the commit you chose,
> along with a comment explaining why (e.g., exactly what you wrote
> above), and update it later when 17.x is released.
> 
> WDYT?

I think that re-send package along with comment explaining is good
choice. 

Although, I have found problems in my first patch. I solved them and
build version 16.3.

A build of my firth patch has two problems:
* It can't read info files.
* It can't read skk-tutorial.

For solve above, I needed to precisely follow installation manual of
ddskk.
https://github.com/skk-dev/ddskk/blob/ddskk-16.3_Kutomatsunai/READMEs/INSTALL

>>>> +(define emacs-ddskk  

>>> Wouldn't it be emacs-skk, since one need to (require 'skk)?

I researched to the history of ddskk's name. skk refer original skk.
Ddskk is extend of original skk , and original skk was developed other team.  It called ddskk for distiguish between it and original skk.
So I think that package name is `emacs-ddskk`. 
Actually debian and melpa use name of `ddskk`.

https://packages.debian.org/sid/utils/ddskk
https://melpa.org/#/ddskk

>>> is a version of @acronym{SKK, Simple Kana to Kanji} conversion
>>> program,

Thanks of teach `@acronym`. 
SKK is acronym of "Simple Kana to Kanji conversion program".

I resend new revision. 

Regards.
From b61f204b81ef2efc290a2f87feb2c98dcb98bdb1 Mon Sep 17 00:00:00 2001
From: Masaya Tojo <[email-masked]>
Date: Thu, 5 Mar 2020 21:37:06 +0900
Subject: [PATCH] gnu: Add emacs-ddskk.

* gnu/packages/emacs-xyz.scm (emacs-ddskk): New variable.
---
 gnu/packages/emacs-xyz.scm | 42 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 19c4ed7571..406c97c208 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -60,6 +60,7 @@
 ;;; Copyright © 2020 Paul Garlick <[email-masked]>
 ;;; Copyright © 2020 Robert Smith <[email-masked]>
 ;;; Copyright © 2020 Evan Straw <[email-masked]>
+;;; Copyright © 2020 Masaya Tojo <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21732,3 +21733,44 @@ supports generation of phonetic and numeric passwords.")
 Separated Value) files.  It follows the format as defined in RFC 4180 \"Common
 Format and MIME Type for CSV Files\" (@url{http://tools.ietf.org/html/rfc4180}).")
     (license license:gpl3+)))
+
+(define-public emacs-ddskk
+  (package
+    (name "emacs-ddskk")
+    (version "16.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/skk-dev/ddskk")
+             (commit "5b4cd5c73e7a273d1814d83bf7534704778f2a2d")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0ln4x8f35z5y3kf9m718g223bn3lzcmw40jfjg2j5yi24ydf1wm9"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:modules ((guix build gnu-build-system)
+                  (guix build utils)
+                  (guix build emacs-utils))
+       #:imported-modules (,@%gnu-build-system-modules
+                           (guix build emacs-utils))
+       #:test-target "test"
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'configure
+           (lambda* (#:key outputs #:allow-other-keys)
+             (make-file-writable "SKK-MK")
+             (emacs-substitute-variables "SKK-MK"
+               ("PREFIX" (assoc-ref outputs "out"))
+               ("LISPDIR" '(expand-file-name "/share/emacs/site-lisp" PREFIX))
+               ("SKK_PREFIX" "")
+               ("SKK_INFODIR" '(expand-file-name "info" PREFIX)))
+             (for-each make-file-writable (find-files "./doc"))
+             #t)))))
+    (native-inputs `(("emacs-minimal" ,emacs-minimal)))
+    (synopsis "Simple Kana to Kanji conversion program")
+    (home-page "https://github.com/skk-dev/ddskk")
+    (description "Daredevil SKK
+is a version of @acronym{SKK, Simple Kana to Kanji conversion program},
+an input method of Japanese.")
+    (license license:gpl2+)))
-- 
2.25.1