From unknown Mon Jun 23 06:02:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39808: 28.0.50; toolbar broken Resent-From: Markus FFM Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2020 12:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39808 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 39808@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: markusffm@fn.de Received: via spool by submit@debbugs.gnu.org id=B.158280679324144 (code B ref -1); Thu, 27 Feb 2020 12:34:01 +0000 Received: (at submit) by debbugs.gnu.org; 27 Feb 2020 12:33:13 +0000 Received: from localhost ([127.0.0.1]:58809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7ILo-0006HM-T7 for submit@debbugs.gnu.org; Thu, 27 Feb 2020 07:33:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:38665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7ILn-0006HF-W1 for submit@debbugs.gnu.org; Thu, 27 Feb 2020 07:33:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38546) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7ILm-0001By-5U for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 07:33:11 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7ILk-0004um-Ee for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 07:33:09 -0500 Received: from mout3.freenet.de ([2001:748:100:40::2:5]:47868) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j7ILk-0004lm-8W for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 07:33:08 -0500 Received: from [195.4.92.163] (helo=mjail0.freenet.de) by mout3.freenet.de with esmtpa (ID markusffm@fn.de) (port 25) (Exim 4.92 #3) id 1j7ILf-0005eq-45 for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 13:33:03 +0100 Received: from [::1] (port=54624 helo=mjail0.freenet.de) by mjail0.freenet.de with esmtpa (ID markusffm@fn.de) (Exim 4.92 #3) id 1j7ILf-0003gU-3D for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 13:33:03 +0100 Received: from sub7.freenet.de ([195.4.92.126]:36882) by mjail0.freenet.de with esmtpa (ID markusffm@fn.de) (Exim 4.92 #3) id 1j7IIl-0002f7-8x for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 13:30:03 +0100 Received: from p5dd1c653.dip0.t-ipconnect.de ([93.209.198.83]:37638 helo=localhost.localdomain) by sub7.freenet.de with esmtpsa (ID markusffm@fn.de) (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256) (port 465) (Exim 4.92 #3) id 1j7IIl-0001je-5s for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 13:30:03 +0100 From: Markus FFM Date: Thu, 27 Feb 2020 13:30:02 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Originated-At: 93.209.198.83!37638 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:748:100:40::2:5 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) emacs -Q Toolbar: Discard (kill) current buffer Wrong type argument: symbolp, # same with all other toolbar items In GNU Emacs 28.0.50 (build 15, x86_64-pc-linux-gnu, GTK+ Version 3.24.13, cairo version 1.16.0) of 2020-01-22 built on INDRA Repository revision: 5715eb94e90b33ace59dd4c4ccb6e2122bc6db72 Repository branch: master System Description: Fedora 31 (Thirty One) Recent messages: >>>activated: get rid of auto-revert-verbosity<<< >>>loaded: GNU Emacs 28.0.50 of 2020-01-22<<< >>>load time: Thursday, February 27, 2020 13:27:29<<< >>>activated: themes<<< Desktop: 3 buffers restored, 1 to restore lazily. For information about GNU Emacs and the GNU system, type C-M-h C-a. Desktop lazily opening mem_log (1 remaining)...done Lazy desktop load complete Making completion list... [4 times] user-error: End of history; no default available [2 times] Configured using: 'configure --prefix=/opt/emacs --sysconfdir=/etc --enable-locallisppath=/usr/local/share/emacs/site-lisp --libexecdir=/opt/emacs/lib/ --localstatedir=/usr/local/var --enable-largefile --with-x-toolkit=gtk3 --with-modules --with-xwidgets --without-pop --without-selinux --without-gnutls --with-file-notification=yes --with-json --with-cairo 'CFLAGS=-march=native -Os'' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD JSON PDUMPER GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Info Minor modes in effect: show-paren-mode: t recentf-mode: t desktop-save-mode: 1 delete-selection-mode: t cua-mode: t global-hl-line-mode: t gpm-mouse-mode: t savehist-mode: t global-auto-revert-mode: t auto-insert-mode: t smooth-scroll-mode: t global-undo-tree-mode: t undo-tree-mode: t save-place-mode: t tooltip-mode: t global-eldoc-mode: t electric-quote-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t global-prettify-symbols-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t size-indication-mode: t column-number-mode: t line-number-mode: t global-visual-line-mode: t visual-line-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired-sort-menu dired dired-loaddefs rfc822 mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cursor-sensor term/linux user-profile powerline powerline-separators powerline-themes server default-profile default-ui paren man recentf sh-script smie executable vc-dispatcher vc-svn enriched mule-util jka-compr info desktop frameset avoid default-faces default-keymap delsel cua-base default-run default-restart default-modes default-platform default-nw hl-line t-mouse default-unix default-flymake default-flymake-go default-flymake-csharp default-flymake-ruby default-flymake-js default-flymake-py default-flymake-java default-flymake-shell flymake-proc flymake compile warnings default-run-assoc run-assoc default-tempo default-tempo-rexx default-tempo-sh default-tempo-pas default-tempo-js default-tempo-java default-tempo-perl default-tempo-elisp default-tempo-c-cpp default-menu default-help default-options default-tools default-search default-format default-view aquamacs-cmm-menu default-edit default-file default-generic savehist autorevert filenotify autoinsert default-functions default-autoload ox-man ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar ox-html table ox-ascii ox-publish ox org-element org ob ob-tangle ob-ref ob-lob ob-table org-macro org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-color ring org-list org-faces org-entities time-date org-version ob-emacs-lisp org-table org-keys org-loaddefs find-func cal-menu calendar cal-loaddefs avl-tree generator ol ob-exp ob-core org-compat ob-eval org-macs format-spec markdown-mode rx color thingatpt noutline outline easy-mmode jison-mode bison-mode cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs flex-mode derived aquamacs-tabbar cus-start cus-load aquamacs-tools tabbar restore-last-frame-size org-bullets syslog-mode hide-lines web-mode disp-table vimrc-mode go-autocomplete go-mode-autoloads neotree advice smooth-scroll aok fill-column-indicator tempbuf auto-complete-config auto-complete edmacro kmacro popup undo-tree diff multi-shell windata tree-mode tree-widget wid-edit imenu imenu-tree tempo saveplace google-translate google-translate-default-ui google-translate-core-ui ido google-translate-core google-translate-tk google-translate-backend url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs cl-loaddefs cl-lib password-cache url-vars mailcap json subr-x map seq byte-opt gv bytecomp byte-compile cconv eol-conversion easymenu default-path tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting xwidget-internal cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 253383 185135) (symbols 48 26324 10) (strings 32 90935 29593) (string-bytes 1 2893472) (vectors 16 35482) (vector-slots 8 389169 203210) (floats 8 284 1433) (intervals 56 2505 232) (buffers 1000 16)) From unknown Mon Jun 23 06:02:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39808: 28.0.50; toolbar broken In-Reply-To: Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2020 13:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39808 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Markus FFM Cc: Stefan Monnier , 39808@debbugs.gnu.org Received: via spool by 39808-submit@debbugs.gnu.org id=B39808.15828098404906 (code B ref 39808); Thu, 27 Feb 2020 13:24:02 +0000 Received: (at 39808) by debbugs.gnu.org; 27 Feb 2020 13:24:00 +0000 Received: from localhost ([127.0.0.1]:58859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7J8x-0001H4-Mv for submit@debbugs.gnu.org; Thu, 27 Feb 2020 08:23:59 -0500 Received: from mail-wm1-f44.google.com ([209.85.128.44]:53497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7J8w-0001Gp-5S for 39808@debbugs.gnu.org; Thu, 27 Feb 2020 08:23:59 -0500 Received: by mail-wm1-f44.google.com with SMTP id f15so3549999wml.3 for <39808@debbugs.gnu.org>; Thu, 27 Feb 2020 05:23:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:message-id:mime-version :content-transfer-encoding; bh=OZMhxLJwj5A5BVJUdi+Et9w5m23cjCj7hsQCu03Tmco=; b=gNsmJs1/m7EgHYKHN9ASmjMlA3WjxBiVI9f/xzJ/zmMuUpwgJjc1t/05cF0yzW5Y1r 67TjF+6PgFmYBJdpiIsFsFwBe1HIguRQlgiU3LO0dV6BcsIp/qEms4apgxBtpBZfaDDR JtIuB+okY8x2s24mOWdqMNlDR9LtqzGiRDPGdZJe7mKVnZKpPWgoJbQj8hxljcnjfnnI FnpRpJyR5CiiVb8FWb8+j3+wBoBEYVuBx/NsOHo3cZy2DpEPE6jotbxTX2axX8QQEri0 Rf2Wpz0+FMIv2BCeCntil9Kc/Q8ZbD6cMJHtNOKIT140ZizqgXTIo/sLKYCAfcfznE2L Djcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :mime-version:content-transfer-encoding; bh=OZMhxLJwj5A5BVJUdi+Et9w5m23cjCj7hsQCu03Tmco=; b=o392+4VEiSFqP8X0reNEzYukwLOettMmaoLUOl5iYoeU9NwaMllsDWLDXLbqK2Y9NN qf9N4qk1uP8n6n9FzUmrNK9t37GCWlFtF9l/f6NekL2M4npTnBCcga/pXCZgDG3vBvH1 aVXqo84lhPjALZeauoV24WAJVE7cKRGd2m/xGjOLxgHVN7A8GA5LDbGlxJMND0AZ1lwD NmJMcI2C/e/iVwDqr3dBmGsPnOiTWWIGH0tgmhSiS1IsRSTpyOfFYBlCF15d6FBjZaWT t+5uvZZ8AEh+D60Gs7pNXG7SX2Gt1u76km9GIy4gJv60FHqarQhub1/tg6XkmdEqwHHM ZFRg== X-Gm-Message-State: APjAAAXJn/BuKjeL2dgxNiPPuWVufaqgZrvKS388ZpjJ9EGyBZWx9+fc yVwj/r8cE11vlribhGlNOdE= X-Google-Smtp-Source: APXvYqyMgpZ50txrVAj+AOTzjVL+H6/6wliDOVoOmB8Uqhr4Y4mjAc9v9Lw0xf2x/GhJ8WUFiDX+HA== X-Received: by 2002:a7b:c3d8:: with SMTP id t24mr5179580wmj.43.1582809831034; Thu, 27 Feb 2020 05:23:51 -0800 (PST) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id f65sm7581588wmf.29.2020.02.27.05.23.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 05:23:50 -0800 (PST) From: Robert Pluim References: Date: Thu, 27 Feb 2020 14:23:49 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) >>>>> On Thu, 27 Feb 2020 13:30:02 +0100, Markus FFM said: Markus> emacs -Q Markus> Toolbar: Discard (kill) current buffer=20 Markus> Wrong type argument: symbolp, # Markus> same with all other toolbar items I=CA=BCve bisected this down to: 3b4bd4be1dfa8717cb6911bd57c4c7d9d13614b4 * 3b4bd4be1d (HEAD, refs/bisect/bad) * src/keyboard.c (make_lispy_event): G= enerate proper tool-bar events. | - Stefan Monnier Robert From unknown Mon Jun 23 06:02:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39808: 28.0.50; toolbar broken Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2020 16:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39808 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: Markus FFM , 39808@debbugs.gnu.org Received: via spool by 39808-submit@debbugs.gnu.org id=B39808.15828204101572 (code B ref 39808); Thu, 27 Feb 2020 16:21:02 +0000 Received: (at 39808) by debbugs.gnu.org; 27 Feb 2020 16:20:10 +0000 Received: from localhost ([127.0.0.1]:60170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7LtR-0000PH-Sv for submit@debbugs.gnu.org; Thu, 27 Feb 2020 11:20:10 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7LtP-0000Om-J3 for 39808@debbugs.gnu.org; Thu, 27 Feb 2020 11:20:07 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0D2BC100ECB; Thu, 27 Feb 2020 11:20:02 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2CC54100BF4; Thu, 27 Feb 2020 11:20:00 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1582820400; bh=jJfWCT+HbTpza400A7p9Pu/rmLE7RbIR1DZD86TcBTU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=J/1x/30Yw9bcGYBFeFs3WmvtVX8Lv/LRyInCq0NQgh5TE995EZwXnLTdrd2E+6700 8tC5KP93o8fc5/8ftOkwIlAHH6MKBoEqbDRcrxcv9GMEBNBrqqcURJSKtwQhMzHQZZ A0uqqiRFtaI7gG48fx2mjnhkDNVYb/jBQkNodCqiDDvp3o3D4ZuCyyX/Uvxs/Yv4Td d/DGWDbH283eJiWFHkAHTDSiIU31bFHfklD/0WqVc8MU2Z+bRpih+iyz/DEA6HFNBi KyFOnKrk79ZhAqnQ5yLXEej3j7nOQM4LfGsu0yk2RnsTNey52CRcEFLW5POb1Nfd7t IBRr0WZ/FbpJA== Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F11641207D6; Thu, 27 Feb 2020 11:19:59 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Thu, 27 Feb 2020 11:19:53 -0500 In-Reply-To: (Robert Pluim's message of "Thu, 27 Feb 2020 14:23:49 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I=CA=BCve bisected this down to: > > 3b4bd4be1dfa8717cb6911bd57c4c7d9d13614b4 > > * 3b4bd4be1d (HEAD, refs/bisect/bad) * src/keyboard.c (make_lispy_event): > Generate proper tool-bar events. > | - Stefan Monnier Looks like my grep-fu was very weak, indeed. I installed the patch below, which should hopefully fix the problem for Gtk and NS builds, Stefan diff --git a/src/gtkutil.c b/src/gtkutil.c index 5e7cf3d211..338c6036c2 100644 --- a/src/gtkutil.c +++ b/src/gtkutil.c @@ -4398,13 +4398,6 @@ xg_tool_bar_callback (GtkWidget *w, gpointer client_= data) key =3D AREF (f->tool_bar_items, idx + TOOL_BAR_ITEM_KEY); XSETFRAME (frame, f); =20 - /* We generate two events here. The first one is to set the prefix - to `(tool_bar)', see keyboard.c. */ - event.kind =3D TOOL_BAR_EVENT; - event.frame_or_window =3D frame; - event.arg =3D frame; - kbd_buffer_store_event (&event); - event.kind =3D TOOL_BAR_EVENT; event.frame_or_window =3D frame; event.arg =3D key; diff --git a/src/nsterm.m b/src/nsterm.m index c0535825ee..aefbb2721e 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -8185,12 +8185,6 @@ - (instancetype)toolbarClicked: (id)item if (!emacs_event) return self; =20 - /* Send first event (for some reason two needed). */ - theEvent =3D [[self window] currentEvent]; - emacs_event->kind =3D TOOL_BAR_EVENT; - XSETFRAME (emacs_event->arg, emacsframe); - EV_TRAILER (theEvent); - emacs_event->kind =3D TOOL_BAR_EVENT; /* XSETINT (emacs_event->code, 0); */ emacs_event->arg =3D AREF (emacsframe->tool_bar_items, From unknown Mon Jun 23 06:02:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39808: 28.0.50; toolbar broken Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2020 16:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39808 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: markusffm@fn.de Cc: Robert Pluim , 39808@debbugs.gnu.org Received: via spool by 39808-submit@debbugs.gnu.org id=B39808.15828216524211 (code B ref 39808); Thu, 27 Feb 2020 16:41:02 +0000 Received: (at 39808) by debbugs.gnu.org; 27 Feb 2020 16:40:52 +0000 Received: from localhost ([127.0.0.1]:60208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7MDU-00015r-01 for submit@debbugs.gnu.org; Thu, 27 Feb 2020 11:40:52 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7MDS-00015c-8o for 39808@debbugs.gnu.org; Thu, 27 Feb 2020 11:40:50 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9164444EE4B; Thu, 27 Feb 2020 11:40:44 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F12CD44EE48; Thu, 27 Feb 2020 11:40:42 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1582821642; bh=AEdoTwInk5hoICjF2/t+e68FpDRs9psviJzliNRn9ig=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=D/shCFTX7A6ZB5V3W0sCCSRpjlHpbV+MqjyrWqDQIhS6KhHpiyFRNJgdrLgKMDo+q zxH0O3URq+C4YP+dQ0TrYF6Ta7dtL3pjNS+A6YZQmGpTMB6kp/gJxLjVybyXQWiOpE pE/TuyOBRkc7LamY4J9knlIZPGYiVgAfXKOSXatpQpMLVxPTV88falHgxJyH3T+sgd pl1znwI5l8Vx/XSnQuoyxC3YksHcH3pSVcQuM3g3KcIlAUnH4T69sr8v0wya1e2hEe ssnlaTtLHWTcQdakG4UaIWnzE1LGEHte8nL1IQKEu1d1mEihzoSZBRYVbpRBtI4EY9 ALjIOF/ZrEdnQ== Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CEE2812072C; Thu, 27 Feb 2020 11:40:42 -0500 (EST) From: Stefan Monnier Message-ID: References: <20200227163456.GA1187539@INDRA> Date: Thu, 27 Feb 2020 11:40:42 -0500 In-Reply-To: <20200227163456.GA1187539@INDRA> (markusffm@fn.de's message of "Thu, 27 Feb 2020 17:34:56 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > why not committing your changes to our git repository? I don't understand what you mean. What's "our git repository"? As I wrote, I already installed the patch (in the `master` branch, in the emacs.git official repository). Stefan From unknown Mon Jun 23 06:02:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39808: 28.0.50; toolbar broken Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2020 16:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39808 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Markus FFM , 39808@debbugs.gnu.org Received: via spool by 39808-submit@debbugs.gnu.org id=B39808.15828218354582 (code B ref 39808); Thu, 27 Feb 2020 16:44:01 +0000 Received: (at 39808) by debbugs.gnu.org; 27 Feb 2020 16:43:55 +0000 Received: from localhost ([127.0.0.1]:60212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7MGR-0001Bq-Ga for submit@debbugs.gnu.org; Thu, 27 Feb 2020 11:43:55 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:35604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7MGQ-0001Be-LZ for 39808@debbugs.gnu.org; Thu, 27 Feb 2020 11:43:55 -0500 Received: by mail-wm1-f48.google.com with SMTP id m3so60466wmi.0 for <39808@debbugs.gnu.org>; Thu, 27 Feb 2020 08:43:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=KK9pkthyyhLgv/zHVEE/evudhIMXa6VOET6pmYDSp4Q=; b=OqcOC6PPuqbosPy706aKsAejhzzCDLgO0BL8IaMivRIXq1XjMIyfe3Bn17KdoGHh8d hLUezy1Yyq40EQJ+8ocgpc5UVI/Y51ZlHMX+WbhBd7xb9sEVd32E36+Xpapk6Qe+ynSB YosVJL1G6RkCi47DMUAA9ckNkD93UEG7y1Z5DC51VIgNA8U5mfjYp4SvnTNIGe1f6qP4 oTIC86fjRcQ7+fvvgAlOOSIiNsEb9Jai6T16WMadtpv5HKJEXnPnc+AjkaA94oomjJZK gpMAzcduAHkKRh6xDtkfaZsqRLQXbRQc83OrgsWaqg0L015m0obvq38mu3Xv2fV7EH2y LShw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=KK9pkthyyhLgv/zHVEE/evudhIMXa6VOET6pmYDSp4Q=; b=Qssa2nrZzK2yaNG6fPn54kPTHXV8Lbiu0BBsQKwwBzj83Y0ffpVnZQ+vKhmEKZdfpn qHPZg09+wyS1SaiFda1Oi6EZZ3VZcHnUzyxu9vONcIqFJrYxz+grxSk6riGEOcdp1v2V ox12bc6i9uuC+oiCW3zTrc4o60O3NSJ/DxMmQ4pg0JacDwNGSVwHz2fIb4Zq7FItfCbQ Wnvz5omXXovi9BtPD97coEabPt1DAP50WQui1a4WpQxNSazrv3Q7wkk1EDAXZT/g0CyS SrhE2j2GazzavIju0U27LVomBM0kVtDkaH0GQW/wgZNM1AimB93py5I5/3a3tVTAwFZe IZ7A== X-Gm-Message-State: APjAAAU6IG33+yDMeP5zZdFj/5/EBfsjxwFtVz4W7Ha9Q2rv0KCoHDrL ZS0iIEvctYBCesw7i8xc5pAgplOc8hY= X-Google-Smtp-Source: APXvYqwzB4G/Pdz/tUCCyG2RCReN07g63rsafomipoM6Qu3EsucFwtsV0XtWMEhc34fRXW0iY4Js7g== X-Received: by 2002:a05:600c:2042:: with SMTP id p2mr375708wmg.79.1582821828260; Thu, 27 Feb 2020 08:43:48 -0800 (PST) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id w8sm8494328wmm.0.2020.02.27.08.43.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 08:43:47 -0800 (PST) From: Robert Pluim References: Date: Thu, 27 Feb 2020 17:43:46 +0100 In-Reply-To: (Stefan Monnier's message of "Thu, 27 Feb 2020 11:19:53 -0500") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 27 Feb 2020 11:19:53 -0500, Stefan Monnier said: >> I=CA=BCve bisected this down to: >>=20 >> 3b4bd4be1dfa8717cb6911bd57c4c7d9d13614b4 >>=20 >> * 3b4bd4be1d (HEAD, refs/bisect/bad) * src/keyboard.c (make_lispy_ev= ent): >> Generate proper tool-bar events. >> | - Stefan Monnier Stefan> Looks like my grep-fu was very weak, indeed. The '.m' used by the NS files always trips me up. Stefan> I installed the patch below, which should hopefully fix the pro= blem for Stefan> Gtk and NS builds, That fixes it for GTK. For NS, the buffer does not get killed, and I get the following in the terminal: 2020-02-27 17:40:03.139 emacs[41579:935742] -[NSControlAuxiliary modifierFlags]: unrecognized selector sent to instance 0x7fd582c6c8c0 To be fair, it might have been doing this before: I never run with the tool bar. Robert From unknown Mon Jun 23 06:02:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39808: 28.0.50; toolbar broken Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2020 16:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39808 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Markus FFM , 39808@debbugs.gnu.org Received: via spool by 39808-submit@debbugs.gnu.org id=B39808.15828221655283 (code B ref 39808); Thu, 27 Feb 2020 16:50:02 +0000 Received: (at 39808) by debbugs.gnu.org; 27 Feb 2020 16:49:25 +0000 Received: from localhost ([127.0.0.1]:60216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7MLl-0001N9-4l for submit@debbugs.gnu.org; Thu, 27 Feb 2020 11:49:25 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:36054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7MLj-0001Mu-Gr for 39808@debbugs.gnu.org; Thu, 27 Feb 2020 11:49:24 -0500 Received: by mail-wm1-f53.google.com with SMTP id f19so78644wmh.1 for <39808@debbugs.gnu.org>; Thu, 27 Feb 2020 08:49:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=YMo7eSr18/o2IYgV4yp48mer4nVvESzx0ExTl8fZ95I=; b=lf1OArbKkX9l43zUdl5xlEaSKBfTbKlHtniwwZ2joeC09DPxC+zhZAPjgGPjj/YxkO I5ecnFUArf3FVpVfmMuQ2beYCcmLGc/JjhgeQdohyAm+vpObOaYrwMypFWL2EJu3xycT IYattoAyAdrsD/IF4HZ7eoyPj60Nq9HvPHY1MhxRxP7ZQTwOqh1kAzDGZOsSt22IuchG 72w8zwpUfWyuaftQqm7V6eCI4XKdoOYrFaOG9sSTq8tCJZ5e117qrRmD0NMjoNiPrfpd aX8MtOK6DwHAS30cLHkX2azPR0S6ybLkpGnPPOXX8C30dYm3gSPaeiaYen+6G9pTwGW9 WryQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=YMo7eSr18/o2IYgV4yp48mer4nVvESzx0ExTl8fZ95I=; b=X1djMuw6GTuFlMDNCViCPyX2GT2hyxJAdHyKxbba2AtXuWYPd2M3VlSIW0YLx/iumD enLoG750GK/MoWDcTBRCT3DCwV7c1oatBpkP1dGNufldwZw3kb652zSaMwdTgqxBw3/n vdCTsOlFMo6zU3mv443kIs/aJcKH2hs0p0fZ+nMJwADvpVX56DbSXI0x3IS9tjUyD6EU 1cw+uUyQpBvlt1EPI0JrSt/TRMYDa4AG/4Dp/XhzoIrj8ZnFz4j8D2GkXi15k5MqEguZ aWU5QDR9V99SWntX5iOPOHGCGoLu7rmtQ6s8gqmPttJdyT3EiP9Be5AJX30bTbkieBew FBzQ== X-Gm-Message-State: APjAAAU+aW+rMdrVDCSrlXSh8Mh3cxQy6ru+2iWgxqYiK6gdZV8DCfoI Ec2Z5Y5OxUcjXimqPmB3S1a5Swsr+h0= X-Google-Smtp-Source: APXvYqykWa/7K3cTVAOIogW1QnGXPiwXiG6Sgv/m1OX5uHpLKjae1ryAZeqvSL1nR7DNDB3KV+053w== X-Received: by 2002:a7b:c257:: with SMTP id b23mr411347wmj.70.1582822157188; Thu, 27 Feb 2020 08:49:17 -0800 (PST) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id h205sm8319896wmf.25.2020.02.27.08.49.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 08:49:16 -0800 (PST) From: Robert Pluim References: Date: Thu, 27 Feb 2020 17:49:15 +0100 In-Reply-To: (Robert Pluim's message of "Thu, 27 Feb 2020 17:43:46 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 27 Feb 2020 17:43:46 +0100, Robert Pluim s= aid: Robert> That fixes it for GTK. For NS, the buffer does not get killed, = and I Robert> get the following in the terminal: Robert> 2020-02-27 17:40:03.139 emacs[41579:935742] -[NSControlAuxiliary Robert> modifierFlags]: unrecognized selector sent to instance 0x7fd582= c6c8c0 Robert> To be fair, it might have been doing this before: I never run w= ith the Robert> tool bar. I think you were over-enthusiastic with your pruning, I put back the initialisation of theEvent, that fixes this (I=CA=BCm a bit pressed for time tonight, so can=CA=BCt commit it right now). diff --git a/src/nsterm.m b/src/nsterm.m index aefbb2721e..84acb61dcd 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -8185,6 +8185,7 @@ - (instancetype)toolbarClicked: (id)item if (!emacs_event) return self; =20 + theEvent =3D [[self window] currentEvent]; emacs_event->kind =3D TOOL_BAR_EVENT; /* XSETINT (emacs_event->code, 0); */ emacs_event->arg =3D AREF (emacsframe->tool_bar_items, From unknown Mon Jun 23 06:02:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39808: 28.0.50; toolbar broken Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2020 17:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39808 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: Markus FFM , 39808@debbugs.gnu.org Received: via spool by 39808-submit@debbugs.gnu.org id=B39808.158282484110299 (code B ref 39808); Thu, 27 Feb 2020 17:34:01 +0000 Received: (at 39808) by debbugs.gnu.org; 27 Feb 2020 17:34:01 +0000 Received: from localhost ([127.0.0.1]:60235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7N2v-0002g3-75 for submit@debbugs.gnu.org; Thu, 27 Feb 2020 12:34:01 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:40635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7N2s-0002fn-Rn for 39808@debbugs.gnu.org; Thu, 27 Feb 2020 12:33:59 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 506A1100ECB; Thu, 27 Feb 2020 12:33:53 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 672F0100E87; Thu, 27 Feb 2020 12:33:51 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1582824831; bh=Bp6viMeJx5FHyUJgrEagsCEnTWrJjoKLkCGi1+Mqo0E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Z3uJKeHKdfIcxNvI7YVg0kPvUnHW2eVYWbks0XGbtjKRuYRyudu5d+kqYA1g5muvr D8QKJFRV4U7+Yw1snYHd4MbLQ1NEJ0Q6z6SwGp8dePTtlhSKgci0xt+ROaQUxnUDsH EVZyzAXv81kf70qdqDRfEY60qS5yRWWE+IlX8bJv2tSTScWfqmVEIBImiwhppDKEGk KxG3PMO7fbya3PIiIcNd7NgQHhGnl6dGCfRv7FGnJ/loIhD0az9Xjlj99lL24Vaklb +g0xsqtGlMx0RIyzVNLM27Mb8M75qLrtB92A2sqjT7Y14P5k4fhl51ybM7uiLPwU3M JYStQ8s5naqDw== Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 420CC120230; Thu, 27 Feb 2020 12:33:51 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Thu, 27 Feb 2020 12:33:50 -0500 In-Reply-To: (Robert Pluim's message of "Thu, 27 Feb 2020 17:43:46 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Stefan> Looks like my grep-fu was very weak, indeed. > The '.m' used by the NS files always trips me up. Yes, that's the regular weakness. But in the present case I also missed the occurrence in the gtkutil.c file. I have no idea how that happened. > Stefan> I installed the patch below, which should hopefully fix > Stefan> the problem for Gtk and NS builds, > > That fixes it for GTK. For NS, the buffer does not get killed, and I > get the following in the terminal: [...] > I think you were over-enthusiastic with your pruning, I put back the > initialisation of theEvent, that fixes this (I=CA=BCm a bit pressed for > time tonight, so can=CA=BCt commit it right now). Thanks, I pushed it for you, Stefan From unknown Mon Jun 23 06:02:19 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: markusffm@fn.de Subject: bug#39808: closed (Re: bug#39808: 28.0.50; toolbar broken) Message-ID: References: X-Gnu-PR-Message: they-closed 39808 X-Gnu-PR-Package: emacs Reply-To: 39808@debbugs.gnu.org Date: Thu, 27 Feb 2020 19:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1582830782-21662-1" This is a multi-part message in MIME format... ------------=_1582830782-21662-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #39808: 28.0.50; toolbar broken which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 39808@debbugs.gnu.org. --=20 39808: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D39808 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1582830782-21662-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 39808-done) by debbugs.gnu.org; 27 Feb 2020 19:12:46 +0000 Received: from localhost ([127.0.0.1]:60270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7OaU-0005cp-Ho for submit@debbugs.gnu.org; Thu, 27 Feb 2020 14:12:46 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7OaS-0005cZ-2o for 39808-done@debbugs.gnu.org; Thu, 27 Feb 2020 14:12:45 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3EF8A85DA9; Thu, 27 Feb 2020 14:12:38 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5BB30814E0; Thu, 27 Feb 2020 14:12:36 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1582830756; bh=8uIQuJcyptuYxOa13v7MUHI2NWmyXn8rn8PzqVzwtAw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=EiQ3apacW0Ocku3DnzTtDPiL9TutK4g3azySSScK5mpmTrM5VqNofAOfntjPep/cC xYze0/t4yGL8kXLwhE9+jEjGgTWZFyepMumPsiJimwdMVhdsz5KWGdiTrldkwOIdmS O3sIIc7Rnsi+AAJsL37Ng87xL+zCh9aIp7hUSVhlLcJp55diDO0hhoou4RmIvhSISK 5nHUOdxbuo6SQbtdFxHmDxEKLUlnjC0BDs0w/qyda+C08zILWHxks1KYMXe0FVLyjt lWv1ktwJ11PlR0wlk2OfokUAnMKut4p5bpSYxj8lhMqFyBxz3lj5nqQMQXozgv8axV rK+shCwW1mhJA== Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 38BD712024D; Thu, 27 Feb 2020 14:12:36 -0500 (EST) From: Stefan Monnier To: markusffm@fn.de Subject: Re: bug#39808: 28.0.50; toolbar broken Message-ID: References: <20200227184358.GA1206030@INDRA> Date: Thu, 27 Feb 2020 14:12:35 -0500 In-Reply-To: <20200227184358.GA1206030@INDRA> (markusffm@fn.de's message of "Thu, 27 Feb 2020 19:43:58 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.110 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39808-done Cc: 39808-done@debbugs.gnu.org, Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > thanks a lot Stefan. It works perfectly! Thank you for the confirmation. Closing, Stefan ------------=_1582830782-21662-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Feb 2020 12:33:13 +0000 Received: from localhost ([127.0.0.1]:58809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7ILo-0006HM-T7 for submit@debbugs.gnu.org; Thu, 27 Feb 2020 07:33:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:38665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j7ILn-0006HF-W1 for submit@debbugs.gnu.org; Thu, 27 Feb 2020 07:33:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38546) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7ILm-0001By-5U for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 07:33:11 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7ILk-0004um-Ee for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 07:33:09 -0500 Received: from mout3.freenet.de ([2001:748:100:40::2:5]:47868) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j7ILk-0004lm-8W for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 07:33:08 -0500 Received: from [195.4.92.163] (helo=mjail0.freenet.de) by mout3.freenet.de with esmtpa (ID markusffm@fn.de) (port 25) (Exim 4.92 #3) id 1j7ILf-0005eq-45 for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 13:33:03 +0100 Received: from [::1] (port=54624 helo=mjail0.freenet.de) by mjail0.freenet.de with esmtpa (ID markusffm@fn.de) (Exim 4.92 #3) id 1j7ILf-0003gU-3D for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 13:33:03 +0100 Received: from sub7.freenet.de ([195.4.92.126]:36882) by mjail0.freenet.de with esmtpa (ID markusffm@fn.de) (Exim 4.92 #3) id 1j7IIl-0002f7-8x for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 13:30:03 +0100 Received: from p5dd1c653.dip0.t-ipconnect.de ([93.209.198.83]:37638 helo=localhost.localdomain) by sub7.freenet.de with esmtpsa (ID markusffm@fn.de) (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256) (port 465) (Exim 4.92 #3) id 1j7IIl-0001je-5s for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2020 13:30:03 +0100 From: Markus FFM To: bug-gnu-emacs@gnu.org Subject: 28.0.50; toolbar broken Date: Thu, 27 Feb 2020 13:30:02 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Originated-At: 93.209.198.83!37638 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:748:100:40::2:5 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: markusffm@fn.de Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) emacs -Q Toolbar: Discard (kill) current buffer Wrong type argument: symbolp, # same with all other toolbar items In GNU Emacs 28.0.50 (build 15, x86_64-pc-linux-gnu, GTK+ Version 3.24.13, cairo version 1.16.0) of 2020-01-22 built on INDRA Repository revision: 5715eb94e90b33ace59dd4c4ccb6e2122bc6db72 Repository branch: master System Description: Fedora 31 (Thirty One) Recent messages: >>>activated: get rid of auto-revert-verbosity<<< >>>loaded: GNU Emacs 28.0.50 of 2020-01-22<<< >>>load time: Thursday, February 27, 2020 13:27:29<<< >>>activated: themes<<< Desktop: 3 buffers restored, 1 to restore lazily. For information about GNU Emacs and the GNU system, type C-M-h C-a. Desktop lazily opening mem_log (1 remaining)...done Lazy desktop load complete Making completion list... [4 times] user-error: End of history; no default available [2 times] Configured using: 'configure --prefix=/opt/emacs --sysconfdir=/etc --enable-locallisppath=/usr/local/share/emacs/site-lisp --libexecdir=/opt/emacs/lib/ --localstatedir=/usr/local/var --enable-largefile --with-x-toolkit=gtk3 --with-modules --with-xwidgets --without-pop --without-selinux --without-gnutls --with-file-notification=yes --with-json --with-cairo 'CFLAGS=-march=native -Os'' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD JSON PDUMPER GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Info Minor modes in effect: show-paren-mode: t recentf-mode: t desktop-save-mode: 1 delete-selection-mode: t cua-mode: t global-hl-line-mode: t gpm-mouse-mode: t savehist-mode: t global-auto-revert-mode: t auto-insert-mode: t smooth-scroll-mode: t global-undo-tree-mode: t undo-tree-mode: t save-place-mode: t tooltip-mode: t global-eldoc-mode: t electric-quote-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t global-prettify-symbols-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t size-indication-mode: t column-number-mode: t line-number-mode: t global-visual-line-mode: t visual-line-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired-sort-menu dired dired-loaddefs rfc822 mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cursor-sensor term/linux user-profile powerline powerline-separators powerline-themes server default-profile default-ui paren man recentf sh-script smie executable vc-dispatcher vc-svn enriched mule-util jka-compr info desktop frameset avoid default-faces default-keymap delsel cua-base default-run default-restart default-modes default-platform default-nw hl-line t-mouse default-unix default-flymake default-flymake-go default-flymake-csharp default-flymake-ruby default-flymake-js default-flymake-py default-flymake-java default-flymake-shell flymake-proc flymake compile warnings default-run-assoc run-assoc default-tempo default-tempo-rexx default-tempo-sh default-tempo-pas default-tempo-js default-tempo-java default-tempo-perl default-tempo-elisp default-tempo-c-cpp default-menu default-help default-options default-tools default-search default-format default-view aquamacs-cmm-menu default-edit default-file default-generic savehist autorevert filenotify autoinsert default-functions default-autoload ox-man ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar ox-html table ox-ascii ox-publish ox org-element org ob ob-tangle ob-ref ob-lob ob-table org-macro org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-color ring org-list org-faces org-entities time-date org-version ob-emacs-lisp org-table org-keys org-loaddefs find-func cal-menu calendar cal-loaddefs avl-tree generator ol ob-exp ob-core org-compat ob-eval org-macs format-spec markdown-mode rx color thingatpt noutline outline easy-mmode jison-mode bison-mode cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs flex-mode derived aquamacs-tabbar cus-start cus-load aquamacs-tools tabbar restore-last-frame-size org-bullets syslog-mode hide-lines web-mode disp-table vimrc-mode go-autocomplete go-mode-autoloads neotree advice smooth-scroll aok fill-column-indicator tempbuf auto-complete-config auto-complete edmacro kmacro popup undo-tree diff multi-shell windata tree-mode tree-widget wid-edit imenu imenu-tree tempo saveplace google-translate google-translate-default-ui google-translate-core-ui ido google-translate-core google-translate-tk google-translate-backend url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs cl-loaddefs cl-lib password-cache url-vars mailcap json subr-x map seq byte-opt gv bytecomp byte-compile cconv eol-conversion easymenu default-path tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting xwidget-internal cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 253383 185135) (symbols 48 26324 10) (strings 32 90935 29593) (string-bytes 1 2893472) (vectors 16 35482) (vector-slots 8 389169 203210) (floats 8 284 1433) (intervals 56 2505 232) (buffers 1000 16)) ------------=_1582830782-21662-1--