GNU bug report logs - #39764
[PATCH] IBM Z DFLTCC: add STREQ definition

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ilya Leoshkevich <iii <at> linux.ibm.com>
To: bug-gzip <at> gnu.org
Cc: Jim Meyering <meyering <at> fb.com>
Subject: Re: [PATCH] IBM Z DFLTCC: add STREQ definition
Date: Fri, 29 May 2020 12:22:39 +0200

On Mon, 2020-02-24 at 10:36 +0100, Ilya Leoshkevich wrote:
> Commit 81c9fe4d0986 replaced !strcmp with STREQ in order to be
> compliant
> with the gnulib linter, however, gnulib does not provide STREQ!
> 
> Quite a few gnulib .c files contain private definitions of STREQ.
> This
> patch just goes with the flow and does the same in dfltcc.c.
> ---
>  dfltcc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/dfltcc.c b/dfltcc.c
> index 1d6d74c..432c68c 100644
> --- a/dfltcc.c
> +++ b/dfltcc.c
> @@ -72,6 +72,8 @@ typedef enum
>  
>  #define MAX(a, b) ((a) > (b) ? (a) : (b))
>  
> +#define STREQ(a, b) (strcmp (a, b) == 0)
> +
>  struct dfltcc_qaf_param
>  {
>    char fns[16];

Gentle ping.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.