GNU bug report logs - #39764
[PATCH] IBM Z DFLTCC: add STREQ definition

Previous Next

Full log

Message #13 received at 39764-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Ilya Leoshkevich <iii <at> linux.ibm.com>
Cc: Jim Meyering <meyering <at> fb.com>, 39764-done <at> debbugs.gnu.org
Subject: Re: bug#39764: [PATCH] IBM Z DFLTCC: add STREQ definition
Date: Fri, 29 May 2020 08:51:11 -0700

On Fri, May 29, 2020 at 3:23 AM Ilya Leoshkevich <iii <at> linux.ibm.com> wrote:
>
> On Mon, 2020-02-24 at 10:36 +0100, Ilya Leoshkevich wrote:
> > Commit 81c9fe4d0986 replaced !strcmp with STREQ in order to be
> > compliant
> > with the gnulib linter, however, gnulib does not provide STREQ!
> >
> > Quite a few gnulib .c files contain private definitions of STREQ.
> > This
> > patch just goes with the flow and does the same in dfltcc.c.
> > ---
> >  dfltcc.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/dfltcc.c b/dfltcc.c
> > index 1d6d74c..432c68c 100644
> > --- a/dfltcc.c
> > +++ b/dfltcc.c
> > @@ -72,6 +72,8 @@ typedef enum
> >
> >  #define MAX(a, b) ((a) > (b) ? (a) : (b))
> >
> > +#define STREQ(a, b) (strcmp (a, b) == 0)
> > +
> >  struct dfltcc_qaf_param
> >  {
> >    char fns[16];
>
> Gentle ping.

Thank you. Strangely, it seems I never received your original email.
I got a copy from https://bugs.gnu.org/39764 and pushed it.
I note that there *is* an identical definition of strequ in gzip.c,
but I prefer the STREQ spelling and don't want to change gzip.c to
address this problem.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.