From unknown Thu Aug 14 18:37:15 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#39764 <39764@debbugs.gnu.org> To: bug#39764 <39764@debbugs.gnu.org> Subject: Status: [PATCH] IBM Z DFLTCC: add STREQ definition Reply-To: bug#39764 <39764@debbugs.gnu.org> Date: Fri, 15 Aug 2025 01:37:15 +0000 retitle 39764 [PATCH] IBM Z DFLTCC: add STREQ definition reassign 39764 gzip submitter 39764 Ilya Leoshkevich severity 39764 normal tag 39764 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 24 04:37:07 2020 Received: (at submit) by debbugs.gnu.org; 24 Feb 2020 09:37:07 +0000 Received: from localhost ([127.0.0.1]:52889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j6AAl-0004Cz-2r for submit@debbugs.gnu.org; Mon, 24 Feb 2020 04:37:07 -0500 Received: from lists.gnu.org ([209.51.188.17]:41985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j6AAj-0004Cs-Nh for submit@debbugs.gnu.org; Mon, 24 Feb 2020 04:37:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36570) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6AAi-0007Qs-KI for bug-gzip@gnu.org; Mon, 24 Feb 2020 04:37:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6AAh-0003VH-F4 for bug-gzip@gnu.org; Mon, 24 Feb 2020 04:37:04 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:7666 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6AAh-0003Ts-Ap for bug-gzip@gnu.org; Mon, 24 Feb 2020 04:37:03 -0500 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01O9TbW4130145 for ; Mon, 24 Feb 2020 04:37:02 -0500 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2yax4466fu-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 24 Feb 2020 04:37:01 -0500 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 24 Feb 2020 09:37:00 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 24 Feb 2020 09:36:57 -0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 01O9atgB54657032 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Feb 2020 09:36:56 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D82C042049; Mon, 24 Feb 2020 09:36:55 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B6A3A42047; Mon, 24 Feb 2020 09:36:55 +0000 (GMT) Received: from t35lp56.lnxne.boe (unknown [9.152.108.100]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 24 Feb 2020 09:36:55 +0000 (GMT) From: Ilya Leoshkevich To: bug-gzip@gnu.org Subject: [PATCH] IBM Z DFLTCC: add STREQ definition Date: Mon, 24 Feb 2020 10:36:50 +0100 X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 20022409-0008-0000-0000-00000355DD3D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20022409-0009-0000-0000-00004A76F51D Message-Id: <20200224093650.2566188-1-iii@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-02-24_02:2020-02-21, 2020-02-24 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 mlxlogscore=976 suspectscore=1 spamscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 malwarescore=0 phishscore=0 bulkscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002240082 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.158.5 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit Cc: Ilya Leoshkevich X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Commit 81c9fe4d0986 replaced !strcmp with STREQ in order to be compliant with the gnulib linter, however, gnulib does not provide STREQ! Quite a few gnulib .c files contain private definitions of STREQ. This patch just goes with the flow and does the same in dfltcc.c. --- dfltcc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dfltcc.c b/dfltcc.c index 1d6d74c..432c68c 100644 --- a/dfltcc.c +++ b/dfltcc.c @@ -72,6 +72,8 @@ typedef enum #define MAX(a, b) ((a) > (b) ? (a) : (b)) +#define STREQ(a, b) (strcmp (a, b) == 0) + struct dfltcc_qaf_param { char fns[16]; -- 2.23.0 From debbugs-submit-bounces@debbugs.gnu.org Fri May 29 06:22:52 2020 Received: (at submit) by debbugs.gnu.org; 29 May 2020 10:22:52 +0000 Received: from localhost ([127.0.0.1]:53883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jecA8-0004bG-9G for submit@debbugs.gnu.org; Fri, 29 May 2020 06:22:52 -0400 Received: from lists.gnu.org ([209.51.188.17]:44902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jecA6-0004b8-EZ for submit@debbugs.gnu.org; Fri, 29 May 2020 06:22:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jecA5-0007Fi-H1 for bug-gzip@gnu.org; Fri, 29 May 2020 06:22:50 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:15214) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jecA4-0008Gq-67 for bug-gzip@gnu.org; Fri, 29 May 2020 06:22:49 -0400 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04TA3CdO103861; Fri, 29 May 2020 06:22:44 -0400 Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com with ESMTP id 31as1au9jb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 May 2020 06:22:43 -0400 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 04TALicT021848; Fri, 29 May 2020 10:22:42 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma01fra.de.ibm.com with ESMTP id 316uf8mtd9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 May 2020 10:22:42 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 04TAMeau57999440 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 May 2020 10:22:40 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E2EB152050; Fri, 29 May 2020 10:22:39 +0000 (GMT) Received: from sig-9-145-4-150.uk.ibm.com (unknown [9.145.4.150]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id AD85552057; Fri, 29 May 2020 10:22:39 +0000 (GMT) Message-ID: Subject: Re: [PATCH] IBM Z DFLTCC: add STREQ definition From: Ilya Leoshkevich To: bug-gzip@gnu.org Date: Fri, 29 May 2020 12:22:39 +0200 In-Reply-To: <20200224093650.2566188-1-iii@linux.ibm.com> References: <20200224093650.2566188-1-iii@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-05-29_02:2020-05-28, 2020-05-29 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=992 priorityscore=1501 spamscore=0 mlxscore=0 suspectscore=5 malwarescore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 phishscore=0 clxscore=1011 impostorscore=0 cotscore=-2147483648 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005290080 Received-SPF: pass client-ip=148.163.158.5; envelope-from=iii@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/29 06:22:45 X-ACL-Warn: Detected OS = Linux 3.1-3.10 X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, KHOP_DYNAMIC=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Jim Meyering X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On Mon, 2020-02-24 at 10:36 +0100, Ilya Leoshkevich wrote: > Commit 81c9fe4d0986 replaced !strcmp with STREQ in order to be > compliant > with the gnulib linter, however, gnulib does not provide STREQ! > > Quite a few gnulib .c files contain private definitions of STREQ. > This > patch just goes with the flow and does the same in dfltcc.c. > --- > dfltcc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dfltcc.c b/dfltcc.c > index 1d6d74c..432c68c 100644 > --- a/dfltcc.c > +++ b/dfltcc.c > @@ -72,6 +72,8 @@ typedef enum > > #define MAX(a, b) ((a) > (b) ? (a) : (b)) > > +#define STREQ(a, b) (strcmp (a, b) == 0) > + > struct dfltcc_qaf_param > { > char fns[16]; Gentle ping. From debbugs-submit-bounces@debbugs.gnu.org Fri May 29 11:51:31 2020 Received: (at 39764-done) by debbugs.gnu.org; 29 May 2020 15:51:31 +0000 Received: from localhost ([127.0.0.1]:55864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jehIB-0000uj-Ed for submit@debbugs.gnu.org; Fri, 29 May 2020 11:51:31 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:34660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jehI9-0000uS-5J for 39764-done@debbugs.gnu.org; Fri, 29 May 2020 11:51:29 -0400 Received: by mail-wr1-f65.google.com with SMTP id r7so4283546wro.1 for <39764-done@debbugs.gnu.org>; Fri, 29 May 2020 08:51:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J1FlKqyuU5udITsaBVFavlQWFqmTurbM0W5QdroBtsY=; b=q5OTBuKnKBT42XY216EA5Rm1euGsX+7hT5cqG/mZ15uMD95OlUAcvjSvAauJCWxTV+ zKwLzHS0yUme8CcjsSQ2Awnhnc/G8W/ulOLAYOEDc/2R71g7Vb9BVVG7jOC8VlVZg8R6 YCiCHNuegja/lZGMmOTp5tAuurfuOQc2FIPHCfIm3H1GGQtrmaQ3wxaZO76HMSYsuYk+ Ll01OqkMEhhzaXaRFbxiuKlaIzFu/yfcTMpN39kvQIUCHiQMwpRMSqk7a5XNwm6h2xf+ XL3HrSarYh8YmGMMWVnRoiQo2F2x1Y4ESgIdyiYdU4y8SJqkzAMfW4h9Jhvfc9fbvdah Cknw== X-Gm-Message-State: AOAM530D0VCq2o5yI9E5Ys97bQfKb5/z2ypRqVak1KXdlhPykEEHex5T 7UzE3Aei7u+3Ryc6FKzU7CHHPverNnEZc9VVBt0= X-Google-Smtp-Source: ABdhPJxe/1jfHWLEK1jy2i8/xhAvIuegpSe7/ZnvltD990r0RQIfvozQpSQFryizl9ut8KmfZ/infwYfxhJy+hHLWMI= X-Received: by 2002:a05:6000:87:: with SMTP id m7mr9418703wrx.306.1590767483338; Fri, 29 May 2020 08:51:23 -0700 (PDT) MIME-Version: 1.0 References: <20200224093650.2566188-1-iii@linux.ibm.com> In-Reply-To: From: Jim Meyering Date: Fri, 29 May 2020 08:51:11 -0700 Message-ID: Subject: Re: bug#39764: [PATCH] IBM Z DFLTCC: add STREQ definition To: Ilya Leoshkevich Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 39764-done Cc: Jim Meyering , 39764-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Fri, May 29, 2020 at 3:23 AM Ilya Leoshkevich wrote: > > On Mon, 2020-02-24 at 10:36 +0100, Ilya Leoshkevich wrote: > > Commit 81c9fe4d0986 replaced !strcmp with STREQ in order to be > > compliant > > with the gnulib linter, however, gnulib does not provide STREQ! > > > > Quite a few gnulib .c files contain private definitions of STREQ. > > This > > patch just goes with the flow and does the same in dfltcc.c. > > --- > > dfltcc.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/dfltcc.c b/dfltcc.c > > index 1d6d74c..432c68c 100644 > > --- a/dfltcc.c > > +++ b/dfltcc.c > > @@ -72,6 +72,8 @@ typedef enum > > > > #define MAX(a, b) ((a) > (b) ? (a) : (b)) > > > > +#define STREQ(a, b) (strcmp (a, b) == 0) > > + > > struct dfltcc_qaf_param > > { > > char fns[16]; > > Gentle ping. Thank you. Strangely, it seems I never received your original email. I got a copy from https://bugs.gnu.org/39764 and pushed it. I note that there *is* an identical definition of strequ in gzip.c, but I prefer the STREQ spelling and don't want to change gzip.c to address this problem. From unknown Thu Aug 14 18:37:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 27 Jun 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator