GNU bug report logs - #39754
[PATCH] gnu: z3: Build the Python bindings

Previous Next

Package: guix-patches;

Reported by: Jakub Kądziołka <kuba <at> kadziolka.net>

Date: Sun, 23 Feb 2020 15:14:02 UTC

Severity: normal

Tags: patch

Done: Jakub Kądziołka <kuba <at> kadziolka.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: 39754 <at> debbugs.gnu.org
Subject: [bug#39754] [PATCH v2] gnu: z3: Build the Python bindings
Date: Sun, 23 Feb 2020 17:48:48 +0100
Hi!

Jakub Kądziołka <kuba <at> kadziolka.net> skribis:

> * gnu/packages/maths.scm (z3)[arguments]: Add the --python and
>   --pypkgdir flags to configure.

Could you also mention the addition of #:modules and #:imported-modules?

> Changed the #:modules argument to only import site-packages from (guix
> build python-build-system) as, as Ludo' pointed out on IRC, it also
> exports %standard-phases, which could conflict with (guix build
> gnu-build-system).
>
> I considered putting the Python bindings in a separate output; I decided not to
> do so as this change increases `guix size z3' from 116.4 MiB to 117.5
> MiB, which is barely noticeable.

Makes sense to me.

LGTM, thanks!

Ludo’.




This bug report was last modified 5 years and 148 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.