From unknown Sun Jun 22 00:54:18 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3975: 23.1; Line height too small with Monaco font on Mac OS X Reply-To: Francis Devereux , 3975@debbugs.gnu.org Resent-From: Francis Devereux Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 30 Jul 2009 09:30:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 3975 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.124894575813167 (code B ref -1); Thu, 30 Jul 2009 09:30:06 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 30 Jul 2009 09:22:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA,FVGT_m_MULTI_ODD autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6U9MUDi013161 for ; Thu, 30 Jul 2009 02:22:32 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWRqH-0001Rn-V5 for bug-gnu-emacs@gnu.org; Thu, 30 Jul 2009 05:22:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWRqD-0001Px-8S for bug-gnu-emacs@gnu.org; Thu, 30 Jul 2009 05:22:29 -0400 Received: from [199.232.76.173] (port=60368 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWRqD-0001Po-0w for bug-gnu-emacs@gnu.org; Thu, 30 Jul 2009 05:22:25 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:61713) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWRqC-0006O0-Dz for bug-gnu-emacs@gnu.org; Thu, 30 Jul 2009 05:22:24 -0400 Received: from [192.168.1.127] (1.2.mediacentre.org [212.42.168.9]) by mrelayeu.kundenserver.de (node=mrelayeu4) with ESMTP (Nemesis) id 0ML21M-1MWRq93SGr-0000pC; Thu, 30 Jul 2009 11:22:22 +0200 Message-Id: <21E71ACF-2CE4-4637-9EF8-71060D547653@devrx.org> From: Francis Devereux To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Thu, 30 Jul 2009 10:22:20 +0100 X-Mailer: Apple Mail (2.935.3) X-Provags-ID: V01U2FsdGVkX1+vFqTUtc4wfZbLuiLF71mocNa4hx9lbY3zHnZ Nr2JvNijTkGaFN/kSLUWI2XzHbR9u1ZUJ15onOBYZWUPndmOnt uhmeuCE4nq26xH0DtF3YA== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. On Mac OS X the line height is too small when the Monaco font is used. This causes, for example, the bottom of ( and ) characters to be clipped. Emacs 22.3 (Carbon port) works OK with this font. Steps to reproduce: 1) Run nextstep/Emacs.app/Contents/MacOS/Emacs -q & 2) Switch to the *scratch* buffer 3) Evaluate (setq default-frame-alist (cons '(font . "-apple-monaco- medium-r-normal--10-100-72-72-m-100-mac-roman") default-frame-alist)) 4) Type C-x 5 2 to open a new window 5) Type ()() to see the problem I have uploaded a screenshot showing the problem to http://www.devrx.org/emacs/emacs-23-osx-font-problem.png Francis In GNU Emacs 23.1.1 (i386-apple-darwin9.7.0, NS apple-appkit-949.46) of 2009-07-30 on spaceman.local Windowing system distributor `Apple', version 10.3.949 configured using `configure '--with-ns'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_GB.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-x b * s c C-y C-x C-e C-x 5 2 ( s e t q SPC C-y C-y ) C-a C-d C-a C-d C-d C-e C-x C-e ' C-a ' ' C-x C-e C-g C-e C-x C-e C-e C-a C-d C-d C-e C-a C-d C-d C-e C-x C-e M-x C-g C-x 5 2 M-x r e p o r t - e m Recent messages: ((font . "-apple-monaco-medium-r-normal--10-100-72-72-m-100-mac- roman") (tool-bar-lines . 0) (menu-bar-lines . 1)) byte-code: Beginning of buffer Mark set [4 times] Entering debugger... (ns-antialias-text nil) Quit Entering debugger... meta Quit goto-history-element: Beginning of history; no preceding item From unknown Sun Jun 22 00:54:18 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3975: 23.1; [PATCH] Line height too small with Monaco font on Mac OS X Reply-To: Francis Devereux , 3975@debbugs.gnu.org Resent-From: Francis Devereux Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 30 Jul 2009 23:00:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3975 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3975-submit@emacsbugs.donarmstrong.com id=B3975.124899468413814 (code B ref 3975); Thu, 30 Jul 2009 23:00:04 +0000 Received: (at 3975) by emacsbugs.donarmstrong.com; 30 Jul 2009 22:58:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,SPF_HELO_PASS autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.186]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6UMvvwj013800 for <3975@emacsbugs.donarmstrong.com>; Thu, 30 Jul 2009 15:57:59 -0700 Received: from jupiter-wifi.repton.int (93-97-163-71.zone5.bethere.co.uk [93.97.163.71]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0MKv5w-1MWeZL0Ffk-000cLs; Fri, 31 Jul 2009 00:57:51 +0200 Message-Id: From: Francis Devereux To: 3975@debbugs.gnu.org In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Date: Thu, 30 Jul 2009 23:57:49 +0100 References: <21E71ACF-2CE4-4637-9EF8-71060D547653@devrx.org> X-Mailer: Apple Mail (2.935.3) X-Provags-ID: V01U2FsdGVkX1/sq3+g8dqqZ2/g0v2osCXBS+tJ502n1wBCTTo BNwNy9Uem1KxPbo2gShOT/NU/V54pcixx4opAZBhjZvPo2Lkw7 E2TslBIqU1l2ZvucnPpLQ== I have done some investigating into this bug and found a fix. The problem was being caused by [sfont descender] returning -2.5, which was being rounded to -2 by the lrint on line 807 of nsfont.c: -lrint (hshrink* [sfont descender] - expand*hd/2); The following patch fixes the problem: --- src/nsfont.m~ 2009-07-30 00:39:40.000000000 +0100 +++ src/nsfont.m 2009-07-30 23:41:56.000000000 +0100 @@ -803,8 +803,11 @@ /* max bounds */ font_info->max_bounds.ascent = lrint (hshrink * [sfont ascender] + expand * hd/2); + /* [sfont descender] is usually negative, so we use floor to round + towards the integer with the greater magnitude so that we don't clip + any descenders. */ font_info->max_bounds.descent = - -lrint (hshrink* [sfont descender] - expand*hd/2); + -lrint (floor(hshrink* [sfont descender] - expand*hd/2)); font_info->height = font_info->max_bounds.ascent + font_info->max_bounds.descent; font_info->max_bounds.width = lrint (font_info->width); @@ -839,8 +842,8 @@ #endif /* set up metrics portion of font struct */ - font->ascent = [sfont ascender]; - font->descent = -[sfont descender]; + font->ascent = lrint([sfont ascender]); + font->descent = -lrint(floor([sfont descender])); font->min_width = [sfont widthOfString: @"|"]; /* FIXME */ font->space_width = lrint (ns_char_width (sfont, ' ')); font->average_width = lrint (font_info->width); The second hunk does not actually seem to be necessary, but I added it for consistency. I think that this patch may also fix bug 3961 (Incorrect font height on Mac OS X). Francis From jasonrumney@gmail.com Sat Aug 1 01:57:36 2009 Received: (at control) by emacsbugs.donarmstrong.com; 1 Aug 2009 08:57:37 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.6 required=4.0 tests=AWL,ONEWORD,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-pz0-f198.google.com (mail-pz0-f198.google.com [209.85.222.198]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n718vXGZ027619 for ; Sat, 1 Aug 2009 01:57:34 -0700 Received: by pzk36 with SMTP id 36so1074581pzk.13 for ; Sat, 01 Aug 2009 01:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:received:message-id :date:from:user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=EaARBEqaoXOdvcperubWOtchSzaSgRDU/AojukKXdgQ=; b=ENrBZSKY/TYjrO8tZ/IUWl9bPXUszVDBQaPS9r6BzGR1qjI8VIMqJit4ibauZp4X6B CH3u89LfyGMaIPhTNBSqUv7G9SFV7o+5inX7B0j6a1eJhNhR/A5Mxs1Y+sKnnsnRPJqm i8cjn0HPgK00NAqS2CbfLhsMfZWgDhfvgbnzY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; b=bitQA+yldz5PIzoeoX+4V1TtE4qUsC7qUjShbV6TZRQwGyHsXHrQvKh/hSJfNsMgyj 8fFvVtj+rGnW4TRovD22iqiXij8nf4Xrw9MLSm3REK8UUBLvWt+JSvrfiwlpoT7eeis9 8n11j2/gKRmP0waSL5P+ANRxIv1WejT6i8+zk= Received: by 10.114.180.16 with SMTP id c16mr5165011waf.57.1249117047847; Sat, 01 Aug 2009 01:57:27 -0700 (PDT) Received: from wanchan.jasonrumney.net ([118.101.136.103]) by mx.google.com with ESMTPS id c26sm6843198waa.50.2009.08.01.01.57.26 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 01 Aug 2009 01:57:27 -0700 (PDT) Sender: Jason Rumney Received: from wanchan.jasonrumney.net (localhost [127.0.0.1]) by wanchan.jasonrumney.net (Postfix) with ESMTP id 6B14B787 for ; Sat, 1 Aug 2009 16:57:23 +0800 (MYT) Message-ID: <4A740372.7070600@gnu.org> Date: Sat, 01 Aug 2009 16:57:22 +0800 From: Jason Rumney User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: Re: housekeeping References: <4A730C27.80402@gnu.org> In-Reply-To: <4A730C27.80402@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit reassign 3975 emacs,ns reassign 2836 emacs,ns reassign 3961 emacs,ns reassign 3986 emacs,ns merge 3975 2836 3961 3986 From unknown Sun Jun 22 00:54:18 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#3975: Line height too small with Monaco font on Mac OS X Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2010 23:45:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 3975 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: To: Leo Cc: francis@devrx.org, 3975@debbugs.gnu.org, emacs-devel@gnu.org Received: via spool by 3975-submit@debbugs.gnu.org id=B3975.126567264315374 (code B ref 3975); Mon, 08 Feb 2010 23:45:02 +0000 Received: (at 3975) by debbugs.gnu.org; 8 Feb 2010 23:44:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NedGt-0003zv-HI for submit@debbugs.gnu.org; Mon, 08 Feb 2010 18:44:03 -0500 Received: from pantheon-po25.its.yale.edu ([130.132.50.119]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NedGs-0003zY-85 for 3975@debbugs.gnu.org; Mon, 08 Feb 2010 18:44:02 -0500 Received: from furry (bb116-15-9-83.singnet.com.sg [116.15.9.83]) (authenticated bits=0) by pantheon-po25.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o18Nhtbr016133 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 8 Feb 2010 18:43:57 -0500 Received: by furry (Postfix, from userid 1000) id A9A7DC05D; Mon, 8 Feb 2010 18:43:54 -0500 (EST) From: Chong Yidong References: <256A1330-5C0B-4F54-926E-83C95923067D@devrx.org> Date: Mon, 08 Feb 2010 18:43:54 -0500 In-Reply-To: (Leo's message of "Mon, 08 Feb 2010 20:16:36 +0000") Message-ID: <874olrz41x.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Leo writes: > On 2010-02-08 11:10 +0000, Francis Devereux wrote: >> A few months ago I tried out Emacs 23.1 on Mac OS X, and found that >> the line height was too small when using the Monaco font (some >> characters are clipped at the bottom, including ()[]). I downloaded >> and compiled Emacs 23.1.92 today and found that it still has the same >> problem. >> >> Could someone have a look at the patch I added to >> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3975 >> and apply it if it looks OK? > > No wonder I always feel a bit weird using monaco. I have moved to DejaVu > Sans Mono and it is looking better. > > Patch is attached to bug #3975. Maybe someone can review it? I've reviewed the patch, and it looks ok. I've checked it in, could you test it? From unknown Sun Jun 22 00:54:18 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#3975: Line height too small with Monaco font on Mac OS X In-Reply-To: <21E71ACF-2CE4-4637-9EF8-71060D547653@devrx.org> Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Feb 2010 02:29:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 3975 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.126568253923332 (code B ref -1); Tue, 09 Feb 2010 02:29:02 +0000 Received: (at submit) by debbugs.gnu.org; 9 Feb 2010 02:28:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NefqV-00064H-I3 for submit@debbugs.gnu.org; Mon, 08 Feb 2010 21:28:59 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NefqS-000648-FL for submit@debbugs.gnu.org; Mon, 08 Feb 2010 21:28:57 -0500 Received: from mail.gnu.org ([199.232.76.166]:37891 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NefqO-00077h-TY for submit@debbugs.gnu.org; Mon, 08 Feb 2010 21:28:53 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NefqN-0002It-OQ for submit@debbugs.gnu.org; Mon, 08 Feb 2010 21:28:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00, UNPARSEABLE_RELAY autolearn=ham version=3.1.0 Received: from lists.gnu.org ([199.232.76.165]:46495) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NefqN-0002In-H8 for submit@debbugs.gnu.org; Mon, 08 Feb 2010 21:28:51 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NefqN-0000ze-7g for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2010 21:28:51 -0500 Received: from [199.232.76.173] (port=34812 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NefqM-0000zW-Rl for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2010 21:28:50 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NefqL-0002IV-B9 for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2010 21:28:50 -0500 Received: from lo.gmane.org ([80.91.229.12]:43147) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NefqK-0002II-Ti for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2010 21:28:49 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1NefqG-0003xe-KJ for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2010 03:28:44 +0100 Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 09 Feb 2010 03:28:44 +0100 Received: from sdl.web by smaug.linux.pwf.cam.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 09 Feb 2010 03:28:44 +0100 X-Injected-Via-Gmane: http://gmane.org/ From: Leo Date: Tue, 09 Feb 2010 02:28:22 +0000 Organization: University of Cambridge Lines: 13 Message-ID: References: <256A1330-5C0B-4F54-926E-83C95923067D@devrx.org> <874olrz41x.fsf__39616.9249354445$1265673156$gmane$org@stupidchicken.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: smaug.linux.pwf.cam.ac.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:c7GJncDafe5xE5WkSLeqF2d53Rw= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) On 2010-02-08 23:43 +0000, Chong Yidong wrote: >> No wonder I always feel a bit weird using monaco. I have moved to >> DejaVu Sans Mono and it is looking better. >> >> Patch is attached to bug #3975. Maybe someone can review it? > > I've reviewed the patch, and it looks ok. I've checked it in, could > you test it? Unfortunately it is a bit awkward for me to test it now as I no longer use the ns port and the font but maybe someone else can test it. Leo From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 09 20:24:18 2010 Received: (at control) by debbugs.gnu.org; 10 Feb 2010 01:24:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nf1JS-0005Ug-3h for submit@debbugs.gnu.org; Tue, 09 Feb 2010 20:24:18 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nf1JQ-0005UX-Up for control@debbugs.gnu.org; Tue, 09 Feb 2010 20:24:17 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1Nf1JN-00085U-AM; Tue, 09 Feb 2010 20:24:13 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19314.2749.266539.846565@fencepost.gnu.org> Date: Tue, 9 Feb 2010 20:24:13 -0500 From: Glenn Morris To: control Subject: control X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) reassign 5521 emacs,erc tags 3975 moreinfo reassign 5542 emacs,ns reassign 5547 emacs,gnus reassign 5554 emacs,rmail severity 5554 wishlist From unknown Sun Jun 22 00:54:18 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#3975: Line height too small with Monaco font on Mac OS X Resent-From: Francis Devereux Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Feb 2010 14:21:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 3975 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: moreinfo To: Chong Yidong Cc: Leo , 3975@debbugs.gnu.org, emacs-devel@gnu.org Received: via spool by 3975-submit@debbugs.gnu.org id=B3975.126589800526778 (code B ref 3975); Thu, 11 Feb 2010 14:21:02 +0000 Received: (at 3975) by debbugs.gnu.org; 11 Feb 2010 14:20:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NfZtl-0006xq-7I for submit@debbugs.gnu.org; Thu, 11 Feb 2010 09:20:05 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NfZNB-0006Uh-1O for 3975@debbugs.gnu.org; Thu, 11 Feb 2010 08:46:26 -0500 Received: from [192.168.1.100] (1.2.mediacentre.org [212.42.168.9]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0Mhekt-1NKTsb1iuR-00MJk4; Thu, 11 Feb 2010 14:45:51 +0100 Message-Id: From: Francis Devereux In-Reply-To: <874olrz41x.fsf@stupidchicken.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Date: Thu, 11 Feb 2010 13:45:49 +0000 References: <256A1330-5C0B-4F54-926E-83C95923067D@devrx.org> <874olrz41x.fsf@stupidchicken.com> X-Mailer: Apple Mail (2.936) X-Provags-ID: V01U2FsdGVkX1+6Rbx0+SEljXAoP3e9nwvGQ7a4KiDNjfKae9l 6yS79G4QmCIR6NwKiIjqCNEMgIAdvwnLYrAvB3RJiql8P82UfI fnv+/KuTKeBXZv5A5WgaQ== X-Spam-Score: -2.6 (--) X-Mailman-Approved-At: Thu, 11 Feb 2010 09:20:04 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 8 Feb 2010, at 23:43, Chong Yidong wrote: > Leo writes: > >> On 2010-02-08 11:10 +0000, Francis Devereux wrote: >>> A few months ago I tried out Emacs 23.1 on Mac OS X, and found that >>> the line height was too small when using the Monaco font (some >>> characters are clipped at the bottom, including ()[]). I downloaded >>> and compiled Emacs 23.1.92 today and found that it still has the >>> same >>> problem. >>> >>> Could someone have a look at the patch I added to >>> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3975 >>> and apply it if it looks OK? >> >> No wonder I always feel a bit weird using monaco. I have moved to >> DejaVu >> Sans Mono and it is looking better. >> >> Patch is attached to bug #3975. Maybe someone can review it? > > I've reviewed the patch, and it looks ok. I've checked it in, could > you > test it? Thanks, I've tested bzr trunk r99485 and the bug is fixed there. Francis From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 12 09:39:34 2010 Received: (at control) by debbugs.gnu.org; 12 Feb 2010 14:39:34 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nfwg9-0007rF-S7 for submit@debbugs.gnu.org; Fri, 12 Feb 2010 09:39:34 -0500 Received: from pantheon-po35.its.yale.edu ([130.132.50.83]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nfwfv-0007r5-GD for control@debbugs.gnu.org; Fri, 12 Feb 2010 09:39:32 -0500 Received: from furry (bb116-15-9-83.singnet.com.sg [116.15.9.83]) (authenticated bits=0) by pantheon-po35.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o1CEdEQM021734 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Fri, 12 Feb 2010 09:39:16 -0500 Received: by furry (Postfix, from userid 1000) id 5E9B1C05D; Fri, 12 Feb 2010 09:39:11 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 3975 Date: Fri, 12 Feb 2010 09:39:11 -0500 Message-ID: <87mxze5xio.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) close 3975 thanks