From unknown Wed Sep 10 09:28:53 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#39725 <39725@debbugs.gnu.org> To: bug#39725 <39725@debbugs.gnu.org> Subject: Status: /gnu/store/.links: base16 or base32? Reply-To: bug#39725 <39725@debbugs.gnu.org> Date: Wed, 10 Sep 2025 16:28:53 +0000 retitle 39725 /gnu/store/.links: base16 or base32? reassign 39725 guix submitter 39725 Ludovic Court=C3=A8s severity 39725 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 21 16:51:41 2020 Received: (at submit) by debbugs.gnu.org; 21 Feb 2020 21:51:41 +0000 Received: from localhost ([127.0.0.1]:48284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5GCy-0006Xs-NY for submit@debbugs.gnu.org; Fri, 21 Feb 2020 16:51:40 -0500 Received: from lists.gnu.org ([209.51.188.17]:52526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5GCx-0006Xk-9l for submit@debbugs.gnu.org; Fri, 21 Feb 2020 16:51:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37096) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5GCw-00063j-5s for bug-Guix@gnu.org; Fri, 21 Feb 2020 16:51:39 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j5GCw-0006ki-2Z for bug-Guix@gnu.org; Fri, 21 Feb 2020 16:51:38 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=40430 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j5GCn-0004bq-Uy for bug-Guix@gnu.org; Fri, 21 Feb 2020 16:51:36 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: bug-Guix@gnu.org Subject: /gnu/store/.links: base16 or base32? X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 3 =?utf-8?Q?Vent=C3=B4se?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 21 Feb 2020 22:51:28 +0100 Message-ID: <87h7zj1ue7.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Seen while stracing guix-daemon during GC (the =E2=80=9Cdeleting unused lin= ks=E2=80=9D phase): --8<---------------cut here---------------start------------->8--- unlink("/gnu/store/.links/3a16c555c7c60f9c781895eec65a31a04a6cc535fff5a3814= 99c1a4717d8f19f") =3D 0 unlink("/gnu/store/.links/1mm1n1xmjb1in2sv71kpa90n5iv30h24blzfj4z0icdssbly1= 9kh") =3D 0 unlink("/gnu/store/.links/4213e7fe3db934f2817fbd0fb3a74e5395736fcc7633d295c= 557462cae88f945") =3D 0 unlink("/gnu/store/.links/1g46q6yf868x7wfqnzcy4rb8r780bqi986vjvb1n7xm4ln3ji= zzf") =3D 0 unlink("/gnu/store/.links/8b261f0461a89419ee4436d11ac828fc63a4d8d6473696262= d020c17758964eb") =3D 0 unlink("/gnu/store/.links/0znm2gdxraz3i88r3iy838d86s1zfidx8gga4kwiqcsnmaz20= 6d6") =3D 0 unlink("/gnu/store/.links/f3fe1645f86a6a1effd8e4f0dfcdaef8d73c8163c96d2b2cb= 42e0bd7c05d9b5b") =3D 0 unlink("/gnu/store/.links/69a86d84c31d5b728f6d7496413bac8a0bc06c388255f0b81= 868066463cff80f") =3D 0 unlink("/gnu/store/.links/0s0bb4pkm282srrdm61fd0lf9zn7r85s370llbp616pk4j2sz= khs") =3D 0 unlink("/gnu/store/.links/a2b0c70e4c03f3247250155d4a2cfdf6a21e03458f892f4c2= a9ba861259022f6") =3D 0 unlink("/gnu/store/.links/5faebd1dc60adbf32b430090a29248b86c56eba4805aeedc8= d99c459a28b34eb") =3D 0 unlink("/gnu/store/.links/8d7d77f86a32f2a0a36b508dcbdc4a44c61dec284b9dc6299= a8b7d18db9938dc") =3D 0 unlink("/gnu/store/.links/1cjlcwkyr59apcym97zaw8r2m4ahqc11zrm51aqzvwg3b0xvc= hhw") =3D 0 unlink("/gnu/store/.links/0z9cw4h1p4cm6jp4zap9db1lh60i0ynal0dxd2f8ilzp085wb= 1xj") =3D 0 unlink("/gnu/store/.links/1vzgxm1png21gf13v5ac3494h9zshy6y35cxk38pf6dd0qimc= and") =3D 0 unlink("/gnu/store/.links/1r8xm4j57m9h99rvv80q2wgv29p3q42ws4s2f0c3jd9a77hl2= qn8") =3D 0 --8<---------------cut here---------------end--------------->8--- There=E2=80=99s an inconsistency here! (guix store deduplication) uses base16, but optimize-store.cc does: /* Check if this is a known hash. */ Path linkPath =3D linksDir + "/" + printHash32(hash); =E2=80=A6 where =E2=80=98printHash32=E2=80=99 returns a nix-base32 string. = Oops! The effect is just that deduplication wouldn=E2=80=99t work as well as it c= ould: results from offloaded builds would be deduplicated among them but not against other store items. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 21 19:00:53 2020 Received: (at 39725-done) by debbugs.gnu.org; 22 Feb 2020 00:00:53 +0000 Received: from localhost ([127.0.0.1]:48445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5IDy-0001c3-4E for submit@debbugs.gnu.org; Fri, 21 Feb 2020 19:00:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5IDt-0001bj-By for 39725-done@debbugs.gnu.org; Fri, 21 Feb 2020 19:00:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j5IDo-0003dI-66 for 39725-done@debbugs.gnu.org; Fri, 21 Feb 2020 19:00:40 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=41504 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j5IDZ-0005EG-30 for 39725-done@debbugs.gnu.org; Fri, 21 Feb 2020 19:00:38 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: 39725-done@debbugs.gnu.org Subject: Re: bug#39725: /gnu/store/.links: base16 or base32? References: <87h7zj1ue7.fsf@inria.fr> Date: Sat, 22 Feb 2020 01:00:23 +0100 In-Reply-To: <87h7zj1ue7.fsf@inria.fr> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22\?\= \=\?utf-8\?Q\?'s\?\= message of "Fri, 21 Feb 2020 22:51:28 +0100") Message-ID: <87o8trze20.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39725-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Ludovic Court=C3=A8s skribis: > (guix store deduplication) uses base16, but optimize-store.cc does: > > /* Check if this is a known hash. */ > Path linkPath =3D linksDir + "/" + printHash32(hash); > > =E2=80=A6 where =E2=80=98printHash32=E2=80=99 returns a nix-base32 string= . Oops! Fixed in 4cb63a564d413c745983a608790a943ac07f8d67. From unknown Wed Sep 10 09:28:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 21 Mar 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator