From unknown Tue Jun 17 20:28:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#3971 <3971@debbugs.gnu.org> To: bug#3971 <3971@debbugs.gnu.org> Subject: Status: 23.1.50; linum-mode kills right margin Reply-To: bug#3971 <3971@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:28:45 +0000 retitle 3971 23.1.50; linum-mode kills right margin reassign 3971 emacs submitter 3971 Lennart Borgman severity 3971 normal thanks From lennart.borgman@gmail.com Wed Jul 29 21:38:33 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 30 Jul 2009 04:38:33 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.8 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6U4cS1N007257 for ; Wed, 29 Jul 2009 21:38:30 -0700 Received: from mx10.gnu.org ([199.232.76.166]:46098) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MWNPQ-0006ru-4K for emacs-pretest-bug@gnu.org; Thu, 30 Jul 2009 00:38:28 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MWNPP-00022T-Ax for emacs-pretest-bug@gnu.org; Thu, 30 Jul 2009 00:38:28 -0400 Received: from mail-yw0-f184.google.com ([209.85.211.184]:33132) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWNPO-000229-Ui for emacs-pretest-bug@gnu.org; Thu, 30 Jul 2009 00:38:27 -0400 Received: by ywh14 with SMTP id 14so397658ywh.1 for ; Wed, 29 Jul 2009 21:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=F7b5y4jJcTLi2JLQAl7142ZDi5dbzkP38Z4oSL96AaQ=; b=RWB87u3yMB13JdFnKZesrOmgrihmklCltvEhap7m7Ec+DIWJ57qdEvoR7+ZB1TrrZx 13LBCatSbwwnf/Bwe1/T5elFh+SqUxu3mi3uURouxvXUlVp9fY+eG99ksPxr5Dn9RJ+l RkSbEaBRG4Jc5HkCoCEqJagMtBn52i8648hk4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=w0m+olgpL2YbeK91acJ4TJjRZOJ5Jmgv20y8MsbExUHCZE1XYoV06YzdcNA1e5I1Hw +K0OcNp8Hx7o95gGdDU+iOFg2p6HooeDpSX/Vwy23imwE8Z+ypYsIgDiB/Shqqn5+0k7 xGr2rA4IS1RbpAataWQgLtqueO1d7O3R6VslI= MIME-Version: 1.0 Received: by 10.100.172.16 with SMTP id u16mr954032ane.85.1248928706454; Wed, 29 Jul 2009 21:38:26 -0700 (PDT) Date: Thu, 30 Jul 2009 06:38:26 +0200 Message-ID: Subject: 23.1.50; linum-mode kills right margin From: Lennart Borgman To: emacs-pretest-bug@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) linum-mode kills the right margin. It should not touch it since it does not use it. The following patch fixes this: Index: linum.el =================================================================== RCS file: /sources/emacs/emacs/lisp/linum.el,v retrieving revision 1.11 diff -c -b -r1.11 linum.el *** linum.el 18 Jan 2009 01:45:38 -0000 1.11 --- linum.el 30 Jul 2009 04:35:10 -0000 *************** *** 108,114 **** (mapc #'delete-overlay linum-overlays) (setq linum-overlays nil) (dolist (w (get-buffer-window-list (current-buffer) nil t)) ! (set-window-margins w 0))) (defun linum-update-current () "Update line numbers for the current buffer." --- 108,114 ---- (mapc #'delete-overlay linum-overlays) (setq linum-overlays nil) (dolist (w (get-buffer-window-list (current-buffer) nil t)) ! (set-window-margins w 0 (cdr (window-margins w))))) (defun linum-update-current () "Update line numbers for the current buffer." *************** *** 163,169 **** (overlay-put ov 'linum-str str)))) (forward-line) (setq line (1+ line))) ! (set-window-margins win width))) (defun linum-after-change (beg end len) ;; update overlays on deletions, and after newlines are inserted --- 163,169 ---- (overlay-put ov 'linum-str str)))) (forward-line) (setq line (1+ line))) ! (set-window-margins win width (cdr (window-margins win))))) (defun linum-after-change (beg end len) ;; update overlays on deletions, and after newlines are inserted In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600) of 2009-06-30 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' From lennart.borgman@gmail.com Wed Jul 29 22:24:35 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 30 Jul 2009 05:24:35 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.8 required=4.0 tests=AWL,GMAIL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6U5OUba012591 for ; Wed, 29 Jul 2009 22:24:31 -0700 Received: from mail.gnu.org ([199.232.76.166]:54135 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MWO7y-0008DU-3r for emacs-pretest-bug@gnu.org; Thu, 30 Jul 2009 01:24:30 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MWO7w-0002xW-MC for emacs-pretest-bug@gnu.org; Thu, 30 Jul 2009 01:24:29 -0400 Received: from an-out-0708.google.com ([209.85.132.247]:15122) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWO7w-0002xQ-EF for emacs-pretest-bug@gnu.org; Thu, 30 Jul 2009 01:24:28 -0400 Received: by an-out-0708.google.com with SMTP id b6so1231809ana.21 for ; Wed, 29 Jul 2009 22:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=euHVKw3MI4nnjSiNF9J/ptsF4Mjfj0B5HPv32A2CvCQ=; b=CeA0nKmpiNYZZUolbBlJd3/6UHh7/mrvE/y4hofuChWRnzF6vk81qX3w4oA2+aMObm YYQ30WdnDZYAVltaxpxh+E/yejQS66/oUNsg4CJOvrX3ju8Xze/xwYi4LKQ4UqgPenDY 6g2NUnWszmPwfNzbhBi/kubkawiK6fJlo7Mmw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=I2+QruELZ84SOgJ0TJnqF6yK5WOmeexQXb3YFjuX1ukAJP+bs69eBsb8eV+3ZtLW6T KEUjIJrkj8OAH/luuxdM67BH1hvkvYmRZDX8or0JVAwJ6fxDtyr5EK7Wrlk+imS/hPmN ShHMzLBSiz6KezFcV6UtkOHcL3V+fZoDD7DBk= MIME-Version: 1.0 Received: by 10.100.254.12 with SMTP id b12mr1030996ani.24.1248931467840; Wed, 29 Jul 2009 22:24:27 -0700 (PDT) In-Reply-To: References: Date: Thu, 30 Jul 2009 07:24:27 +0200 Message-ID: Subject: Re: bug#3971: 23.1.50; linum-mode kills right margin From: Lennart Borgman To: emacs-pretest-bug@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Or, maybe it is better to redefine set-window-margins so that a nil argument for a margin means "don't touch"...? On Thu, Jul 30, 2009 at 6:38 AM, Lennart Borgman wrote: > linum-mode kills the right margin. It should not touch it since it > does not use it. The following patch fixes this: > > Index: linum.el > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /sources/emacs/emacs/lisp/linum.el,v > retrieving revision 1.11 > diff -c -b -r1.11 linum.el > *** linum.el =C2=A0 =C2=A018 Jan 2009 01:45:38 -0000 =C2=A0 =C2=A0 =C2=A0= 1.11 > --- linum.el =C2=A0 =C2=A030 Jul 2009 04:35:10 -0000 > *************** > *** 108,114 **** > =C2=A0 =C2=A0(mapc #'delete-overlay linum-overlays) > =C2=A0 =C2=A0(setq linum-overlays nil) > =C2=A0 =C2=A0(dolist (w (get-buffer-window-list (current-buffer) nil t)) > ! =C2=A0 =C2=A0 (set-window-margins w 0))) > > =C2=A0(defun linum-update-current () > =C2=A0 =C2=A0"Update line numbers for the current buffer." > --- 108,114 ---- > =C2=A0 =C2=A0(mapc #'delete-overlay linum-overlays) > =C2=A0 =C2=A0(setq linum-overlays nil) > =C2=A0 =C2=A0(dolist (w (get-buffer-window-list (current-buffer) nil t)) > ! =C2=A0 =C2=A0 (set-window-margins w 0 (cdr (window-margins w))))) > > =C2=A0(defun linum-update-current () > =C2=A0 =C2=A0"Update line numbers for the current buffer." > *************** > *** 163,169 **** > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(overlay-put ov 'linum-st= r str)))) > =C2=A0 =C2=A0 =C2=A0 =C2=A0(forward-line) > =C2=A0 =C2=A0 =C2=A0 =C2=A0(setq line (1+ line))) > ! =C2=A0 =C2=A0 (set-window-margins win width))) > > =C2=A0(defun linum-after-change (beg end len) > =C2=A0 =C2=A0;; update overlays on deletions, and after newlines are inse= rted > --- 163,169 ---- > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(overlay-put ov 'linum-st= r str)))) > =C2=A0 =C2=A0 =C2=A0 =C2=A0(forward-line) > =C2=A0 =C2=A0 =C2=A0 =C2=A0(setq line (1+ line))) > ! =C2=A0 =C2=A0 (set-window-margins win width (cdr (window-margins win)))= )) > > =C2=A0(defun linum-after-change (beg end len) > =C2=A0 =C2=A0;; update overlays on deletions, and after newlines are inse= rted > > > > In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600) > =C2=A0of 2009-06-30 > Windowing system distributor `Microsoft Corp.', version 5.1.2600 > configured using `configure --with-gcc (3.4) --no-opt --cflags > -Ic:/g/include -fno-crossjumping' > > > > From lekktu@gmail.com Mon Sep 21 17:10:12 2009 Received: (at 3971-done) by emacsbugs.donarmstrong.com; 22 Sep 2009 00:10:12 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,GMAIL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f207.google.com (mail-fx0-f207.google.com [209.85.220.207]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8M0AAfQ018562 for <3971-done@emacsbugs.donarmstrong.com>; Mon, 21 Sep 2009 17:10:11 -0700 Received: by fxm3 with SMTP id 3so2548179fxm.44 for <3971-done@emacsbugs.donarmstrong.com>; Mon, 21 Sep 2009 17:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=L/XlwED4BzzVx431opB60fZlWSgkmlEdQ+4Wov+cQoM=; b=VMWfPPBTeQStoMaPUEzHZyKYeCIJCXt2Q0I80pOjeeMPGxHvC+BnTDqOin2UDe8ApX aDljMeDkc/8w9bAdGP4ai4pZ+gDXb6NljAEgRjTeTYENuuqv0A04lDtdWsohCG9uYg4W plY9YnYmFIz7t5ZhMn5bcY0pb9KhI9kkRuQrc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=SUawPpNXsECJhtdmTFOTq3uUjyfBdc80XzUgyjFqi8pbxc7L9EMZ4/2vwlz+lpVCjQ F9t7Cw+IgTI37N4CxkoWg0XbY9e7Wd+F20TAOQ7N8O3qcew+2hqNgMuvUpxygqV0NtGo 3f21X2HhHzQ7yozGPG91jyZBYvyoDAyOqVbis= MIME-Version: 1.0 Received: by 10.239.145.34 with SMTP id q34mr23216hba.124.1253578203102; Mon, 21 Sep 2009 17:10:03 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Tue, 22 Sep 2009 02:09:43 +0200 Message-ID: Subject: Re: bug#3971: 23.1.50; linum-mode kills right margin To: Lennart Borgman Cc: 3971-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 On Thu, Jul 30, 2009 at 07:24, Lennart Borgman wrote: > Or, maybe it is better to redefine set-window-margins so that a nil > argument for a margin means "don't touch"...? I think that would be cleaner, because 0 is already available to set a margin to "no margin". But that's an interface change, so for now I've installed your change, which fixes the bug. Juanma From lennart.borgman@gmail.com Tue Sep 22 00:58:18 2009 Received: (at 3971-done) by emacsbugs.donarmstrong.com; 22 Sep 2009 07:58:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.8 required=4.0 tests=AWL,GMAIL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.242]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8M7wHTZ024205 for <3971-done@emacsbugs.donarmstrong.com>; Tue, 22 Sep 2009 00:58:18 -0700 Received: by an-out-0708.google.com with SMTP id b2so1709374ana.31 for <3971-done@emacsbugs.donarmstrong.com>; Tue, 22 Sep 2009 00:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=TvYmCgS62c0hpR7tcxj8syuvnrdEkiaJ0MOedxWT6Fo=; b=I8dQkqF1UUeekARsTHIybmlGw3YBsPAM8o4PKmBh6N24mJjKjxgUR6GmPnW3Tr6sI8 6csAzG3keY05CTVAwVfCHk/2xAvDoKWdq/kdelsLpj9BDvKGKuBkKoc7b/A2GCxSOUNy pVR41Qg5x6L2EVgDt0cqPwah84g7JIEgIhfbA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=sqhP90Mel80wdKFTzd0zUpCXHSWSZ+LyzL/WNCYT3jQiVl2OQmFrpd6UPwMDsK+n81 l/aXCZQJMySqNP3y6zksUt7K24LyHpeK3lxEuJ/SgoI38wbjuDFNICS9kfDTrYhRXy7C NP7atMu+WQsuKAzCNZz2d5oxqhuXhBxvpKxhE= MIME-Version: 1.0 Received: by 10.100.246.14 with SMTP id t14mr629321anh.176.1253606297115; Tue, 22 Sep 2009 00:58:17 -0700 (PDT) In-Reply-To: References: From: Lennart Borgman Date: Tue, 22 Sep 2009 09:57:57 +0200 Message-ID: Subject: Re: bug#3971: 23.1.50; linum-mode kills right margin To: Juanma Barranquero Cc: 3971-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 On Tue, Sep 22, 2009 at 2:09 AM, Juanma Barranquero wrote: > On Thu, Jul 30, 2009 at 07:24, Lennart Borgman > wrote: > >> Or, maybe it is better to redefine set-window-margins so that a nil >> argument for a margin means "don't touch"...? > > I think that would be cleaner, because 0 is already available to set a > margin to "no margin". > > But that's an interface change, so for now I've installed your change, > which fixes the bug. Thanks. From unknown Tue Jun 17 20:28:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 20 Oct 2009 14:24:11 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator