GNU bug report logs - #39709
28.0.50; [PATCH] substring and the byte compiler

Previous Next

Package: emacs;

Reported by: Mark Oteiza <mvoteiza <at> udel.edu>

Date: Fri, 21 Feb 2020 06:23:02 UTC

Severity: normal

Tags: patch

Found in version 28.0.50

Done: Mattias Engdegård <mattiase <at> acm.org>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 39709 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattiase <at> acm.org>
To: Mark Oteiza <mvoteiza <at> udel.edu>
Cc: 39709 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: #39709: 28.0.50; [PATCH] substring and the byte compiler
Date: Fri, 21 Feb 2020 12:48:01 +0100

[Message part 1 (text/plain, inline)]
The missing 1-3 case seems to be a simple omission -- thanks for spotting it.

+(defun byte-compile-one-to-three-args (form)
+  (let ((len (length form)))
+    (cond ((= len 2) (byte-compile-one-arg form))
+          ((= len 3) (byte-compile-two-args form))
+          ((= len 4) (byte-compile-three-args form))
+	  (t (byte-compile-subr-wrong-args form "1-3")))))

Not sure how this would work. Don't you need to add the missing arguments?

Cleaned-up patch attached.
(Unless, of course, there is evidence that the byte op has never been emitted --- then we have an opportunity to drop it instead.)


[0001-Generate-substring-byte-op-bug-39709.patch (application/octet-stream, attachment)]
This bug report was last modified 5 years and 125 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.