From unknown Thu Sep 11 16:06:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39705: 28.0.50; mode-line-process in comint-redirect-setup Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Feb 2020 00:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39705 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 39705@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158224384019931 (code B ref -1); Fri, 21 Feb 2020 00:11:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Feb 2020 00:10:40 +0000 Received: from localhost ([127.0.0.1]:46122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4vtw-0005BP-Er for submit@debbugs.gnu.org; Thu, 20 Feb 2020 19:10:40 -0500 Received: from lists.gnu.org ([209.51.188.17]:43286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4vtv-0005BI-4M for submit@debbugs.gnu.org; Thu, 20 Feb 2020 19:10:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60971) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4vtt-00083l-Un for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 19:10:39 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4vtt-0007EQ-0c for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 19:10:37 -0500 Received: from crocodile.birch.relay.mailchannels.net ([23.83.209.45]:36938) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j4vts-0007Dh-Mv for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 19:10:36 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 285D65409E0 for ; Fri, 21 Feb 2020 00:10:35 +0000 (UTC) Received: from pdx1-sub0-mail-a86.g.dreamhost.com (100-96-1-6.trex.outbound.svc.cluster.local [100.96.1.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 8E1F7540960 for ; Fri, 21 Feb 2020 00:10:34 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a86.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Fri, 21 Feb 2020 00:10:35 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Zesty-Stupid: 61fef9a1615972ac_1582243834968_1621445824 X-MC-Loop-Signature: 1582243834968:2268816763 X-MC-Ingress-Time: 1582243834968 Received: from pdx1-sub0-mail-a86.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a86.g.dreamhost.com (Postfix) with ESMTP id 9375A7F000 for ; Thu, 20 Feb 2020 16:10:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:date:message-id:mime-version:content-type; s= linkov.net; bh=0GENmMdr1PZJVhjaPKRsu4v2pps=; b=Bylp6KAp9OHKych+E mvVppj9oaGy5dGvI5XG9PtKaBQugBoOSgYXhz0Te8xg8oqRQZvPM9pobR3eiPISi QSxAbRtyJCcSIAp1Zl59Fie1BHP7kAWRn7D6Qk44cqr/geI8QwnGr3h+HtT+4PvF 8heXMkJ/8Ylbjagfh+HZFP/n/g= Received: from localhost.linkov.net (m91-129-103-27.cust.tele2.ee [91.129.103.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a86.g.dreamhost.com (Postfix) with ESMTPSA id 72CEA7F003 for ; Thu, 20 Feb 2020 16:10:30 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a86 From: Juri Linkov Organization: LINKOV.NET Date: Fri, 21 Feb 2020 01:45:36 +0200 Message-ID: <87pne8g6vz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrkeefgddvtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhofffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucffohhmrghinhepghhmrghnvgdrohhrghenucfkphepledurdduvdelrddutdefrddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehlohgtrghlhhhoshhtrdhlihhnkhhovhdrnhgvthdpihhnvghtpeeluddruddvledruddtfedrvdejpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepsghughdqghhnuhdqvghmrggtshesghhnuhdrohhrgh X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 23.83.209.45 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Tags: patch I customized mode-line-process to highlight its status with a color (add-hook 'comint-mode-hook (lambda () (require 'compile) (setq mode-line-process '(:propertize ":%s" face compilation-mode-line-fail)))) as was recommended in http://thread.gmane.org/gmane.emacs.devel/153647/focus=153682 But comint.el signals an error because it expects mode-line-process to be in its default value. I don't know how to make mode-line customization to be less brittle, but at least this case can be fixed by: diff --git a/lisp/comint.el b/lisp/comint.el index 5c521ff0fd..ea06f8af87 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -3641,7 +3641,7 @@ comint-redirect-setup (setq-local comint-redirect-previous-input-string "") (setq mode-line-process - (if mode-line-process + (if (and mode-line-process (stringp (elt mode-line-process 0))) (list (concat (elt mode-line-process 0) " Redirection")) (list ":%s Redirection"))))) From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 24 19:41:48 2020 Received: (at control) by debbugs.gnu.org; 25 Feb 2020 00:41:48 +0000 Received: from localhost ([127.0.0.1]:54275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j6OIF-00043C-O2 for submit@debbugs.gnu.org; Mon, 24 Feb 2020 19:41:47 -0500 Received: from fossa.birch.relay.mailchannels.net ([23.83.209.62]:34382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j6OID-000433-Nq for control@debbugs.gnu.org; Mon, 24 Feb 2020 19:41:46 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 6A97D502426 for ; Tue, 25 Feb 2020 00:41:44 +0000 (UTC) Received: from pdx1-sub0-mail-a13.g.dreamhost.com (100-96-219-27.trex.outbound.svc.cluster.local [100.96.219.27]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 28BEB501D45 for ; Tue, 25 Feb 2020 00:41:44 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a13.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Tue, 25 Feb 2020 00:41:44 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Lyrical-Trouble: 74717cce78195303_1582591304210_342511190 X-MC-Loop-Signature: 1582591304210:649021359 X-MC-Ingress-Time: 1582591304210 Received: from pdx1-sub0-mail-a13.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a13.g.dreamhost.com (Postfix) with ESMTP id 537798D856 for ; Mon, 24 Feb 2020 16:41:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=xa3IGtkPqlhktUYSTn6kxGWAVWE=; b= gwezETWp0vYql8lc0klFMcvIvkfDaNwC6KuufitNFO5HUGOrcNV3f54Qmv5AkKXX newRFNFudvg/vcAZsm1Ei7ENQG23JpLIQDCbg1LVL6fBuimPD9qGRI/iNKOkWyiB Wt1ivpy+5ZCl1lRAE4fAxqEUHsuB7tOzkgf7cFAI3Uc= Received: from localhost.linkov.net (m91-129-103-27.cust.tele2.ee [91.129.103.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a13.g.dreamhost.com (Postfix) with ESMTPSA id 3DA4A8CF3F for ; Mon, 24 Feb 2020 16:41:41 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a13 From: Juri Linkov To: control@debbugs.gnu.org Subject: Re: bug#39705: 28.0.50; mode-line-process in comint-redirect-setup Organization: LINKOV.NET References: <87pne8g6vz.fsf@mail.linkov.net> Date: Tue, 25 Feb 2020 02:22:47 +0200 In-Reply-To: <87pne8g6vz.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 21 Feb 2020 01:45:36 +0200") Message-ID: <87lfory0q0.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrledugddvhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehlohgtrghlhhhoshhtrdhlihhnkhhovhdrnhgvthdpihhnvghtpeeluddruddvledruddtfedrvdejpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtoheptghonhhtrhholhesuggvsggsuhhgshdrghhnuhdrohhrgh X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 39705 fixed close 39705 28.0.50 quit