From unknown Thu Sep 11 18:07:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39704: 28.0.50; vc-print-branch-log data loss Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Feb 2020 00:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39704 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 39704@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158224383519913 (code B ref -1); Fri, 21 Feb 2020 00:11:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Feb 2020 00:10:35 +0000 Received: from localhost ([127.0.0.1]:46119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4vtr-0005B7-73 for submit@debbugs.gnu.org; Thu, 20 Feb 2020 19:10:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:43003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4vtp-0005B0-Ra for submit@debbugs.gnu.org; Thu, 20 Feb 2020 19:10:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60958) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4vto-00082v-Qs for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 19:10:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05, RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4vtn-0007A6-Hv for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 19:10:32 -0500 Received: from elephant.ash.relay.mailchannels.net ([23.83.222.57]:11200) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j4vtm-000745-MN for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 19:10:31 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BA7C820C39 for ; Fri, 21 Feb 2020 00:10:25 +0000 (UTC) Received: from pdx1-sub0-mail-a86.g.dreamhost.com (100-96-0-7.trex.outbound.svc.cluster.local [100.96.0.7]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 37EB420B78 for ; Fri, 21 Feb 2020 00:10:25 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a86.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Fri, 21 Feb 2020 00:10:25 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Attack-Dime: 25251ba374d46d0c_1582243825446_1818334750 X-MC-Loop-Signature: 1582243825445:2144076842 X-MC-Ingress-Time: 1582243825445 Received: from pdx1-sub0-mail-a86.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a86.g.dreamhost.com (Postfix) with ESMTP id 714D37EFDF for ; Thu, 20 Feb 2020 16:10:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:date:message-id:mime-version:content-type; s= linkov.net; bh=w7u6nHGFlW8yKiGD8iAyzIZQduY=; b=ibAcyRiCGYOLY0oba VgVcFcEo99vIXF6xpooOiWrwIpyTA86ux4hfOW1iyD9YvmO3bwAcrikQnPis9PRt I0xUYI6XjBAy2OHlHFrgrsyzZy5SfBnsm8Yekm04C/vc9Gj4egZIQNnsVkxCCBJL /C9uFAgFF3TUSkeCbIV7dQ51TU= Received: from localhost.linkov.net (m91-129-103-27.cust.tele2.ee [91.129.103.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a86.g.dreamhost.com (Postfix) with ESMTPSA id 3B3887F048 for ; Thu, 20 Feb 2020 16:10:22 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a86 From: Juri Linkov Organization: LINKOV.NET Date: Fri, 21 Feb 2020 01:32:35 +0200 Message-ID: <871rqoj0mk.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrkeefgddvtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhofffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehlohgtrghlhhhoshhtrdhlihhnkhhovhdrnhgvthdpihhnvghtpeeluddruddvledruddtfedrvdejpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepsghughdqghhnuhdqvghmrggtshesghhnuhdrohhrgh X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 23.83.222.57 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Tags: patch Accidentally I noticed that vc-print-branch-log prints a narrower log than it should. I don't remember any damage from this data loss but this is not the right thing to do - by default it should show logs from the repository root, not logs limited to a subdirectory when this command happens to be called from a subdirectory. Am I correct to expect that vc-print-branch-log should print log from branch's root like vc-print-root-log does, and not from a subdirectory like vc-print-log does? diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index f7d651fac6..13d60b6fcf 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2559,9 +2590,11 @@ vc-print-branch-log (vc-read-revision "Branch to log: "))) (when (equal branch "") (error "No branch specified")) - (vc-print-log-internal (vc-responsible-backend default-directory) - (list default-directory) branch t - (when (> vc-log-show-limit 0) vc-log-show-limit))) + (let* ((backend (vc-responsible-backend default-directory)) + (rootdir (vc-call-backend backend 'root default-directory))) + (vc-print-log-internal backend + (list rootdir) branch t + (when (> vc-log-show-limit 0) vc-log-show-limit)))) ;;;###autoload (defun vc-log-incoming (&optional remote-location) From unknown Thu Sep 11 18:07:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39704: 28.0.50; vc-print-branch-log data loss Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Feb 2020 00:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39704 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov , 39704@debbugs.gnu.org Cc: Tom Tromey Received: via spool by 39704-submit@debbugs.gnu.org id=B39704.158224473221417 (code B ref 39704); Fri, 21 Feb 2020 00:26:02 +0000 Received: (at 39704) by debbugs.gnu.org; 21 Feb 2020 00:25:32 +0000 Received: from localhost ([127.0.0.1]:46150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4w8K-0005ZM-0v for submit@debbugs.gnu.org; Thu, 20 Feb 2020 19:25:32 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:56276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4w8H-0005Z9-FH for 39704@debbugs.gnu.org; Thu, 20 Feb 2020 19:25:30 -0500 Received: by mail-wm1-f48.google.com with SMTP id q9so411872wmj.5 for <39704@debbugs.gnu.org>; Thu, 20 Feb 2020 16:25:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0EYMiDS4/xPEH8wpOwOi7WyihfDHRY0isrI0qSADulY=; b=I3KJJKT6lpZHQ+gAJ0kUbrr+WB+qW+/encgKbkJYUg30wfBQBop3awqmENWscDdgNa 2OWOzbNixmo7P6rVtUqcUu6oU7ZOfgrrLduGBTqKWcGxr0PeNbaQRl1kVbqkDoiQ8etE EN5JKsMQA9eVgglsKDm3ZWnJAJ5z7ZCMkvM7FVg2zQtzHvisVuV0g1EwVHZbVE1Z14L7 sEqEj9rjAr/CMlfodWOzm0TYYt2YGy4v39nZexXlaQtPo0s17gopQYQiQKp1Y4wJgdqe ayMkqnr4EPU9oLwz3UagBzg//Jc1UuDELLU/AnFKhpXSSjcYkwmm/RpCoCXhmb9wjuNu kGUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0EYMiDS4/xPEH8wpOwOi7WyihfDHRY0isrI0qSADulY=; b=kHvEuPU/iqZS6iRLIav9/ol1hpdCXrVg5fKD+5LLCGd0B0oZWTEzaqgBvZ9/gf6FSR Ip4C+BajWWnjQaC1rI3UtUEb43uAIbvtOS48oV+Umv8H70HqX9IsLamODXYFe+jWMc/4 3YWFCjPOD4t3Qjgbdol1F0iayYoz/dYd3dh2FIPqha8H2CKKlVkJopMyoz7wFCUbycbX Lmp7yL2vyvxQ1Pa7MuoR9AMv6+Ht6YYJ+qX62XcdoNt/XmcA6+CjjeJ2jfeNZwFDJLKi LlAfol7CcWF2EIvVNUCLxwwu9uu5MqAbqS19ftmI4YZcuMZnVa/vmSO1hs1jbvJyK0KJ r44Q== X-Gm-Message-State: APjAAAWLto4mg1gTJabmhqLrDmitn4JXCWpMsxXugLxaNa/5eT+0sibp fy9g7fBs/H1dKhVMFu3WgwoHy0on X-Google-Smtp-Source: APXvYqxF582PDPROY/y4bFXznkAvI7DkZiy2EFWqFeSoM/VN9wcRRGQcM4zFf5yVmHXLzfdzzj/R7w== X-Received: by 2002:a1c:8095:: with SMTP id b143mr6935828wmd.7.1582244723530; Thu, 20 Feb 2020 16:25:23 -0800 (PST) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id c9sm1316448wme.41.2020.02.20.16.25.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Feb 2020 16:25:23 -0800 (PST) References: <871rqoj0mk.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <1428b9d3-4017-491a-dccc-8db93de2373b@yandex.ru> Date: Fri, 21 Feb 2020 02:25:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <871rqoj0mk.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 21.02.2020 1:32, Juri Linkov wrote: > Tags: patch > > Accidentally I noticed that vc-print-branch-log prints a narrower log > than it should. I don't remember any damage from this data loss > but this is not the right thing to do - by default it should show logs > from the repository root, not logs limited to a subdirectory when > this command happens to be called from a subdirectory. > > Am I correct to expect that vc-print-branch-log should print > log from branch's root like vc-print-root-log does, and > not from a subdirectory like vc-print-log does? I think so (then, the patch LGTM). Tom might want to weigh in on this, though. From unknown Thu Sep 11 18:07:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39704: 28.0.50; vc-print-branch-log data loss Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Feb 2020 18:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39704 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: Tom Tromey , 39704@debbugs.gnu.org, Juri Linkov Received: via spool by 39704-submit@debbugs.gnu.org id=B39704.158230976829984 (code B ref 39704); Fri, 21 Feb 2020 18:30:02 +0000 Received: (at 39704) by debbugs.gnu.org; 21 Feb 2020 18:29:28 +0000 Received: from localhost ([127.0.0.1]:48093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5D3H-0007nX-Vq for submit@debbugs.gnu.org; Fri, 21 Feb 2020 13:29:28 -0500 Received: from gateway23.websitewelcome.com ([192.185.50.129]:23349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5D3E-0007nM-Cw for 39704@debbugs.gnu.org; Fri, 21 Feb 2020 13:29:25 -0500 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway23.websitewelcome.com (Postfix) with ESMTP id C1DB3A6C8 for <39704@debbugs.gnu.org>; Fri, 21 Feb 2020 12:29:23 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 5D3DjOb4J8vkB5D3DjKmDW; Fri, 21 Feb 2020 12:29:23 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4VygV8U9Bm24RIgu4WSID2pz/DjG6CyZUrgkSkWNXOw=; b=pIX0n+KE4cBgSP60Xs1E7Sk73V FI8YthVCZCusVrqdq8nPhXsPoetmqYrlSnyppgIZpMwyt49nEE235uAO5vsEdUKnPDbiISfArfHfL KSttzhbtrsDu37/d+KsAdE9xo; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:33594 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j5D3D-003qrq-HM; Fri, 21 Feb 2020 11:29:23 -0700 From: Tom Tromey References: <871rqoj0mk.fsf@mail.linkov.net> <1428b9d3-4017-491a-dccc-8db93de2373b@yandex.ru> X-Attribution: Tom Date: Fri, 21 Feb 2020 11:29:22 -0700 In-Reply-To: <1428b9d3-4017-491a-dccc-8db93de2373b@yandex.ru> (Dmitry Gutov's message of "Fri, 21 Feb 2020 02:25:21 +0200") Message-ID: <87blpr7q0t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.123.50 X-Source-L: No X-Exim-ID: 1j5D3D-003qrq-HM X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-123-50.hlrn.qwest.net (murgatroyd) [75.166.123.50]:33594 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Dmitry> Tom might want to weigh in on this, though. I don't really have an opinion. The proposed behavior seems fine to me. Tom From unknown Thu Sep 11 18:07:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39704: 28.0.50; vc-print-branch-log data loss Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Feb 2020 00:45:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39704 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: Tom Tromey , 39704@debbugs.gnu.org Received: via spool by 39704-submit@debbugs.gnu.org id=B39704.1582418684508 (code B ref 39704); Sun, 23 Feb 2020 00:45:04 +0000 Received: (at 39704) by debbugs.gnu.org; 23 Feb 2020 00:44:44 +0000 Received: from localhost ([127.0.0.1]:50258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5fO0-000088-3F for submit@debbugs.gnu.org; Sat, 22 Feb 2020 19:44:44 -0500 Received: from bird.elm.relay.mailchannels.net ([23.83.212.17]:21837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5fNx-00007w-No for 39704@debbugs.gnu.org; Sat, 22 Feb 2020 19:44:42 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 17550600139; Sun, 23 Feb 2020 00:44:40 +0000 (UTC) Received: from pdx1-sub0-mail-a92.g.dreamhost.com (100-96-38-98.trex.outbound.svc.cluster.local [100.96.38.98]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 50FFC600956; Sun, 23 Feb 2020 00:44:39 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a92.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sun, 23 Feb 2020 00:44:39 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Ski-Illustrious: 7ccb734144c0b2bd_1582418679566_3999813044 X-MC-Loop-Signature: 1582418679566:226919974 X-MC-Ingress-Time: 1582418679566 Received: from pdx1-sub0-mail-a92.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a92.g.dreamhost.com (Postfix) with ESMTP id 0C2D87F1C5; Sat, 22 Feb 2020 16:44:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=KwJCQ3jvnPIiIz1c3C5NA9oNHw0=; b= voHGNuKfc8YCyH1lt9yfN3CYqYQPU7qlWxYS6Zg/c5XwG+jrmcWOh+A2Vn915uyh pQq7+aUUtNcTEP7OVPlCSWjDbXhxgQzGtJJ5MJjgs9ZSWrboYVzMv0e82J8L4Tvs Qkkpr017z6/+qyTjU3cwEGdU7fViDJIQtgGj4IZGoCA= Received: from localhost.linkov.net (m91-129-103-27.cust.tele2.ee [91.129.103.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a92.g.dreamhost.com (Postfix) with ESMTPSA id A6F827F1BF; Sat, 22 Feb 2020 16:44:31 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a92 From: Juri Linkov Organization: LINKOV.NET References: <871rqoj0mk.fsf@mail.linkov.net> <1428b9d3-4017-491a-dccc-8db93de2373b@yandex.ru> Date: Sun, 23 Feb 2020 02:07:10 +0200 In-Reply-To: <1428b9d3-4017-491a-dccc-8db93de2373b@yandex.ru> (Dmitry Gutov's message of "Fri, 21 Feb 2020 02:25:21 +0200") Message-ID: <87d0a6np3l.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrkeejgddvudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtfedrvdejnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmohguvgepshhmthhppdhhvghloheplhhotggrlhhhohhsthdrlhhinhhkohhvrdhnvghtpdhinhgvthepledurdduvdelrddutdefrddvjedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegughhuthhovheshigrnhguvgigrdhruh X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Accidentally I noticed that vc-print-branch-log prints a narrower log >> than it should. I don't remember any damage from this data loss >> but this is not the right thing to do - by default it should show logs >> from the repository root, not logs limited to a subdirectory when >> this command happens to be called from a subdirectory. >> Am I correct to expect that vc-print-branch-log should print >> log from branch's root like vc-print-root-log does, and >> not from a subdirectory like vc-print-log does? > > I think so (then, the patch LGTM). Or maybe retain the old behavior on using a prefix arg? I.e. C-u M-x vc-print-branch-log could ask for a directory, with the default on default-directory. From unknown Thu Sep 11 18:07:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39704: 28.0.50; vc-print-branch-log data loss Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Feb 2020 08:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39704 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: Tom Tromey , 39704@debbugs.gnu.org Received: via spool by 39704-submit@debbugs.gnu.org id=B39704.158244825025909 (code B ref 39704); Sun, 23 Feb 2020 08:58:01 +0000 Received: (at 39704) by debbugs.gnu.org; 23 Feb 2020 08:57:30 +0000 Received: from localhost ([127.0.0.1]:50337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5n4s-0006jp-Dl for submit@debbugs.gnu.org; Sun, 23 Feb 2020 03:57:30 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:38171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5n4q-0006jX-Ar for 39704@debbugs.gnu.org; Sun, 23 Feb 2020 03:57:28 -0500 Received: by mail-wm1-f42.google.com with SMTP id a9so6223620wmj.3 for <39704@debbugs.gnu.org>; Sun, 23 Feb 2020 00:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JTVRiU2vPPQJ2LyCfhWKiGEOKT41Yaa8SRWXcwRilMo=; b=fO+fBsxYNeXljo1tA1ZCLkNQjNFpjuRhTugKSyWVaNTBKhmZ3TKhprJR1/HtnyGsUd NCK/AZCiA6kQ0k4DnsfWrNNEgUnWokONdOkOtmaBDhbYM44O47E81pppTUdaHgx6iWAG XEpajjblz7QzwfKXyQh9GNFsJlwGkSolxL3seGrIPXS1x+g2q50lI3Fx3qduHx4jXjBc joP6eko0qRCCARvceWKs8au15DPzPbj8n8u/RD1kd6VWfAOQhmNehybjVI/C6WASRKkV nt1h7TYzMqWdI7InVwBB5qfbSgJg1AeTc8znikBLciMGEOlKzEkoc+KqtuniEg+B0chC pW/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JTVRiU2vPPQJ2LyCfhWKiGEOKT41Yaa8SRWXcwRilMo=; b=PRLkkYgGRO2cmS1EYWyzp5cuh1M+JAbT16TeS4IbVKskOroAbqsIT5t1EXz13iSKkm H5hPegRQVL+6VVeC1lXdDQJpmGQKyZJT6YwPNBYhg5NXJH7LuN80/ju5dMSI8s15LzYl MqhRsdJKTgnl5KuLqIaEuD7ZH+h6VEPn4zeXYTW3eGR4AgmXcVLIs6nnNs6HZqhhBcEw jHtzOaVn9iJuOe0r6WVDz4IyJxtVqN1xdKzsVqGgIRkqVM6gRNA0+nt4UZC5pOClavhA mHa6IhftM5bUIURITHxN1vvPN1dBcmU5nYAZRayjUIqe1kjS26/nIrEDsRJ58VyiwUmx mqVA== X-Gm-Message-State: APjAAAX0jFjkh6H8HDiU5QlaipUo5m8w3lgflxidtq2SCvIZBt+KInvA iBIXBeseeUSiS/bkMpc4Bjb/8siH X-Google-Smtp-Source: APXvYqw+PekEzQfLJ0kuJMUjmN3M9a4mbdnueqnuF8pDBmaTBwLlTVx1G5IovD3cyj+HmMyHkvETyA== X-Received: by 2002:a1c:f001:: with SMTP id a1mr14413685wmb.76.1582448241979; Sun, 23 Feb 2020 00:57:21 -0800 (PST) Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id m125sm12856376wmf.8.2020.02.23.00.57.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 23 Feb 2020 00:57:21 -0800 (PST) References: <871rqoj0mk.fsf@mail.linkov.net> <1428b9d3-4017-491a-dccc-8db93de2373b@yandex.ru> <87d0a6np3l.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: Date: Sun, 23 Feb 2020 10:57:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87d0a6np3l.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 23.02.2020 2:07, Juri Linkov wrote: > Or maybe retain the old behavior on using a prefix arg? > > I.e. C-u M-x vc-print-branch-log could ask for a directory, > with the default on default-directory. Personally, I don't remember needing something like that (or, in a once-a-decade occurrence, I can use the console). But if you find it useful, sure. From unknown Thu Sep 11 18:07:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39704: 28.0.50; vc-print-branch-log data loss Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Mar 2020 23:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39704 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: Tom Tromey , 39704@debbugs.gnu.org Received: via spool by 39704-submit@debbugs.gnu.org id=B39704.158379693014654 (code B ref 39704); Mon, 09 Mar 2020 23:36:01 +0000 Received: (at 39704) by debbugs.gnu.org; 9 Mar 2020 23:35:30 +0000 Received: from localhost ([127.0.0.1]:51622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBRvm-0003oI-AY for submit@debbugs.gnu.org; Mon, 09 Mar 2020 19:35:30 -0400 Received: from bonobo.birch.relay.mailchannels.net ([23.83.209.22]:30965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBRvk-0003o6-QW; Mon, 09 Mar 2020 19:35:29 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BCC3A26178D; Mon, 9 Mar 2020 23:35:25 +0000 (UTC) Received: from pdx1-sub0-mail-a70.g.dreamhost.com (100-96-215-21.trex.outbound.svc.cluster.local [100.96.215.21]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 3014B26176B; Mon, 9 Mar 2020 23:35:25 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a70.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Mon, 09 Mar 2020 23:35:25 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Continue-Turn: 0d54f09d7ff838a0_1583796925451_3923226379 X-MC-Loop-Signature: 1583796925451:1095389378 X-MC-Ingress-Time: 1583796925451 Received: from pdx1-sub0-mail-a70.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a70.g.dreamhost.com (Postfix) with ESMTP id E00F17F0F0; Mon, 9 Mar 2020 16:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=EcVPXUfdaTnIMjYyiCiwXga9u70=; b= iqWi9QCYmznBn997FLOubIO3At/AFtQ9ofbqkW2Ui/RFJuHwx+7xhnOP5WVlZCwK EcCqzBLIlB8nJRf2cRc1lceZWeQCDAIcxxv5ovJor9zK7TI0HFArvJiGiHPCtPbN xrNlPjDiRiz3Fn5kd3HRLqiIZV9uf2DaNChVB1PGFUA= Received: from mail.jurta.org (m91-129-103-27.cust.tele2.ee [91.129.103.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a70.g.dreamhost.com (Postfix) with ESMTPSA id 2F2497F0F2; Mon, 9 Mar 2020 16:35:16 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a70 From: Juri Linkov Organization: LINKOV.NET References: <871rqoj0mk.fsf@mail.linkov.net> <1428b9d3-4017-491a-dccc-8db93de2373b@yandex.ru> <87d0a6np3l.fsf@mail.linkov.net> Date: Tue, 10 Mar 2020 01:34:37 +0200 In-Reply-To: (Dmitry Gutov's message of "Sun, 23 Feb 2020 10:57:19 +0200") Message-ID: <878sk9p0fm.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrudduledgudduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrvdejpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhu X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 39704 fixed close 39704 28.0.50 quit >> Or maybe retain the old behavior on using a prefix arg? >> I.e. C-u M-x vc-print-branch-log could ask for a directory, >> with the default on default-directory. > > Personally, I don't remember needing something like that (or, in > a once-a-decade occurrence, I can use the console). But if you find it > useful, sure. Ok, pushed to master, and closed.