Subject: bug#39694: closed (Re: [bug#39694] [SHEPHERD] [PATCH] build: Adjust clean targets.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 06 Mar 2020 11:12:02 +0000

Your bug report

#39694: [SHEPHERD] [PATCH] build: Adjust clean targets.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
39694: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39694
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#39694] [SHEPHERD] [PATCH] build: Adjust clean targets.
From: Ludovic Courtès <[email-masked]>
To: Efraim Flashner <[email-masked]>
Cc: [email-masked]
Date: Fri, 06 Mar 2020 12:10:52 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Efraim,

Efraim Flashner <[email-masked]> skribis:

> Makefile.am: Add man pages to the 'make clean' target.
> ---
> Currently 'man shepherd' shows version 0.6.1, 'man herd' 0.6.0, 'man
> halt' and 'man reboot' 0.3.2. With this patch these 4 manpages are added
> to the 'make clean' list and are deleted. The manpage creation works as
> expected.

[...]

> +CLEANFILES += $(dist_man1_MANS) $(dist_man8_MANS)

This would remove man pages upon “make clean”, whereas they should only
be removed upon “make distclean”, per GNU conventions.

I went with a different fix in Shepherd commit
f32a2ff8ad329f224b2f693ad7e9fefac142a459.

Thank you!

Ludo’.

Subject: [SHEPHERD] [PATCH] build: Adjust clean targets.
From: Efraim Flashner <[email-masked]>
To: [email-masked]
Cc: Efraim Flashner <[email-masked]>
Date: Thu, 20 Feb 2020 17:42:21 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Makefile.am: Add man pages to the 'make clean' target.
---
Currently 'man shepherd' shows version 0.6.1, 'man herd' 0.6.0, 'man
halt' and 'man reboot' 0.3.2. With this patch these 4 manpages are added
to the 'make clean' list and are deleted. The manpage creation works as
expected.

---
 Makefile.am | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Makefile.am b/Makefile.am
index 9a1f019..8cf98d6 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -2,6 +2,7 @@
 # Copyright © 2002, 2003 Wolfgang Jährling <[email-masked]>
 # Copyright © 2013, 2014, 2015, 2016, 2018, 2019 Ludovic Courtès <[email-masked]>
 # Copyright © 2018 Carlo Zancanaro <[email-masked]>
+# Copyright © 2020 Efraim Flashner <[email-masked]>
 #
 # This file is part of the GNU Shepherd.
 #
@@ -122,6 +123,8 @@ doc/%.8: modules/shepherd/scripts/%.scm
 dist_man1_MANS = doc/shepherd.1 doc/herd.1
 dist_man8_MANS = doc/halt.8 doc/reboot.8
 
+CLEANFILES += $(dist_man1_MANS) $(dist_man8_MANS)
+
 # Things not automatically included in the distribution.
 EXTRA_DIST +=					\
   build-aux/config.rpath			\
-- 
2.25.1