GNU bug report logs - #39687
26.3; Add customize-variable option for not locking keyboards

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Logan Perkins <logan <at> lp-programming.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 39687 <at> debbugs.gnu.org
Subject: bug#39687: 26.3; Add customize-variable option for not locking keyboards
Date: Wed, 21 Jul 2021 17:57:44 +0200

Logan Perkins <logan <at> lp-programming.com> writes:

> I *think* I have a patch that still fixes the current behavior, and
> does not reintroduce those two bugs, I've included it below.
> Basically, the fix for Bug#5095 should only be applied if we are in
> the right context.  If we're not, the if block above puts a
> Qswitch_frame at the head of the side queue and triggers
> replay_entire_sequence, so we just skip the second check.  It'll get
> run again and catch the interruption on the next pass, but in the
> right context.

I tried the various test cases, and the behaviour with your patch
clearly seems better to me, so I've applied it to Emacs 28.

But as Eli says, this is a ticklish area, so if this (re-)introduces
other bugs, we'll have to revert.

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.