GNU bug report logs - #39683
[PATCH] Add NOFOLLOW flag to set-file-modes etc.

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 39683 <at> debbugs.gnu.org
Subject: bug#39683: [PATCH] Add NOFOLLOW flag to set-file-modes etc.
Date: Thu, 20 Feb 2020 16:51:53 +0200

> From: Paul Eggert <eggert <at> cs.ucla.edu>
> Date: Wed, 19 Feb 2020 16:34:00 -0800
> Cc: Paul Eggert <eggert <at> cs.ucla.edu>
> 
> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
> index 0069c1744d..de5e8bb567 100644
> --- a/lisp/dired-aux.el
> +++ b/lisp/dired-aux.el
> @@ -409,7 +409,8 @@ dired-do-chmod
>        (set-file-modes
>         file
>         (if num-modes num-modes
> -	 (file-modes-symbolic-to-number modes (file-modes file)))))
> +	 (file-modes-symbolic-to-number modes (file-modes file t)))

Can we please use some descriptive symbol, like 'nofollow, instead of
just t?  I expect that to save at least some of us an extra read of
the doc string each time we see such code.

TIA

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.