From unknown Tue Jun 17 22:08:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39637: mongo-tools test fail with Go 1.13 Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 16 Feb 2020 21:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39637 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 39637@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158188848931027 (code B ref -1); Sun, 16 Feb 2020 21:29:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Feb 2020 21:28:09 +0000 Received: from localhost ([127.0.0.1]:37780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j3RSS-00084N-Vn for submit@debbugs.gnu.org; Sun, 16 Feb 2020 16:28:09 -0500 Received: from lists.gnu.org ([209.51.188.17]:46859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j3RSR-00084G-NU for submit@debbugs.gnu.org; Sun, 16 Feb 2020 16:28:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45730) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3RSQ-0008Iz-DW for bug-guix@gnu.org; Sun, 16 Feb 2020 16:28:07 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3RSP-0001o0-Au for bug-guix@gnu.org; Sun, 16 Feb 2020 16:28:06 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:44090) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j3RSP-0001mr-7b for bug-guix@gnu.org; Sun, 16 Feb 2020 16:28:05 -0500 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1j3RSO-0001al-6d for bug-guix@gnu.org; Sun, 16 Feb 2020 16:28:04 -0500 Date: Sun, 16 Feb 2020 16:28:04 -0500 (EST) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 104.248.1.95 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi Guix, After the recent Go 1.13 update, the test for mongo-tools package (currently at vervsion 3.4.0) fails with: ``` flag provided but not defined: -test.testlogfile Usage of /tmp/guix-build-mongo-tools-3.4.24.drv-0/go-build972699285/b001/mongofiles.test: -convey-json When true, emits results in JSON blocks. Default: 'false' -convey-silent When true, all output from GoConvey is suppressed. -convey-story When true, emits story output, otherwise emits dot output. When not provided, this flag mirros the value of the '-test.v' flag -test.types string Comma-separated list of the types of tests to be run (default "unit") FAIL github.com/mongodb/mongo-tools/mongofiles 0.002s FAIL command "go" "test" "-v" "github.com/mongodb/mongo-tools/mongofiles" failed with status 1 ``` I believe that this is related to a change in Go's testing module with 1.13: https://golang.org/doc/go1.13#testing For more information, also see the Go bug report: https://github.com/golang/go/issues/31859 Note that mongo-tools provides a number of tools in different Go packages, and the mongofiles tool is the only one that has this error. I have tried to adding a call to flag.Parse() in TestMain, which I added, as described in the documentation [0], but that did not resolve the problem. I'm not exactly sure why. The same fix worked for containerd [1]. [0] https://golang.org/pkg/testing/#hdr-Main [1] http://git.savannah.gnu.org/cgit/guix.git/commit/?id=13c8e747e86e39c0a8c6ec7da8c812d9bbcb682b I wonder if the difference is that mongofiles does not use the flag package directly, but flag.Parse() is being called in the wrong place in one of its dependencies. A note on versions: the problem persists in the latest release of mongo-tools in the 3.4 series, 3.4.24. I have not tried the other release series, 3.6, 4.0, and 4.2 because those require dependencies not yet packaged in Guix. I have opened a bug report upstream: https://jira.mongodb.org/browse/TOOLS-2482 Thoughts or suggestions? Best, Jack From unknown Tue Jun 17 22:08:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39637: mongo-tools test fail with Go 1.13 Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 17 Feb 2020 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39637 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 39637@debbugs.gnu.org Received: via spool by 39637-submit@debbugs.gnu.org id=B39637.158195487822553 (code B ref 39637); Mon, 17 Feb 2020 15:55:02 +0000 Received: (at 39637) by debbugs.gnu.org; 17 Feb 2020 15:54:38 +0000 Received: from localhost ([127.0.0.1]:39101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j3ijG-0005rh-33 for submit@debbugs.gnu.org; Mon, 17 Feb 2020 10:54:38 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:42776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j3ijE-0005rR-TO for 39637@debbugs.gnu.org; Mon, 17 Feb 2020 10:54:37 -0500 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1j3ij6-00062g-PS for 39637@debbugs.gnu.org; Mon, 17 Feb 2020 10:54:31 -0500 Date: Mon, 17 Feb 2020 10:54:28 -0500 (EST) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, 16 Feb 2020, Jack Hill wrote: > I have opened a bug report upstream: > https://jira.mongodb.org/browse/TOOLS-2482 Upstream reports, "MongoDB 3.4 is now EOL so it is no longer supported. For MongoDB Tools specifically, we're only making critical fixes to versions <4.2." Therefore, it seems like the thing to do is to work on updating our mongo-tools package. Best, Jack From unknown Tue Jun 17 22:08:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39637: Policy to remove broken packages Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 22 Jun 2020 17:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39637 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Jack Hill Cc: Guix Devel , 39637@debbugs.gnu.org, zimoun Received: via spool by 39637-submit@debbugs.gnu.org id=B39637.159284561718556 (code B ref 39637); Mon, 22 Jun 2020 17:07:01 +0000 Received: (at 39637) by debbugs.gnu.org; 22 Jun 2020 17:06:57 +0000 Received: from localhost ([127.0.0.1]:34442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnPuK-0004pE-L4 for submit@debbugs.gnu.org; Mon, 22 Jun 2020 13:06:56 -0400 Received: from mira.cbaines.net ([212.71.252.8]:39188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnPuD-0004oy-RJ for 39637@debbugs.gnu.org; Mon, 22 Jun 2020 13:06:55 -0400 Received: from localhost (unknown [46.237.174.39]) by mira.cbaines.net (Postfix) with ESMTPSA id D704B27BBE1; Mon, 22 Jun 2020 18:06:48 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id c6d26709; Mon, 22 Jun 2020 17:06:46 +0000 (UTC) References: <86y2oisj41.fsf@gmail.com> <87v9jm6nmo.fsf@cbaines.net> User-agent: mu4e 1.4.10; emacs 26.3 From: Christopher Baines In-reply-to: Date: Mon, 22 Jun 2020 18:06:44 +0100 Message-ID: <87k0zz6ndn.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Jack Hill writes: > On Sat, 20 Jun 2020, Christopher Baines wrote: > >> Do you have any examples of packages that are currently broken, and >> which you'd like to remove? > > Perhaps mongo-tools: https://issues.guix.gnu.org/39637 > > It broke when Go was upgraded to 1.13, and changed the test library. I > fixed some other Go packages that ran into this issue, but it wasn't > as easy for mongo-tools. Our version is old, so it should be > updated. For various reasons, I don't see this package being fixed in > the short term. mongo-tools is definitely failing to build, and it has been since the 11th of Feb (2020) I think. It seems like you got further in understanding this than I did. Given that this seems like a test failure, and I don't think there's anything to suggest that the actual functionality doesn't work, the course of action I see here is to disable either the failing tests, or running the test suite entirely. I originally packaged MongoDB and mongo-tools for Guix, but that was before the licence of MongoDB changed, so I'm not sure about the long term future of the packages. Keeping the packages we have actually building though is still useful. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl7w5SRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XegDg//fkUuTqQaeic5b/gQiQ0s8dfi49or9A1iBb+gSbr9GtBad6ktdTdSnxZw AeDVaXl8SdHOuVXcFRmsxLnLNCBaner9w3HYNBIBLJ5WKSGJObHFCt4kcMxSa4mG hVkpm9I12CarQUe2EZmPjSoITYRU+kBxTaKANq5kcIPAO8nsl9i+DD48EjAG1mzK LtfoT4OS0qEVUy+t5sdyhXTk4J9vK8dUtDOHI7nOykfrsMwLdNwHd2Uosm0jCdnX BDSUJY49vvCpQYwDBt2XEVUGwajMmOTI+y7q+vxDV1GIlKV+oDnMLUmP5l5pO5vl x6BM27EbOj4YZ43Hd26D+WxrK54WQlqyTDdMuHUoLyYRuUKt8GkKttCBCKIt3dVT nasCqcmHtnX8YRAv89c4Cqr3S0fmYU0aZQDRvV74XSbJABkuVheTGvq6YhPd8a9W LXknmUZoCAPmzFH4ACSOGMRJxuJ1sTK5blvbFNiZuyzKXzG6zPz/TkW7H/A+XOhm p6tYb31UiUWly67LPSSrrZyWtC7is/NQSqsDDo7BvAY+wr9TCcEAVY/8tKVWr62N Td9+E1QtWmIc2ABw8mTfN4RdFHzCO/TUhKe5E/ex/25TBuwr28R0m2xM4dCRT/IE yCZGyuHYS7nHtbdX1LY+4iKAZrkgbGUoeThJlNaPvonuhk47gxQ= =ptFZ -----END PGP SIGNATURE----- --=-=-=-- From unknown Tue Jun 17 22:08:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#39637: Policy to remove broken packages Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 22 Jun 2020 18:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39637 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Christopher Baines Cc: Guix Devel , Jack Hill , 39637@debbugs.gnu.org Received: via spool by 39637-submit@debbugs.gnu.org id=B39637.159285152927608 (code B ref 39637); Mon, 22 Jun 2020 18:46:02 +0000 Received: (at 39637) by debbugs.gnu.org; 22 Jun 2020 18:45:29 +0000 Received: from localhost ([127.0.0.1]:34524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnRRg-0007BE-Sd for submit@debbugs.gnu.org; Mon, 22 Jun 2020 14:45:29 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnRRb-0007Ay-Ki for 39637@debbugs.gnu.org; Mon, 22 Jun 2020 14:45:27 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 4B1BD5C0F62; Mon, 22 Jun 2020 14:45:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 22 Jun 2020 14:45:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=VaBfIX6rl5ms7qulSd6NdpK3 OwJc9HmeecL2l3BlVU8=; b=NnGM3L4xbzkZBlsrdZLQZA/svR2H/VNclEbkxzr1 U554WJSxZ2aj60aTHD9u6TpqW1Ve9QklmmBU2/fN86+BIwzLI50LiFHCSoGd6pXH 2deK65c5Ekl7vMoozDINg6U7uE6cudCoK8kdTSlXktV8sfM3yXMPigA/FjaOFUEm p3o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=VaBfIX 6rl5ms7qulSd6NdpK3OwJc9HmeecL2l3BlVU8=; b=HA2v4M09RgoFpZUAaA709p P0LfqsNkJ09XjGxAZByEwxZ9vcce5dWpnmze4jRwvJM2eVt61qV3/mnVQR9Xe5fn 9JGFMsqrUF0DklhMTICC3idzBHkhmy/cFP8Q9e9/y8OuCgyRdg/yD+LyYUZ5laLq q3dcm+BNFJXJejg/gS/EAjT3VUaYaVXJqOd1Z1shVw8o2BfMWledoyibHXIle5ux 6dHruhx6Z4h9LxymABTaUY8n9jnhNGkuBQGx2dnZUNjkRdByh4EyT5Dy/0kQjN6s oj5XQhwkh+vgBYuy65Zw/hSFKyq7QF9U6pnZMc59UCQvQiVshX2IckAJbxJh78ig == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudekvddgudefudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepueekkedtffdvtddugeejgedtvefhueefiedvjeeitdeigedtveejvdejheff vefgnecukfhppeejiedruddvgedrudefkedrieefnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id C48D830673E1; Mon, 22 Jun 2020 14:45:17 -0400 (EDT) Date: Mon, 22 Jun 2020 14:45:11 -0400 From: Leo Famulari Message-ID: <20200622184511.GA22400@jasmine.lan> References: <86y2oisj41.fsf@gmail.com> <87v9jm6nmo.fsf@cbaines.net> <87k0zz6ndn.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k0zz6ndn.fsf@cbaines.net> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, Jun 22, 2020 at 06:06:44PM +0100, Christopher Baines wrote: > It seems like you got further in understanding this than I did. Given > that this seems like a test failure, and I don't think there's anything > to suggest that the actual functionality doesn't work, the course of > action I see here is to disable either the failing tests, or running the > test suite entirely. Not having looked into it closely, I think that, in general, test failures do indicate that actual functionality is broken. Of course it's a different story in many cases since the Guix build environment is so unusual. From unknown Tue Jun 17 22:08:18 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jack Hill Subject: bug#39637: closed (mongo-tool no longer in Guix, so the tests no longer fail) Message-ID: References: X-Gnu-PR-Message: they-closed 39637 X-Gnu-PR-Package: guix Reply-To: 39637@debbugs.gnu.org Date: Mon, 22 Mar 2021 16:50:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1616431802-20832-1" This is a multi-part message in MIME format... ------------=_1616431802-20832-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #39637: mongo-tools test fail with Go 1.13 which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 39637@debbugs.gnu.org. --=20 39637: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D39637 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1616431802-20832-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 39637-done) by debbugs.gnu.org; 22 Mar 2021 16:49:54 +0000 Received: from localhost ([127.0.0.1]:58391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lONkY-0005Pd-0q for submit@debbugs.gnu.org; Mon, 22 Mar 2021 12:49:54 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:40508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lONkW-0005PP-V7 for 39637-done@debbugs.gnu.org; Mon, 22 Mar 2021 12:49:53 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lONkR-00005u-8g for 39637-done@debbugs.gnu.org; Mon, 22 Mar 2021 12:49:47 -0400 Date: Mon, 22 Mar 2021 12:49:47 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: 39637-done@debbugs.gnu.org Subject: mongo-tool no longer in Guix, so the tests no longer fail Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39637-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) mongo-tools was removed from Guix in commit 097cf21d1d34f4f66a403c3fb6e15b6709c4dd8a so I'm closing this issue. Best, Jack ------------=_1616431802-20832-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 16 Feb 2020 21:28:09 +0000 Received: from localhost ([127.0.0.1]:37780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j3RSS-00084N-Vn for submit@debbugs.gnu.org; Sun, 16 Feb 2020 16:28:09 -0500 Received: from lists.gnu.org ([209.51.188.17]:46859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j3RSR-00084G-NU for submit@debbugs.gnu.org; Sun, 16 Feb 2020 16:28:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45730) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3RSQ-0008Iz-DW for bug-guix@gnu.org; Sun, 16 Feb 2020 16:28:07 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3RSP-0001o0-Au for bug-guix@gnu.org; Sun, 16 Feb 2020 16:28:06 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:44090) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j3RSP-0001mr-7b for bug-guix@gnu.org; Sun, 16 Feb 2020 16:28:05 -0500 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1j3RSO-0001al-6d for bug-guix@gnu.org; Sun, 16 Feb 2020 16:28:04 -0500 Date: Sun, 16 Feb 2020 16:28:04 -0500 (EST) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: bug-guix@gnu.org Subject: mongo-tools test fail with Go 1.13 Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 104.248.1.95 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi Guix, After the recent Go 1.13 update, the test for mongo-tools package (currently at vervsion 3.4.0) fails with: ``` flag provided but not defined: -test.testlogfile Usage of /tmp/guix-build-mongo-tools-3.4.24.drv-0/go-build972699285/b001/mongofiles.test: -convey-json When true, emits results in JSON blocks. Default: 'false' -convey-silent When true, all output from GoConvey is suppressed. -convey-story When true, emits story output, otherwise emits dot output. When not provided, this flag mirros the value of the '-test.v' flag -test.types string Comma-separated list of the types of tests to be run (default "unit") FAIL github.com/mongodb/mongo-tools/mongofiles 0.002s FAIL command "go" "test" "-v" "github.com/mongodb/mongo-tools/mongofiles" failed with status 1 ``` I believe that this is related to a change in Go's testing module with 1.13: https://golang.org/doc/go1.13#testing For more information, also see the Go bug report: https://github.com/golang/go/issues/31859 Note that mongo-tools provides a number of tools in different Go packages, and the mongofiles tool is the only one that has this error. I have tried to adding a call to flag.Parse() in TestMain, which I added, as described in the documentation [0], but that did not resolve the problem. I'm not exactly sure why. The same fix worked for containerd [1]. [0] https://golang.org/pkg/testing/#hdr-Main [1] http://git.savannah.gnu.org/cgit/guix.git/commit/?id=13c8e747e86e39c0a8c6ec7da8c812d9bbcb682b I wonder if the difference is that mongofiles does not use the flag package directly, but flag.Parse() is being called in the wrong place in one of its dependencies. A note on versions: the problem persists in the latest release of mongo-tools in the 3.4 series, 3.4.24. I have not tried the other release series, 3.6, 4.0, and 4.2 because those require dependencies not yet packaged in Guix. I have opened a bug report upstream: https://jira.mongodb.org/browse/TOOLS-2482 Thoughts or suggestions? Best, Jack ------------=_1616431802-20832-1--