Subject: bug#39628: closed (Re: [bug#39628] [PATCH] gnu: accountsservice: 'Add patch-/bin/cat' phase.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 16 Feb 2020 15:33:02 +0000

Your bug report

#39628: [PATCH] gnu: accountsservice: 'Add patch-/bin/cat' phase.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
39628: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39628
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#39628] [PATCH] gnu: accountsservice: 'Add patch-/bin/cat' phase.
From: Marius Bakke <[email-masked]>
To: Rene <[email-masked]>, [email-masked]
Date: Sun, 16 Feb 2020 16:32:47 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Rene via Guix-patches via <[email-masked]> writes:

> Hello,
>
> this patch fix the absolute path for /bin/cat and is required to set thumbnail image for user in GNOME desktop.

Good catch, applied in c9aadd074961b149870cbe6128d77b6cacb1d2b6.

By the way, there are some other hard coded file names in that file, for
/usr/bin/passwd and /usr/bin/chage.  We should probably patch those too.

Thanks!

Subject: [PATCH] gnu: accountsservice: 'Add patch-/bin/cat' phase.
From: Rene <[email-masked]>
To: "[email-masked]" <[email-masked]>
Date: Sun, 16 Feb 2020 01:10:48 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

this patch fix the absolute path for /bin/cat and is required to set thumbnail image for user in GNOME desktop.

Debug error:

--
1) gnome-control-center -v
2) try changing the user's thumbnail.

00:25:56.0336           AccountsService:  WARNING: SetIconFile call failed: GDBus.Error:org.freedesktop.Accounts.Error.Failed: reading file '/gnu/store/k159736sj00s0jkirkr2270nlx6sx6h2-gnome-control-center-3.32.2/share/pixmaps/faces/mountain.jpg' failed: Failed to execute child process “/bin/cat” (No such file or directory)
--

Thanks
Rene

From 9df62bc0f1a4e99311191ae940e85b559887a480 Mon Sep 17 00:00:00 2001
From: Rene Saavedra <[email-masked]>
Date: Sat, 15 Feb 2020 18:46:14 -0600
Subject: [PATCH] gnu: accountsservice: 'Add patch-/bin/cat' phase.

* gnu/packages/freedesktop.scm (accountsservice)[arguments]: Add 'patch-/bin/cat'
phase.
---
 gnu/packages/freedesktop.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 01466b8ec5..80e185c8e7 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -17,6 +17,7 @@
 ;;; Copyright © 2019 Reza Alizadeh Majd <[email-masked]>
 ;;; Copyright © 2019, 2020 Guillaume Le Vaillant <[email-masked]>
 ;;; Copyright © 2020 Jakub Kądziołka <[email-masked]>
+;;; Copyright © 2020 Rene Saavedra <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -921,6 +922,11 @@ message bus.")
          "--enable-elogind")
        #:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'patch-/bin/cat
+           (lambda _
+             (substitute* "src/user.c"
+               (("/bin/cat") (which "cat")))
+             #t))
          (add-before
           'configure 'pre-configure
           (lambda* (#:key inputs #:allow-other-keys)
-- 
2.21.0