GNU bug report logs - #39596
26.3; Export INSIDE_EMACS with Eshell

Previous Next

Package: emacs;

Reported by: Pierre Neidhardt <mail <at> ambrevar.xyz>

Date: Fri, 14 Feb 2020 07:18:02 UTC

Severity: minor

Tags: fixed, patch

Merged with 25496

Found in versions 25.1.91, 26.3

Fixed in version 28.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Federico Tedin <federicotedin <at> gmail.com>
Cc: 39596 <at> debbugs.gnu.org
Subject: bug#39596: 26.3; Export INSIDE_EMACS with Eshell
Date: Wed, 19 Feb 2020 08:40:19 +0100

[Message part 1 (text/plain, inline)]
Thanks for looking at this, Federico!

Your patch looks good to me, just one comment below:

> --- a/lisp/eshell/em-dirs.el
> +++ b/lisp/eshell/em-dirs.el
> @@ -191,6 +191,9 @@ eshell-dirs-initialize
>  		        (unless (ring-empty-p eshell-last-dir-ring)
>  			  (expand-file-name
>  			   (ring-ref eshell-last-dir-ring 0))))
> +            t)
> +           ("INSIDE_EMACS" ,(lambda (_indices)
> +                              (format "%s,eshell" emacs-version))
>              t))))

Why did you unquote the lambda here?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 5 years and 98 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.