From unknown Tue Aug 19 14:22:22 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#39581] [PATCH] gnu: containerd: Fix test failure with Go 1.13 Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 12 Feb 2020 20:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39581 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 39581@debbugs.gnu.org Cc: Jack Hill X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15815396448082 (code B ref -1); Wed, 12 Feb 2020 20:35:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Feb 2020 20:34:04 +0000 Received: from localhost ([127.0.0.1]:59110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1yhv-00026I-Ps for submit@debbugs.gnu.org; Wed, 12 Feb 2020 15:34:04 -0500 Received: from lists.gnu.org ([209.51.188.17]:37957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1yhr-00025s-W8 for submit@debbugs.gnu.org; Wed, 12 Feb 2020 15:34:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42014) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1yhq-00023m-Ml for guix-patches@gnu.org; Wed, 12 Feb 2020 15:33:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1yhn-00056n-3M for guix-patches@gnu.org; Wed, 12 Feb 2020 15:33:58 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:34146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j1yhn-00056c-06 for guix-patches@gnu.org; Wed, 12 Feb 2020 15:33:55 -0500 Received: from lib-its13.lib.duke.edu ([152.3.118.151] helo=localhost.localdomain) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1j1yhl-00076S-5M; Wed, 12 Feb 2020 15:33:53 -0500 From: Jack Hill Date: Wed, 12 Feb 2020 15:33:43 -0500 Message-Id: <20200212203343.2327-1-jackhill@jackhill.us> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 104.248.1.95 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) * gnu/packages/docker.scm (containerd)[source]: Add patch. * gnu/packages/patches/containerd-test-with-go1.13.patch: New file. * gnu/local.mk (dist_patch_DATA): Add patch. --- gnu/local.mk | 1 + gnu/packages/docker.scm | 4 +++- .../patches/containerd-test-with-go1.13.patch | 21 +++++++++++++++++++ 3 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/containerd-test-with-go1.13.patch diff --git a/gnu/local.mk b/gnu/local.mk index 3f8fa2ed7b..0efb53f416 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -794,6 +794,7 @@ dist_patch_DATA = \ %D%/packages/patches/coda-use-system-libs.patch \ %D%/packages/patches/combinatorial-blas-awpm.patch \ %D%/packages/patches/combinatorial-blas-io-fix.patch \ + %D%/packages/patches/containerd-test-with-go1.13.patch \ %D%/packages/patches/cpufrequtils-fix-aclocal.patch \ %D%/packages/patches/crawl-upgrade-saves.patch \ %D%/packages/patches/crda-optional-gcrypt.patch \ diff --git a/gnu/packages/docker.scm b/gnu/packages/docker.scm index 1f832a25e5..cc353fd11f 100644 --- a/gnu/packages/docker.scm +++ b/gnu/packages/docker.scm @@ -183,7 +183,9 @@ Python without keeping their credentials in a Docker configuration file.") (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "0npbzixf3c0jvzm159vygvkydrr8h36c9sq50yv0mdinrys2bvg0")))) + (base32 "0npbzixf3c0jvzm159vygvkydrr8h36c9sq50yv0mdinrys2bvg0")) + (patches + (search-patches "containerd-test-with-go1.13.patch")))) (build-system go-build-system) (arguments `(#:import-path "github.com/containerd/containerd" diff --git a/gnu/packages/patches/containerd-test-with-go1.13.patch b/gnu/packages/patches/containerd-test-with-go1.13.patch new file mode 100644 index 0000000000..964adee9e6 --- /dev/null +++ b/gnu/packages/patches/containerd-test-with-go1.13.patch @@ -0,0 +1,21 @@ +Compatibility fix for go 1.13, flag.Parse() shouldn't be called during +package initialization. +https://golang.org/doc/go1.13#testing +--- a/client_test.go 2020-02-12 14:50:28.991245371 -0500 ++++ b/client_test.go 2020-02-12 15:12:37.383523980 -0500 +@@ -49,7 +49,6 @@ + flag.StringVar(&address, "address", defaultAddress, "The address to the containerd socket for use in the tests") + flag.BoolVar(&noDaemon, "no-daemon", false, "Do not start a dedicated daemon for the tests") + flag.BoolVar(&noCriu, "no-criu", false, "Do not run the checkpoint tests") +- flag.Parse() + } + + func testContext() (context.Context, context.CancelFunc) { +@@ -59,6 +58,7 @@ + } + + func TestMain(m *testing.M) { ++ flag.Parse() + if testing.Short() { + os.Exit(m.Run()) + } -- 2.25.0 From unknown Tue Aug 19 14:22:22 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jack Hill Subject: bug#39581: closed (Re: [bug#39581] [PATCH] gnu: containerd: Fix test failure with Go 1.13) Message-ID: References: <20200215143213.566efc76@scratchpost.org> <20200212203343.2327-1-jackhill@jackhill.us> X-Gnu-PR-Message: they-closed 39581 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 39581@debbugs.gnu.org Date: Sat, 15 Feb 2020 13:33:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1581773582-3146-1" This is a multi-part message in MIME format... ------------=_1581773582-3146-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #39581: [PATCH] gnu: containerd: Fix test failure with Go 1.13 which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 39581@debbugs.gnu.org. --=20 39581: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D39581 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1581773582-3146-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 39581-done) by debbugs.gnu.org; 15 Feb 2020 13:32:18 +0000 Received: from localhost ([127.0.0.1]:35102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2xYQ-0000nr-8f for submit@debbugs.gnu.org; Sat, 15 Feb 2020 08:32:18 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:35502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2xYO-0000nj-K5 for 39581-done@debbugs.gnu.org; Sat, 15 Feb 2020 08:32:17 -0500 Received: from localhost (unknown [185.17.13.127]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 2437E3362016; Sat, 15 Feb 2020 14:32:15 +0100 (CET) Date: Sat, 15 Feb 2020 14:32:13 +0100 From: Danny Milosavljevic To: Jack Hill Subject: Re: [bug#39581] [PATCH] gnu: containerd: Fix test failure with Go 1.13 Message-ID: <20200215143213.566efc76@scratchpost.org> In-Reply-To: <20200212203343.2327-1-jackhill@jackhill.us> References: <20200212203343.2327-1-jackhill@jackhill.us> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/jc26s6uObI3xU_R5ai9ddx+"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39581-done Cc: 39581-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/jc26s6uObI3xU_R5ai9ddx+ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, thanks for the patch! Pushed to guix master as commit 42a69d1f16debfc8a923754695700ddfc9a74b12. --Sig_/jc26s6uObI3xU_R5ai9ddx+ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl5H8t0ACgkQ5xo1VCww uqVq6Af+LkStJtfTAhDwph9DFPPmCI6aUsaOkgk7UTw/cHQAB0cTgZsbNzLtt7MO bV1RII7nNKkT12HFokY4MSb0FpvaOcqonDZh0G9Pb91sh0352OsbrqzeLCpDnKlJ qpLyD702XXFXFn3lXXHg3BAyVG1lBaZecek3P3K5jej9BGYU9IRkNIDypb1pJmTm w+z3h6TSFWb1Dt/Gnty2x7VeJi/5AY+j+hJuFskvrkvdJvhdX3gYZAA5fslrtsd8 W2skBbyPZeOGp6SKLKL17XT1FDLTGuc5kUY/l208dfZYijVItsCY8/r/BdKhU16k 3qnU48OyvsOGAAghCaxh8DrgI1t3OA== =z6No -----END PGP SIGNATURE----- --Sig_/jc26s6uObI3xU_R5ai9ddx+-- ------------=_1581773582-3146-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Feb 2020 20:34:04 +0000 Received: from localhost ([127.0.0.1]:59110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1yhv-00026I-Ps for submit@debbugs.gnu.org; Wed, 12 Feb 2020 15:34:04 -0500 Received: from lists.gnu.org ([209.51.188.17]:37957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1yhr-00025s-W8 for submit@debbugs.gnu.org; Wed, 12 Feb 2020 15:34:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42014) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1yhq-00023m-Ml for guix-patches@gnu.org; Wed, 12 Feb 2020 15:33:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1yhn-00056n-3M for guix-patches@gnu.org; Wed, 12 Feb 2020 15:33:58 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:34146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j1yhn-00056c-06 for guix-patches@gnu.org; Wed, 12 Feb 2020 15:33:55 -0500 Received: from lib-its13.lib.duke.edu ([152.3.118.151] helo=localhost.localdomain) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1j1yhl-00076S-5M; Wed, 12 Feb 2020 15:33:53 -0500 From: Jack Hill To: guix-patches@gnu.org Subject: [PATCH] gnu: containerd: Fix test failure with Go 1.13 Date: Wed, 12 Feb 2020 15:33:43 -0500 Message-Id: <20200212203343.2327-1-jackhill@jackhill.us> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 104.248.1.95 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit Cc: Jack Hill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) * gnu/packages/docker.scm (containerd)[source]: Add patch. * gnu/packages/patches/containerd-test-with-go1.13.patch: New file. * gnu/local.mk (dist_patch_DATA): Add patch. --- gnu/local.mk | 1 + gnu/packages/docker.scm | 4 +++- .../patches/containerd-test-with-go1.13.patch | 21 +++++++++++++++++++ 3 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/containerd-test-with-go1.13.patch diff --git a/gnu/local.mk b/gnu/local.mk index 3f8fa2ed7b..0efb53f416 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -794,6 +794,7 @@ dist_patch_DATA = \ %D%/packages/patches/coda-use-system-libs.patch \ %D%/packages/patches/combinatorial-blas-awpm.patch \ %D%/packages/patches/combinatorial-blas-io-fix.patch \ + %D%/packages/patches/containerd-test-with-go1.13.patch \ %D%/packages/patches/cpufrequtils-fix-aclocal.patch \ %D%/packages/patches/crawl-upgrade-saves.patch \ %D%/packages/patches/crda-optional-gcrypt.patch \ diff --git a/gnu/packages/docker.scm b/gnu/packages/docker.scm index 1f832a25e5..cc353fd11f 100644 --- a/gnu/packages/docker.scm +++ b/gnu/packages/docker.scm @@ -183,7 +183,9 @@ Python without keeping their credentials in a Docker configuration file.") (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "0npbzixf3c0jvzm159vygvkydrr8h36c9sq50yv0mdinrys2bvg0")))) + (base32 "0npbzixf3c0jvzm159vygvkydrr8h36c9sq50yv0mdinrys2bvg0")) + (patches + (search-patches "containerd-test-with-go1.13.patch")))) (build-system go-build-system) (arguments `(#:import-path "github.com/containerd/containerd" diff --git a/gnu/packages/patches/containerd-test-with-go1.13.patch b/gnu/packages/patches/containerd-test-with-go1.13.patch new file mode 100644 index 0000000000..964adee9e6 --- /dev/null +++ b/gnu/packages/patches/containerd-test-with-go1.13.patch @@ -0,0 +1,21 @@ +Compatibility fix for go 1.13, flag.Parse() shouldn't be called during +package initialization. +https://golang.org/doc/go1.13#testing +--- a/client_test.go 2020-02-12 14:50:28.991245371 -0500 ++++ b/client_test.go 2020-02-12 15:12:37.383523980 -0500 +@@ -49,7 +49,6 @@ + flag.StringVar(&address, "address", defaultAddress, "The address to the containerd socket for use in the tests") + flag.BoolVar(&noDaemon, "no-daemon", false, "Do not start a dedicated daemon for the tests") + flag.BoolVar(&noCriu, "no-criu", false, "Do not run the checkpoint tests") +- flag.Parse() + } + + func testContext() (context.Context, context.CancelFunc) { +@@ -59,6 +58,7 @@ + } + + func TestMain(m *testing.M) { ++ flag.Parse() + if testing.Short() { + os.Exit(m.Run()) + } -- 2.25.0 ------------=_1581773582-3146-1--