GNU bug report logs - #39578
27.0.50; [rainbow-mode] #define is colored in c++-mode

Previous Next

Package: emacs;

Reported by: tastytea <tastytea <at> tastytea.de>

Date: Wed, 12 Feb 2020 15:33:02 UTC

Severity: minor

Tags: confirmed

Merged with 37681

Found in version 27.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Julien Danjou <julien <at> danjou.info>
Cc: tastytea <tastytea <at> tastytea.de>, 39578 <at> debbugs.gnu.org
Subject: bug#39578: 27.0.50; [rainbow-mode] #define is colored in c++-mode
Date: Fri, 30 Oct 2020 13:00:26 +0100

Julien Danjou <julien <at> danjou.info> writes:

> It's not a bug per say since it matches the regexp.
> We just need to add even more code to avoid matching languages'
> keywords.

It seems like a more general problem to me.  That is, "#def" should be
colourized, but "#defi" should not?

So would checking for a word boundary after the regexp be sufficient?
Or are there places where #000000foobar makes sense and we really want
to colourize that #000000 bit?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 3 years and 20 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.