From unknown Fri Sep 12 06:18:11 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#39543 <39543@debbugs.gnu.org> To: bug#39543 <39543@debbugs.gnu.org> Subject: Status: 28.0.50; Add completion to gnus-summary-save-parts from mime parts in the message Reply-To: bug#39543 <39543@debbugs.gnu.org> Date: Fri, 12 Sep 2025 13:18:11 +0000 retitle 39543 28.0.50; Add completion to gnus-summary-save-parts from mime = parts in the message reassign 39543 emacs submitter 39543 Filipp Gunbin severity 39543 wishlist tag 39543 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 10 08:19:22 2020 Received: (at submit) by debbugs.gnu.org; 10 Feb 2020 13:19:22 +0000 Received: from localhost ([127.0.0.1]:53803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j18yA-00058y-DZ for submit@debbugs.gnu.org; Mon, 10 Feb 2020 08:19:22 -0500 Received: from lists.gnu.org ([209.51.188.17]:38684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j18y8-00058r-RB for submit@debbugs.gnu.org; Mon, 10 Feb 2020 08:19:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46431) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j18y7-0007rh-JF for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 08:19:20 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.1 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j18y6-0000aX-K0 for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 08:19:19 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:53937) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j18y6-0000XA-9K for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 08:19:18 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D7905207FD for ; Mon, 10 Feb 2020 08:19:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 10 Feb 2020 08:19:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:subject:date:message-id:mime-version:content-type; s= fm2; bh=sqMpjbi+jWpcb+srR+s5StZGrxL5WaRvQqP0uOUspiM=; b=E0ttRNKF 4rxxqU4cIxdA3NHpg3R7pMMd1nLMQlSOt/OOKWKxPyeadZd2S1yJydpBfJ+mIMnj a2T23OET6c53vy9EzN12mSgD/17y6yoJODWn78oALgUZI0H+JMMgLBKmRjgq8Myt aBXGo2QOUxNKUZq5rVMXsij0NWtnJ120YMt7//nEI4sdIOHrDRZsKKFx//Ha/4Xz 2zZTZ0/4+mJ4eRaJaoL7EXyaeQMk9r3ESxA74BQsYKBFjFCFy4yWJDu3K8MqIgtr 9jK4vKudObfEz4OZU7Dr+N2RZLS9S6oNbxY0i8q3HUGbAOkivcBlNG9NlQKW7eF/ TeXGQmpAuCQurw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=sqMpjbi+jWpcb+srR+s5StZGrxL5W aRvQqP0uOUspiM=; b=pSjiGbnqZjrPRVOHDPly8voPYVpHLNsWwT43JZ1OyUb9c Q0TWocAEmjK/c6cuWSZP+YU4tSN8kiRVvc5pw0hM0j249lfc/6lbk19//3qfAYXG L9WiJLvPA+a51QvZZ9JoJ1GxSyzunTMw5LHQMZ99hznwt0Fi9uXZYdhQTjPQZuzv +RuLC8J18mRxEl9QSPvekURRrwKLkCzpaqXYRMki3Mp4ju8K9RitRb9xa2oekgxK mNXayXE1tCrPmpGuOQE3i0RpAObSVDwnqFCTrGlTKH46Lvd7K/28YZ00EcFRJ78U eEolWQyEPXEQBSa+baIo2Fs3b0gWkM5NjElVaK//A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedriedugdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfggtgesthdtredttddttd enucfhrhhomhephfhilhhiphhpucfiuhhnsghinhcuoehfghhunhgsihhnsehfrghsthhm rghilhdrfhhmqeenucfkphepudekhedrfedvrdeikedrudefheenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehfghhunhgsihhnsehfrghsthhm rghilhdrfhhm X-ME-Proxy: Received: from fgunbin.local (unknown [185.32.68.135]) by mail.messagingengine.com (Postfix) with ESMTPA id 359A03280067 for ; Mon, 10 Feb 2020 08:19:15 -0500 (EST) From: Filipp Gunbin To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Add completion to gnus-summary-save-parts from mime parts in the message Mail-Followup-To: bug-gnu-emacs@gnu.org Date: Mon, 10 Feb 2020 16:19:13 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: As gnus-summary-save-parts (X m) is invoked on the article, it could offer completion based on what mime parts are present in the article. Thanks. In GNU Emacs 28.0.50 (build 22, x86_64-apple-darwin19.2.0, NS appkit-1894.20 Version 10.15.2 (Build 19C57)) of 2020-02-07 built on fgunbin.local Repository revision: 30abcda54e1b0e15fc10b3db1c2b9f89ca [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: fastmail.fm] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (fgunbin[at]fastmail.fm) 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.17 listed in list.dnswl.org] 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) As gnus-summary-save-parts (X m) is invoked on the article, it could offer completion based on what mime parts are present in the article. Thanks. In GNU Emacs 28.0.50 (build 22, x86_64-apple-darwin19.2.0, NS appkit-1894.20 Version 10.15.2 (Build 19C57)) of 2020-02-07 built on fgunbin.local Repository revision: 30abcda54e1b0e15fc10b3db1c2b9f89ca521bfa Repository branch: master System Description: Mac OS X 10.15.2 From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 10 14:29:32 2020 Received: (at submit) by debbugs.gnu.org; 10 Feb 2020 19:29:32 +0000 Received: from localhost ([127.0.0.1]:55423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1EkO-0001be-33 for submit@debbugs.gnu.org; Mon, 10 Feb 2020 14:29:32 -0500 Received: from lists.gnu.org ([209.51.188.17]:57993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1EkL-0001bW-Vj for submit@debbugs.gnu.org; Mon, 10 Feb 2020 14:29:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45698) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1EkK-00060c-Q5 for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 14:29:29 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1EkJ-0000xp-Me for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 14:29:28 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:48060 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j1EkJ-0000wf-IP for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 14:29:27 -0500 Received: from localhost (unknown [205.175.106.48]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 46438FA12C for ; Mon, 10 Feb 2020 19:29:25 +0000 (UTC) From: Eric Abrahamsen To: bug-gnu-emacs@gnu.org Subject: Re: bug#39543: 28.0.50; Add completion to gnus-summary-save-parts from mime parts in the message References: Date: Mon, 10 Feb 2020 11:29:23 -0800 In-Reply-To: (Filipp Gunbin's message of "Mon, 10 Feb 2020 16:19:13 +0300") Message-ID: <87r1z2kzqk.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 52.70.2.18 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain Filipp Gunbin writes: > As gnus-summary-save-parts (X m) is invoked on the article, it could > offer completion based on what mime parts are present in the article. I've attached a "dumb" version of what that could look like. Two notes: 1. This would obsolete `gnus-summary-save-parts-default-mime'. Personally I think that's totally fine: between completion and a history variable, I don't see any use for a default value. 2. If we go this route, it would be nice to extend it so that, for instance, if _any_ image/ media types are present, we also manually add a "image/*" entry to the completion collection. Or for maximum OCD, only add that "image/*" entry if there are more than one image/ type handles present. Matches are not required, so you could always just type in your own regexp, anyway. Let's see if anyone has any comments. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=gnus-save-mime-completion.diff diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index a47e657623..39d9ad5057 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -12508,10 +12508,12 @@ gnus-summary-save-parts "Save parts matching TYPE to DIR. If REVERSE, save parts that do not match TYPE." (interactive - (list (read-string "Save parts of type: " - (or (car gnus-summary-save-parts-type-history) - gnus-summary-save-parts-default-mime) - 'gnus-summary-save-parts-type-history) + (list (completing-read "Save parts of type: " + (gnus-eval-in-buffer-window gnus-article-buffer + (delete-dups + (mapcar (lambda (h) (mm-handle-media-type (cdr h))) + gnus-article-mime-handle-alist))) + nil nil nil 'gnus-summary-save-parts-type-history) (setq gnus-summary-save-parts-last-directory (read-directory-name "Save to directory: " gnus-summary-save-parts-last-directory --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 20 08:05:12 2020 Received: (at 39543) by debbugs.gnu.org; 20 Feb 2020 13:05:12 +0000 Received: from localhost ([127.0.0.1]:43998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4lVv-0005u3-PC for submit@debbugs.gnu.org; Thu, 20 Feb 2020 08:05:12 -0500 Received: from quimby.gnus.org ([95.216.78.240]:46640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4lVu-0005tj-10 for 39543@debbugs.gnu.org; Thu, 20 Feb 2020 08:05:10 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j4lVl-0002t9-4E; Thu, 20 Feb 2020 14:05:03 +0100 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#39543: 28.0.50; Add completion to gnus-summary-save-parts from mime parts in the message References: <87r1z2kzqk.fsf@ericabrahamsen.net> Date: Thu, 20 Feb 2020 14:05:00 +0100 In-Reply-To: <87r1z2kzqk.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 10 Feb 2020 11:29:23 -0800") Message-ID: <87r1yp5s03.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: >> As gnus-summary-save-parts (X m) is invoked on the article, it could >> offer completion based on what mime parts are present in the article. Sounds like a good idea, but is probably not practical, since it would mean that Gnus would have to retrieve all the process-marked articles first to do the prompting. If there's only a single article [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39543 Cc: 39543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: >> As gnus-summary-save-parts (X m) is invoked on the article, it could >> offer completion based on what mime parts are present in the article. Sounds like a good idea, but is probably not practical, since it would mean that Gnus would have to retrieve all the process-marked articles first to do the prompting. If there's only a single article in the list, then it would be fine. > I've attached a "dumb" version of what that could look like. > > Two notes: > > 1. This would obsolete `gnus-summary-save-parts-default-mime'. > Personally I think that's totally fine: between completion and > a history variable, I don't see any use for a default > value. I think that variable is useful. In practice, people are interested in saving only certain types (images for some, pdfs for others), and being able to hit RET to do just that is nice. This is particularly the case when using the command over a large set of messages (typically, all the messages in the summary buffer). > 2. If we go this route, it would be nice to extend it so that, for > instance, if _any_ image/ media types are present, we also manually > add a "image/*" entry to the completion collection. Or for maximum > OCD, only add that "image/*" entry if there are more than one image/ > type handles present. Matches are not required, so you could always > just type in your own regexp, anyway. Adding foo/* variants if several different foo/s are in there would be nice. > + (list (completing-read "Save parts of type: " > + (gnus-eval-in-buffer-window gnus-article-buffer > + (delete-dups > + (mapcar (lambda (h) (mm-handle-media-type (cdr h))) > + gnus-article-mime-handle-alist))) > + nil nil nil 'gnus-summary-save-parts-type-history) This only deals with types in the current article? The message may not even be selected, so (in addition to not working on sets of articles), it would not work if the user hasn't selected an article? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 20 11:31:59 2020 Received: (at 39543) by debbugs.gnu.org; 20 Feb 2020 16:31:59 +0000 Received: from localhost ([127.0.0.1]:45720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4ok2-0005yK-Ey for submit@debbugs.gnu.org; Thu, 20 Feb 2020 11:31:58 -0500 Received: from ericabrahamsen.net ([52.70.2.18]:47746 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4ok0-0005tQ-Nf for 39543@debbugs.gnu.org; Thu, 20 Feb 2020 11:31:57 -0500 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 1BE58FA9B0; Thu, 20 Feb 2020 16:31:50 +0000 (UTC) From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#39543: 28.0.50; Add completion to gnus-summary-save-parts from mime parts in the message References: <87r1z2kzqk.fsf@ericabrahamsen.net> <87r1yp5s03.fsf@gnus.org> Date: Thu, 20 Feb 2020 08:31:48 -0800 In-Reply-To: <87r1yp5s03.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 20 Feb 2020 14:05:00 +0100") Message-ID: <87h7zl8bkb.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 39543 Cc: 39543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 02/20/20 14:05 PM, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >>> As gnus-summary-save-parts (X m) is invoked on the article, it could >>> offer completion based on what mime parts are present in the article. > > Sounds like a good idea, but is probably not practical, since it would > mean that Gnus would have to retrieve all the process-marked articles > first to do the prompting. If there's only a single article in the > list, then it would be fine. Well I did say it was a "dumb" version :) I hadn't considered the case of multiple articles. Just for the sake of argument: if we're expecting to save parts from some of the process-marked articles, aren't we going to need to fetch them all, anyway? >> I've attached a "dumb" version of what that could look like. >> >> Two notes: >> >> 1. This would obsolete `gnus-summary-save-parts-default-mime'. >> Personally I think that's totally fine: between completion and >> a history variable, I don't see any use for a default >> value. > > I think that variable is useful. In practice, people are interested in > saving only certain types (images for some, pdfs for others), and being > able to hit RET to do just that is nice. This is particularly the case > when using the command over a large set of messages (typically, all the > messages in the summary buffer). I still think that combining "the mimetype we saved last time" with "what's actually present and saveable" mostly obviates any generally preferred mimetype. But I don't feel strongly about this at all, and there's no great need to remove that variable. >> 2. If we go this route, it would be nice to extend it so that, for >> instance, if _any_ image/ media types are present, we also manually >> add a "image/*" entry to the completion collection. Or for maximum >> OCD, only add that "image/*" entry if there are more than one image/ >> type handles present. Matches are not required, so you could always >> just type in your own regexp, anyway. > > Adding foo/* variants if several different foo/s are in there would be nice. > >> + (list (completing-read "Save parts of type: " >> + (gnus-eval-in-buffer-window gnus-article-buffer >> + (delete-dups >> + (mapcar (lambda (h) (mm-handle-media-type (cdr h))) >> + gnus-article-mime-handle-alist))) >> + nil nil nil 'gnus-summary-save-parts-type-history) > > This only deals with types in the current article? The message may not > even be selected, so (in addition to not working on sets of articles), > it would not work if the user hasn't selected an article? Right, like I said this was more a proof of concept than a working solution. If you think there's a practical improvement to be made in here, I'd be happy to work on it. Eric From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 20 12:45:14 2020 Received: (at 39543) by debbugs.gnu.org; 20 Feb 2020 17:45:14 +0000 Received: from localhost ([127.0.0.1]:45817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4psw-0008Mu-8Z for submit@debbugs.gnu.org; Thu, 20 Feb 2020 12:45:14 -0500 Received: from quimby.gnus.org ([95.216.78.240]:50334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4pst-0008MY-ON for 39543@debbugs.gnu.org; Thu, 20 Feb 2020 12:45:12 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j4psk-0005rz-2m; Thu, 20 Feb 2020 18:45:05 +0100 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#39543: 28.0.50; Add completion to gnus-summary-save-parts from mime parts in the message References: <87r1z2kzqk.fsf@ericabrahamsen.net> <87r1yp5s03.fsf@gnus.org> <87h7zl8bkb.fsf@ericabrahamsen.net> Date: Thu, 20 Feb 2020 18:45:01 +0100 In-Reply-To: <87h7zl8bkb.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 20 Feb 2020 08:31:48 -0800") Message-ID: <87v9o12lwi.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > I hadn't considered the case of multiple articles. Just for the sake of > argument: if we're expecting to save parts from some of the > process-marked articles, aren't we going to need to fetch them [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39543 Cc: 39543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > I hadn't considered the case of multiple articles. Just for the sake of > argument: if we're expecting to save parts from some of the > process-marked articles, aren't we going to need to fetch them all, > anyway? We are, but unless you have backlog (etc) switched on, Gnus will then fetch everything twice. > Right, like I said this was more a proof of concept than a working > solution. If you think there's a practical improvement to be made in > here, I'd be happy to work on it. If there's only one article in the selection, then ensuring that it's fetched should be sufficient before you look at the MIME handles. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 12 15:22:13 2020 Received: (at submit) by debbugs.gnu.org; 12 Mar 2020 19:22:13 +0000 Received: from localhost ([127.0.0.1]:57815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCTPJ-0008DO-JF for submit@debbugs.gnu.org; Thu, 12 Mar 2020 15:22:13 -0400 Received: from lists.gnu.org ([209.51.188.17]:57452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCTPI-0008DH-CP for submit@debbugs.gnu.org; Thu, 12 Mar 2020 15:22:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40861) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCTPH-0003A8-5T for bug-gnu-emacs@gnu.org; Thu, 12 Mar 2020 15:22:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCTPG-0008Ed-2w for bug-gnu-emacs@gnu.org; Thu, 12 Mar 2020 15:22:11 -0400 Received: from ciao.gmane.io ([159.69.161.202]:58740) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jCTPF-0008Dp-TD for bug-gnu-emacs@gnu.org; Thu, 12 Mar 2020 15:22:10 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1jCTPD-000WyJ-O7 for bug-gnu-emacs@gnu.org; Thu, 12 Mar 2020 20:22:07 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#39543: 28.0.50; Add completion to gnus-summary-save-parts from mime parts in the message Date: Thu, 12 Mar 2020 12:22:02 -0700 Message-ID: <87o8t12xb9.fsf@ericabrahamsen.net> References: <87r1z2kzqk.fsf@ericabrahamsen.net> <87r1yp5s03.fsf@gnus.org> <87h7zl8bkb.fsf@ericabrahamsen.net> <87v9o12lwi.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cancel-Lock: sha1:B5I44cdmIMdnbHD1BZEQegztapg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 159.69.161.202 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen writes: > Eric Abrahamsen writes: > >> I hadn't considered the case of multiple articles. Just for the sake of >> argument: if we're expecting to save parts from some of the >> process-marked articles, aren't we going to need to fetch them all, >> anyway? > > We are, but unless you have backlog (etc) switched on, Gnus will then > fetch everything twice. > >> Right, like I said this was more a proof of concept than a working >> solution. If you think there's a practical improvement to be made in >> here, I'd be happy to work on it. > > If there's only one article in the selection, then ensuring that it's > fetched should be sufficient before you look at the MIME handles. Bleagh, no time for coding... Anyway, I played with this, and the amount of (duplicate) code that would be required to check if we're only dealing with one article, and whether the article is fetched or not, sort of makes it not quite worth the effort. Unless we're interested in factoring out the tests in `gnus-summary-select-article' into a new function like 'gnus-summary-current-article-fetched-p', which could be used in both places. That might make it easier. Eric From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 19 10:17:06 2020 Received: (at 39543) by debbugs.gnu.org; 19 Jul 2020 14:17:06 +0000 Received: from localhost ([127.0.0.1]:60925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxA7l-0005AE-Qu for submit@debbugs.gnu.org; Sun, 19 Jul 2020 10:17:06 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxA7j-00054G-Oy for 39543@debbugs.gnu.org; Sun, 19 Jul 2020 10:17:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tZ5SmewYmgyGBk7YErbcWeN+E83arP6MltSKg+BP4mE=; b=Jnjwhcy+h1LbftO1jvrtSFnEk7 SnQcN8t93fjRIEIrZzseMDei49Y9huY2dR/XLCCHUvk1ry8FcVc2FFJQo/PpBNOzkoIicaVHh/Mb/ P3RuZz/sX541MnhtP2I9pbf1aRZFquTedlKRn7/owCN8tECxxaE213ftMDmQjDhVIfZ4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxA7S-0006mz-KH; Sun, 19 Jul 2020 16:16:52 +0200 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#39543: 28.0.50; Add completion to gnus-summary-save-parts from mime parts in the message References: <87r1z2kzqk.fsf@ericabrahamsen.net> <87r1yp5s03.fsf@gnus.org> <87h7zl8bkb.fsf@ericabrahamsen.net> <87v9o12lwi.fsf@gnus.org> <87o8t12xb9.fsf@ericabrahamsen.net> Date: Sun, 19 Jul 2020 16:16:45 +0200 In-Reply-To: <87o8t12xb9.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 12 Mar 2020 12:22:02 -0700") Message-ID: <87ft9nr3n6.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > Bleagh, no time for coding... Anyway, I played with this, and the amount > of (duplicate) code that would be required to check if we're only > dealing with one article, and whether the article is fe [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 39543 Cc: 39543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > Bleagh, no time for coding... Anyway, I played with this, and the amount > of (duplicate) code that would be required to check if we're only > dealing with one article, and whether the article is fetched or not, > sort of makes it not quite worth the effort. I think so, too. But offering completion based on just the first article is better than nothing, so I applied your patch (with some slight changes) to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 19 10:17:07 2020 Received: (at control) by debbugs.gnu.org; 19 Jul 2020 14:17:07 +0000 Received: from localhost ([127.0.0.1]:60928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxA7n-0005BL-5u for submit@debbugs.gnu.org; Sun, 19 Jul 2020 10:17:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxA7m-00055w-2N for control@debbugs.gnu.org; Sun, 19 Jul 2020 10:17:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=S7DZhBypEciEfy8O+DXkkGFt4t2d2UNNc5plJtP1PG8=; b=ulzgcpVUl7y19iNF6IxxdgYubq bM84sICUbzTX4RZNInT2FCjFSPFx2rCTFbOGIgBd13fZ/VgHPVzOaNg37vc7TNkeNr8Gid0bLl9WV tz6xkbeSrYFNHSoQC6rucALnmOK37NAa81Xl5bY9SRzHFYdfmH82nE/L5RVB9R0R0SrI=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxA7e-0006n4-D3 for control@debbugs.gnu.org; Sun, 19 Jul 2020 16:17:00 +0200 Date: Sun, 19 Jul 2020 16:16:57 +0200 Message-Id: <87eep7r3mu.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #39543 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 39543 fixed close 39543 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 39543 fixed close 39543 28.1 quit From unknown Fri Sep 12 06:18:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 17 Aug 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator