GNU bug report logs - #39523
[PATCH] gnu: password-store: Install fish and zsh completions.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#39523: closed ([PATCH] gnu: password-store: Install fish and
 zsh completions.)
Date: Mon, 10 Feb 2020 00:11:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 10 Feb 2020 01:10:50 +0100
with message-id <875zgfz4hh.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#39523] [PATCH] gnu: password-store: Install fish and zsh completions.
has caused the debbugs.gnu.org bug report #39523,
regarding [PATCH] gnu: password-store: Install fish and zsh completions.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
39523: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39523
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: password-store: Install fish and zsh completions.
Date: Sun,  9 Feb 2020 10:11:25 +0100

* gnu/packages/password-utils.scm (password-store)[arguments]: Remove
phase install-shell-completions. Adjust make-flags.
---
 gnu/packages/password-utils.scm | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index db5f54e1d9..9cfa5ed3a3 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -496,17 +496,11 @@ any X11 window.")
                                 "sed" "tree" "which" "xclip"))))
                (wrap-program (string-append out "/bin/pass")
                  `("PATH" ":" prefix (,(string-join path ":"))))
-               #t)))
-         (add-after 'wrap-path 'install-shell-completions
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let* ((out      (assoc-ref outputs "out"))
-                    (bashcomp (string-append out "/etc/bash_completion.d")))
-               ;; TODO: install fish and zsh completions.
-               (mkdir-p bashcomp)
-               (copy-file "src/completion/pass.bash-completion"
-                          (string-append bashcomp "/pass"))
                #t))))
-       #:make-flags (list "CC=gcc" (string-append "PREFIX=" %output))
+       #:make-flags (list "CC=gcc" (string-append "PREFIX=" %output)
+                          "WITH_ALLCOMP=yes"
+                          (string-append "BASHCOMPDIR="
+                                         %output "/etc/bash_completion.d"))
        ;; Parallel tests may cause a race condition leading to a
        ;; timeout in some circumstances.
        #:parallel-tests? #f
-- 
2.24.1

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 39523-done <at> debbugs.gnu.org
Subject: Re: [bug#39523] [PATCH] gnu: password-store: Install fish and zsh
 completions.
Date: Mon, 10 Feb 2020 01:10:50 +0100

Hello,

Brice Waegeneire <brice <at> waegenei.re> writes:

> * gnu/packages/password-utils.scm (password-store)[arguments]: Remove
> phase install-shell-completions. Adjust make-flags.

I applied your patch (as df931ac39c40ac8a702e37cb434d9a1016606ed7)...
aaaaaaaand added a copyright line. Phew :)

Thank you!

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.