Subject: bug#39523: closed (Re: [bug#39523] [PATCH] gnu: password-store: Install fish and zsh completions.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 10 Feb 2020 00:11:02 +0000

Your bug report

#39523: [PATCH] gnu: password-store: Install fish and zsh completions.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
39523: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39523
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#39523] [PATCH] gnu: password-store: Install fish and zsh completions.
From: Nicolas Goaziou <[email-masked]>
To: Brice Waegeneire <[email-masked]>
Cc: [email-masked]
Date: Mon, 10 Feb 2020 01:10:50 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Brice Waegeneire <[email-masked]> writes:

> * gnu/packages/password-utils.scm (password-store)[arguments]: Remove
> phase install-shell-completions. Adjust make-flags.

I applied your patch (as df931ac39c40ac8a702e37cb434d9a1016606ed7)...
aaaaaaaand added a copyright line. Phew :)

Thank you!

Regards,

-- 
Nicolas Goaziou

Subject: [PATCH] gnu: password-store: Install fish and zsh completions.
From: Brice Waegeneire <[email-masked]>
To: [email-masked]
Date: Sun, 9 Feb 2020 10:11:25 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/password-utils.scm (password-store)[arguments]: Remove
phase install-shell-completions. Adjust make-flags.
---
 gnu/packages/password-utils.scm | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index db5f54e1d9..9cfa5ed3a3 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -496,17 +496,11 @@ any X11 window.")
                                 "sed" "tree" "which" "xclip"))))
                (wrap-program (string-append out "/bin/pass")
                  `("PATH" ":" prefix (,(string-join path ":"))))
-               #t)))
-         (add-after 'wrap-path 'install-shell-completions
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let* ((out      (assoc-ref outputs "out"))
-                    (bashcomp (string-append out "/etc/bash_completion.d")))
-               ;; TODO: install fish and zsh completions.
-               (mkdir-p bashcomp)
-               (copy-file "src/completion/pass.bash-completion"
-                          (string-append bashcomp "/pass"))
                #t))))
-       #:make-flags (list "CC=gcc" (string-append "PREFIX=" %output))
+       #:make-flags (list "CC=gcc" (string-append "PREFIX=" %output)
+                          "WITH_ALLCOMP=yes"
+                          (string-append "BASHCOMPDIR="
+                                         %output "/etc/bash_completion.d"))
        ;; Parallel tests may cause a race condition leading to a
        ;; timeout in some circumstances.
        #:parallel-tests? #f
-- 
2.24.1