From unknown Thu Aug 14 21:55:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#39522] [PATCH] gnu: dunst: Build dunstify. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 09 Feb 2020 09:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39522 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 39522@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15812394813349 (code B ref -1); Sun, 09 Feb 2020 09:12:01 +0000 Received: (at submit) by debbugs.gnu.org; 9 Feb 2020 09:11:21 +0000 Received: from localhost ([127.0.0.1]:52037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0icb-0000rx-H0 for submit@debbugs.gnu.org; Sun, 09 Feb 2020 04:11:21 -0500 Received: from lists.gnu.org ([209.51.188.17]:46250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0icZ-0000ro-Ph for submit@debbugs.gnu.org; Sun, 09 Feb 2020 04:11:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54268) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0icY-0006wv-PE for guix-patches@gnu.org; Sun, 09 Feb 2020 04:11:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j0icU-0001PO-P0 for guix-patches@gnu.org; Sun, 09 Feb 2020 04:11:18 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:39033) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j0icU-0001P0-Ip for guix-patches@gnu.org; Sun, 09 Feb 2020 04:11:14 -0500 X-Originating-IP: 78.237.113.178 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 5A43A40004 for ; Sun, 9 Feb 2020 09:11:13 +0000 (UTC) From: Brice Waegeneire Date: Sun, 9 Feb 2020 10:11:09 +0100 Message-Id: <20200209091109.28930-1-brice@waegenei.re> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.194 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/dunst.scm (dunst)[arguments]: Add phase install-dunstify. [inputs]: Add libnotify. --- gnu/packages/dunst.scm | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/gnu/packages/dunst.scm b/gnu/packages/dunst.scm index 75f2b80e5f..ecb6c15e16 100644 --- a/gnu/packages/dunst.scm +++ b/gnu/packages/dunst.scm @@ -26,6 +26,7 @@ #:use-module (gnu packages base) #:use-module (gnu packages freedesktop) #:use-module (gnu packages glib) + #:use-module (gnu packages gnome) #:use-module (gnu packages gtk) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) @@ -52,9 +53,15 @@ ;; Otherwise it tries to install service file ;; to "dbus" store directory. (string-append "SERVICEDIR_DBUS=" %output - "/share/dbus-1/services")) + "/share/dbus-1/services") + "dunstify") #:phases (modify-phases %standard-phases - (delete 'configure)))) + (delete 'configure) + (add-after 'install 'install-dunstify + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (copy-file "dunstify" + (string-append out "/bin/dunstify")))))))) (native-inputs `(("pkg-config" ,pkg-config) ("perl" ,perl) ; for pod2man @@ -65,6 +72,7 @@ ("glib" ,glib) ("cairo" ,cairo) ("pango" ,pango) + ("libnotify" ,libnotify) ; for dunstify ("libx11" ,libx11) ("libxscrnsaver" ,libxscrnsaver) ("libxinerama" ,libxinerama) -- 2.24.1 From unknown Thu Aug 14 21:55:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#39522] [PATCH] gnu: dunst: Build dunstify. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 09 Feb 2020 23:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39522 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire Cc: 39522@debbugs.gnu.org Received: via spool by 39522-submit@debbugs.gnu.org id=B39522.158129190510394 (code B ref 39522); Sun, 09 Feb 2020 23:46:02 +0000 Received: (at 39522) by debbugs.gnu.org; 9 Feb 2020 23:45:05 +0000 Received: from localhost ([127.0.0.1]:53430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0wG9-0002ha-0V for submit@debbugs.gnu.org; Sun, 09 Feb 2020 18:45:05 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:22431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0wG7-0002hJ-AW for 39522@debbugs.gnu.org; Sun, 09 Feb 2020 18:45:03 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 783A9240003; Sun, 9 Feb 2020 23:45:01 +0000 (UTC) From: Nicolas Goaziou References: <20200209091109.28930-1-brice@waegenei.re> Date: Mon, 10 Feb 2020 00:45:00 +0100 In-Reply-To: <20200209091109.28930-1-brice@waegenei.re> (Brice Waegeneire's message of "Sun, 9 Feb 2020 10:11:09 +0100") Message-ID: <87mu9rz5oj.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Brice Waegeneire writes: > * gnu/packages/dunst.scm (dunst)[arguments]: Add phase install-dunstify. > [inputs]: Add libnotify. Please add a copyright line for you. > + (add-after 'install 'install-dunstify > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (copy-file "dunstify" > + (string-append out "/bin/dunstify")))))))) I suggest to use (install-file "dunstify" (string-append out "/bin")) instead. Also, the phase must end with #t. Could you send an updated patch? Thank you! Regards, -- Nicolas Goaziou From unknown Thu Aug 14 21:55:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#39522] [PATCH v2] gnu: dunst: Build dunstify. References: <20200209091109.28930-1-brice@waegenei.re> In-Reply-To: <20200209091109.28930-1-brice@waegenei.re> Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Feb 2020 08:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39522 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 39522@debbugs.gnu.org Received: via spool by 39522-submit@debbugs.gnu.org id=B39522.15813247204899 (code B ref 39522); Mon, 10 Feb 2020 08:52:02 +0000 Received: (at 39522) by debbugs.gnu.org; 10 Feb 2020 08:52:00 +0000 Received: from localhost ([127.0.0.1]:53651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j14nQ-0001Gw-26 for submit@debbugs.gnu.org; Mon, 10 Feb 2020 03:52:00 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:42181) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j14nO-0001Gn-7X for 39522@debbugs.gnu.org; Mon, 10 Feb 2020 03:51:59 -0500 X-Originating-IP: 78.237.113.178 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 72B9C1BF20B for <39522@debbugs.gnu.org>; Mon, 10 Feb 2020 08:51:56 +0000 (UTC) From: Brice Waegeneire Date: Mon, 10 Feb 2020 09:51:48 +0100 Message-Id: <20200210085148.12612-1-brice@waegenei.re> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/dunst.scm (dunst)[arguments]: Add phase install-dunstify. [inputs]: Add libnotify. --- gnu/packages/dunst.scm | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/gnu/packages/dunst.scm b/gnu/packages/dunst.scm index 75f2b80e5f..5b20d6d013 100644 --- a/gnu/packages/dunst.scm +++ b/gnu/packages/dunst.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2015, 2017, 2018 Alex Kost ;;; Copyright © 2018 Tobias Geerinckx-Rice ;;; Copyright © 2019 Efraim Flashner +;;; Copyright © 2020 Brice Waegeneire ;;; ;;; This file is part of GNU Guix. ;;; @@ -26,6 +27,7 @@ #:use-module (gnu packages base) #:use-module (gnu packages freedesktop) #:use-module (gnu packages glib) + #:use-module (gnu packages gnome) #:use-module (gnu packages gtk) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) @@ -52,9 +54,16 @@ ;; Otherwise it tries to install service file ;; to "dbus" store directory. (string-append "SERVICEDIR_DBUS=" %output - "/share/dbus-1/services")) + "/share/dbus-1/services") + "dunstify") #:phases (modify-phases %standard-phases - (delete 'configure)))) + (delete 'configure) + (add-after 'install 'install-dunstify + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (install-file "dunstify" + (string-append out "/bin"))) + #t))))) (native-inputs `(("pkg-config" ,pkg-config) ("perl" ,perl) ; for pod2man @@ -65,6 +74,7 @@ ("glib" ,glib) ("cairo" ,cairo) ("pango" ,pango) + ("libnotify" ,libnotify) ; for dunstify ("libx11" ,libx11) ("libxscrnsaver" ,libxscrnsaver) ("libxinerama" ,libxinerama) -- 2.25.0 From unknown Thu Aug 14 21:55:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#39522] [PATCH] gnu: dunst: Build dunstify. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Feb 2020 08:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39522 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 39522@debbugs.gnu.org, Guix-patches Received: via spool by 39522-submit@debbugs.gnu.org id=B39522.15813250435359 (code B ref 39522); Mon, 10 Feb 2020 08:58:01 +0000 Received: (at 39522) by debbugs.gnu.org; 10 Feb 2020 08:57:23 +0000 Received: from localhost ([127.0.0.1]:53655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j14sc-0001ON-OW for submit@debbugs.gnu.org; Mon, 10 Feb 2020 03:57:22 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:37905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j14sb-0001OG-IH for 39522@debbugs.gnu.org; Mon, 10 Feb 2020 03:57:21 -0500 Received: from webmail.gandi.net (webmail18.sd4.0x35.net [10.200.201.18]) (Authenticated sender: brice@waegenei.re) by relay8-d.mail.gandi.net (Postfix) with ESMTPA id 180061BF207; Mon, 10 Feb 2020 08:57:19 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 10 Feb 2020 08:57:19 +0000 From: Brice Waegeneire In-Reply-To: <87mu9rz5oj.fsf@nicolasgoaziou.fr> References: <20200209091109.28930-1-brice@waegenei.re> <87mu9rz5oj.fsf@nicolasgoaziou.fr> Message-ID: <2f90edd9716114944689eb3e4abb0f36@waegenei.re> X-Sender: brice@waegenei.re User-Agent: Roundcube Webmail/1.3.8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2020-02-09 23:45, Nicolas Goaziou wrote: > I suggest to use > > (install-file "dunstify" (string-append out "/bin")) > > instead. > > Also, the phase must end with #t. > > Could you send an updated patch? I wrote a new patch with your suggestion. Sorry for the missing copyright lines in the previous patches you merged, I thought it was non-mandatory on trivial modifications. I added one in this new one. From unknown Thu Aug 14 21:55:18 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Brice Waegeneire Subject: bug#39522: closed (Re: [bug#39522] [PATCH] gnu: dunst: Build dunstify.) Message-ID: References: <87zhdpvv3x.fsf@nicolasgoaziou.fr> <20200209091109.28930-1-brice@waegenei.re> X-Gnu-PR-Message: they-closed 39522 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 39522@debbugs.gnu.org Date: Tue, 11 Feb 2020 18:27:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1581445623-3275-1" This is a multi-part message in MIME format... ------------=_1581445623-3275-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #39522: [PATCH] gnu: dunst: Build dunstify. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 39522@debbugs.gnu.org. --=20 39522: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D39522 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1581445623-3275-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 39522-done) by debbugs.gnu.org; 11 Feb 2020 18:26:16 +0000 Received: from localhost ([127.0.0.1]:57515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1aEh-0000p9-Sl for submit@debbugs.gnu.org; Tue, 11 Feb 2020 13:26:16 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:60097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1aEf-0000oz-RB for 39522-done@debbugs.gnu.org; Tue, 11 Feb 2020 13:26:14 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id B6CA72000C; Tue, 11 Feb 2020 18:26:11 +0000 (UTC) From: Nicolas Goaziou To: Brice Waegeneire Subject: Re: [bug#39522] [PATCH] gnu: dunst: Build dunstify. References: <20200209091109.28930-1-brice@waegenei.re> <87mu9rz5oj.fsf@nicolasgoaziou.fr> <2f90edd9716114944689eb3e4abb0f36@waegenei.re> Date: Tue, 11 Feb 2020 19:26:10 +0100 In-Reply-To: <2f90edd9716114944689eb3e4abb0f36@waegenei.re> (Brice Waegeneire's message of "Mon, 10 Feb 2020 08:57:19 +0000") Message-ID: <87zhdpvv3x.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 39522-done Cc: 39522-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Brice Waegeneire writes: > I wrote a new patch with your suggestion. Thank you! I applied it as 81565d23df3080b4d43d2ce0bfa49251827a34e9. > Sorry for the missing copyright lines in the previous patches you > merged, I thought it was non-mandatory on trivial modifications. I honestly do not know if it is mandatory in this case. However, trivial modifications may pile up and it could become a concern at some point. > I added one in this new one. Yay! Regards, -- Nicolas Goaziou ------------=_1581445623-3275-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 9 Feb 2020 09:11:21 +0000 Received: from localhost ([127.0.0.1]:52037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0icb-0000rx-H0 for submit@debbugs.gnu.org; Sun, 09 Feb 2020 04:11:21 -0500 Received: from lists.gnu.org ([209.51.188.17]:46250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j0icZ-0000ro-Ph for submit@debbugs.gnu.org; Sun, 09 Feb 2020 04:11:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54268) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0icY-0006wv-PE for guix-patches@gnu.org; Sun, 09 Feb 2020 04:11:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j0icU-0001PO-P0 for guix-patches@gnu.org; Sun, 09 Feb 2020 04:11:18 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:39033) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j0icU-0001P0-Ip for guix-patches@gnu.org; Sun, 09 Feb 2020 04:11:14 -0500 X-Originating-IP: 78.237.113.178 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 5A43A40004 for ; Sun, 9 Feb 2020 09:11:13 +0000 (UTC) From: Brice Waegeneire To: guix-patches@gnu.org Subject: [PATCH] gnu: dunst: Build dunstify. Date: Sun, 9 Feb 2020 10:11:09 +0100 Message-Id: <20200209091109.28930-1-brice@waegenei.re> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.194 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/dunst.scm (dunst)[arguments]: Add phase install-dunstify. [inputs]: Add libnotify. --- gnu/packages/dunst.scm | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/gnu/packages/dunst.scm b/gnu/packages/dunst.scm index 75f2b80e5f..ecb6c15e16 100644 --- a/gnu/packages/dunst.scm +++ b/gnu/packages/dunst.scm @@ -26,6 +26,7 @@ #:use-module (gnu packages base) #:use-module (gnu packages freedesktop) #:use-module (gnu packages glib) + #:use-module (gnu packages gnome) #:use-module (gnu packages gtk) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) @@ -52,9 +53,15 @@ ;; Otherwise it tries to install service file ;; to "dbus" store directory. (string-append "SERVICEDIR_DBUS=" %output - "/share/dbus-1/services")) + "/share/dbus-1/services") + "dunstify") #:phases (modify-phases %standard-phases - (delete 'configure)))) + (delete 'configure) + (add-after 'install 'install-dunstify + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (copy-file "dunstify" + (string-append out "/bin/dunstify")))))))) (native-inputs `(("pkg-config" ,pkg-config) ("perl" ,perl) ; for pod2man @@ -65,6 +72,7 @@ ("glib" ,glib) ("cairo" ,cairo) ("pango" ,pango) + ("libnotify" ,libnotify) ; for dunstify ("libx11" ,libx11) ("libxscrnsaver" ,libxscrnsaver) ("libxinerama" ,libxinerama) -- 2.24.1 ------------=_1581445623-3275-1-- From unknown Thu Aug 14 21:55:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#39522] When to add a copyright line? Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 14 Feb 2020 14:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39522 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire , 39522@debbugs.gnu.org, Nicolas Goaziou Received: via spool by 39522-submit@debbugs.gnu.org id=B39522.15816890571257 (code B ref 39522); Fri, 14 Feb 2020 14:05:01 +0000 Received: (at 39522) by debbugs.gnu.org; 14 Feb 2020 14:04:17 +0000 Received: from localhost ([127.0.0.1]:32791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2bZp-0000KD-C1 for submit@debbugs.gnu.org; Fri, 14 Feb 2020 09:04:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2bZn-0000Jv-RB for 39522@debbugs.gnu.org; Fri, 14 Feb 2020 09:04:16 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:32870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j2bZh-0005L0-Kb; Fri, 14 Feb 2020 09:04:09 -0500 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=44924 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j2bZf-0000Fi-QS; Fri, 14 Feb 2020 09:04:09 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87zhdpvv3x.fsf@nicolasgoaziou.fr> <20200209091109.28930-1-brice@waegenei.re> Date: Fri, 14 Feb 2020 15:04:06 +0100 In-Reply-To: (GNU bug Tracking System's message of "Tue, 11 Feb 2020 18:27:03 +0000") Message-ID: <87mu9lgt9l.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello! > Brice Waegeneire writes: > >> I wrote a new patch with your suggestion. > > Thank you! I applied it as 81565d23df3080b4d43d2ce0bfa49251827a34e9. > >> Sorry for the missing copyright lines in the previous patches you >> merged, I thought it was non-mandatory on trivial modifications. > > I honestly do not know if it is mandatory in this case. However, trivial > modifications may pile up and it could become a concern at some point. FWIW, I agree with both of you. :-) Technically, a contribution is not considered =E2=80=9Clegally significant= =E2=80=9D if it is below 15 lines of code or so (info "(maintain) Legally Significant"). Furthermore, copyright only applies to things that are =E2=80=9Cinventive= =E2=80=9D, which typically means there=E2=80=99s more than one way to do it. Thus, one could argue about whether some of our package definitions are copyrightable at all (in the EU, there=E2=80=99s a =E2=80=9Csui generis=E2= =80=9D database right though, so it could fall under that, but IANAL.) Anyway, long story short: I agree with Nicolas that it=E2=80=99s easier to = just always add a copyright line, and it=E2=80=99s better than forgetting to add= one. Ludo=E2=80=99.